111229 2013-03-01 15:55:48 -0800 Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true 2013-03-04 15:02:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 qinmin webkit-unassigned aelias eric esprehn+autocc ojan.autocc simon.fraser skyostil webkit.review.bot oldest_to_newest 845575 0 qinmin 2013-03-01 15:55:48 -0800 Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true 845583 1 191060 qinmin 2013-03-01 16:04:29 -0800 Created attachment 191060 Patch 846607 2 191060 wangxianzhu 2013-03-04 10:21:14 -0800 Comment on attachment 191060 Patch CQ+ per Min's request. 846610 3 191060 webkit.review.bot 2013-03-04 10:25:19 -0800 Comment on attachment 191060 Patch Clearing flags on attachment: 191060 Committed r144642: <http://trac.webkit.org/changeset/144642> 846611 4 webkit.review.bot 2013-03-04 10:25:22 -0800 All reviewed patches have been landed. Closing bug. 846863 5 191060 darin 2013-03-04 14:32:41 -0800 Comment on attachment 191060 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191060&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:787 > + if (Settings* settings = m_renderView->document()->settings()) > + if (!settings->applyPageScaleFactorInCompositor()) > + clipRect.scale(pageScaleFactor()); WebKit coding style requires braces around the body of the outer if since the inner if is two lines long. 846886 6 qinmin 2013-03-04 15:02:16 -0800 (In reply to comment #5) > (From update of attachment 191060 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191060&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.cpp:787 > > + if (Settings* settings = m_renderView->document()->settings()) > > + if (!settings->applyPageScaleFactorInCompositor()) > > + clipRect.scale(pageScaleFactor()); > > WebKit coding style requires braces around the body of the outer if since the inner if is two lines long. hmm... this file seems to have the same style error in another place. will fix both in a separate patch. 191060 2013-03-01 16:04:29 -0800 2013-03-04 14:32:41 -0800 Patch bug-111229-20130301160040.patch text/plain 1913 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWYxYWVhMTliMjc0OTJh Nzk4MDNlZWJjYTU4NzQxMjlkMDgzNWQ1NC4uMjJmMDliOGM1ZmUyNTYyMjQ3NGYwNTg3MWNhMDE0 ZGFjMWFjMGVjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTAxICBNaW4g UWluICA8cWlubWluQGNocm9taXVtLm9yZz4KKworICAgICAgICBEb24ndCBhcHBseSBwYWdlIHNj YWxlIHRvIGNsaXBSZWN0IGlmIGFwcGx5UGFnZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yIGlzIHNl dCB0byB0cnVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTEyMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJZiBhcHBseVBhZ2VTY2FsZUZhY3RvckluQ29tcG9zaXRvciBpcyBzZXQgdG8gdHJ1ZSwgd2Vi Y29yZSBzaG91bGQgdXNlIGNzcyBjb29yZGluYXRlcy4KKyAgICAgICAgQXMgYSByZXN1bHQsIHdl IHNob3VsZG4ndCBhcHBseSBwYWdlIHNjYWxlIHRvIGNsaXBSZWN0IGluIFJlbmRlckxheWVyQ29t cG9zaXRvci4KKyAgICAgICAgTGF5b3V0IHRlc3RzIHNldCB0aGUgZmxhZyB0byBmYWxzZSwgc28g d2UgZG9uJ3QgaGF2ZSBhbnl0aGluZyB0byB0ZXN0IGFnYWluc3QuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckxheWVyQ29tcG9zaXRvcjo6YWRkVG9PdmVybGFwTWFwKToKKwogMjAxMy0wMy0wMSAgU2hlcmlm ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjE0NDQ0My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggZWY4OWZjYWNiZWZiODYzNzdkMmQ5MGZj MmViYzVmMzQwZmY2Mjc5NC4uMGViODEzMDcwZTllMzFmNmI1MjcwMGIxYjIzNTk3MGFiM2U2ZmFl NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKQEAgLTc4Miw3ICs3ODIsOSBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6 YWRkVG9PdmVybGFwTWFwKE92ZXJsYXBNYXAmIG92ZXJsYXBNYXAsIFJlbmRlckxheWVyKgogICAg IH0KIAogICAgIEludFJlY3QgY2xpcFJlY3QgPSBwaXhlbFNuYXBwZWRJbnRSZWN0KGxheWVyLT5i YWNrZ3JvdW5kQ2xpcFJlY3QoUmVuZGVyTGF5ZXI6OkNsaXBSZWN0c0NvbnRleHQocm9vdFJlbmRl ckxheWVyKCksIDAsIEFic29sdXRlQ2xpcFJlY3RzKSkucmVjdCgpKTsgLy8gRklYTUU6IEluY29y cmVjdCBmb3IgQ1NTIHJlZ2lvbnMuCi0gICAgY2xpcFJlY3Quc2NhbGUocGFnZVNjYWxlRmFjdG9y KCkpOworICAgIGlmIChTZXR0aW5ncyogc2V0dGluZ3MgPSBtX3JlbmRlclZpZXctPmRvY3VtZW50 KCktPnNldHRpbmdzKCkpCisgICAgICAgIGlmICghc2V0dGluZ3MtPmFwcGx5UGFnZVNjYWxlRmFj dG9ySW5Db21wb3NpdG9yKCkpCisgICAgICAgICAgICBjbGlwUmVjdC5zY2FsZShwYWdlU2NhbGVG YWN0b3IoKSk7CiAgICAgY2xpcFJlY3QuaW50ZXJzZWN0KGxheWVyQm91bmRzKTsKICAgICBvdmVy bGFwTWFwLmFkZChsYXllciwgY2xpcFJlY3QpOwogfQo=