111223 2013-03-01 14:43:55 -0800 [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell 2013-03-03 16:00:51 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 845518 0 haraken 2013-03-01 14:43:55 -0800 HTMLDocument::getNamedProperty() is used by DOMWindowShell. It can be a static method in DOMWindowShell. 845521 1 191039 haraken 2013-03-01 14:45:01 -0800 Created attachment 191039 Patch 845929 2 191039 abarth 2013-03-02 23:20:45 -0800 Comment on attachment 191039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435 > + return v8Undefined(); Should we pass the isolate to v8Undefined ? 846102 3 haraken 2013-03-03 15:54:44 -0800 Committed r144584: <http://trac.webkit.org/changeset/144584> 846105 4 haraken 2013-03-03 16:00:51 -0800 (In reply to comment #2) > (From update of attachment 191039 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review > > > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435 > > + return v8Undefined(); > > Should we pass the isolate to v8Undefined ? I have to fix it when I fix bug 104088. Currently v8::Undefined(), v8Undefined() and Handle<Value>() are mixed inconsistently. 191039 2013-03-01 14:45:01 -0800 2013-03-03 15:56:46 -0800 Patch bug-111223-20130301144112.patch text/plain 5723 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTBkYzczMDU4NjI2NGJk ODcwYWFkN2Y0MGIxY2IxOTIxMzAwM2Y4NC4uNDY2YWJhNjVhMWVjY2Y4MWVmYWE5ZjQ2ZDI2NDk4 MDExNjZlMmI1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgSFRN TERvY3VtZW50OjpnZXROYW1lZFByb3BlcnR5KCkgdG8gRE9NV2luZG93U2hlbGwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTIyMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhUTUxEb2N1bWVudDo6Z2V0 TmFtZWRQcm9wZXJ0eSgpIGlzIHVzZWQgYnkgRE9NV2luZG93U2hlbGwuCisgICAgICAgIEl0IGNh biBiZSBhIHN0YXRpYyBtZXRob2QgaW4gRE9NV2luZG93U2hlbGwuCisKKyAgICAgICAgTm8gdGVz dHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVIZWFkZXIpOgorICAgICAgICAq IGJpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0 TmFtZWRQcm9wZXJ0eSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6Omdl dHRlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9t LmNwcDoKKwogMjAxMy0wMy0wMSAgVWRheSBLaXJhbiAgPHVkYXlraXJhbkBtb3Rvcm9sYS5jb20+ CiAKICAgICAgICAgZ2V0Q29tcHV0ZWRTdHlsZSBub3QgaW1wbGVtZW50ZWQgZm9yIC13ZWJraXQt Y29sdW1uLXJ1bGUgc2hvcnRoYW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IGJjZDNkYzY4MWE2YWM0ZTU5YWVkODZiZjBk ZmNiMTU1Mjg4ZDM5Y2QuLjY2NDBkZGMzZDg1MjY2MjVkZjdlZDJlYTU2OWEzZTM3ZDgzZjk1YTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtCkBAIC0zOTIsNyArMzkyLDYgQEAgRU5ECiAgICAgaWYgKCRpbnRlcmZhY2VOYW1lIGVx ICJIVE1MRG9jdW1lbnQiKSB7CiAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCA8PEVORCk7CiAg ICAgc3RhdGljIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiB3cmFwSW5TaGFkb3dPYmplY3Qodjg6Okxv Y2FsPHY4OjpPYmplY3Q+IHdyYXBwZXIsIE5vZGUqIGltcGwsIHY4OjpJc29sYXRlKik7Ci0gICAg c3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBnZXROYW1lZFByb3BlcnR5KEhUTUxEb2N1bWVu dCogaHRtbERvY3VtZW50LCBjb25zdCBBdG9taWNTdHJpbmcmIGtleSwgdjg6OkhhbmRsZTx2ODo6 T2JqZWN0PiBjcmVhdGlvbkNvbnRleHQsIHY4OjpJc29sYXRlKik7CiBFTkQKICAgICB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKaW5kZXgg OTU0NjkwNDE4ZDBmNTdiNWY3YzdkOGEyYmNlOGEyMjg2ZDNlM2E1ZS4uMGIzOTEwZWNjZjhlNmMx MTA0ODJkYjFkMzFiYWNhM2Y2N2NmMzE3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKQEAgLTM2LDYgKzM2LDggQEAKICNpbmNsdWRlICJE b2N1bWVudExvYWRlci5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVMb2Fk ZXJDbGllbnQuaCIKKyNpbmNsdWRlICJIVE1MQ29sbGVjdGlvbi5oIgorI2luY2x1ZGUgIkhUTUxJ RnJhbWVFbGVtZW50LmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uLmgiCiAj aW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMuaCIKQEAg LTQ1LDYgKzQ3LDcgQEAKICNpbmNsdWRlICJWOERPTVdpbmRvdy5oIgogI2luY2x1ZGUgIlY4RG9j dW1lbnQuaCIKICNpbmNsdWRlICJWOEdDRm9yQ29udGV4dERpc3Bvc2UuaCIKKyNpbmNsdWRlICJW OEhUTUxDb2xsZWN0aW9uLmgiCiAjaW5jbHVkZSAiVjhIVE1MRG9jdW1lbnQuaCIKICNpbmNsdWRl ICJWOEhpZGRlblByb3BlcnR5TmFtZS5oIgogI2luY2x1ZGUgIlY4SW5pdGlhbGl6ZXIuaCIKQEAg LTQyNiwxMyArNDI5LDMyIEBAIHZvaWQgVjhET01XaW5kb3dTaGVsbDo6dXBkYXRlRG9jdW1lbnQo KQogICAgIHVwZGF0ZVNlY3VyaXR5T3JpZ2luKCk7CiB9CiAKK3N0YXRpYyB2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gZ2V0TmFtZWRQcm9wZXJ0eShIVE1MRG9jdW1lbnQqIGh0bWxEb2N1bWVudCwgY29u c3QgQXRvbWljU3RyaW5nJiBrZXksIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gY3JlYXRpb25Db250 ZXh0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKK3sKKyAgICBpZiAoIWh0bWxEb2N1bWVudC0+aGFz TmFtZWRJdGVtKGtleS5pbXBsKCkpICYmICFodG1sRG9jdW1lbnQtPmhhc0V4dHJhTmFtZWRJdGVt KGtleS5pbXBsKCkpKQorICAgICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTsKKworICAgIFJlZlB0 cjxIVE1MQ29sbGVjdGlvbj4gaXRlbXMgPSBodG1sRG9jdW1lbnQtPmRvY3VtZW50TmFtZWRJdGVt cyhrZXkpOworICAgIGlmIChpdGVtcy0+aXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gdjhVbmRl ZmluZWQoKTsKKworICAgIGlmIChpdGVtcy0+aGFzRXhhY3RseU9uZUl0ZW0oKSkgeworICAgICAg ICBOb2RlKiBub2RlID0gaXRlbXMtPml0ZW0oMCk7CisgICAgICAgIEZyYW1lKiBmcmFtZSA9IDA7 CisgICAgICAgIGlmIChub2RlLT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6aWZyYW1lVGFnKSAmJiAo ZnJhbWUgPSBzdGF0aWNfY2FzdDxIVE1MSUZyYW1lRWxlbWVudCo+KG5vZGUpLT5jb250ZW50RnJh bWUoKSkpCisgICAgICAgICAgICByZXR1cm4gdG9WOChmcmFtZS0+ZG9jdW1lbnQoKS0+ZG9tV2lu ZG93KCksIGNyZWF0aW9uQ29udGV4dCwgaXNvbGF0ZSk7CisgICAgICAgIHJldHVybiB0b1Y4KG5v ZGUsIGNyZWF0aW9uQ29udGV4dCwgaXNvbGF0ZSk7CisgICAgfQorICAgIHJldHVybiB0b1Y4KGl0 ZW1zLnJlbGVhc2UoKSwgY3JlYXRpb25Db250ZXh0LCBpc29sYXRlKTsKK30KKwogc3RhdGljIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBnZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IHByb3BlcnR5 LCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZvKQogewogICAgIC8vIEZJWE1FOiBDb25zaWRl ciBwYXNzaW5nIEF0b21pY1N0cmluZ0ltcGwgZGlyZWN0bHkuCiAgICAgQXRvbWljU3RyaW5nIG5h bWUgPSB0b1dlYkNvcmVBdG9taWNTdHJpbmcocHJvcGVydHkpOwogICAgIEhUTUxEb2N1bWVudCog aHRtbERvY3VtZW50ID0gVjhIVE1MRG9jdW1lbnQ6OnRvTmF0aXZlKGluZm8uSG9sZGVyKCkpOwog ICAgIEFTU0VSVChodG1sRG9jdW1lbnQpOwotICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiByZXN1 bHQgPSBWOEhUTUxEb2N1bWVudDo6Z2V0TmFtZWRQcm9wZXJ0eShodG1sRG9jdW1lbnQsIG5hbWUs IGluZm8uSG9sZGVyKCksIGluZm8uR2V0SXNvbGF0ZSgpKTsKKyAgICB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gcmVzdWx0ID0gZ2V0TmFtZWRQcm9wZXJ0eShodG1sRG9jdW1lbnQsIG5hbWUsIGluZm8u SG9sZGVyKCksIGluZm8uR2V0SXNvbGF0ZSgpKTsKICAgICBpZiAoIXJlc3VsdC5Jc0VtcHR5KCkp CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHByb3Rv dHlwZSA9IGluZm8uSG9sZGVyKCktPkdldFByb3RvdHlwZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5jcHAK aW5kZXggNWMxZjY1ZmY1MTlkYTJlYzU3ODdlNDcyMDBlNzA2NThmYWNhODIxNC4uMjQ0NzIwZDA0 ZTJmNmNmZjI0NDVjYWRlNDU5Y2Q3NzMxNDAxZWZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCkBA IC04MCwyNyArODAsNiBAQCB2ODo6TG9jYWw8djg6Ok9iamVjdD4gVjhIVE1MRG9jdW1lbnQ6Ondy YXBJblNoYWRvd09iamVjdCh2ODo6TG9jYWw8djg6Ok9iamVjdD4gdwogICAgIHJldHVybiBzaGFk b3c7CiB9CiAKLXY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhUTUxEb2N1bWVudDo6Z2V0TmFtZWRQ cm9wZXJ0eShIVE1MRG9jdW1lbnQqIGh0bWxEb2N1bWVudCwgY29uc3QgQXRvbWljU3RyaW5nJiBr ZXksIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gY3JlYXRpb25Db250ZXh0LCB2ODo6SXNvbGF0ZSog aXNvbGF0ZSkKLXsKLSAgICBpZiAoIWh0bWxEb2N1bWVudC0+aGFzTmFtZWRJdGVtKGtleS5pbXBs KCkpICYmICFodG1sRG9jdW1lbnQtPmhhc0V4dHJhTmFtZWRJdGVtKGtleS5pbXBsKCkpKQotICAg ICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTsKLQotICAgIFJlZlB0cjxIVE1MQ29sbGVjdGlvbj4g aXRlbXMgPSBodG1sRG9jdW1lbnQtPmRvY3VtZW50TmFtZWRJdGVtcyhrZXkpOwotICAgIGlmIChp dGVtcy0+aXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTsKLQotICAgIGlm IChpdGVtcy0+aGFzRXhhY3RseU9uZUl0ZW0oKSkgewotICAgICAgICBOb2RlKiBub2RlID0gaXRl bXMtPml0ZW0oMCk7Ci0gICAgICAgIEZyYW1lKiBmcmFtZSA9IDA7Ci0gICAgICAgIGlmIChub2Rl LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6aWZyYW1lVGFnKSAmJiAoZnJhbWUgPSBzdGF0aWNfY2Fz dDxIVE1MSUZyYW1lRWxlbWVudCo+KG5vZGUpLT5jb250ZW50RnJhbWUoKSkpCi0gICAgICAgICAg ICByZXR1cm4gdG9WOChmcmFtZS0+ZG9jdW1lbnQoKS0+ZG9tV2luZG93KCksIGNyZWF0aW9uQ29u dGV4dCwgaXNvbGF0ZSk7Ci0KLSAgICAgICAgcmV0dXJuIHRvVjgobm9kZSwgY3JlYXRpb25Db250 ZXh0LCBpc29sYXRlKTsKLSAgICB9Ci0KLSAgICByZXR1cm4gdG9WOChpdGVtcy5yZWxlYXNlKCks IGNyZWF0aW9uQ29udGV4dCwgaXNvbGF0ZSk7Ci19Ci0KIC8vIEhUTUxEb2N1bWVudCAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiAKIC8vIENvbmNhdGVuYXRlcyAiYXJncyIgdG8gYSBzdHJpbmcuIElmIGFyZ3MgaXMgZW1wdHks IHJldHVybnMgZW1wdHkgc3RyaW5nLgo=