111204 2013-03-01 12:06:17 -0800 [BlackBerry] Improve input bounds clipping for search fields. 2013-03-01 13:09:41 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 845382 0 mifenton 2013-03-01 12:06:17 -0800 The input field bounds used by selection handling does not take into account the X in the search field. 845388 1 191006 mifenton 2013-03-01 12:10:56 -0800 Created attachment 191006 Patch 845394 2 191006 rwlbuis 2013-03-01 12:17:14 -0800 Comment on attachment 191006 Patch LGTM. 845444 3 191006 webkit.review.bot 2013-03-01 13:09:32 -0800 Comment on attachment 191006 Patch Clearing flags on attachment: 191006 Committed r144488: <http://trac.webkit.org/changeset/144488> 845446 4 webkit.review.bot 2013-03-01 13:09:41 -0800 All reviewed patches have been landed. Closing bug. 191006 2013-03-01 12:10:56 -0800 2013-03-01 13:09:31 -0800 Patch 0001-2013-03-01-Mike-Fenton-mifenton-rim.com.patch text/plain 3950 mifenton RnJvbSA1OGZjNTU1MGRhMmVhMGZmMzlhNTUwZmU3ZTYxMWFkNzNjZjBiYjhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog RnJpLCAxIE1hciAyMDEzIDEyOjQxOjE5IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMy0wMy0w MSAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgoKICAgICAgICBQUiAyOTI2NzMuCgog ICAgICAgIFVzZSB0aGUgc3RhbmRhcmRpemVkIElucHV0SGFuZGxlciBmdW5jdGlvbiB0byBnZXQg dGhlCiAgICAgICAgYm91bmRzIG9mIGFuIGlucHV0IGZpZWxkIHNvIHRoYXQgc2VhcmNoIGZpZWxk cyBhcmUKICAgICAgICB0cnVuY2F0ZWQgc21hbGxlciB0byBhY2NvdW50IGZvciB0aGUgWC4KCiAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9y dC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxl Y3Rpb25IYW5kbGVyOjpzZXRDYXJldFBvc2l0aW9uKToKKGNoZXJyeSBwaWNrZWQgZnJvbSBjb21t aXQgNDRiMmU5YTY1OTZlOGIwNmE0MThjM2ZjYWRhMzAzMzc3OWMzMzY2YSkKLS0tCiBTb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysr KysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVy LmNwcCAgfCAgIDIyICsrKysrKysrLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI3IGlu c2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n CmluZGV4IDEyNDhiOWEuLjA4MDQwOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpA QCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTAxICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5j b20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEltcHJvdmUgaW5wdXQgYm91bmRzIGNsaXBwaW5n IGZvciBzZWFyY2ggZmllbGRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTExMjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUFIgMjkyNjczLgorCisgICAgICAgIFVzZSB0aGUgc3RhbmRhcmRpemVkIElu cHV0SGFuZGxlciBmdW5jdGlvbiB0byBnZXQgdGhlCisgICAgICAgIGJvdW5kcyBvZiBhbiBpbnB1 dCBmaWVsZCBzbyB0aGF0IHNlYXJjaCBmaWVsZHMgYXJlCisgICAgICAgIHRydW5jYXRlZCBzbWFs bGVyIHRvIGFjY291bnQgZm9yIHRoZSBYLgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkg YnkgR2VuIE1hay4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OnNldENh cmV0UG9zaXRpb24pOgorCiAyMDEzLTAyLTA3ICBKYWtvYiBQZXRzb3ZpdHMgIDxqcGV0c292aXRz QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEZpeCBhbGwgZmxpY2tlciBjYXVzZWQg YnkgZW1wdHkvaW5jb21wbGV0ZSBnZW9tZXRyaWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRl eCBlMWRlZTg5Li5mMmZjMGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcApAQCAtMjYwLDIyICsy NjAsMTggQEAgdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZXRDYXJldFBvc2l0aW9uKGNvbnN0IFdl YkNvcmU6OkludFBvaW50JiBwb3NpdGlvbikKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAg IFZpc2libGVQb3NpdGlvbiB2aXNpYmxlQ2FyZXRQb3NpdGlvbihmb2N1c2VkRnJhbWUtPnZpc2li bGVQb3NpdGlvbkZvclBvaW50KHJlbGF0aXZlUG9pbnQpKTsKKyAgICBXZWJDb3JlOjpJbnRSZWN0 IG5vZGVPdXRsaW5lQm91bmRzKG1fd2ViUGFnZS0+bV9pbnB1dEhhbmRsZXItPmJvdW5kaW5nQm94 Rm9ySW5wdXRGaWVsZCgpKTsKKyAgICBpZiAoIW5vZGVPdXRsaW5lQm91bmRzLmlzRW1wdHkoKSAm JiAhbm9kZU91dGxpbmVCb3VuZHMuY29udGFpbnMocmVsYXRpdmVQb2ludCkpIHsKKyAgICAgICAg aWYgKHVuc2lnbmVkIGNoYXJhY3RlciA9IGRpcmVjdGlvbk9mUG9pbnRSZWxhdGl2ZVRvUmVjdChy ZWxhdGl2ZVBvaW50LCBjdXJyZW50Q2FyZXRSZWN0KSkKKyAgICAgICAgICAgIG1fd2ViUGFnZS0+ bV9pbnB1dEhhbmRsZXItPmhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06OktleWJvYXJkRXZl bnQoY2hhcmFjdGVyKSk7CiAKLSAgICBpZiAoUmVuZGVyT2JqZWN0KiBmb2N1c2VkUmVuZGVyZXIg PSBmb2N1c2VkRnJhbWUtPmRvY3VtZW50KCktPmZvY3VzZWROb2RlKCktPnJlbmRlcmVyKCkpIHsK LSAgICAgICAgV2ViQ29yZTo6SW50UmVjdCBub2RlT3V0bGluZUJvdW5kcyhmb2N1c2VkUmVuZGVy ZXItPmFic29sdXRlT3V0bGluZUJvdW5kcygpKTsKLSAgICAgICAgaWYgKCFub2RlT3V0bGluZUJv dW5kcy5jb250YWlucyhyZWxhdGl2ZVBvaW50KSkgewotICAgICAgICAgICAgaWYgKHVuc2lnbmVk IGNoYXJhY3RlciA9IGRpcmVjdGlvbk9mUG9pbnRSZWxhdGl2ZVRvUmVjdChyZWxhdGl2ZVBvaW50 LCBjdXJyZW50Q2FyZXRSZWN0KSkKLSAgICAgICAgICAgICAgICBtX3dlYlBhZ2UtPm1faW5wdXRI YW5kbGVyLT5oYW5kbGVLZXlib2FyZElucHV0KFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50KGNoYXJh Y3RlcikpOwotCi0gICAgICAgICAgICAvLyBTZW5kIHRoZSBzZWxlY3Rpb24gY2hhbmdlZCBpbiBj YXNlIHRoaXMgZG9lcyBub3QgdHJpZ2dlciBhIHNlbGVjdGlvbiBjaGFuZ2UgdG8KLSAgICAgICAg ICAgIC8vIGVuc3VyZSB0aGUgY2FyZXQgcG9zaXRpb24gaXMgYWNjdXJhdGUuIFRoaXMgbWF5IGJl IGEgZHVwbGljYXRlIGV2ZW50LgotICAgICAgICAgICAgc2VsZWN0aW9uUG9zaXRpb25DaGFuZ2Vk KHRydWUgLyogZm9yY2VVcGRhdGVXaXRob3V0Q2hhbmdlICovKTsKLSAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgfQorICAgICAgICAvLyBTZW5kIHRoZSBzZWxlY3Rpb24gY2hhbmdlZCBpbiBj YXNlIHRoaXMgZG9lcyBub3QgdHJpZ2dlciBhIHNlbGVjdGlvbiBjaGFuZ2UgdG8KKyAgICAgICAg Ly8gZW5zdXJlIHRoZSBjYXJldCBwb3NpdGlvbiBpcyBhY2N1cmF0ZS4gVGhpcyBtYXkgYmUgYSBk dXBsaWNhdGUgZXZlbnQuCisgICAgICAgIHNlbGVjdGlvblBvc2l0aW9uQ2hhbmdlZCh0cnVlIC8q IGZvcmNlVXBkYXRlV2l0aG91dENoYW5nZSAqLyk7CisgICAgICAgIHJldHVybjsKICAgICB9CiAK LSAgICBWaXNpYmxlU2VsZWN0aW9uIG5ld1NlbGVjdGlvbih2aXNpYmxlQ2FyZXRQb3NpdGlvbik7 CisgICAgVmlzaWJsZVNlbGVjdGlvbiBuZXdTZWxlY3Rpb24oZm9jdXNlZEZyYW1lLT52aXNpYmxl UG9zaXRpb25Gb3JQb2ludChyZWxhdGl2ZVBvaW50KSk7CiAgICAgaWYgKGNvbnRyb2xsZXItPnNl bGVjdGlvbigpID09IG5ld1NlbGVjdGlvbikgewogICAgICAgICBzZWxlY3Rpb25Qb3NpdGlvbkNo YW5nZWQodHJ1ZSAvKiBmb3JjZVVwZGF0ZVdpdGhvdXRDaGFuZ2UgKi8pOwogICAgICAgICByZXR1 cm47Ci0tIAoxLjcuOS41Cgo=