111195 2013-03-01 10:58:04 -0800 Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort(). 2013-03-04 09:26:47 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 acolwell acolwell abarth dglazkov eric.carlson feature-media-reviews fishd jamesr jer.noble tkent+wkapi webkit.review.bot oldest_to_newest 845308 0 acolwell 2013-03-01 10:58:04 -0800 I accidentally added a boolean return value to SourceBufferPrivate::abort() and WebSourceBuffer::abort() that is not used anywhere. This should be removed. 845314 1 190992 acolwell 2013-03-01 11:03:13 -0800 Created attachment 190992 Patch 845322 2 webkit.review.bot 2013-03-01 11:06:14 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 845925 3 190992 abarth 2013-03-02 23:13:46 -0800 Comment on attachment 190992 Patch ok 845955 4 190992 webkit.review.bot 2013-03-03 00:29:56 -0800 Comment on attachment 190992 Patch Rejecting attachment 190992 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190992, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://webkit-commit-queue.appspot.com/results/16898247 846564 5 190992 webkit.review.bot 2013-03-04 09:26:43 -0800 Comment on attachment 190992 Patch Clearing flags on attachment: 190992 Committed r144638: <http://trac.webkit.org/changeset/144638> 846565 6 webkit.review.bot 2013-03-04 09:26:47 -0800 All reviewed patches have been landed. Closing bug. 190992 2013-03-01 11:03:13 -0800 2013-03-04 09:26:43 -0800 Patch bug-111195-20130301105924.patch text/plain 5594 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWMyODhlOWVjYThhMWM5 NGI0YWY5ZjlmMjQ2ZmE5ZWE0MTdkNjkxYi4uZWI2OWZhOTA5YjExYjc0NTg3Y2ZiNzVhZjRjOGM5 NTU2ZWU0ZDZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTAxICBBYXJv biBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSB1bnVz ZWQgcmV0dXJuIHZhbHVlIGZyb20gU291cmNlQnVmZmVyUHJpdmF0ZTo6YWJvcnQoKSBhbmQgV2Vi U291cmNlQnVmZmVyOjphYm9ydCgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTExMTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyB1c2VyIHZpc2libGUgYmVoYXZpb3IgY2hh bmdlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1NvdXJjZUJ1ZmZlclByaXZhdGUu aDoKKyAgICAgICAgKFNvdXJjZUJ1ZmZlclByaXZhdGUpOgorCiAyMDEzLTAzLTAxICBWc2V2b2xv ZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IE5hdmlnYXRvciBzaG91bGQgc2hvdyB0cmVlIGVsZW1lbnQgZm9yIGVhY2ggZm9sZGVyIGluIHRo ZSBzb3VyY2UgcGF0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggODUwMmZkYzY0MjBj OWY5ZDYzNTE5ZjNlNjk4MjJmNTM4MTQwNDE4Yi4uY2UyYTFlM2RmMmMxY2NhMjk4NWM4OTczYjI0 YjMwYWQ3NmYwZmVjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBA QAorMjAxMy0wMy0wMSAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZW1vdmUgdW51c2VkIHJldHVybiB2YWx1ZSBmcm9tIFNvdXJjZUJ1ZmZlclByaXZh dGU6OmFib3J0KCkgYW5kIFdlYlNvdXJjZUJ1ZmZlcjo6YWJvcnQoKS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTE5NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGljL1dlYlNvdXJjZUJ1ZmZl ci5oOgorICAgICAgICAoV2ViU291cmNlQnVmZmVyKToKKyAgICAgICAgKiBzcmMvU291cmNlQnVm ZmVyUHJpdmF0ZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpTb3VyY2VCdWZmZXJQcml2YXRl SW1wbDo6YWJvcnQpOgorICAgICAgICAqIHNyYy9Tb3VyY2VCdWZmZXJQcml2YXRlSW1wbC5oOgor ICAgICAgICAoU291cmNlQnVmZmVyUHJpdmF0ZUltcGwpOgorICAgICAgICAqIHNyYy9XZWJNZWRp YVBsYXllckNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViU291cmNlQnVmZmVySW1wbCk6Cisg ICAgICAgIChXZWJLaXQ6OldlYlNvdXJjZUJ1ZmZlckltcGw6OmFib3J0KToKKwogMjAxMy0wMy0w MSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0NDQyMiBhbmQgcjE0NDQyNC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NvdXJjZUJ1ZmZlclByaXZhdGUuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NvdXJjZUJ1ZmZlclByaXZhdGUuaApp bmRleCAwMjQwZGE3ZDdjYTlkNWI5MDc2NzVmMWQ4NmViYzAxY2RjNjUzYmZiLi4wMDliYWRmNzdl NWFiMjI2YmFmMGViZjJjYTJkNzVmZjc0ODRkM2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9Tb3VyY2VCdWZmZXJQcml2YXRlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU291cmNlQnVmZmVyUHJpdmF0ZS5oCkBAIC00Myw3ICs0 Myw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxUaW1lUmFuZ2VzPiBidWZm ZXJlZCgpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgYXBwZW5kKGNvbnN0IHVuc2lnbmVkIGNoYXIq IGRhdGEsIHVuc2lnbmVkIGxlbmd0aCkgPSAwOwotICAgIHZpcnR1YWwgYm9vbCBhYm9ydCgpID0g MDsKKyAgICB2aXJ0dWFsIHZvaWQgYWJvcnQoKSA9IDA7CiAgICAgdmlydHVhbCBib29sIHNldFRp bWVzdGFtcE9mZnNldChkb3VibGUpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlZEZyb21N ZWRpYVNvdXJjZSgpID0gMDsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJTb3VyY2VCdWZmZXIuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlNvdXJjZUJ1ZmZlci5oCmluZGV4IGQ1Nzk1OTY3M2EwMmU1MzYzOGU0MDJlMGEyYTgzZWI5 NjFiYmU5N2MuLjA2NDYyNmNkYTliOTRmZjRmNjFjMzViMTBiMmJiOGQ3M2Y4YWY5ZDkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNvdXJjZUJ1ZmZlci5oCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNvdXJjZUJ1ZmZlci5oCkBAIC00 MSw3ICs0MSw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgV2ViVGltZVJhbmdlcyBidWZmZXJl ZCgpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgYXBwZW5kKGNvbnN0IHVuc2lnbmVkIGNoYXIqIGRh dGEsIHVuc2lnbmVkIGxlbmd0aCkgPSAwOwotICAgIHZpcnR1YWwgYm9vbCBhYm9ydCgpID0gMDsK KyAgICB2aXJ0dWFsIHZvaWQgYWJvcnQoKSA9IDA7CiAgICAgdmlydHVhbCBib29sIHNldFRpbWVz dGFtcE9mZnNldChkb3VibGUpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlZEZyb21NZWRp YVNvdXJjZSgpID0gMDsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9Tb3VyY2VCdWZmZXJQcml2YXRlSW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9Tb3VyY2VCdWZmZXJQcml2YXRlSW1wbC5jcHAKaW5kZXggMDlhMmE2NzM4ZTZmNDBhYWQ0N2Uy NTc5MjA0NDdhOGI2NzY3YjI2ZC4uY2ZhZmVkODEyNDk1ZThkNWFmY2IxZmEyZTZlMGM5N2EyZjBk MTdiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU291cmNlQnVmZmVy UHJpdmF0ZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NvdXJjZUJ1 ZmZlclByaXZhdGVJbXBsLmNwcApAQCAtNjEsMTEgKzYxLDExIEBAIHZvaWQgU291cmNlQnVmZmVy UHJpdmF0ZUltcGw6OmFwcGVuZChjb25zdCB1bnNpZ25lZCBjaGFyKiBkYXRhLCB1bnNpZ25lZCBs ZW5ndGgpCiAgICAgbV9zb3VyY2VCdWZmZXItPmFwcGVuZChkYXRhLCBsZW5ndGgpOwogfQogCi1i b29sIFNvdXJjZUJ1ZmZlclByaXZhdGVJbXBsOjphYm9ydCgpCit2b2lkIFNvdXJjZUJ1ZmZlclBy aXZhdGVJbXBsOjphYm9ydCgpCiB7CiAgICAgaWYgKCFtX3NvdXJjZUJ1ZmZlcikKLSAgICAgICAg cmV0dXJuIGZhbHNlOwotICAgIHJldHVybiBtX3NvdXJjZUJ1ZmZlci0+YWJvcnQoKTsKKyAgICAg ICAgcmV0dXJuOworICAgIG1fc291cmNlQnVmZmVyLT5hYm9ydCgpOwogfQogCiBib29sIFNvdXJj ZUJ1ZmZlclByaXZhdGVJbXBsOjpzZXRUaW1lc3RhbXBPZmZzZXQoZG91YmxlIG9mZnNldCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NvdXJjZUJ1ZmZlclByaXZhdGVJ bXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Tb3VyY2VCdWZmZXJQcml2YXRlSW1w bC5oCmluZGV4IGJjMjg3ZDJkYzQwMjVkNWViOWY5ZjYyMzkwNjFkNzMwZjUwZTkzMWQuLjM2NWU0 ZmI0YzlmNTZjNDVjNjgzNmY5MDAwYWE3NjQ0ZjdlNmY1YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1NvdXJjZUJ1ZmZlclByaXZhdGVJbXBsLmgKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvU291cmNlQnVmZmVyUHJpdmF0ZUltcGwuaApAQCAtNDksNyAr NDksNyBAQCBwdWJsaWM6CiAgICAgLy8gU291cmNlQnVmZmVyUHJpdmF0ZSBtZXRob2RzLgogICAg IHZpcnR1YWwgUGFzc1JlZlB0cjxXZWJDb3JlOjpUaW1lUmFuZ2VzPiBidWZmZXJlZCgpOwogICAg IHZpcnR1YWwgdm9pZCBhcHBlbmQoY29uc3QgdW5zaWduZWQgY2hhciogZGF0YSwgdW5zaWduZWQg bGVuZ3RoKTsKLSAgICB2aXJ0dWFsIGJvb2wgYWJvcnQoKTsKKyAgICB2aXJ0dWFsIHZvaWQgYWJv cnQoKTsKICAgICB2aXJ0dWFsIGJvb2wgc2V0VGltZXN0YW1wT2Zmc2V0KGRvdWJsZSk7CiAgICAg dmlydHVhbCB2b2lkIHJlbW92ZWRGcm9tTWVkaWFTb3VyY2UoKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAKaW5k ZXggZWU5ZGNiNWE4MjliNTY0NGRjZTMyMDE2OTRhNTIzYWQ4Njk2ZmZiMS4uYzNkYmJjMzM0M2I1 YjM0YTY2ZjhlN2E5Yzc3Yjg2Y2JhYmM5Mzc4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCkBAIC04MSw3ICs4 MSw3IEBAIHB1YmxpYzoKICAgICAvLyBXZWJTb3VyY2VCdWZmZXIgbWV0aG9kcy4KICAgICB2aXJ0 dWFsIFdlYlRpbWVSYW5nZXMgYnVmZmVyZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgYXBwZW5kKGNv bnN0IHVuc2lnbmVkIGNoYXIqIGRhdGEsIHVuc2lnbmVkIGxlbmd0aCk7Ci0gICAgdmlydHVhbCBi b29sIGFib3J0KCk7CisgICAgdmlydHVhbCB2b2lkIGFib3J0KCk7CiAgICAgdmlydHVhbCBib29s IHNldFRpbWVzdGFtcE9mZnNldChkb3VibGUpOwogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVkRnJv bU1lZGlhU291cmNlKCk7CiAKQEAgLTE0MSw5ICsxNDEsOSBAQCB2b2lkIFdlYlNvdXJjZUJ1ZmZl ckltcGw6OmFwcGVuZChjb25zdCB1bnNpZ25lZCBjaGFyKiBkYXRhLCB1bnNpZ25lZCBsZW5ndGgp CiAgICAgbV93ZWJNZWRpYVBsYXllci0+c291cmNlQXBwZW5kKG1faWQsIGRhdGEsIGxlbmd0aCk7 CiB9CiAKLWJvb2wgV2ViU291cmNlQnVmZmVySW1wbDo6YWJvcnQoKQordm9pZCBXZWJTb3VyY2VC dWZmZXJJbXBsOjphYm9ydCgpCiB7Ci0gICAgcmV0dXJuIG1fd2ViTWVkaWFQbGF5ZXItPnNvdXJj ZUFib3J0KG1faWQpOworICAgIG1fd2ViTWVkaWFQbGF5ZXItPnNvdXJjZUFib3J0KG1faWQpOwog fQogCiBib29sIFdlYlNvdXJjZUJ1ZmZlckltcGw6OnNldFRpbWVzdGFtcE9mZnNldChkb3VibGUg b2Zmc2V0KQo=