111178 2013-03-01 06:48:50 -0800 Changing "#define YYDEBUG 0" to 1 causing compilation error 2013-03-21 04:19:56 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P3 Trivial --- 1 serya serya esprehn+autocc macpherson menard ojan.autocc webkit.review.bot oldest_to_newest 845136 0 serya 2013-03-01 06:48:50 -0800 Changing "#define YYDEBUG 0: in Source/WebCore/css/CSSGrammar.y.includes to 1 causes compilation error. 845139 1 190960 serya 2013-03-01 06:51:20 -0800 Created attachment 190960 Patch 845714 2 190960 mrowe 2013-03-01 20:04:26 -0800 Comment on attachment 190960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190960&action=review > Source/WebCore/ChangeLog:3 > + Fixed. This is unnecessary. > Source/WebCore/ChangeLog:5 > + CSS debugging code is broken This is too vague. > Source/WebCore/ChangeLog:16 > + * css/CSSGrammar.y.includes: > + * css/CSSParser.cpp: > + (WebCore::CSSParser::rewriteSpecifiers): > + * css/CSSParser.h: > + (WebCore): These are here so you can provide a description of what changes you made, and why. > Source/WebCore/css/CSSParser.cpp:11964 > +String yylvalToString(int yytype, const void* yylvalWithoutType) Why is this implemented unconditionally when it's only ever used when YYDEBUG is > 0? > Source/WebCore/css/CSSParser.h:713 > + Why is this defined unconditionally when it's only ever used when YYDEBUG is > 0? 859118 3 193992 serya 2013-03-20 00:22:50 -0700 Created attachment 193992 Patch 859121 4 190960 serya 2013-03-20 00:29:14 -0700 Comment on attachment 190960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190960&action=review I moved this code to CSSGrammar.y.in. I hope it make it easier to understand. >> Source/WebCore/css/CSSParser.cpp:11964 >> +String yylvalToString(int yytype, const void* yylvalWithoutType) > > Why is this implemented unconditionally when it's only ever used when YYDEBUG is > 0? Because YYDEBUG from CSSGrammar.y.include if completely different from one defined in CSSParser.cpp. Is inaccessible here. I prefer to use only one from CSSGrammar.y.include in order to have more precise contron on what stylesheet to debug. 860202 5 193992 webkit.review.bot 2013-03-21 04:19:53 -0700 Comment on attachment 193992 Patch Clearing flags on attachment: 193992 Committed r146451: <http://trac.webkit.org/changeset/146451> 860203 6 webkit.review.bot 2013-03-21 04:19:56 -0700 All reviewed patches have been landed. Closing bug. 190960 2013-03-01 06:51:20 -0800 2013-03-20 00:29:14 -0700 Patch bug-111178-20130301184730.patch text/plain 3372 serya U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIzOGJjNDViNGQzN2Q0 NDhmYmU1N2Y5MDkyYTIyY2M0OTdiYWRmZi4uZmRjYWI3MWIyMTBiMGJmZDQ5ZWFlOTNmMDg5MTdk ZWNkOWVjNGVlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTAxICBTZXJn ZXkgUnlhemFub3YgIDxzZXJ5YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4ZWQuCisKKyAg ICAgICAgQ1NTIGRlYnVnZ2luZyBjb2RlIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAg ICAgKiBjc3MvQ1NTR3JhbW1hci55LmluY2x1ZGVzOgorICAgICAgICAqIGNzcy9DU1NQYXJzZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpyZXdyaXRlU3BlY2lmaWVycyk6Cisg ICAgICAgICogY3NzL0NTU1BhcnNlci5oOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTMtMDMt MDEgIEFsZXhlaSBGaWxpcHBvdiAgPGFscGhAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IGZpeCBjbG9zdXJlIGNvbXBpbGVyIHdhcm5pbmdzIGluIFByb2ZpbGVzUGFuZWwK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW5jbHVkZXMgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluY2x1ZGVzCmluZGV4IDcyNjg5NzQ1MGI0 MWM1ODE3MDE5M2I5YjAwOGI2NDZiNGNkYTY2N2EuLjQ4ZjZiMjBjYzJiY2JkNjNjY2NmMTgwZDRh ZDU2MWRjM2NmZGFjNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFy LnkuaW5jbHVkZXMKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbmNsdWRl cwpAQCAtNTQsMzIgKzU0LDcgQEAgdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKICNkZWZpbmUg WVlERUJVRyAwCiAKICNpZiBZWURFQlVHID4gMAotI2RlZmluZSBZWVBSSU5UKEZpbGUsVHlwZSxW YWx1ZSkgcHJpbnRfdG9rZW5fdmFsdWUoRmlsZSxUeXBlLFZhbHVlKQotc3RhdGljIHZvaWQgcHJp bnRfdG9rZW5fdmFsdWUoRklMRSAqIHl5b3V0cHV0LCBpbnQgeXl0eXBlLCBZWVNUWVBFIGNvbnN0 ICZ5eXZhbHVlKQotewotICAgIHN3aXRjaCAoeXl0eXBlKSB7Ci0gICAgY2FzZSBJREVOVDoKLSAg ICBjYXNlIFNUUklORzoKLSAgICBjYXNlIE5USDoKLSAgICBjYXNlIEhFWDoKLSAgICBjYXNlIElE U0VMOgotICAgIGNhc2UgRElNRU46Ci0gICAgY2FzZSBJTlZBTElERElNRU46Ci0gICAgY2FzZSBV Ukk6Ci0gICAgY2FzZSBGVU5DVElPTjoKLSAgICBjYXNlIEFOWUZVTkNUSU9OOgotICAgIGNhc2Ug Tk9URlVOQ1RJT046Ci0gICAgY2FzZSBDQUxDRlVOQ1RJT046Ci0gICAgY2FzZSBNSU5GVU5DVElP TjoKLSAgICBjYXNlIE1BWEZVTkNUSU9OOgotICAgIGNhc2UgVkFSX0RFRklOSVRJT046Ci0gICAg Y2FzZSBVTklDT0RFUkFOR0U6Ci0gICAgICAgIFlZRlBSSU5URih5eW91dHB1dCwgIiVzIiwgU3Ry aW5nKHl5dmFsdWUuc3RyaW5nKS51dGY4KCkuZGF0YSgpKTsKLSAgICAgICAgYnJlYWs7Ci0gICAg ZGVmYXVsdDoKLSAgICAgICAgYnJlYWs7Ci0gICAgfQotfQorI2RlZmluZSBZWVBSSU5UKEZpbGUs VHlwZSxWYWx1ZSkgWVlGUFJJTlRGKEZpbGUsICIlcyIsIHl5bHZhbFRvU3RyaW5nKFR5cGUsICYo VmFsdWUpKS51dGY4KCkuZGF0YSgpKQogI2VuZGlmCiAKICV9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCmluZGV4IGUwMDJlMTAyZWEwMzA3NzEwN2M0OWMyMjk5MDEyZjcwNWQyYzgwYTYuLjVlMGUx N2FhY2IxNjViMmUwOTdkOTMzYjdiZTRkOTk3ZGM4YzUzOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuY3BwCkBAIC0xMTk2MSw0ICsxMTk2MSwzMSBAQCBib29sIGlzVmFsaWROdGhUb2tlbihjb25z dCBDU1NQYXJzZXJTdHJpbmcmIHRva2VuKQogICAgICAgICB8fCBlcXVhbElnbm9yaW5nQ2FzZSh0 b2tlbiwgIm4iKSB8fCBlcXVhbElnbm9yaW5nQ2FzZSh0b2tlbiwgIi1uIik7CiB9CiAKK1N0cmlu ZyB5eWx2YWxUb1N0cmluZyhpbnQgeXl0eXBlLCBjb25zdCB2b2lkKiB5eWx2YWxXaXRob3V0VHlw ZSkKK3sKKyAgICBjb25zdCBZWVNUWVBFKiB5eWx2YWwgPSBzdGF0aWNfY2FzdDxjb25zdCBZWVNU WVBFKj4oeXlsdmFsV2l0aG91dFR5cGUpOworCisgICAgc3dpdGNoICh5eXR5cGUpIHsKKyAgICBj YXNlIElERU5UOgorICAgIGNhc2UgU1RSSU5HOgorICAgIGNhc2UgTlRIOgorICAgIGNhc2UgSEVY OgorICAgIGNhc2UgSURTRUw6CisgICAgY2FzZSBESU1FTjoKKyAgICBjYXNlIElOVkFMSURESU1F TjoKKyAgICBjYXNlIFVSSToKKyAgICBjYXNlIEZVTkNUSU9OOgorICAgIGNhc2UgQU5ZRlVOQ1RJ T046CisgICAgY2FzZSBOT1RGVU5DVElPTjoKKyAgICBjYXNlIENBTENGVU5DVElPTjoKKyAgICBj YXNlIE1JTkZVTkNUSU9OOgorICAgIGNhc2UgTUFYRlVOQ1RJT046CisgICAgY2FzZSBWQVJfREVG SU5JVElPTjoKKyAgICBjYXNlIFVOSUNPREVSQU5HRToKKyAgICAgICAgcmV0dXJuIFN0cmluZyh5 eWx2YWwtPnN0cmluZyk7CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOwor ICAgIH0KK30KKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5o IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCmluZGV4IGRjYmEwMzM3NzMyZTI1NjY0 M2I0MTM5NTQ2OWYxNjlhYTEwMzRkZTIuLjI0OTkzMjVjZTc3OTQ4ODY2NTFlZjdjYzVhOTU4NTA1 MWYwNDFkYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKQEAgLTcwOSw2ICs3MDksOCBAQCBpbmxp bmUgaW50IGNzc3l5bGV4KHZvaWQqIHl5bHZhbCwgQ1NTUGFyc2VyKiBwYXJzZXIpCiAgICAgcmV0 dXJuIHBhcnNlci0+bGV4KHl5bHZhbCk7CiB9CiAKK1N0cmluZyB5eWx2YWxUb1N0cmluZyhpbnQs IGNvbnN0IHZvaWQqKTsKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gQ1NT UGFyc2VyX2gK 193992 2013-03-20 00:22:50 -0700 2013-03-21 04:19:53 -0700 Patch bug-111178-20130320111839.patch text/plain 3063 serya U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2MzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZiMGUzZTU5Y2Y3NzEz MDYyM2ExOWVlODYxNzUxMzllMjQ1OWY5Ni4uNGY3ZDJjMjNlMTI0MGY3Mjg5NDc2NWE2MTU5Yzll YjliM2JhZmJiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTIwICBTZXJn ZXkgUnlhemFub3YgIDxzZXJ5YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hhbmdpbmcgIiNk ZWZpbmUgWVlERUJVRyAwIiB0byAxIGNhdXNpbmcgY29tcGlsYXRpb24gZXJyb3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTE3OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvZGUgdGhhdCByZWZlcmVu Y2UgdG9rZW5zIGNhbid0IGJlIHBsYWNlZCBpbnRvIENTU0dyYW1tYXIueXkuaW5jbHVkZSBiZWNh dXNlIGl0J3MgaW5jbHVkZWQgYmVmb3JlIHRva2VucyBkZWZpbmVkLgorICAgICAgICBZWURFQlVH IGNhbid0IGJlIHVzZWQgaW4gQ1NTR3JhbW1hci55eS5pbiBiZWNhdXNlIHRoZSAjZGVmaW5lIGlz IG9ubHkgZGVmaW5lZCBpbiBDU1NHcmFtbWFyLnl5LmluY2x1ZGUuIFRoaXMKKyAgICAgICAgY2hh bmdlIHNpbXBsaWZpZXMgQ1NTIGRlYnVnZ2luZyBsZXR0aW5nIG1hbmlwdWxhdGUgb25seSAjZGVm aW5lIFlZREVCVUcgaW4gQ1NTR3JhbW1hci55eS5pbmNsdWRlIGFuZC9vciBpbiBDU1NQYXJzZXIu Y3BwLgorCisgICAgICAgICogY3NzL0NTU0dyYW1tYXIueS5pbjoKKyAgICAgICAgKiBjc3MvQ1NT R3JhbW1hci55LmluY2x1ZGVzOgorCiAyMDEzLTAzLTE5ICBFdWdlbmUgS2x5dWNobmlrb3YgIDxl dXN0YXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtUaW1lbGluZV0g VHVuZSBzdGF0dXMgYmFyIFVJIGZvciBsaW1pdGVkLXdpZHRoIHdpbmRvdy4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4gYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTR3JhbW1hci55LmluCmluZGV4IDAyZWNkZmU3MWVlZjYyZDQwZGI0ODY3MWZmZGRhNzZhZjg3 YTU5MjkuLjMwNTY5MjAyZjhhMWQwN2NlYTllYTMwOTI0OTUwNjk2NTUyMGU2MDkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkuaW4KKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU0dyYW1tYXIueS5pbgpAQCAtNTksNiArNTksMzEgQEAgc3RhdGljIGlubGluZSBp bnQgY3NzeXllcnJvcih2b2lkKiwgY29uc3QgY2hhciopCiAgICAgcmV0dXJuIDE7CiB9CiAKK3N0 YXRpYyBpbmxpbmUgYm9vbCBpc0NTU1Rva2VuQVN0cmluZyhpbnQgeXl0eXBlKQoreworICAgIHN3 aXRjaCAoeXl0eXBlKSB7CisgICAgY2FzZSBJREVOVDoKKyAgICBjYXNlIFNUUklORzoKKyAgICBj YXNlIE5USDoKKyAgICBjYXNlIEhFWDoKKyAgICBjYXNlIElEU0VMOgorICAgIGNhc2UgRElNRU46 CisgICAgY2FzZSBJTlZBTElERElNRU46CisgICAgY2FzZSBVUkk6CisgICAgY2FzZSBGVU5DVElP TjoKKyAgICBjYXNlIEFOWUZVTkNUSU9OOgorICAgIGNhc2UgTk9URlVOQ1RJT046CisgICAgY2Fz ZSBDQUxDRlVOQ1RJT046CisgICAgY2FzZSBNSU5GVU5DVElPTjoKKyAgICBjYXNlIE1BWEZVTkNU SU9OOgorICAgIGNhc2UgVkFSX0RFRklOSVRJT046CisgICAgY2FzZSBVTklDT0RFUkFOR0U6Cisg ICAgICAgIHJldHVybiB0cnVlOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICB9Cit9CisKICV9CiAKICNpZiBFTkFCTEVfU0hBRE9XX0RPTQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbmNsdWRlcyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NHcmFtbWFyLnkuaW5jbHVkZXMKaW5kZXggNzI2ODk3NDUwYjQxYzU4MTcwMTkzYjliMDA4 YjY0NmI0Y2RhNjY3YS4uYzlkMjRlNzY3NzVlYTM3ZjA0MmVhMDdmYTgyMDY1ZGNjNjkwNDdiZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueS5pbmNsdWRlcworKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55LmluY2x1ZGVzCkBAIC01NCwzMiArNTQs NyBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogI2RlZmluZSBZWURFQlVHIDAKIAogI2lm IFlZREVCVUcgPiAwCi0jZGVmaW5lIFlZUFJJTlQoRmlsZSxUeXBlLFZhbHVlKSBwcmludF90b2tl bl92YWx1ZShGaWxlLFR5cGUsVmFsdWUpCi1zdGF0aWMgdm9pZCBwcmludF90b2tlbl92YWx1ZShG SUxFICogeXlvdXRwdXQsIGludCB5eXR5cGUsIFlZU1RZUEUgY29uc3QgJnl5dmFsdWUpCi17Ci0g ICAgc3dpdGNoICh5eXR5cGUpIHsKLSAgICBjYXNlIElERU5UOgotICAgIGNhc2UgU1RSSU5HOgot ICAgIGNhc2UgTlRIOgotICAgIGNhc2UgSEVYOgotICAgIGNhc2UgSURTRUw6Ci0gICAgY2FzZSBE SU1FTjoKLSAgICBjYXNlIElOVkFMSURESU1FTjoKLSAgICBjYXNlIFVSSToKLSAgICBjYXNlIEZV TkNUSU9OOgotICAgIGNhc2UgQU5ZRlVOQ1RJT046Ci0gICAgY2FzZSBOT1RGVU5DVElPTjoKLSAg ICBjYXNlIENBTENGVU5DVElPTjoKLSAgICBjYXNlIE1JTkZVTkNUSU9OOgotICAgIGNhc2UgTUFY RlVOQ1RJT046Ci0gICAgY2FzZSBWQVJfREVGSU5JVElPTjoKLSAgICBjYXNlIFVOSUNPREVSQU5H RToKLSAgICAgICAgWVlGUFJJTlRGKHl5b3V0cHV0LCAiJXMiLCBTdHJpbmcoeXl2YWx1ZS5zdHJp bmcpLnV0ZjgoKS5kYXRhKCkpOwotICAgICAgICBicmVhazsKLSAgICBkZWZhdWx0OgotICAgICAg ICBicmVhazsKLSAgICB9Ci19CisjZGVmaW5lIFlZUFJJTlQoRmlsZSxUeXBlLFZhbHVlKSBpZiAo aXNDU1NUb2tlbkFTdHJpbmcoVHlwZSkpIFlZRlBSSU5URihGaWxlLCAiJXMiLCBTdHJpbmcoKFZh bHVlKS5zdHJpbmcpLnV0ZjgoKS5kYXRhKCkpCiAjZW5kaWYKIAogJX0K