111160 2013-03-01 04:09:25 -0800 [GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API 2013-03-08 02:42:24 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned andersca benjamin gustavo mrobinson sam webkit.review.bot oldest_to_newest 845046 0 cgarcia 2013-03-01 04:09:25 -0800 leakRef() is used for the returned PassRefPtr without taking the ownership of the leaked ref. 845048 1 190931 cgarcia 2013-03-01 04:11:50 -0800 Created attachment 190931 Patch 845050 2 cgarcia 2013-03-01 04:12:13 -0800 Adding WebKit2 owners to CC. 845054 3 webkit.review.bot 2013-03-01 04:20:13 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 845270 4 190931 mrobinson 2013-03-01 10:09:28 -0800 Comment on attachment 190931 Patch Yikes. Looks good to me. 851016 5 190931 benjamin 2013-03-08 02:21:35 -0800 Comment on attachment 190931 Patch Ouch :) Funny leakRef() was even used in this context. 851021 6 cgarcia 2013-03-08 02:25:41 -0800 (In reply to comment #5) > (From update of attachment 190931 [details]) > Ouch :) > > Funny leakRef() was even used in this context. Yeah, an unfortunate copy paste from another place where it made sense. Thanks for the review! 851033 7 190931 webkit.review.bot 2013-03-08 02:42:20 -0800 Comment on attachment 190931 Patch Clearing flags on attachment: 190931 Committed r145202: <http://trac.webkit.org/changeset/145202> 851034 8 webkit.review.bot 2013-03-08 02:42:24 -0800 All reviewed patches have been landed. Closing bug. 190931 2013-03-01 04:11:50 -0800 2013-03-08 02:42:19 -0800 Patch wk2-memleak.diff text/plain 1523 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1ZGViM2RiLi5mOGY0OTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDMtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIE1lbW9yeSBsZWFrIGluIHdlYmtpdF93ZWJfdmlld19sb2FkX3Jl cXVlc3QoKSBpbiBXZWJLaXQyIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTExMTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgbGVha1JlZigpIGlzIHVzZWQgZm9yIHRoZSByZXR1cm5lZCBQYXNzUmVm UHRyIHdpdGhvdXQgdGFraW5nIHRoZQorICAgICAgICBvd25lcnNoaXAgb2YgdGhlIGxlYWtlZCBy ZWYuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcDoKKyAg ICAgICAgKHdlYmtpdF93ZWJfdmlld19sb2FkX3JlcXVlc3QpOiBVc2UgUmVmUHRyIGxvY2FsIHZh cmlhYmxlLgorCiAyMDEzLTAyLTI4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFJlZHVjZSBhbW91bnQgb2YgcmVidWlsZGluZyB3aGVuIHRvdWNoaW5nIG5l dHdvcmtpbmcgaGVhZGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCAyMzIwZTFjLi44ZDU0YjVmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApAQCAtMTgy MSw3ICsxODIxLDggQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfbG9hZF9yZXF1ZXN0KFdlYktpdFdl YlZpZXcqIHdlYlZpZXcsIFdlYktpdFVSSVJlcXVlc3QqIHJlcXUKICAgICBnX3JldHVybl9pZl9m YWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSk7CiAgICAgZ19yZXR1cm5faWZfZmFpbChX RUJLSVRfSVNfVVJJX1JFUVVFU1QocmVxdWVzdCkpOwogCi0gICAgZ2V0UGFnZSh3ZWJWaWV3KS0+ bG9hZFVSTFJlcXVlc3QoV2ViVVJMUmVxdWVzdDo6Y3JlYXRlKHdlYmtpdFVSSVJlcXVlc3RHZXRS ZXNvdXJjZVJlcXVlc3QocmVxdWVzdCkpLmxlYWtSZWYoKSk7CisgICAgUmVmUHRyPFdlYlVSTFJl cXVlc3Q+IHVybFJlcXVlc3QgPSBXZWJVUkxSZXF1ZXN0OjpjcmVhdGUod2Via2l0VVJJUmVxdWVz dEdldFJlc291cmNlUmVxdWVzdChyZXF1ZXN0KSk7CisgICAgZ2V0UGFnZSh3ZWJWaWV3KS0+bG9h ZFVSTFJlcXVlc3QodXJsUmVxdWVzdC5nZXQoKSk7CiB9CiAKIC8qKgo=