111151 2013-03-01 00:35:32 -0800 Get rid of two silly static null Strings 2013-03-01 02:15:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin eric esprehn+autocc kling ojan.autocc webkit.review.bot oldest_to_newest 844884 0 benjamin 2013-03-01 00:35:32 -0800 Get rid of two silly static null Strings 844888 1 190901 benjamin 2013-03-01 00:40:55 -0800 Created attachment 190901 Patch 844891 2 benjamin 2013-03-01 00:43:08 -0800 Before: __ZNK7WebCore4Page9groupNameEv: 0000000000001750 pushq %rbp 0000000000001751 movq %rsp,%rbp 0000000000001754 pushq %rbx 0000000000001755 pushq %rax 0000000000001756 movq %rdi,%rbx 0000000000001759 movb __ZGVZNK7WebCore4Page9groupNameEvE10nullString.b(%rip),%al 000000000000175f cmpb $0x01,%al 0000000000001761 jne 0x0000176c 0000000000001763 movq __ZZNK7WebCore4Page9groupNameEvE10nullString(%rip),%rax 000000000000176a jmp 0x0000178b 000000000000176c movl $0x00000008,%edi 0000000000001771 callq __ZN3WTF10fastMallocEm 0000000000001776 movq $__ZN7WebCore17deviceScaleFactorEPNS_5FrameE,(%rax) 000000000000177d movq %rax,__ZZNK7WebCore4Page9groupNameEvE10nullString(%rip) 0000000000001784 movb $0x01,__ZGVZNK7WebCore4Page9groupNameEvE10nullString.b+0xffffffff(%rip) 000000000000178b movq 0x00000110(%rbx),%rcx 0000000000001792 testq %rcx,%rcx 0000000000001795 leaq 0x18(%rcx),%rcx 0000000000001799 cmoveq %rax,%rcx 000000000000179d movq %rcx,%rax 00000000000017a0 addq $0x08,%rsp 00000000000017a4 popq %rbx 00000000000017a5 popq %rbp 00000000000017a6 ret After (I like that Clang made is jmp free :)): __ZNK7WebCore4Page9groupNameEv: 0000000000001820 pushq %rbp 0000000000001821 movq %rsp,%rbp 0000000000001824 movq 0x00000110(%rdi),%rax 000000000000182b testq %rax,%rax 000000000000182e leaq 0x18(%rax),%rax 0000000000001832 cmoveq __ZN3WTF8nullAtomE(%rip),%rax 000000000000183a popq %rbp 000000000000183b ret 844941 3 190901 eric 2013-03-01 02:11:18 -0800 Comment on attachment 190901 Patch LGTM. 844944 4 190901 webkit.review.bot 2013-03-01 02:15:21 -0800 Comment on attachment 190901 Patch Clearing flags on attachment: 190901 Committed r144432: <http://trac.webkit.org/changeset/144432> 844945 5 webkit.review.bot 2013-03-01 02:15:24 -0800 All reviewed patches have been landed. Closing bug. 190901 2013-03-01 00:40:55 -0800 2013-03-01 02:15:20 -0800 Patch bug-111151-20130301003706.patch text/plain 2049 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA4MmQyZjM3NTIxMGYz ZTU2ZWM3MWNmZWY4ZjUxNTkyNzA0Mjk0Yy4uYzVlYmNhNzhlYTBkMzlmNzYwOGNmNjVlMGEzZjAy ZDUyMGNjNjRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTAxICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBHZXQgcmlkIG9m IHR3byBzaWxseSBzdGF0aWMgbnVsbCBTdHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTExNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIGEgZ2xvYmFsIG51bGwgU3RyaW5nIHRocm91 Z2ggbnVsbEF0b20sIHRoZXJlIGlzIG5vIG5lZWQKKyAgICAgICAgZm9yIGxvY2FsIHN0YXRpYyBu dWxsIHN0cmluZ3MuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UGFnZTo6Z3JvdXBOYW1lKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGlzdEl0ZW06Om1hcmtlclRleHQpOgorCiAy MDEzLTAyLTI4ICBYaW5nbmFuIFdhbmcgIDx4aW5nbmFuLndhbmdAaW50ZWwuY29tPgogCiAgICAg ICAgIEhlYXAtdXNlLWFmdGVyLWZyZWUgaW4gV2ViQ29yZTo6QXVkaW9Ob2RlSW5wdXQ6OnVwZGF0 ZUludGVybmFsQnVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCAyMzQ0NWM3ZTNjYzQ0Mjk2MTMyYTQx YjJmZjU3ZmI0OTNlZDJhNjRiLi5lYWFkYjE4OTE4YmRiNzFmNTE3ZWVhZjk0NzYxMGIyMTJhMGE2 ODc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTQzOCw5ICs0MzgsNyBAQCB2b2lkIFBhZ2U6OnNl dEdyb3VwTmFtZShjb25zdCBTdHJpbmcmIG5hbWUpCiAKIGNvbnN0IFN0cmluZyYgUGFnZTo6Z3Jv dXBOYW1lKCkgY29uc3QKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgbnVsbFN0 cmluZywgKCkpOwotICAgIC8vIEZJWE1FOiBXaHkgbm90IGp1c3QgcmV0dXJuIFN0cmluZygpPwot ICAgIHJldHVybiBtX2dyb3VwID8gbV9ncm91cC0+bmFtZSgpIDogbnVsbFN0cmluZzsKKyAgICBy ZXR1cm4gbV9ncm91cCA/IG1fZ3JvdXAtPm5hbWUoKSA6IG51bGxBdG9tLnN0cmluZygpOwogfQog CiB2b2lkIFBhZ2U6OmluaXRHcm91cCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxpc3RJdGVtLmNwcAppbmRleCBiZmM2MmIxYzlhOWVkYzBmZmY5YjViOTM4NjU3N2EyZDY5ODI0 ODNjLi5mMmMyZmIzMjU2ZDlmMTk2MTk2Y2VkNzVjZjFkNmM4NTI2MmQyMDc4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5jcHAKQEAgLTM5Niw4ICszOTYsNyBA QCBjb25zdCBTdHJpbmcmIFJlbmRlckxpc3RJdGVtOjptYXJrZXJUZXh0KCkgY29uc3QKIHsKICAg ICBpZiAobV9tYXJrZXIpCiAgICAgICAgIHJldHVybiBtX21hcmtlci0+dGV4dCgpOwotICAgIERF RklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBzdGF0aWNOdWxsU3RyaW5nLCAoKSk7Ci0gICAgcmV0 dXJuIHN0YXRpY051bGxTdHJpbmc7CisgICAgcmV0dXJuIG51bGxBdG9tLnN0cmluZygpOwogfQog CiBTdHJpbmcgUmVuZGVyTGlzdEl0ZW06Om1hcmtlclRleHRXaXRoU3VmZml4KCkgY29uc3QK