111147 2013-02-28 23:41:33 -0800 [chromium] Use lipo(1) rather than file(1) to list library architectures. 2013-03-12 12:45:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gavinp gavinp eric japhet rsesek thakis webkit.review.bot oldest_to_newest 844859 0 gavinp 2013-02-28 23:41:33 -0800 [chromium] Use lipo(1) rather than file(1) to list library architectures. 844867 1 190894 gavinp 2013-02-28 23:50:48 -0800 Created attachment 190894 Patch 844868 2 gavinp 2013-02-28 23:55:56 -0800 japhet, You have no idea how sad this build failure made me. I will not, except under duress, tell you how much time I wasted trying to figure this out. WDYT? (of the patch, not my bad attitude) 844869 3 190894 eric 2013-03-01 00:02:57 -0800 Comment on attachment 190894 Patch otool also works. nm might too. :) 853454 4 gavinp 2013-03-12 07:50:14 -0700 japhet? seidel? Any chance at a review? 853537 5 japhet 2013-03-12 09:15:25 -0700 (In reply to comment #4) > japhet? seidel? > > Any chance at a review? Not it. I don't speak .sh well enough to review it. 853539 6 gavinp 2013-03-12 09:19:11 -0700 Thanks for getting back to me japhet. I found you using blame on that file, I guess you'd reformatted it... I am aware of this curse. :D thakis or rsesek, can either of you review this? 853549 7 190894 thakis 2013-03-12 09:31:32 -0700 Comment on attachment 190894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190894&action=review > Source/WebCore/ChangeLog:6 > + Parsing file(1) output can be fragile; this patch replaces a use of file(1) to get Which problem are you seeing? 853574 8 gavinp 2013-03-12 10:14:58 -0700 (In reply to comment #7) > (From update of attachment 190894 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190894&action=review > > > Source/WebCore/ChangeLog:6 > > + Parsing file(1) output can be fragile; this patch replaces a use of file(1) to get > > Which problem are you seeing? On my mac, I couldn't build Chromium. I have MacPorts, and the file(1) installed with that had incompatible output, which made ARCHS not get loaded correctly. Since the script already uses lipo(1) later, and since it can output the data that's being looked for, that seemed the way to go, rather than coding /usr/bin/file or adding a more flexible parser of file(1)'s output. 853585 9 190894 thakis 2013-03-12 10:24:37 -0700 Comment on attachment 190894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190894&action=review >>> Source/WebCore/ChangeLog:6 >>> + Parsing file(1) output can be fragile; this patch replaces a use of file(1) to get >> >> Which problem are you seeing? > > On my mac, I couldn't build Chromium. I have MacPorts, and the file(1) installed with that had incompatible output, which made ARCHS not get loaded correctly. > > Since the script already uses lipo(1) later, and since it can output the data that's being looked for, that seemed the way to go, rather than coding /usr/bin/file or adding a more flexible parser of file(1)'s output. Hm, ok. MacPorts breaks other stuff too (see e.g. the thread on chromium-dev from yesterday night), but if you're happy with being on the hook if the output of lipo varies over time, I can live with this :-) 853699 10 190894 gavinp 2013-03-12 12:31:57 -0700 Comment on attachment 190894 Patch Thanks Nico. If lipo changes, I assume I will be hearing about it quick fast. 853709 11 190894 webkit.review.bot 2013-03-12 12:45:56 -0700 Comment on attachment 190894 Patch Clearing flags on attachment: 190894 Committed r145574: <http://trac.webkit.org/changeset/145574> 853710 12 webkit.review.bot 2013-03-12 12:45:59 -0700 All reviewed patches have been landed. Closing bug. 190894 2013-02-28 23:50:48 -0800 2013-03-12 12:45:56 -0700 Patch bug-111147-20130301154659.patch text/plain 1607 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmU1NzcyOGVjY2JlMmI4 MjIyZjBiZDhkMTk5N2ZiM2Y4ZjgzMDhiOC4uNWQ4YWJjOWFlNDgwZWJjYTg1NWY3MDcwMDQ1Mjdk NTMwMjA5MDkyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTI4ICBHYXZp biBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gVXNl IGxpcG8oMSkgcmF0aGVyIHRoYW4gZmlsZSgxKSB0byBsaXN0IGxpYnJhcnkgYXJjaGl0ZWN0dXJl cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTE0 NworCisgICAgICAgIFBhcnNpbmcgZmlsZSgxKSBvdXRwdXQgY2FuIGJlIGZyYWdpbGU7IHRoaXMg cGF0Y2ggcmVwbGFjZXMgYSB1c2Ugb2YgZmlsZSgxKSB0byBnZXQKKyAgICAgICAgdGhlIGFyY2hp dGVjdHVyZSBsaXN0IG9mIGEgbGlicmFyeSB3aXRoIGFuIGludm9jYXRpb24gb2YgbGlwbygxKSwg d2hpY2ggc2hvdWxkIGJlIG1vcmUKKyAgICAgICAgc3RhYmxlLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2luY2UgYWRqdXN0 X3Zpc2liaWxpdHkuc2ggZG9lc24ndCBoYXZlIGEgdGVzdC4KKworICAgICAgICAqIFdlYkNvcmUu Z3lwL21hYy9hZGp1c3RfdmlzaWJpbGl0eS5zaDoKKwogMjAxMy0wMi0yNiAgQW5kcmV3IExvICA8 YW5sb0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBbmltYXRlZCBpbWFnZXMgbm90 IGFuaW1hdGluZyBvbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBsYXllcnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL21hYy9hZGp1c3RfdmlzaWJpbGl0eS5zaCBiL1Nv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL21hYy9hZGp1c3RfdmlzaWJpbGl0eS5zaAppbmRleCA5 NjM5MmFlNmUyZTZlOGJkMTJjNDM1MzEzNTZmNTVmNWE0M2IyM2U0Li5iODE1ZTk4YjY1YTNkZmM3 NzhmY2NkYmVmYjNhMjg5ZDM5YzcyYTI4IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmd5cC9tYWMvYWRqdXN0X3Zpc2liaWxpdHkuc2gKKysrIGIvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5neXAvbWFjL2FkanVzdF92aXNpYmlsaXR5LnNoCkBAIC01NSw3ICs1NSw3IEBAIG1rZGly IC1wICIke1dPUktfRElSfSIKIAogIyBhciBkb2Vzbid0IG9wZXJhdGUgb24gZmF0IGZpbGVzLiAg RmlndXJlIG91dCB3aGF0IGFyY2hpdGVjdHVyZXMgYXJlCiAjIGludm9sdmVkLgotQVJDSFM9JChm aWxlICIke0lOUFVUfSIgfCBzZWQgLUVuZSAncy9eLipcKGZvciBhcmNoaXRlY3R1cmUgKC4rKVwp Oi4qJC9cMS9wJykKK0FSQ0hTPSQobGlwbyAtaW5mbyAiJHtJTlBVVH0iIHwgc2VkIC1FbmUgJ3Mv Xi4qIGFyZTogKC4rKS9cMS9wJykKIGlmIFsgLXogIiR7QVJDSFN9IiBdIDsgdGhlbgogICBBUkNI Uz1zZWxmCiBmaQo=