111146 2013-02-28 23:36:23 -0800 REGRESSION(r144398): put WebTestProxy::scheduleComposite back in place 2013-03-01 14:38:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111017 1 jochen jochen abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 844856 0 jochen 2013-02-28 23:36:23 -0800 [chromium] put WebTestProxy::scheduleComposite back in place 844857 1 190892 jochen 2013-02-28 23:38:31 -0800 Created attachment 190892 Patch 844858 2 webkit.review.bot 2013-02-28 23:40:59 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 844860 3 jochen 2013-02-28 23:43:16 -0800 broke almost all compositing tests on content_shell 844947 4 190892 thakis 2013-03-01 02:16:49 -0800 Comment on attachment 190892 Patch Can you mention where this was removed in the changelog? 844949 5 190913 jochen 2013-03-01 02:20:41 -0800 Created attachment 190913 Patch for landing 844951 6 190913 jochen 2013-03-01 02:21:29 -0800 Comment on attachment 190913 Patch for landing Clearing flags on attachment: 190913 Committed r144433: <http://trac.webkit.org/changeset/144433> 844952 7 jochen 2013-03-01 02:21:33 -0800 All reviewed patches have been landed. Closing bug. 845343 8 jamesr 2013-03-01 11:20:21 -0800 This isn't a terribly good solution. The basic problem here appears to be that WebTestProxy wants to intercept a call (scheduleComposite) that otherwise has no reason to go through any WebKit APIs. I resolved this for DumpRenderTree by hooking a special call (DRTLayerTreeViewClient::ScheduleComposite) to DRT's test harness. It looks like to maintain this behavior in content shell I'll have to hook up a call to WebTextProxy from content::RenderWidget somehow. Is there an established pattern for this? Having this WebTextProxy stuff live in the WebKit repo but need access to things that happen normally only inside the WebKit embedder is a big pain for refactors like this :( 845390 9 jochen 2013-03-01 12:12:56 -0800 (In reply to comment #8) > This isn't a terribly good solution. The basic problem here appears to be that WebTestProxy wants to intercept a call (scheduleComposite) that otherwise has no reason to go through any WebKit APIs. I resolved this for DumpRenderTree by hooking a special call (DRTLayerTreeViewClient::ScheduleComposite) to DRT's test harness. It looks like to maintain this behavior in content shell I'll have to hook up a call to WebTextProxy from content::RenderWidget somehow. Is there an established pattern for this? not really. I read through the code, and I think having the method on WebTestProxy is actually the cleanest solution. it's the only solution where only when running layout tests extra code is executed. If we're adding some test code to renderwidget, we'd always execute the check whether we're in a test or not. > > Having this WebTextProxy stuff live in the WebKit repo but need access to things that happen normally only inside the WebKit embedder is a big pain for refactors like this :( Having it live in the content module would make it a big pain for any change to layout tests 845512 10 jamesr 2013-03-01 14:38:14 -0800 Jochen and I chatted some more and I think we've sorted this out. We'll keep scheduleComposite() on WebTestProxy and on RenderWidget and just remove it from WebWidgetClient. 190892 2013-02-28 23:38:31 -0800 2013-03-01 02:20:37 -0800 Patch bug-111146-20130301083442.patch text/plain 1692 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTY2NDEwZTMxYmE2YjU4NjU4MmU3MDM0MzAwNzVjOGUw MGFmM2NlYS4uYTVlMjE4NzBiZTM5YTNlNjA2YTM1M2YzNjZhNWUwMDAwMTEyMGI4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAyLTI4ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gcHV0IFdlYlRlc3RQcm94eTo6c2NoZWR1bGVDb21wb3NpdGUg YmFjayBpbiBwbGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTExMTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ29udGVudCBzaGVsbCBkZXBlbmRzIG9uIHRoaXMgY2FsbC4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvcHVibGljL1dlYlRlc3RQcm94eS5oOgor ICAgICAgICAoV2ViVGVzdFJ1bm5lcjo6V2ViVGVzdFByb3h5OjpzY2hlZHVsZUNvbXBvc2l0ZSk6 CisKIDIwMTMtMDItMjggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgTWVyZ2UgUGVyZlRlc3RSdW5uZXIuX3J1bl9zaW5nbGVfdGVzdCBpbnRvIFBlcmZUZXN0UnVu bmVyLl9ydW5fdGVzdHNfc2V0CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9UZXN0UnVubmVyL3B1YmxpYy9XZWJUZXN0UHJveHkuaCBiL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvcHVibGljL1dlYlRlc3RQcm94eS5oCmluZGV4IGY2YzUw ZTZlZjE0NWEyOGZhMDkwMWUzZDlhMjgwMWUyZmQ2ZTlhOTEuLmE3MGM0YmVjMjE3NWMyODViZjFh ZjcyZTY5ZTBhNDQ2YmQ5NDE0YzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2No cm9taXVtL1Rlc3RSdW5uZXIvcHVibGljL1dlYlRlc3RQcm94eS5oCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvcHVibGljL1dlYlRlc3RQcm94eS5oCkBAIC0x MDgsNiArMTA4LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRMb2dDb25zb2xlT3V0cHV0KGJv b2wgZW5hYmxlZCk7CiAKKyAgICAvLyBGSVhNRTogTWFrZSB0aGlzIHByaXZhdGUgYWdhaW4uCiAg ICAgdm9pZCBzY2hlZHVsZUNvbXBvc2l0ZSgpOwogCiAjaWYgV0VCVEVTVFJVTk5FUl9JTVBMRU1F TlRBVElPTgpAQCAtMjUyLDYgKzI1MywxMSBAQCBwdWJsaWM6CiAgICAgICAgIFdlYlRlc3RQcm94 eUJhc2U6OmRpZFNjcm9sbFJlY3QoZHgsIGR5LCBjbGlwUmVjdCk7CiAgICAgICAgIEJhc2U6OmRp ZFNjcm9sbFJlY3QoZHgsIGR5LCBjbGlwUmVjdCk7CiAgICAgfQorICAgIHZpcnR1YWwgdm9pZCBz Y2hlZHVsZUNvbXBvc2l0ZSgpCisgICAgeworICAgICAgICBXZWJUZXN0UHJveHlCYXNlOjpzY2hl ZHVsZUNvbXBvc2l0ZSgpOworICAgICAgICBCYXNlOjpzY2hlZHVsZUNvbXBvc2l0ZSgpOworICAg IH0KICAgICB2aXJ0dWFsIHZvaWQgc2NoZWR1bGVBbmltYXRpb24oKQogICAgIHsKICAgICAgICAg V2ViVGVzdFByb3h5QmFzZTo6c2NoZWR1bGVBbmltYXRpb24oKTsK 190913 2013-03-01 02:20:41 -0800 2013-03-01 02:21:28 -0800 Patch for landing bug-111146-20130301111652.patch text/plain 1799 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTY2NDEwZTMxYmE2YjU4NjU4MmU3MDM0MzAwNzVjOGUw MGFmM2NlYS4uOGY3OTA0NjlhN2JmOWY4M2QzNTk4M2EzZmU5ZWUxOWI4YWJkMTcyNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTAyLTI4ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gcHV0IFdlYlRlc3RQcm94eTo6c2NoZWR1bGVDb21wb3NpdGUg YmFjayBpbiBwbGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTExMTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTmljbyBXZWJlci4KKworICAgICAg ICBUaGUgY2FsbCB3YXMgcmVtb3ZlZCBpbiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNl dC8xNDQzOTggYmVjYXVzZQorICAgICAgICBEUlQgZG9lc24ndCBuZWVkIGl0LiBIb3dldmVyLCBj b250ZW50IHNoZWxsIGRlcGVuZHMgb24gdGhpcyBjYWxsLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9wdWJsaWMvV2ViVGVzdFByb3h5Lmg6CisgICAgICAg IChXZWJUZXN0UnVubmVyOjpXZWJUZXN0UHJveHk6OnNjaGVkdWxlQ29tcG9zaXRlKToKKwogMjAx My0wMi0yOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNZXJn ZSBQZXJmVGVzdFJ1bm5lci5fcnVuX3NpbmdsZV90ZXN0IGludG8gUGVyZlRlc3RSdW5uZXIuX3J1 bl90ZXN0c19zZXQKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rl c3RSdW5uZXIvcHVibGljL1dlYlRlc3RQcm94eS5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vVGVzdFJ1bm5lci9wdWJsaWMvV2ViVGVzdFByb3h5LmgKaW5kZXggZjZjNTBlNmVmMTQ1 YTI4ZmEwOTAxZTNkOWEyODAxZTJmZDZlOWE5MS4uYTcwYzRiZWMyMTc1YzI4NWJmMWFmNzJlNjll MGE0NDZiZDk0MTRjNyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v VGVzdFJ1bm5lci9wdWJsaWMvV2ViVGVzdFByb3h5LmgKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9wdWJsaWMvV2ViVGVzdFByb3h5LmgKQEAgLTEwOCw2ICsx MDgsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHNldExvZ0NvbnNvbGVPdXRwdXQoYm9vbCBlbmFi bGVkKTsKIAorICAgIC8vIEZJWE1FOiBNYWtlIHRoaXMgcHJpdmF0ZSBhZ2Fpbi4KICAgICB2b2lk IHNjaGVkdWxlQ29tcG9zaXRlKCk7CiAKICNpZiBXRUJURVNUUlVOTkVSX0lNUExFTUVOVEFUSU9O CkBAIC0yNTIsNiArMjUzLDExIEBAIHB1YmxpYzoKICAgICAgICAgV2ViVGVzdFByb3h5QmFzZTo6 ZGlkU2Nyb2xsUmVjdChkeCwgZHksIGNsaXBSZWN0KTsKICAgICAgICAgQmFzZTo6ZGlkU2Nyb2xs UmVjdChkeCwgZHksIGNsaXBSZWN0KTsKICAgICB9CisgICAgdmlydHVhbCB2b2lkIHNjaGVkdWxl Q29tcG9zaXRlKCkKKyAgICB7CisgICAgICAgIFdlYlRlc3RQcm94eUJhc2U6OnNjaGVkdWxlQ29t cG9zaXRlKCk7CisgICAgICAgIEJhc2U6OnNjaGVkdWxlQ29tcG9zaXRlKCk7CisgICAgfQogICAg IHZpcnR1YWwgdm9pZCBzY2hlZHVsZUFuaW1hdGlvbigpCiAgICAgewogICAgICAgICBXZWJUZXN0 UHJveHlCYXNlOjpzY2hlZHVsZUFuaW1hdGlvbigpOwo=