111142 2013-02-28 22:18:45 -0800 Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set 2013-02-28 22:36:16 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 rniwa rniwa abarth benjamin dpranke eric oldest_to_newest 844823 0 rniwa 2013-02-28 22:18:45 -0800 Another refactoring. _run_single_test and _run_tests_set should be a single method. 844827 1 190885 rniwa 2013-02-28 22:22:04 -0800 Created attachment 190885 Cleanup 844834 2 190885 abarth 2013-02-28 22:32:03 -0800 Comment on attachment 190885 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=190885&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:371 > + _log.error('FAILED') I guess we don't say which test failed. 844837 3 190885 rniwa 2013-02-28 22:35:39 -0800 Comment on attachment 190885 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=190885&action=review >> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:371 >> + _log.error('FAILED') > > I guess we don't say which test failed. Ordinarily, we see the test name right above it: Running DOM/CreateNodes.html (32 of 113) error: DOM/CreateNodes.html Received an invalid message "WebPageProxy.DidFailProvisionalLoadForFrame" from the web process. FAILED Finished: 18.626504 s 844838 4 rniwa 2013-02-28 22:36:16 -0800 Committed r144421: <http://trac.webkit.org/changeset/144421> 190885 2013-02-28 22:22:04 -0800 2013-02-28 22:35:38 -0800 Cleanup bug-111142-20130228221815.patch text/plain 5867 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE0NDQxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDEzLTAyLTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIE1lcmdlIFBlcmZUZXN0UnVubmVyLl9ydW5fc2luZ2xlX3Rlc3QgaW50byBQZXJm VGVzdFJ1bm5lci5fcnVuX3Rlc3RzX3NldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTExMTQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTWVyZ2VkIF9ydW5fc2luZ2xlX3Rlc3QgaW50byBfcnVuX3Rlc3Rz X3NldC4gVGhlIGNvZGUgbG9va3MgbXVjaCBjbGVhbmVyIG5vdy4KKworICAgICAgICBBbHNvIHJl bW92ZWQgX3ByaW50X3N0YXR1cyBzaW5jZSBpdCdzIG5ldmVyIHVzZWQgYW55d2hlcmUuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5l ci5weToKKyAgICAgICAgKFBlcmZUZXN0c1J1bm5lci5ydW4pOgorICAgICAgICAoUGVyZlRlc3Rz UnVubmVyLl9ydW5fdGVzdHNfc2V0KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BlcmZv cm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lcl9pbnRlZ3JhdGlvbnRlc3QucHk6CisgICAgICAg IChNYWluVGVzdC5ydW5fdGVzdCk6CisgICAgICAgIChNYWluVGVzdC50ZXN0X3J1bl90ZXN0X3Nl dCk6CisgICAgICAgIChNYWluVGVzdC50ZXN0X3J1bl90ZXN0X3NldF9raWxsc19kcnRfcGVyX3J1 bik6CisgICAgICAgIChNYWluVGVzdC50ZXN0X3J1bl90ZXN0X3NldF9mb3JfcGFyc2VyX3Rlc3Rz KToKKwogMjAxMy0wMi0yOCAgS2lyYW4gTXVwcGFsYSAgPGNtdXBwYWxhQGFwcGxlLmNvbT4KIAog ICAgICAgICBEaXNhYmxlIHdpbmRvdyBvY2NsdXNpb24gZGV0ZWN0aW9uIGZvciBXZWJLaXRUZXN0 UnVubmVyIFdlYiBWaWV3IG9uIE1hYwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJm b3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkJKHJldmlz aW9uIDE0NDQxNikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMv cGVyZnRlc3RzcnVubmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODYsNyArMTg2LDcgQEAgY2xh c3MgUGVyZlRlc3RzUnVubmVyKG9iamVjdCk6CiAgICAgICAgIHRyeToKICAgICAgICAgICAgIGlm IG5lZWRzX2h0dHA6CiAgICAgICAgICAgICAgICAgc2VsZi5fc3RhcnRfaHR0cF9zZXJ2ZXJzKCkK LSAgICAgICAgICAgIHVuZXhwZWN0ZWQgPSBzZWxmLl9ydW5fdGVzdHNfc2V0KHNvcnRlZChsaXN0 KHRlc3RzKSwga2V5PWxhbWJkYSB0ZXN0OiB0ZXN0LnRlc3RfbmFtZSgpKSwgc2VsZi5fcG9ydCkK KyAgICAgICAgICAgIHVuZXhwZWN0ZWQgPSBzZWxmLl9ydW5fdGVzdHNfc2V0KHNvcnRlZChsaXN0 KHRlc3RzKSwga2V5PWxhbWJkYSB0ZXN0OiB0ZXN0LnRlc3RfbmFtZSgpKSkKIAogICAgICAgICBm aW5hbGx5OgogICAgICAgICAgICAgaWYgbmVlZHNfaHR0cDoKQEAgLTM1Niw0MCArMzU2LDIxIEBA IGNsYXNzIFBlcmZUZXN0c1J1bm5lcihvYmplY3QpOgogICAgICAgICBfbG9nLmluZm8oIkpTT04g ZmlsZSB1cGxvYWRlZCB0byAlcy4iICUgdXJsKQogICAgICAgICByZXR1cm4gVHJ1ZQogCi0gICAg ZGVmIF9wcmludF9zdGF0dXMoc2VsZiwgdGVzdHMsIGV4cGVjdGVkLCB1bmV4cGVjdGVkKToKLSAg ICAgICAgaWYgbGVuKHRlc3RzKSA9PSBleHBlY3RlZCArIHVuZXhwZWN0ZWQ6Ci0gICAgICAgICAg ICBzdGF0dXMgPSAiUmFuICVkIHRlc3RzIiAlIGxlbih0ZXN0cykKLSAgICAgICAgZWxzZToKLSAg ICAgICAgICAgIHN0YXR1cyA9ICJSdW5uaW5nICVkIG9mICVkIHRlc3RzIiAlIChleHBlY3RlZCAr IHVuZXhwZWN0ZWQgKyAxLCBsZW4odGVzdHMpKQotICAgICAgICBpZiB1bmV4cGVjdGVkOgotICAg ICAgICAgICAgc3RhdHVzICs9ICIgKCVkIGRpZG4ndCBydW4pIiAlIHVuZXhwZWN0ZWQKLSAgICAg ICAgX2xvZy5pbmZvKHN0YXR1cykKLQotICAgIGRlZiBfcnVuX3Rlc3RzX3NldChzZWxmLCB0ZXN0 cywgcG9ydCk6CisgICAgZGVmIF9ydW5fdGVzdHNfc2V0KHNlbGYsIHRlc3RzKToKICAgICAgICAg cmVzdWx0X2NvdW50ID0gbGVuKHRlc3RzKQotICAgICAgICBleHBlY3RlZCA9IDAKLSAgICAgICAg dW5leHBlY3RlZCA9IDAKLSAgICAgICAgZHJpdmVyID0gTm9uZQotCi0gICAgICAgIGZvciB0ZXN0 IGluIHRlc3RzOgotICAgICAgICAgICAgX2xvZy5pbmZvKCdSdW5uaW5nICVzICglZCBvZiAlZCkn ICUgKHRlc3QudGVzdF9uYW1lKCksIGV4cGVjdGVkICsgdW5leHBlY3RlZCArIDEsIGxlbih0ZXN0 cykpKQotICAgICAgICAgICAgaWYgc2VsZi5fcnVuX3NpbmdsZV90ZXN0KHRlc3QpOgotICAgICAg ICAgICAgICAgIGV4cGVjdGVkID0gZXhwZWN0ZWQgKyAxCisgICAgICAgIGZhaWx1cmVzID0gMAor CisgICAgICAgIGZvciBpLCB0ZXN0IGluIGVudW1lcmF0ZSh0ZXN0cyk6CisgICAgICAgICAgICBf bG9nLmluZm8oJ1J1bm5pbmcgJXMgKCVkIG9mICVkKScgJSAodGVzdC50ZXN0X25hbWUoKSwgaSAr IDEsIGxlbih0ZXN0cykpKQorICAgICAgICAgICAgc3RhcnRfdGltZSA9IHRpbWUudGltZSgpCisg ICAgICAgICAgICBuZXdfcmVzdWx0cyA9IHRlc3QucnVuKHNlbGYuX29wdGlvbnMudGltZV9vdXRf bXMpCisgICAgICAgICAgICBpZiBuZXdfcmVzdWx0czoKKyAgICAgICAgICAgICAgICBzZWxmLl9y ZXN1bHRzLnVwZGF0ZShuZXdfcmVzdWx0cykKICAgICAgICAgICAgIGVsc2U6Ci0gICAgICAgICAg ICAgICAgdW5leHBlY3RlZCA9IHVuZXhwZWN0ZWQgKyAxCisgICAgICAgICAgICAgICAgZmFpbHVy ZXMgKz0gMQorICAgICAgICAgICAgICAgIF9sb2cuZXJyb3IoJ0ZBSUxFRCcpCiAKKyAgICAgICAg ICAgIF9sb2cuaW5mbygnRmluaXNoZWQ6ICVmIHMnICUgKHRpbWUudGltZSgpIC0gc3RhcnRfdGlt ZSkpCiAgICAgICAgICAgICBfbG9nLmluZm8oJycpCiAKLSAgICAgICAgcmV0dXJuIHVuZXhwZWN0 ZWQKLQotICAgIGRlZiBfcnVuX3NpbmdsZV90ZXN0KHNlbGYsIHRlc3QpOgotICAgICAgICBzdGFy dF90aW1lID0gdGltZS50aW1lKCkKLSAgICAgICAgbmV3X3Jlc3VsdHMgPSB0ZXN0LnJ1bihzZWxm Ll9vcHRpb25zLnRpbWVfb3V0X21zKQotICAgICAgICBpZiBuZXdfcmVzdWx0czoKLSAgICAgICAg ICAgIHNlbGYuX3Jlc3VsdHMudXBkYXRlKG5ld19yZXN1bHRzKQotICAgICAgICBlbHNlOgotICAg ICAgICAgICAgX2xvZy5lcnJvcignRkFJTEVEJykKLQotICAgICAgICBfbG9nLmluZm8oIkZpbmlz aGVkOiAlZiBzIiAlICh0aW1lLnRpbWUoKSAtIHN0YXJ0X3RpbWUpKQotCi0gICAgICAgIHJldHVy biBuZXdfcmVzdWx0cyAhPSBOb25lCisgICAgICAgIHJldHVybiBmYWlsdXJlcwpJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXJfaW50 ZWdyYXRpb250ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVy Zm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyX2ludGVncmF0aW9udGVzdC5weQkocmV2aXNp b24gMTQ0NDE2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9w ZXJmdGVzdHNydW5uZXJfaW50ZWdyYXRpb250ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMTQs NyArMjE0LDggQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgZGVm IHJ1bl90ZXN0KHNlbGYsIHRlc3RfbmFtZSk6CiAgICAgICAgIHJ1bm5lciwgcG9ydCA9IHNlbGYu Y3JlYXRlX3J1bm5lcigpCi0gICAgICAgIHJldHVybiBydW5uZXIuX3J1bl9zaW5nbGVfdGVzdChD aHJvbWl1bVN0eWxlUGVyZlRlc3QocG9ydCwgdGVzdF9uYW1lLCBydW5uZXIuX2hvc3QuZmlsZXN5 c3RlbS5qb2luKCdzb21lLWRpcicsIHRlc3RfbmFtZSkpKQorICAgICAgICB0ZXN0cyA9IFtDaHJv bWl1bVN0eWxlUGVyZlRlc3QocG9ydCwgdGVzdF9uYW1lLCBydW5uZXIuX2hvc3QuZmlsZXN5c3Rl bS5qb2luKCdzb21lLWRpcicsIHRlc3RfbmFtZSkpXQorICAgICAgICByZXR1cm4gcnVubmVyLl9y dW5fdGVzdHNfc2V0KHRlc3RzKSA9PSAwCiAKICAgICBkZWYgdGVzdF9ydW5fcGFzc2luZ190ZXN0 KHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydFRydWUoc2VsZi5ydW5fdGVzdCgncGFzcy5odG1s JykpCkBAIC0yNTMsNyArMjU0LDcgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2Up OgogICAgICAgICBvdXRwdXQgPSBPdXRwdXRDYXB0dXJlKCkKICAgICAgICAgb3V0cHV0LmNhcHR1 cmVfb3V0cHV0KCkKICAgICAgICAgdHJ5OgotICAgICAgICAgICAgdW5leHBlY3RlZF9yZXN1bHRf Y291bnQgPSBydW5uZXIuX3J1bl90ZXN0c19zZXQodGVzdHMsIHBvcnQpCisgICAgICAgICAgICB1 bmV4cGVjdGVkX3Jlc3VsdF9jb3VudCA9IHJ1bm5lci5fcnVuX3Rlc3RzX3NldCh0ZXN0cykKICAg ICAgICAgZmluYWxseToKICAgICAgICAgICAgIHN0ZG91dCwgc3RkZXJyLCBsb2cgPSBvdXRwdXQu cmVzdG9yZV9vdXRwdXQoKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHVuZXhwZWN0ZWRfcmVz dWx0X2NvdW50LCBsZW4odGVzdHMpIC0gMSkKQEAgLTI3MCw3ICsyNzEsNyBAQCBjbGFzcyBNYWlu VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICAgICAgdGVzdHMgPSBzZWxmLl90ZXN0c19m b3JfcnVubmVyKHJ1bm5lciwgWydpbnNwZWN0b3IvcGFzcy5odG1sJywgJ2luc3BlY3Rvci9zaWxl bnQuaHRtbCcsICdpbnNwZWN0b3IvZmFpbGVkLmh0bWwnLAogICAgICAgICAgICAgJ2luc3BlY3Rv ci90b25ndWV5Lmh0bWwnLCAnaW5zcGVjdG9yL3RpbWVvdXQuaHRtbCcsICdpbnNwZWN0b3IvY3Jh c2guaHRtbCddKQotICAgICAgICB1bmV4cGVjdGVkX3Jlc3VsdF9jb3VudCA9IHJ1bm5lci5fcnVu X3Rlc3RzX3NldCh0ZXN0cywgcG9ydCkKKyAgICAgICAgdW5leHBlY3RlZF9yZXN1bHRfY291bnQg PSBydW5uZXIuX3J1bl90ZXN0c19zZXQodGVzdHMpCiAKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bChUZXN0RHJpdmVyV2l0aFN0b3BDb3VudC5zdG9wX2NvdW50LCA2KQogCkBAIC0yODAsNyArMjgx LDcgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBvdXRwdXQg PSBPdXRwdXRDYXB0dXJlKCkKICAgICAgICAgb3V0cHV0LmNhcHR1cmVfb3V0cHV0KCkKICAgICAg ICAgdHJ5OgotICAgICAgICAgICAgdW5leHBlY3RlZF9yZXN1bHRfY291bnQgPSBydW5uZXIuX3J1 bl90ZXN0c19zZXQodGVzdHMsIHBvcnQpCisgICAgICAgICAgICB1bmV4cGVjdGVkX3Jlc3VsdF9j b3VudCA9IHJ1bm5lci5fcnVuX3Rlc3RzX3NldCh0ZXN0cykKICAgICAgICAgZmluYWxseToKICAg ICAgICAgICAgIHN0ZG91dCwgc3RkZXJyLCBsb2cgPSBvdXRwdXQucmVzdG9yZV9vdXRwdXQoKQog ICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHVuZXhwZWN0ZWRfcmVzdWx0X2NvdW50LCAwKQo=