111118 2013-02-28 15:02:46 -0800 Add FeatureObserver for marquee and reflection 2013-03-01 07:49:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix eae eric esprehn+autocc leviw ojan.autocc ojan simon.fraser webkit.review.bot oldest_to_newest 844517 0 jchaffraix 2013-02-28 15:02:46 -0800 These 2 features are still proprietary / prefixed and we will need to unprefix them some day. In order to know if that's an option, we need to gather some numbers about their popularity. That's where FeatureObserver kicks in. 844539 1 190823 jchaffraix 2013-02-28 15:28:17 -0800 Created attachment 190823 Proposed change. 844546 2 190823 leviw 2013-02-28 15:33:14 -0800 Comment on attachment 190823 Proposed change. Great! I'm really curious :) 844547 3 simon.fraser 2013-02-28 15:33:19 -0800 What are you trying to observe? <marquee> or overflow: -webkit-marquee ? 844554 4 jchaffraix 2013-02-28 15:37:12 -0800 (In reply to comment #3) > What are you trying to observe? <marquee> or overflow: -webkit-marquee ? Both, basically whenever we create a RenderMarquee on a page. For now, I am not really concerned by what generated the marquee. If needed, we can always add more granularity. 844559 5 simon.fraser 2013-02-28 15:39:00 -0800 (In reply to comment #4) > (In reply to comment #3) > > What are you trying to observe? <marquee> or overflow: -webkit-marquee ? > > Both, basically whenever we create a RenderMarquee on a page. For now, I am not really concerned by what generated the marquee. If needed, we can always add more granularity. It's obvious that <marquee> is pretty popular (perhaps less so with the demise of Geocities). 844586 6 190833 jchaffraix 2013-02-28 16:04:47 -0800 Created attachment 190833 Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee. 844591 7 190833 leviw 2013-02-28 16:13:08 -0800 Comment on attachment 190833 Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee. LGTM, but I'll wait for smfr. 845175 8 190833 webkit.review.bot 2013-03-01 07:49:23 -0800 Comment on attachment 190833 Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee. Clearing flags on attachment: 190833 Committed r144456: <http://trac.webkit.org/changeset/144456> 845176 9 webkit.review.bot 2013-03-01 07:49:27 -0800 All reviewed patches have been landed. Closing bug. 190823 2013-02-28 15:28:17 -0800 2013-02-28 16:04:44 -0800 Proposed change. bug-111118-20130228152429.patch text/plain 2755 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQ3ZWM2ODEwODM5MTlm M2I3NzEyY2E1M2NlODQwNTE0Yzc1ZGZjMC4uMTU5ZGRmOTRiM2YzYjMwNDFhOTU5MGZmYzQ2Yjc2 OGE1YTI3MGY2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTI4ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBGZWF0 dXJlT2JzZXJ2ZXIgZm9yIG1hcnF1ZWUgYW5kIHJlZmxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTExOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yaW5nIGNvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL0ZlYXR1cmVPYnNlcnZlci5oOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllcjo6c3R5bGVDaGFuZ2VkKToKKyAgICAgICAgQWRkZWQgc29tZSBpbnN0cnVtZW50YXRpb24g Zm9yIHJlZmxlY3Rpb24gYW5kIG1hcnF1ZWUgYXMgdGhleSBhcmUgYm90aCBwcmVmaXhlZCBhbmQg dGhpcworICAgICAgICB3b3VsZCBoZWxwIHRvIGtub3cgdGhlaXIgcG9wdWxhcml0eSBvbiB0aGUg d2ViLgorCiAyMDEzLTAyLTI3ICBHbGVubiBBZGFtcyAgPGdsZW5uQHNreW5hdi5jb20+CiAKICAg ICAgICAgQWRkIEVOQUJMRV9DU1MzX1RFWFRfTElORV9CUkVBSyBmbGFnLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRmVhdHVyZU9ic2VydmVyLmgKaW5kZXggNzFmN2E4YTVkN2MyMmEyM2ZhYTQ1YzM1YjBiNmM4 NmNkMTQ4ZDQzZi4uYTA1MjJjN2U5NDQyNzFhMDdjNWQ5NTEzYWRjNjlkMmU1OWVhZDJjYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCkBAIC05Niw2ICs5Niw4IEBAIHB1Ymxp YzoKICAgICAgICAgUmVzdWx0c0F0dHJpYnV0ZSwKICAgICAgICAgU3RlcEF0dHJpYnV0ZSwKICAg ICAgICAgUGFnZVZpc2l0cywKKyAgICAgICAgTWFycXVlZSwKKyAgICAgICAgUmVmbGVjdGlvbiwK ICAgICAgICAgLy8gQWRkIG5ldyBmZWF0dXJlcyBhYm92ZSB0aGlzIGxpbmUuIERvbid0IGNoYW5n ZSBhc3NpZ25lZCBudW1iZXJzIG9mIGVhY2ggaXRlbXMuCiAgICAgICAgIE51bWJlck9mRmVhdHVy ZXMsIC8vIFRoaXMgZW51bSB2YWx1ZSBtdXN0IGJlIGxhc3QuCiAgICAgfTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGQzZWY1ZWQwYWQwMGNlZjc1OGY1YmQ5 NWFlNjhlYWYxNjhiZDEwMTguLjk0ZmI1MjJhZDc3YjgwMDY3ZWMxNDNhNzg5Yzk1OTZmNjViNmRk OWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNTUsNiAr NTUsNyBAQAogI2luY2x1ZGUgIkZFTWVyZ2UuaCIKICNpbmNsdWRlICJGaWx0ZXJFZmZlY3RSZW5k ZXJlci5oIgogI2VuZGlmCisjaW5jbHVkZSAiRmVhdHVyZU9ic2VydmVyLmgiCiAjaW5jbHVkZSAi RmxvYXRDb252ZXJzaW9uLmgiCiAjaW5jbHVkZSAiRmxvYXRQb2ludDNELmgiCiAjaW5jbHVkZSAi RmxvYXRSZWN0LmgiCkBAIC01NjgwLDYgKzU2ODEsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpzdHls ZUNoYW5nZWQoU3R5bGVEaWZmZXJlbmNlLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bGUpCiAg ICAgaWYgKHJlbmRlcmVyKCktPnN0eWxlKCktPm92ZXJmbG93WCgpID09IE9NQVJRVUVFICYmIHJl bmRlcmVyKCktPnN0eWxlKCktPm1hcnF1ZWVCZWhhdmlvcigpICE9IE1OT05FICYmIHJlbmRlcmVy KCktPmlzQm94KCkpIHsKICAgICAgICAgaWYgKCFtX21hcnF1ZWUpCiAgICAgICAgICAgICBtX21h cnF1ZWUgPSBhZG9wdFB0cihuZXcgUmVuZGVyTWFycXVlZSh0aGlzKSk7CisgICAgICAgIEZlYXR1 cmVPYnNlcnZlcjo6b2JzZXJ2ZShyZW5kZXJlcigpLT5kb2N1bWVudCgpLCBGZWF0dXJlT2JzZXJ2 ZXI6Ok1hcnF1ZWUpOwogICAgICAgICBtX21hcnF1ZWUtPnVwZGF0ZU1hcnF1ZWVTdHlsZSgpOwog ICAgIH0KICAgICBlbHNlIGlmIChtX21hcnF1ZWUpIHsKQEAgLTU2OTgsNiArNTcwMCw3IEBAIHZv aWQgUmVuZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZChTdHlsZURpZmZlcmVuY2UsIGNvbnN0IFJlbmRl clN0eWxlKiBvbGRTdHlsZSkKICAgICBlbHNlIGlmIChoYXNSZWZsZWN0aW9uKCkpIHsKICAgICAg ICAgaWYgKCFtX3JlZmxlY3Rpb24pCiAgICAgICAgICAgICBjcmVhdGVSZWZsZWN0aW9uKCk7Cisg ICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6b2JzZXJ2ZShyZW5kZXJlcigpLT5kb2N1bWVudCgpLCBG ZWF0dXJlT2JzZXJ2ZXI6OlJlZmxlY3Rpb24pOwogICAgICAgICB1cGRhdGVSZWZsZWN0aW9uU3R5 bGUoKTsKICAgICB9CiAgICAgCg== 190833 2013-02-28 16:04:47 -0800 2013-03-01 07:49:23 -0800 Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee. bug-111118-20130228160059.patch text/plain 2993 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQ3ZWM2ODEwODM5MTlm M2I3NzEyY2E1M2NlODQwNTE0Yzc1ZGZjMC4uZWE5OGE3YmU5YWNkZmNiNzI0ZWU1Zjk2MjcwNDEx OGQyNDBmYTMwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI4ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBGZWF0 dXJlT2JzZXJ2ZXIgZm9yIG1hcnF1ZWUgYW5kIHJlZmxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTExOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yaW5nIGNvdmVyZWQgYnkgZXhp c3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL0ZlYXR1cmVPYnNlcnZlci5oOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM YXllcjo6c3R5bGVDaGFuZ2VkKToKKyAgICAgICAgQWRkZWQgc29tZSBpbnN0cnVtZW50YXRpb24g Zm9yIHJlZmxlY3Rpb24gYW5kIG1hcnF1ZWUgYXMgdGhleSBhcmUgYm90aCBwcmVmaXhlZCBhbmQg dGhpcyB3b3VsZCBoZWxwCisgICAgICAgIHRvIGtub3cgdGhlaXIgcG9wdWxhcml0eSBvbiB0aGUg d2ViLiBNYXJxdWVlIHdhcyBzcGxpdCBiZXR3ZWVuIDxtYXJxdWVlPiAoSFRNTE1hcnF1ZWVFbGVt ZW50KSBhbmQgCisgICAgICAgIG92ZXJmbG93OiAtd2Via2l0LW1hcnF1ZWUgKENTU092ZXJmbG93 TWFycXVlZSkuCisKIDIwMTMtMDItMjcgIEdsZW5uIEFkYW1zICA8Z2xlbm5Ac2t5bmF2LmNvbT4K IAogICAgICAgICBBZGQgRU5BQkxFX0NTUzNfVEVYVF9MSU5FX0JSRUFLIGZsYWcuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oIGIvU291cmNlL1dlYkNv cmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaAppbmRleCA3MWY3YThhNWQ3YzIyYTIzZmFhNDVjMzVi MGI2Yzg2Y2QxNDhkNDNmLi5mODZjYjkxMDM4NTFiMWUwOTZjMTU4Yjg2ZTVmZmY1NDFkNTVmNTAx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmgKQEAgLTk2LDYgKzk2LDkgQEAg cHVibGljOgogICAgICAgICBSZXN1bHRzQXR0cmlidXRlLAogICAgICAgICBTdGVwQXR0cmlidXRl LAogICAgICAgICBQYWdlVmlzaXRzLAorICAgICAgICBIVE1MTWFycXVlZUVsZW1lbnQsCisgICAg ICAgIENTU092ZXJmbG93TWFycXVlZSwKKyAgICAgICAgUmVmbGVjdGlvbiwKICAgICAgICAgLy8g QWRkIG5ldyBmZWF0dXJlcyBhYm92ZSB0aGlzIGxpbmUuIERvbid0IGNoYW5nZSBhc3NpZ25lZCBu dW1iZXJzIG9mIGVhY2ggaXRlbXMuCiAgICAgICAgIE51bWJlck9mRmVhdHVyZXMsIC8vIFRoaXMg ZW51bSB2YWx1ZSBtdXN0IGJlIGxhc3QuCiAgICAgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwCmluZGV4IGQzZWY1ZWQwYWQwMGNlZjc1OGY1YmQ5NWFlNjhlYWYxNjhi ZDEwMTguLjFhYTkxOWQwNWM4YjFjNTNmZTdmYzlkNGJkMDgxMjg4MGRkNmVkMjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNTUsNiArNTUsNyBAQAogI2lu Y2x1ZGUgIkZFTWVyZ2UuaCIKICNpbmNsdWRlICJGaWx0ZXJFZmZlY3RSZW5kZXJlci5oIgogI2Vu ZGlmCisjaW5jbHVkZSAiRmVhdHVyZU9ic2VydmVyLmgiCiAjaW5jbHVkZSAiRmxvYXRDb252ZXJz aW9uLmgiCiAjaW5jbHVkZSAiRmxvYXRQb2ludDNELmgiCiAjaW5jbHVkZSAiRmxvYXRSZWN0Lmgi CkBAIC01NjgwLDYgKzU2ODEsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpzdHlsZUNoYW5nZWQoU3R5 bGVEaWZmZXJlbmNlLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bGUpCiAgICAgaWYgKHJlbmRl cmVyKCktPnN0eWxlKCktPm92ZXJmbG93WCgpID09IE9NQVJRVUVFICYmIHJlbmRlcmVyKCktPnN0 eWxlKCktPm1hcnF1ZWVCZWhhdmlvcigpICE9IE1OT05FICYmIHJlbmRlcmVyKCktPmlzQm94KCkp IHsKICAgICAgICAgaWYgKCFtX21hcnF1ZWUpCiAgICAgICAgICAgICBtX21hcnF1ZWUgPSBhZG9w dFB0cihuZXcgUmVuZGVyTWFycXVlZSh0aGlzKSk7CisgICAgICAgIEZlYXR1cmVPYnNlcnZlcjo6 b2JzZXJ2ZShyZW5kZXJlcigpLT5kb2N1bWVudCgpLCByZW5kZXJlcigpLT5pc0hUTUxNYXJxdWVl KCkgPyBGZWF0dXJlT2JzZXJ2ZXI6OkhUTUxNYXJxdWVlRWxlbWVudCA6IEZlYXR1cmVPYnNlcnZl cjo6Q1NTT3ZlcmZsb3dNYXJxdWVlKTsKICAgICAgICAgbV9tYXJxdWVlLT51cGRhdGVNYXJxdWVl U3R5bGUoKTsKICAgICB9CiAgICAgZWxzZSBpZiAobV9tYXJxdWVlKSB7CkBAIC01Njk4LDYgKzU3 MDAsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpzdHlsZUNoYW5nZWQoU3R5bGVEaWZmZXJlbmNlLCBj b25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bGUpCiAgICAgZWxzZSBpZiAoaGFzUmVmbGVjdGlvbigp KSB7CiAgICAgICAgIGlmICghbV9yZWZsZWN0aW9uKQogICAgICAgICAgICAgY3JlYXRlUmVmbGVj dGlvbigpOworICAgICAgICBGZWF0dXJlT2JzZXJ2ZXI6Om9ic2VydmUocmVuZGVyZXIoKS0+ZG9j dW1lbnQoKSwgRmVhdHVyZU9ic2VydmVyOjpSZWZsZWN0aW9uKTsKICAgICAgICAgdXBkYXRlUmVm bGVjdGlvblN0eWxlKCk7CiAgICAgfQogICAgIAo=