111116 2013-02-28 14:45:56 -0800 Disable window occlusion detection for WebKitTestRunner Web View on Mac 2013-02-28 21:48:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 111107 1 cmuppala cmuppala simon.fraser webkit.review.bot oldest_to_newest 844496 0 cmuppala 2013-02-28 14:45:56 -0800 Window Occlusion Notifications on Mac mark the WebKitTestRunner's WebView as not visible as soon as created. On Mac this enables JavaScript timer throttling and hence causes the following layouts tests to fail. fast/dom/timer-increase-min-interval-and-reset-part-2.html fast/dom/timer-increase-then-decrease-min-interval-repeating.html fast/dom/timer-increase-then-decrease-min-interval.html fast/dom/timer-throttling-hidden-page.html This issue was initially fixed by just setting the page visibility to "visible" after creating the WebView in https://bugs.webkit.org/show_bug.cgi?id=111025. But, it is not very robust, since the view still thinks it is invisible and this might cause other tests to fail. Hence, using the private API being added by https://bugs.webkit.org/show_bug.cgi?id=111107, to disable window occlusion detection entirely for the WebKitTestRunner's web view is a better solution. 844497 1 cmuppala 2013-02-28 14:46:33 -0800 <rdar://problem/13305561> 844699 2 190862 cmuppala 2013-02-28 18:23:33 -0800 Created attachment 190862 Patch 844712 3 190862 simon.fraser 2013-02-28 19:01:38 -0800 Comment on attachment 190862 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190862&action=review > Tools/ChangeLog:11 > + Window occlusion notifications on Mac cause the WebKitTestRunner's > + Web View to be treated as invisible and this automatically enables > + JavaScript timer throttling, causing some layout tests exercising > + JavaScript timers to fail. Hence, disable window occlusion detection. This doesn't seem to match the patch (yes, I know it's a follow-up but should not be copied from the other bug). 844722 4 190869 cmuppala 2013-02-28 19:17:07 -0800 Created attachment 190869 Patch 844724 5 cmuppala 2013-02-28 19:18:56 -0800 (In reply to comment #3) > (From update of attachment 190862 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190862&action=review > > > Tools/ChangeLog:11 > > + Window occlusion notifications on Mac cause the WebKitTestRunner's > > + Web View to be treated as invisible and this automatically enables > > + JavaScript timer throttling, causing some layout tests exercising > > + JavaScript timers to fail. Hence, disable window occlusion detection. > > This doesn't seem to match the patch (yes, I know it's a follow-up but should not be copied from the other bug). You're right, I wrote the change log as if I was fixing the tests, while they have already been fixed. Corrected the ChangeLog. 844800 6 190869 webkit.review.bot 2013-02-28 21:48:18 -0800 Comment on attachment 190869 Patch Clearing flags on attachment: 190869 Committed r144415: <http://trac.webkit.org/changeset/144415> 844801 7 webkit.review.bot 2013-02-28 21:48:21 -0800 All reviewed patches have been landed. Closing bug. 190862 2013-02-28 18:23:33 -0800 2013-02-28 19:17:06 -0800 Patch bug-111116-20130228181945.patch text/plain 3078 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MTQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjdkYTczYmEzMThjYzI0MWE0YzBmYTFhNWZjNjJhMTA5 YTc1NjZjYi4uOWRkMzA2Yzc2NDVjYzhjNTRmNzc2MzdiNTJlYjAwYzkzM2EwYTA2MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEzLTAyLTI4ICBLaXJhbiBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgorCisg ICAgICAgIERpc2FibGUgd2luZG93IG9jY2x1c2lvbiBkZXRlY3Rpb24gZm9yIFdlYktpdFRlc3RS dW5uZXIgV2ViIFZpZXcgb24gTWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTExMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaW5kb3cgb2NjbHVzaW9uIG5vdGlmaWNhdGlvbnMgb24gTWFjIGNhdXNl IHRoZSBXZWJLaXRUZXN0UnVubmVyJ3MKKyAgICAgICAgV2ViIFZpZXcgdG8gYmUgdHJlYXRlZCBh cyBpbnZpc2libGUgYW5kIHRoaXMgYXV0b21hdGljYWxseSBlbmFibGVzCisgICAgICAgIEphdmFT Y3JpcHQgdGltZXIgdGhyb3R0bGluZywgY2F1c2luZyBzb21lIGxheW91dCB0ZXN0cyBleGVyY2lz aW5nCisgICAgICAgIEphdmFTY3JpcHQgdGltZXJzIHRvIGZhaWwuICBIZW5jZSwgZGlzYWJsZSB3 aW5kb3cgb2NjbHVzaW9uIGRldGVjdGlvbi4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6Y3JlYXRl V2ViVmlld1dpdGhPcHRpb25zKTogUmVtb3ZlIGNhbGwgdG8KKyAgICAgICAgc2V0VmlzaWJpbGl0 eVN0YXRlLCBhZGRlZCBvcmdpbmFsbHkgdG8gZml4IHRoZSBmYWlsaW5nIEphdmFTY3JpcHQKKyAg ICAgICAgdGltZXIgbGF5b3V0IHRlc3RzLCBieSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTExMDI1LAorICAgICAgICBidXQgaXMgbm8gbG9uZ2VyIG5lY2Vzc2FyeS4K KyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW06Cisg ICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KTogRGlzYWJsZSB3 aW5kb3cgb2NjbHVzaW9uCisgICAgICAgIGRldGVjdGlvbiBmb3IgdGhlIGNyZWF0ZWQgV0tWaWV3 LgorCiAyMDEzLTAyLTI3ICBLaXJhbiBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgogCiAg ICAgICAgIEluaXRpYWxpemUgcGFnZSB2aXNpYmlsaXR5IGFmdGVyIGNyZWF0aW5nIFdlYktpdFRl c3RSdW5uZXIgV2ViVmlldyBvbiBNYWMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJv bGxlci5jcHAKaW5kZXggOTcyOWU5YzYxMmJjNGU5M2M0ODRhYWRmNDVlNjVjZjczZWI1ZDIyNS4u YTA1ZjFhZmU4Y2U2NzYxY2Q5Y2QwN2U4MWVjZWE3ODBiNTMxN2ZiOCAxMDA2NDQKLS0tIGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTQ4MiwxMCArNDgyLDYgQEAgdm9pZCBU ZXN0Q29udHJvbGxlcjo6Y3JlYXRlV2ViVmlld1dpdGhPcHRpb25zKFdLRGljdGlvbmFyeVJlZiBv cHRpb25zKQogICAgICAgICAwLCAvLyB1bmFibGVUb0ltcGxlbWVudFBvbGljeQogICAgIH07CiAg ICAgV0tQYWdlU2V0UGFnZVBvbGljeUNsaWVudChtX21haW5XZWJWaWV3LT5wYWdlKCksICZwYWdl UG9saWN5Q2xpZW50KTsKLQotI2lmIFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9O X01JTl9SRVFVSVJFRCA+PSAxMDkwCi0gICAgc2V0VmlzaWJpbGl0eVN0YXRlKGtXS1BhZ2VWaXNp YmlsaXR5U3RhdGVWaXNpYmxlLCB0cnVlKTsKLSNlbmRpZgogfQogCiB2b2lkIFRlc3RDb250cm9s bGVyOjplbnN1cmVWaWV3U3VwcG9ydHNPcHRpb25zKFdLRGljdGlvbmFyeVJlZiBvcHRpb25zKQpk aWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFj Lm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tCmlu ZGV4IDZmYWNkZDQyNmZhNWE4MDg3MGE0NjA5MDY0Y2FmODliMWI3NTEyYmYuLjdkYzI2NTU5ZDRh ZDQ1ZTRlOThlZDA2ZDcyNTUxNzhlNDEwMmE3MTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KQEAgLTExNSw2ICsxMTUsNyBAQCBQbGF0 Zm9ybVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyhXS0NvbnRleHRSZWYgY29udGV4dFJlZiwgV0tQ YWdlR3JvdXBSZWYgcGFnZUdybwogCiAgICAgTlNSZWN0IHJlY3QgPSBOU01ha2VSZWN0KDAsIDAs IDgwMCwgNjAwKTsKICAgICBtX3ZpZXcgPSBbW1Rlc3RSdW5uZXJXS1ZpZXcgYWxsb2NdIGluaXRX aXRoRnJhbWU6cmVjdCBjb250ZXh0UmVmOmNvbnRleHRSZWYgcGFnZUdyb3VwUmVmOnBhZ2VHcm91 cFJlZiB1c2VUaWxlZERyYXdpbmc6dXNlVGlsZWREcmF3aW5nXTsKKyAgICBbbV92aWV3IHNldFdp bmRvd09jY2x1c2lvbkRldGVjdGlvbkVuYWJsZWQ6Tk9dOwogCiAgICAgTlNSZWN0IHdpbmRvd1Jl Y3QgPSBOU09mZnNldFJlY3QocmVjdCwgLTEwMDAwLCBbKE5TU2NyZWVuICopW1tOU1NjcmVlbiBz Y3JlZW5zXSBvYmplY3RBdEluZGV4OjBdIGZyYW1lXS5zaXplLmhlaWdodCAtIHJlY3Quc2l6ZS5o ZWlnaHQgKyAxMDAwMCk7CiAgICAgbV93aW5kb3cgPSBbW1dlYktpdFRlc3RSdW5uZXJXaW5kb3cg YWxsb2NdIGluaXRXaXRoQ29udGVudFJlY3Q6d2luZG93UmVjdCBzdHlsZU1hc2s6TlNCb3JkZXJs ZXNzV2luZG93TWFzayBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6WUVTXTsK 190869 2013-02-28 19:17:07 -0800 2013-02-28 21:48:18 -0800 Patch bug-111116-20130228191319.patch text/plain 3116 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MTQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjdkYTczYmEzMThjYzI0MWE0YzBmYTFhNWZjNjJhMTA5 YTc1NjZjYi4uNDI0NTMxZWViYjE3ZTA2NTAxZTM2MWRiM2YyOTE5NzFlMGM4M2JiMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEzLTAyLTI4ICBLaXJhbiBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgorCisg ICAgICAgIERpc2FibGUgd2luZG93IG9jY2x1c2lvbiBkZXRlY3Rpb24gZm9yIFdlYktpdFRlc3RS dW5uZXIgV2ViIFZpZXcgb24gTWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTExMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaW5kb3cgb2NjbHVzaW9uIG5vdGlmaWNhdGlvbnMgd2VyZSBjYXVzaW5n IFdlYktpdFRlc3RSdW5uZXIncyBXZWIgVmlldworICAgICAgICB0byBiZSBkZXRlY3RlZCBhcyBv Y2NsdWRlZCBhbmQgY2F1c2luZyBhIGZldyBKYXZhU2NyaXB0IHRpbWVyIGxheW91dAorICAgICAg ICB0ZXN0cyB0byBmYWlsLiAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMTAyNSwgZml4ZWQgdGhpcworICAgICAgICBieSBpbml0aWFsaXppbmcgdGhlIHBhZ2Ugdmlz aWJpbGl0eSB0byAidmlzaWJsZSIgYWZ0ZXIgY3JlYXRpbmcgdGhlIHZpZXcuCisgICAgICAgIEJ1 dCBhIGJldHRlciBzb2x1dGlvbiBpcyB0byBkaXNhYmxlIHdpbmRvdyBvY2NsdXNpb24gZGV0ZWN0 aW9uLCBzbyB0aGF0CisgICAgICAgIG5vdCBvbmx5IHRoZSBwYWdlIGJ1dCBhbHNvIHRoZSB2aWV3 IGlzIHRyZWF0ZWQgYXMgdmlzaWJsZS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6Y3JlYXRlV2Vi Vmlld1dpdGhPcHRpb25zKTogUmVtb3ZlIGNhbGwgdG8KKyAgICAgICAgc2V0VmlzaWJpbGl0eVN0 YXRlLCBzaW5jZSBpdCBpcyBubyBsb25nZXIgbmVjZXNzYXJ5LgorICAgICAgICAqIFdlYktpdFRl c3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbToKKyAgICAgICAgKFdUUjo6UGxhdGZv cm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZpZXcpOiBEaXNhYmxlIHdpbmRvdyBvY2NsdXNpb24KKyAg ICAgICAgZGV0ZWN0aW9uIGZvciB0aGUgY3JlYXRlZCBXS1ZpZXcuCisKIDIwMTMtMDItMjcgIEtp cmFuIE11cHBhbGEgIDxjbXVwcGFsYUBhcHBsZS5jb20+CiAKICAgICAgICAgSW5pdGlhbGl6ZSBw YWdlIHZpc2liaWxpdHkgYWZ0ZXIgY3JlYXRpbmcgV2ViS2l0VGVzdFJ1bm5lciBXZWJWaWV3IG9u IE1hYwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAppbmRleCA5NzI5 ZTljNjEyYmM0ZTkzYzQ4NGFhZGY0NWU2NWNmNzNlYjVkMjI1Li5hMDVmMWFmZThjZTY3NjFjZDlj ZDA3ZTgxZWNlYTc4MGI1MzE3ZmI4IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1Rlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250 cm9sbGVyLmNwcApAQCAtNDgyLDEwICs0ODIsNiBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpjcmVh dGVXZWJWaWV3V2l0aE9wdGlvbnMoV0tEaWN0aW9uYXJ5UmVmIG9wdGlvbnMpCiAgICAgICAgIDAs IC8vIHVuYWJsZVRvSW1wbGVtZW50UG9saWN5CiAgICAgfTsKICAgICBXS1BhZ2VTZXRQYWdlUG9s aWN5Q2xpZW50KG1fbWFpbldlYlZpZXctPnBhZ2UoKSwgJnBhZ2VQb2xpY3lDbGllbnQpOwotCi0j aWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEw OTAKLSAgICBzZXRWaXNpYmlsaXR5U3RhdGUoa1dLUGFnZVZpc2liaWxpdHlTdGF0ZVZpc2libGUs IHRydWUpOwotI2VuZGlmCiB9CiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OmVuc3VyZVZpZXdTdXBw b3J0c09wdGlvbnMoV0tEaWN0aW9uYXJ5UmVmIG9wdGlvbnMpCmRpZmYgLS1naXQgYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0gYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KaW5kZXggNmZhY2RkNDI2ZmE1YTgw ODcwYTQ2MDkwNjRjYWY4OWIxYjc1MTJiZi4uN2RjMjY1NTlkNGFkNDVlNGU5OGVkMDZkNzI1NTE3 OGU0MTAyYTcxMyAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZv cm1XZWJWaWV3TWFjLm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3Jt V2ViVmlld01hYy5tbQpAQCAtMTE1LDYgKzExNSw3IEBAIFBsYXRmb3JtV2ViVmlldzo6UGxhdGZv cm1XZWJWaWV3KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3Jv CiAKICAgICBOU1JlY3QgcmVjdCA9IE5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApOwogICAgIG1f dmlldyA9IFtbVGVzdFJ1bm5lcldLVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpyZWN0IGNvbnRl eHRSZWY6Y29udGV4dFJlZiBwYWdlR3JvdXBSZWY6cGFnZUdyb3VwUmVmIHVzZVRpbGVkRHJhd2lu Zzp1c2VUaWxlZERyYXdpbmddOworICAgIFttX3ZpZXcgc2V0V2luZG93T2NjbHVzaW9uRGV0ZWN0 aW9uRW5hYmxlZDpOT107CiAKICAgICBOU1JlY3Qgd2luZG93UmVjdCA9IE5TT2Zmc2V0UmVjdChy ZWN0LCAtMTAwMDAsIFsoTlNTY3JlZW4gKilbW05TU2NyZWVuIHNjcmVlbnNdIG9iamVjdEF0SW5k ZXg6MF0gZnJhbWVdLnNpemUuaGVpZ2h0IC0gcmVjdC5zaXplLmhlaWdodCArIDEwMDAwKTsKICAg ICBtX3dpbmRvdyA9IFtbV2ViS2l0VGVzdFJ1bm5lcldpbmRvdyBhbGxvY10gaW5pdFdpdGhDb250 ZW50UmVjdDp3aW5kb3dSZWN0IHN0eWxlTWFzazpOU0JvcmRlcmxlc3NXaW5kb3dNYXNrIGJhY2tp bmc6TlNCYWNraW5nU3RvcmVCdWZmZXJlZCBkZWZlcjpZRVNdOwo=