111114 2013-02-28 14:34:36 -0800 [V8] Remove the world->isMainWorld() check from minorGCPrologue() 2013-02-28 15:27:43 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth dcarney japhet webkit.review.bot oldest_to_newest 844481 0 haraken 2013-02-28 14:34:36 -0800 A couple of weeks ago, I introduced the following check to minorGCPrologue() in r142419. void minorGCPrologue() { // A minor GC can handle the main world only. DOMWrapperWorld* world = worldForEnteredContextWithoutContextCheck(); if (world && world->isMainWorld()) { MinorGCWrapperVisitor visitor(isolate); v8::V8::VisitHandlesForPartialDependence(isolate, &visitor); visitor.notifyFinished(); } } - The check makes no sense. A GC should not care about what world we are in. There is no concept of worlds in GC. - worldForEnteredContextWithoutContextCheck() returns 0 for the main world. So if a GC runs in the main world, the minor DOM GC is skipped. - worldForEnteredContextWithoutContextCheck() caused a Chromium crash (https://code.google.com/p/chromium/issues/detail?id=177587) We should remove the check. 844484 1 190810 haraken 2013-02-28 14:36:20 -0800 Created attachment 190810 Patch 844485 2 190811 haraken 2013-02-28 14:37:17 -0800 Created attachment 190811 Patch 844537 3 190811 webkit.review.bot 2013-02-28 15:27:40 -0800 Comment on attachment 190811 Patch Clearing flags on attachment: 190811 Committed r144381: <http://trac.webkit.org/changeset/144381> 844538 4 webkit.review.bot 2013-02-28 15:27:43 -0800 All reviewed patches have been landed. Closing bug. 190810 2013-02-28 14:36:20 -0800 2013-02-28 14:37:15 -0800 Patch bug-111114-20130228143232.patch text/plain 7127 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwMWE4ZTM5ZWQ1NjM5 NTk0YWNiYWM2MzU5Y2VkZTAyZTRlNjU2ZC4uMGEyZjk3Mjc2OGFmYWVlZGJlMDdlOGI1ODE3NDI4 ZmE2NWUyZjJlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQzIEBACisyMDEzLTAyLTI4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSB0 aGUgd29ybGQtPmlzTWFpbldvcmxkKCkgY2hlY2sgZnJvbSBtaW5vckdDUHJvbG9ndWUoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBjb3VwbGUgb2Yg d2Vla3MgYWdvLCBJIGludHJvZHVjZWQgdGhlIGZvbGxvd2luZyBjaGVjayB0byBtaW5vckdDUHJv bG9ndWUoKSBpbiByMTQyNDE5LgorCisgICAgICAgICAgdm9pZCBtaW5vckdDUHJvbG9ndWUoKSB7 CisgICAgICAgICAgICAvLyBBIG1pbm9yIEdDIGNhbiBoYW5kbGUgdGhlIG1haW4gd29ybGQgb25s eS4KKyAgICAgICAgICAgIERPTVdyYXBwZXJXb3JsZCogd29ybGQgPSB3b3JsZEZvckVudGVyZWRD b250ZXh0V2l0aG91dENvbnRleHRDaGVjaygpOworICAgICAgICAgICAgaWYgKHdvcmxkICYmIHdv cmxkLT5pc01haW5Xb3JsZCgpKSB7CisgICAgICAgICAgICAgIE1pbm9yR0NXcmFwcGVyVmlzaXRv ciB2aXNpdG9yKGlzb2xhdGUpOworICAgICAgICAgICAgICB2ODo6Vjg6OlZpc2l0SGFuZGxlc0Zv clBhcnRpYWxEZXBlbmRlbmNlKGlzb2xhdGUsICZ2aXNpdG9yKTsKKyAgICAgICAgICAgICAgdmlz aXRvci5ub3RpZnlGaW5pc2hlZCgpOworICAgICAgICAgICAgfQorICAgICAgICAgIH0KKworICAg ICAgICAtIFRoZSBjaGVjayBtYWtlcyBubyBzZW5zZS4gQSBHQyBzaG91bGQgbm90IGNhcmUgYWJv dXQgd2hhdCB3b3JsZCB3ZSBhcmUgaW4uCisgICAgICAgIFRoZXJlIGlzIG5vIGNvbmNlcHQgb2Yg d29ybGRzIGluIEdDLgorCisgICAgICAgIC0gd29ybGRGb3JFbnRlcmVkQ29udGV4dFdpdGhvdXRD b250ZXh0Q2hlY2soKSByZXR1cm5zIDAgZm9yIHRoZSBtYWluIHdvcmxkLgorICAgICAgICBTbyBp ZiBhIEdDIHJ1bnMgaW4gdGhlIG1haW4gd29ybGQsIHRoZSBtaW5vciBET00gR0MgaXMgc2tpcHBl ZC4KKworICAgICAgICAtIHdvcmxkRm9yRW50ZXJlZENvbnRleHRXaXRob3V0Q29udGV4dENoZWNr KCkgY2F1c2VkIGEgQ2hyb21pdW0gY3Jhc2gKKyAgICAgICAgKGh0dHBzOi8vY29kZS5nb29nbGUu Y29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0xNzc1ODcpCisKKyAgICAgICAgV2Ugc2hv dWxkIHJlbW92ZSB0aGUgY2hlY2suCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBi ZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5oOgorICAg ICAgICAoV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkOjpnZXRXb3JsZCk6CisgICAgICAgICogYmlu ZGluZ3MvdjgvVjhCaW5kaW5nLmg6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xs ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6Om1pbm9yR0NQcm9sb2d1 ZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmg6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJCbG9jazo6Y3JlYXRlQW5vbnltb3VzQmxvY2spOgorCiAyMDEzLTAyLTI4ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IElP IGVycm9yIHdoZW4gY2hlY2tpbmcgc2NoZW1hIHNob3VsZCBkZXN0cm95IExldmVsREIgZGlyZWN0 b3J5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01XcmFwcGVyV29y bGQuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5oCmluZGV4 IDQ4YzIwZTQ2MjUzMmU3OTNlM2NiMjE0YzI2YWE3ZmQzZWRiNTZjMjEuLmY3NWZhN2JkYTFkOTE4 Mzg5YTNkYTExNzYwYjRmYWQyNGNkZDUxNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L0RPTVdyYXBwZXJXb3JsZC5oCkBAIC02NywxMCArNjcsNiBAQCBwdWJsaWM6CiAgICAgICAg IGFzc2VydENvbnRleHRIYXNDb3JyZWN0UHJvdG90eXBlKGNvbnRleHQpOwogICAgICAgICByZXR1 cm4gc3RhdGljX2Nhc3Q8RE9NV3JhcHBlcldvcmxkKj4oY29udGV4dC0+R2V0QWxpZ25lZFBvaW50 ZXJGcm9tRW1iZWRkZXJEYXRhKHY4Q29udGV4dElzb2xhdGVkV29ybGQpKTsKICAgICB9Ci0gICAg c3RhdGljIERPTVdyYXBwZXJXb3JsZCogZ2V0V29ybGRXaXRob3V0Q29udGV4dENoZWNrKHY4OjpI YW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQpCi0gICAgewotICAgICAgICByZXR1cm4gc3RhdGlj X2Nhc3Q8RE9NV3JhcHBlcldvcmxkKj4oY29udGV4dC0+R2V0QWxpZ25lZFBvaW50ZXJGcm9tRW1i ZWRkZXJEYXRhKHY4Q29udGV4dElzb2xhdGVkV29ybGQpKTsKLSAgICB9CiAKICAgICAvLyBBc3Nv Y2lhdGVzIGFuIGlzb2xhdGVkIHdvcmxkIChzZWUgYWJvdmUgZm9yIGRlc2NyaXB0aW9uKSB3aXRo IGEgc2VjdXJpdHkKICAgICAvLyBvcmlnaW4uIFhNTEh0dHBSZXF1ZXN0IGluc3RhbmNlcyB1c2Vk IGluIHRoYXQgd29ybGQgd2lsbCBiZSBjb25zaWRlcmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4QmluZGluZy5oCmluZGV4IDk2MmIwODY5OWU4MWVmYTcwMTU0YzNkMGFhYTUxMzUxNmEyNjE5 OTUuLjc2NmRjMjQxZWI4YTM1ZGE3Nzk4ZTg2ZTIyODBmOGU0NDMzZWUwZWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCkBAIC00NTAsMjIgKzQ1MCw2IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgcmV0dXJuIERPTVdyYXBwZXJXb3JsZDo6Z2V0V29ybGQoY29u dGV4dCk7CiAgICAgfQogCi0gICAgLy8gVGhpcyBpcyBhIHNsaWdodGx5IGRpZmZlcmVudCB2ZXJz aW9uIG9mIHdvcmxkRm9yRW50ZXJlZENvbnRleHQoKS4KLSAgICAvLyBUaGUgZGlmZmVyZW5jZSBp cyBqdXN0IHRoYXQgd29ybGRGb3JFbnRlcmVkQ29udGV4dFdpdGhvdXRDb250ZXh0Q2hlY2soKQot ICAgIC8vIGRvZXMgbm90IGNhbGwgYXNzZXJ0Q29udGV4dEhhc0NvcnJlY3RQcm90b3R5cGUoKSAo d2hpY2ggaXMgZW5hYmxlZCBvbgotICAgIC8vIERlYnVnIGJ1aWxkcyBvbmx5KS4gQmVjYXVzZSBh c3NlcnRDb250ZXh0SGFzQ29ycmVjdFByb3RvdHlwZSgpIGNyYXNoZXMKLSAgICAvLyBpZiBpdCBp cyBjYWxsZWQgd2hlbiBhIGN1cnJlbnQgY29udGV4dCBpcyBub3QgY29tcGxldGVseSBpbml0aWFs aXplZCwKLSAgICAvLyB5b3UgaGF2ZSB0byB1c2Ugd29ybGRGb3JFbnRlcmVkQ29udGV4dFdpdGhv dXRDb250ZXh0Q2hlY2soKSBpZiB5b3UgbmVlZAotICAgIC8vIHRvIGdldCBhIERPTVdyYXBwZXJX b3JsZCB3aGlsZSBhIGN1cnJlbnQgY29udGV4dCBpcyBiZWluZyBpbml0aWFsaXplZC4KLSAgICAv LyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODU3OSNjMTUg Zm9yIG1vcmUgZGV0YWlscy4KLSAgICBpbmxpbmUgRE9NV3JhcHBlcldvcmxkKiB3b3JsZEZvckVu dGVyZWRDb250ZXh0V2l0aG91dENvbnRleHRDaGVjaygpCi0gICAgewotICAgICAgICB2ODo6SGFu ZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0ID0gdjg6OkNvbnRleHQ6OkdldEVudGVyZWQoKTsKLSAg ICAgICAgaWYgKGNvbnRleHQuSXNFbXB0eSgpKQotICAgICAgICAgICAgcmV0dXJuIDA7Ci0gICAg ICAgIHJldHVybiBET01XcmFwcGVyV29ybGQ6OmdldFdvcmxkV2l0aG91dENvbnRleHRDaGVjayhj b250ZXh0KTsKLSAgICB9Ci0KICAgICAvLyBJZiB0aGUgY3VycmVudCBjb250ZXh0IGNhdXNlcyBv dXQgb2YgbWVtb3J5LCBKYXZhU2NyaXB0IHNldHRpbmcKICAgICAvLyBpcyBkaXNhYmxlZCBhbmQg aXQgcmV0dXJucyB0cnVlLgogICAgIGJvb2wgaGFuZGxlT3V0T2ZNZW1vcnkoKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAppbmRleCAxMmZkNTQ2NDI5 MGRlOGU2MzJkYzQ1NmY3ZTA3NTcyNzM3NjMwYzY2Li43ZTZjNGJiMTE4NTE4ZTY3MmQzYTAyZmRh YWIxZjI4YzI4ODA3OGY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEdDQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0Nv bnRyb2xsZXIuY3BwCkBAIC0yNTgsOCArMjU4LDEzIEBAIHB1YmxpYzoKICAgICAgICAgQVNTRVJU KFY4RE9NV3JhcHBlcjo6bWF5YmVET01XcmFwcGVyKHZhbHVlKSk7CiAgICAgICAgIEFTU0VSVChW OE5vZGU6Okhhc0luc3RhbmNlKHdyYXBwZXIsIG1faXNvbGF0ZSkpOwogICAgICAgICBOb2RlKiBu b2RlID0gVjhOb2RlOjp0b05hdGl2ZSh3cmFwcGVyKTsKLSAgICAgICAgbV9ub2Rlc0luTmV3U3Bh Y2UuYXBwZW5kKG5vZGUpOwotICAgICAgICBub2RlLT5zZXRWOENvbGxlY3RhYmxlRHVyaW5nTWlu b3JHQyh0cnVlKTsKKyAgICAgICAgLy8gQSBtaW5vciBET00gR0MgY2FuIGhhbmRsZSBvbmx5IG5v ZGUgd3JhcHBlcnMgaW4gdGhlIG1haW4gd29ybGQuCisgICAgICAgIC8vIE5vdGUgdGhhdCBub2Rl LT53cmFwcGVyKCkuSXNFbXB0eSgpIHJldHVybnMgdHJ1ZSBmb3Igbm9kZXMgdGhhdAorICAgICAg ICAvLyBkbyBub3QgaGF2ZSB3cmFwcGVycyBpbiB0aGUgbWFpbiB3b3JsZC4KKyAgICAgICAgaWYg KCFub2RlLT53cmFwcGVyKCkuSXNFbXB0eSgpKSB7CisgICAgICAgICAgICBtX25vZGVzSW5OZXdT cGFjZS5hcHBlbmQobm9kZSk7CisgICAgICAgICAgICBub2RlLT5zZXRWOENvbGxlY3RhYmxlRHVy aW5nTWlub3JHQyh0cnVlKTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHZvaWQgbm90aWZ5Rmlu aXNoZWQoKQpAQCAtMzY0LDEzICszNjksOSBAQCB2b2lkIFY4R0NDb250cm9sbGVyOjptaW5vckdD UHJvbG9ndWUodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAgICAgICAgIHY4OjpJc29sYXRlKiBpc29s YXRlID0gdjg6Oklzb2xhdGU6OkdldEN1cnJlbnQoKTsKICAgICAgICAgdjg6OkhhbmRsZVNjb3Bl IHNjb3BlOwogCi0gICAgICAgIC8vIEEgbWlub3IgR0MgY2FuIGhhbmRsZSB0aGUgbWFpbiB3b3Js ZCBvbmx5LgotICAgICAgICBET01XcmFwcGVyV29ybGQqIHdvcmxkID0gd29ybGRGb3JFbnRlcmVk Q29udGV4dFdpdGhvdXRDb250ZXh0Q2hlY2soKTsKLSAgICAgICAgaWYgKHdvcmxkICYmIHdvcmxk LT5pc01haW5Xb3JsZCgpKSB7Ci0gICAgICAgICAgICBNaW5vckdDV3JhcHBlclZpc2l0b3Igdmlz aXRvcihpc29sYXRlKTsKLSAgICAgICAgICAgIHY4OjpWODo6VmlzaXRIYW5kbGVzRm9yUGFydGlh bERlcGVuZGVuY2UoaXNvbGF0ZSwgJnZpc2l0b3IpOwotICAgICAgICAgICAgdmlzaXRvci5ub3Rp ZnlGaW5pc2hlZCgpOwotICAgICAgICB9CisgICAgICAgIE1pbm9yR0NXcmFwcGVyVmlzaXRvciB2 aXNpdG9yKGlzb2xhdGUpOworICAgICAgICB2ODo6Vjg6OlZpc2l0SGFuZGxlc0ZvclBhcnRpYWxE ZXBlbmRlbmNlKGlzb2xhdGUsICZ2aXNpdG9yKTsKKyAgICAgICAgdmlzaXRvci5ub3RpZnlGaW5p c2hlZCgpOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaApp bmRleCBiYjI5MDFlNmM2ODM2MTgzZmU0YWMwMjUwZjZhMGIwMzUzZGVkMTg5Li4xZDNlZDkzM2M3 ZDUwNjY3NTNlNTZkNWYwZTMzYjYyMDkzYmNjMmZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suaApAQCAtMjY1LDcgKzI2NSw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUmVu ZGVyQmxvY2sqIGNyZWF0ZUFub255bW91c1dpdGhQYXJlbnRSZW5kZXJlckFuZERpc3BsYXkoY29u c3QgUmVuZGVyT2JqZWN0KiwgRURpc3BsYXkgPSBCTE9DSyk7CiAgICAgc3RhdGljIFJlbmRlckJs b2NrKiBjcmVhdGVBbm9ueW1vdXNDb2x1bW5zV2l0aFBhcmVudFJlbmRlcmVyKGNvbnN0IFJlbmRl ck9iamVjdCopOwogICAgIHN0YXRpYyBSZW5kZXJCbG9jayogY3JlYXRlQW5vbnltb3VzQ29sdW1u U3BhbldpdGhQYXJlbnRSZW5kZXJlcihjb25zdCBSZW5kZXJPYmplY3QqKTsKLSAgICBSZW5kZXJC bG9jayogY3JlYXRlQW5vbnltb3VzQmxvY2soRURpc3BsYXkgZGlzcGxheSA9IEJMT0NLKSBjb25z dCB7IHJldHVybiBjcmVhdGVBbm9ueW1vdXNXaXRoUGFyZW50UmVuZGVyZXJBbmREaXNwbGF5KHRo aXMsIGRpc3BsYXkpOyB9CisgICAgUmVuZGVyQmxvY2sqIGNyZWF0ZUFub255bW91c0Jsb2NrKEVE aXNwbGF5IGRpc3BsYXkgPSBCTE9DSykgY29uc3QgeyBDUkFTSCgpOyByZXR1cm4gY3JlYXRlQW5v bnltb3VzV2l0aFBhcmVudFJlbmRlcmVyQW5kRGlzcGxheSh0aGlzLCBkaXNwbGF5KTsgfQogICAg IFJlbmRlckJsb2NrKiBjcmVhdGVBbm9ueW1vdXNDb2x1bW5zQmxvY2soKSBjb25zdCB7IHJldHVy biBjcmVhdGVBbm9ueW1vdXNDb2x1bW5zV2l0aFBhcmVudFJlbmRlcmVyKHRoaXMpOyB9CiAgICAg UmVuZGVyQmxvY2sqIGNyZWF0ZUFub255bW91c0NvbHVtblNwYW5CbG9jaygpIGNvbnN0IHsgcmV0 dXJuIGNyZWF0ZUFub255bW91c0NvbHVtblNwYW5XaXRoUGFyZW50UmVuZGVyZXIodGhpcyk7IH0K IAo= 190811 2013-02-28 14:37:17 -0800 2013-02-28 15:27:39 -0800 Patch bug-111114-20130228143329.patch text/plain 5914 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwMWE4ZTM5ZWQ1NjM5 NTk0YWNiYWM2MzU5Y2VkZTAyZTRlNjU2ZC4uODMyYTAxODUwZWE5YjE1N2FhOGFjYzg0YThhZDBh ZTA0NDM4NDFmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQxIEBACisyMDEzLTAyLTI4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSB0 aGUgd29ybGQtPmlzTWFpbldvcmxkKCkgY2hlY2sgZnJvbSBtaW5vckdDUHJvbG9ndWUoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBjb3VwbGUgb2Yg d2Vla3MgYWdvLCBJIGludHJvZHVjZWQgdGhlIGZvbGxvd2luZyBjaGVjayB0byBtaW5vckdDUHJv bG9ndWUoKSBpbiByMTQyNDE5LgorCisgICAgICAgICAgdm9pZCBtaW5vckdDUHJvbG9ndWUoKSB7 CisgICAgICAgICAgICAvLyBBIG1pbm9yIEdDIGNhbiBoYW5kbGUgdGhlIG1haW4gd29ybGQgb25s eS4KKyAgICAgICAgICAgIERPTVdyYXBwZXJXb3JsZCogd29ybGQgPSB3b3JsZEZvckVudGVyZWRD b250ZXh0V2l0aG91dENvbnRleHRDaGVjaygpOworICAgICAgICAgICAgaWYgKHdvcmxkICYmIHdv cmxkLT5pc01haW5Xb3JsZCgpKSB7CisgICAgICAgICAgICAgIE1pbm9yR0NXcmFwcGVyVmlzaXRv ciB2aXNpdG9yKGlzb2xhdGUpOworICAgICAgICAgICAgICB2ODo6Vjg6OlZpc2l0SGFuZGxlc0Zv clBhcnRpYWxEZXBlbmRlbmNlKGlzb2xhdGUsICZ2aXNpdG9yKTsKKyAgICAgICAgICAgICAgdmlz aXRvci5ub3RpZnlGaW5pc2hlZCgpOworICAgICAgICAgICAgfQorICAgICAgICAgIH0KKworICAg ICAgICAtIFRoZSBjaGVjayBtYWtlcyBubyBzZW5zZS4gQSBHQyBzaG91bGQgbm90IGNhcmUgYWJv dXQgd2hhdCB3b3JsZCB3ZSBhcmUgaW4uCisgICAgICAgIFRoZXJlIGlzIG5vIGNvbmNlcHQgb2Yg d29ybGRzIGluIEdDLgorCisgICAgICAgIC0gd29ybGRGb3JFbnRlcmVkQ29udGV4dFdpdGhvdXRD b250ZXh0Q2hlY2soKSByZXR1cm5zIDAgZm9yIHRoZSBtYWluIHdvcmxkLgorICAgICAgICBTbyBp ZiBhIEdDIHJ1bnMgaW4gdGhlIG1haW4gd29ybGQsIHRoZSBtaW5vciBET00gR0MgaXMgc2tpcHBl ZC4KKworICAgICAgICAtIHdvcmxkRm9yRW50ZXJlZENvbnRleHRXaXRob3V0Q29udGV4dENoZWNr KCkgY2F1c2VkIGEgQ2hyb21pdW0gY3Jhc2gKKyAgICAgICAgKGh0dHBzOi8vY29kZS5nb29nbGUu Y29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0xNzc1ODcpCisKKyAgICAgICAgV2Ugc2hv dWxkIHJlbW92ZSB0aGUgY2hlY2suCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBi ZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5oOgorICAg ICAgICAoV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkOjpnZXRXb3JsZCk6CisgICAgICAgICogYmlu ZGluZ3MvdjgvVjhCaW5kaW5nLmg6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xs ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6Om1pbm9yR0NQcm9sb2d1 ZSk6CisKIDIwMTMtMDItMjggIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIEluZGV4ZWREQjogSU8gZXJyb3Igd2hlbiBjaGVja2luZyBzY2hlbWEgc2hvdWxk IGRlc3Ryb3kgTGV2ZWxEQiBkaXJlY3RvcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv RE9NV3JhcHBlcldvcmxkLmgKaW5kZXggNDhjMjBlNDYyNTMyZTc5M2UzY2IyMTRjMjZhYTdmZDNl ZGI1NmMyMS4uZjc1ZmE3YmRhMWQ5MTgzODlhM2RhMTE3NjBiNGZhZDI0Y2RkNTE0ZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmgKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmgKQEAgLTY3LDEwICs2 Nyw2IEBAIHB1YmxpYzoKICAgICAgICAgYXNzZXJ0Q29udGV4dEhhc0NvcnJlY3RQcm90b3R5cGUo Y29udGV4dCk7CiAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxET01XcmFwcGVyV29ybGQqPihj b250ZXh0LT5HZXRBbGlnbmVkUG9pbnRlckZyb21FbWJlZGRlckRhdGEodjhDb250ZXh0SXNvbGF0 ZWRXb3JsZCkpOwogICAgIH0KLSAgICBzdGF0aWMgRE9NV3JhcHBlcldvcmxkKiBnZXRXb3JsZFdp dGhvdXRDb250ZXh0Q2hlY2sodjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gY29udGV4dCkKLSAgICB7 Ci0gICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxET01XcmFwcGVyV29ybGQqPihjb250ZXh0LT5H ZXRBbGlnbmVkUG9pbnRlckZyb21FbWJlZGRlckRhdGEodjhDb250ZXh0SXNvbGF0ZWRXb3JsZCkp OwotICAgIH0KIAogICAgIC8vIEFzc29jaWF0ZXMgYW4gaXNvbGF0ZWQgd29ybGQgKHNlZSBhYm92 ZSBmb3IgZGVzY3JpcHRpb24pIHdpdGggYSBzZWN1cml0eQogICAgIC8vIG9yaWdpbi4gWE1MSHR0 cFJlcXVlc3QgaW5zdGFuY2VzIHVzZWQgaW4gdGhhdCB3b3JsZCB3aWxsIGJlIGNvbnNpZGVyZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKaW5kZXggOTYyYjA4Njk5ZTgxZWZh NzAxNTRjM2QwYWFhNTEzNTE2YTI2MTk5NS4uNzY2ZGMyNDFlYjhhMzVkYTc3OThlODZlMjI4MGY4 ZTQ0MzNlZTBlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5k aW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTQ1 MCwyMiArNDUwLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICByZXR1cm4gRE9NV3Jh cHBlcldvcmxkOjpnZXRXb3JsZChjb250ZXh0KTsKICAgICB9CiAKLSAgICAvLyBUaGlzIGlzIGEg c2xpZ2h0bHkgZGlmZmVyZW50IHZlcnNpb24gb2Ygd29ybGRGb3JFbnRlcmVkQ29udGV4dCgpLgot ICAgIC8vIFRoZSBkaWZmZXJlbmNlIGlzIGp1c3QgdGhhdCB3b3JsZEZvckVudGVyZWRDb250ZXh0 V2l0aG91dENvbnRleHRDaGVjaygpCi0gICAgLy8gZG9lcyBub3QgY2FsbCBhc3NlcnRDb250ZXh0 SGFzQ29ycmVjdFByb3RvdHlwZSgpICh3aGljaCBpcyBlbmFibGVkIG9uCi0gICAgLy8gRGVidWcg YnVpbGRzIG9ubHkpLiBCZWNhdXNlIGFzc2VydENvbnRleHRIYXNDb3JyZWN0UHJvdG90eXBlKCkg Y3Jhc2hlcwotICAgIC8vIGlmIGl0IGlzIGNhbGxlZCB3aGVuIGEgY3VycmVudCBjb250ZXh0IGlz IG5vdCBjb21wbGV0ZWx5IGluaXRpYWxpemVkLAotICAgIC8vIHlvdSBoYXZlIHRvIHVzZSB3b3Js ZEZvckVudGVyZWRDb250ZXh0V2l0aG91dENvbnRleHRDaGVjaygpIGlmIHlvdSBuZWVkCi0gICAg Ly8gdG8gZ2V0IGEgRE9NV3JhcHBlcldvcmxkIHdoaWxlIGEgY3VycmVudCBjb250ZXh0IGlzIGJl aW5nIGluaXRpYWxpemVkLgotICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA4NTc5I2MxNSBmb3IgbW9yZSBkZXRhaWxzLgotICAgIGlubGluZSBET01X cmFwcGVyV29ybGQqIHdvcmxkRm9yRW50ZXJlZENvbnRleHRXaXRob3V0Q29udGV4dENoZWNrKCkK LSAgICB7Ci0gICAgICAgIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IGNvbnRleHQgPSB2ODo6Q29u dGV4dDo6R2V0RW50ZXJlZCgpOwotICAgICAgICBpZiAoY29udGV4dC5Jc0VtcHR5KCkpCi0gICAg ICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgcmV0dXJuIERPTVdyYXBwZXJXb3JsZDo6Z2V0V29y bGRXaXRob3V0Q29udGV4dENoZWNrKGNvbnRleHQpOwotICAgIH0KLQogICAgIC8vIElmIHRoZSBj dXJyZW50IGNvbnRleHQgY2F1c2VzIG91dCBvZiBtZW1vcnksIEphdmFTY3JpcHQgc2V0dGluZwog ICAgIC8vIGlzIGRpc2FibGVkIGFuZCBpdCByZXR1cm5zIHRydWUuCiAgICAgYm9vbCBoYW5kbGVP dXRPZk1lbW9yeSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhH Q0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xs ZXIuY3BwCmluZGV4IDEyZmQ1NDY0MjkwZGU4ZTYzMmRjNDU2ZjdlMDc1NzI3Mzc2MzBjNjYuLjdl NmM0YmIxMTg1MThlNjcyZDNhMDJmZGFhYjFmMjhjMjg4MDc4ZjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKQEAgLTI1OCw4ICsyNTgsMTMgQEAg cHVibGljOgogICAgICAgICBBU1NFUlQoVjhET01XcmFwcGVyOjptYXliZURPTVdyYXBwZXIodmFs dWUpKTsKICAgICAgICAgQVNTRVJUKFY4Tm9kZTo6SGFzSW5zdGFuY2Uod3JhcHBlciwgbV9pc29s YXRlKSk7CiAgICAgICAgIE5vZGUqIG5vZGUgPSBWOE5vZGU6OnRvTmF0aXZlKHdyYXBwZXIpOwot ICAgICAgICBtX25vZGVzSW5OZXdTcGFjZS5hcHBlbmQobm9kZSk7Ci0gICAgICAgIG5vZGUtPnNl dFY4Q29sbGVjdGFibGVEdXJpbmdNaW5vckdDKHRydWUpOworICAgICAgICAvLyBBIG1pbm9yIERP TSBHQyBjYW4gaGFuZGxlIG9ubHkgbm9kZSB3cmFwcGVycyBpbiB0aGUgbWFpbiB3b3JsZC4KKyAg ICAgICAgLy8gTm90ZSB0aGF0IG5vZGUtPndyYXBwZXIoKS5Jc0VtcHR5KCkgcmV0dXJucyB0cnVl IGZvciBub2RlcyB0aGF0CisgICAgICAgIC8vIGRvIG5vdCBoYXZlIHdyYXBwZXJzIGluIHRoZSBt YWluIHdvcmxkLgorICAgICAgICBpZiAoIW5vZGUtPndyYXBwZXIoKS5Jc0VtcHR5KCkpIHsKKyAg ICAgICAgICAgIG1fbm9kZXNJbk5ld1NwYWNlLmFwcGVuZChub2RlKTsKKyAgICAgICAgICAgIG5v ZGUtPnNldFY4Q29sbGVjdGFibGVEdXJpbmdNaW5vckdDKHRydWUpOworICAgICAgICB9CiAgICAg fQogCiAgICAgdm9pZCBub3RpZnlGaW5pc2hlZCgpCkBAIC0zNjQsMTMgKzM2OSw5IEBAIHZvaWQg VjhHQ0NvbnRyb2xsZXI6Om1pbm9yR0NQcm9sb2d1ZSh2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKICAg ICAgICAgdjg6Oklzb2xhdGUqIGlzb2xhdGUgPSB2ODo6SXNvbGF0ZTo6R2V0Q3VycmVudCgpOwog ICAgICAgICB2ODo6SGFuZGxlU2NvcGUgc2NvcGU7CiAKLSAgICAgICAgLy8gQSBtaW5vciBHQyBj YW4gaGFuZGxlIHRoZSBtYWluIHdvcmxkIG9ubHkuCi0gICAgICAgIERPTVdyYXBwZXJXb3JsZCog d29ybGQgPSB3b3JsZEZvckVudGVyZWRDb250ZXh0V2l0aG91dENvbnRleHRDaGVjaygpOwotICAg ICAgICBpZiAod29ybGQgJiYgd29ybGQtPmlzTWFpbldvcmxkKCkpIHsKLSAgICAgICAgICAgIE1p bm9yR0NXcmFwcGVyVmlzaXRvciB2aXNpdG9yKGlzb2xhdGUpOwotICAgICAgICAgICAgdjg6OlY4 OjpWaXNpdEhhbmRsZXNGb3JQYXJ0aWFsRGVwZW5kZW5jZShpc29sYXRlLCAmdmlzaXRvcik7Ci0g ICAgICAgICAgICB2aXNpdG9yLm5vdGlmeUZpbmlzaGVkKCk7Ci0gICAgICAgIH0KKyAgICAgICAg TWlub3JHQ1dyYXBwZXJWaXNpdG9yIHZpc2l0b3IoaXNvbGF0ZSk7CisgICAgICAgIHY4OjpWODo6 VmlzaXRIYW5kbGVzRm9yUGFydGlhbERlcGVuZGVuY2UoaXNvbGF0ZSwgJnZpc2l0b3IpOworICAg ICAgICB2aXNpdG9yLm5vdGlmeUZpbmlzaGVkKCk7CiAgICAgfQogfQogCg==