111112 2013-02-28 14:11:21 -0800 [chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt' 2013-03-08 15:29:25 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 chandra.vallala webkit-unassigned dglazkov tony webkit.review.bot oldest_to_newest 844465 0 chandra.vallala 2013-02-28 14:11:21 -0800 Steps to reproduce the problem: 1. Create an onkeydown event handler for an html input element 2. Press shift 3. While holding shift, press alt What is the expected behavior? The onkeydown event for the alt keypress should contain the following: altKey: true which: 18 What went wrong? The onkeydown event for the alt keypress contains the following: altKey: false which: 91 Ref: http://code.google.com/p/chromium/issues/detail?id=177100 844477 1 190807 chandra.vallala 2013-02-28 14:27:31 -0800 Created attachment 190807 patch 846771 2 190807 tony 2013-03-04 13:14:05 -0800 Comment on attachment 190807 patch View in context: https://bugs.webkit.org/attachment.cgi?id=190807&action=review > Source/WebCore/ChangeLog:12 > + Added Manual Test : ManualTests/shift-alt-key-event.html > + Try press Shift then alt key. The test passes if the shiftKey, altKey values > + of JSKeyEvent are true and keycode/which is 18. Did you try writing a layout test using eventSender? It would be nice to know why that doesn't work. Also, did you test this in Firefox on Linux? What does it send? If we are matching Firefox, please include that in the ChangeLog. 848197 3 chandra.vallala 2013-03-05 16:06:17 -0800 (In reply to comment #2) > (From update of attachment 190807 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190807&action=review > > > Source/WebCore/ChangeLog:12 > > + Added Manual Test : ManualTests/shift-alt-key-event.html > > + Try press Shift then alt key. The test passes if the shiftKey, altKey values > > + of JSKeyEvent are true and keycode/which is 18. > > Did you try writing a layout test using eventSender? It would be nice to know why that doesn't work. > Yes, I tried writing a layout test using eventSender. It didn't work since EventeSender::keyDown is unable to simulate a WebKeyboardEvent with keycode = GDK_Meta, modifier=Shift|Alt > Also, did you test this in Firefox on Linux? What does it send? If we are matching Firefox, please include that in the ChangeLog. Yes, I tried in Firefox, Opera and its working fine. Firefox do not map the keycode to Windows keycode directly, They find the right keycode for a GdkEventKey if the key event has a modifier. Chrome key code conversion does the same in above case. ui/base/keycodes/keyboard_code_conversion_x.cc:791 848199 4 191592 chandra.vallala 2013-03-05 16:07:50 -0800 Created attachment 191592 patch Added Firefox behaviour in change log 848263 5 191592 tony 2013-03-05 16:58:11 -0800 Comment on attachment 191592 patch View in context: https://bugs.webkit.org/attachment.cgi?id=191592&action=review Looks like you also need to rebase your patch to ToT. > ManualTests/shift-alt-key-event.html:8 > +function myFunction(event) Please use a better name than myFunction. How about keyDown? > ManualTests/shift-alt-key-event.html:14 > + if(event.shiftKey == true && event.altKey == true && event.which == 18) { Nit: Put a space after if. > ManualTests/shift-alt-key-event.html:16 > + }else { Nit: Space between } and else. > ManualTests/shift-alt-key-event.html:19 > + output.innerHTML=text; Nit: Spaces around =. > ManualTests/shift-alt-key-event.html:25 > +<p>Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=?????">bug ?????</a>: Please fill in the bug number or just remove this text. 848281 6 191610 chandra.vallala 2013-03-05 17:13:27 -0800 Created attachment 191610 updated patch Done. 851528 7 192288 chandra.vallala 2013-03-08 14:48:39 -0800 Created attachment 192288 rebased the patch Hi Tony, Please look at the rebased patch. 851562 8 192288 webkit.review.bot 2013-03-08 15:29:21 -0800 Comment on attachment 192288 rebased the patch Clearing flags on attachment: 192288 Committed r145276: <http://trac.webkit.org/changeset/145276> 851563 9 webkit.review.bot 2013-03-08 15:29:25 -0800 All reviewed patches have been landed. Closing bug. 190807 2013-02-28 14:27:31 -0800 2013-03-05 16:07:50 -0800 patch patch text/plain 4025 chandra.vallala ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiZjlmMmI3Li5iNjRiODU0 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTMtMDItMjggIENoYW5kcmEgU2hla2FyIFZhbGxhbGEgIDxicmszNzZAbW90b3JvbGEuY29t PgorCisgICAgICAgIEtleWRvd24gZXZlbnQgZm9yICdzaGlmdCthbHQnIHJldHVybnMgd2luIGtl eWNvZGUgaW5zdGVhZCBvZiAnYWx0JworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTExMTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmV0dXJuIHdpbmRvd3Mga2V5Y29kZSBvZiBBbHQgaW5jYXNlIG9mIEdE S19NRVRBX0wsIEdES19NRVRBX1IuCisKKyAgICAgICAgVHJ5IHByZXNzIFNoaWZ0IHRoZW4gYWx0 IGtleS4gVGhlIHRlc3QgcGFzc2VzIGlmIHRoZSBzaGlmdEtleSwgYWx0S2V5IHZhbHVlcworICAg ICAgICBvZiBKU0tleUV2ZW50IGFyZSB0cnVlIGFuZCBrZXljb2RlL3doaWNoIGlzIDE4LgorCisg ICAgICAgICogTWFudWFsVGVzdHMvc2hpZnQtYWx0LWtleS1ldmVudC5odG1sOiBBZGRlZC4KKwog MjAxMy0wMi0yNCAgTGFzemxvIEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFtFRkxdIFJlbmFtZSBFTkFCTEVfUkVHSU9OUyB0byBFTkFCTEVfQ1NTX1JFR0lPTlMKZGlm ZiAtLWdpdCBhL01hbnVhbFRlc3RzL3NoaWZ0LWFsdC1rZXktZXZlbnQuaHRtbCBiL01hbnVhbFRl c3RzL3NoaWZ0LWFsdC1rZXktZXZlbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi42YTllNDQ2Ci0tLSAvZGV2L251bGwKKysrIGIvTWFudWFsVGVzdHMvc2hpZnQtYWx0 LWtleS1ldmVudC5odG1sCkBAIC0wLDAgKzEsMzYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ Cis8aGVhZD4KKzxzY3JpcHQ+Cit3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKSB7CisgICAgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm15aW5wdXQiKS5mb2N1cygpOworfTsKK2Z1bmN0aW9uIG15 RnVuY3Rpb24oZXZlbnQpCit7CisgICAgY29uc29sZS5sb2coImFsdD0iK2V2ZW50LmFsdEtleSAr ICIgLS0gc2hpZnQ9IitldmVudC5zaGlmdEtleSsgIiAtLSAiKyAgZXZlbnQud2hpY2gpOworICAg IHZhciBvdXRwdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpOworICAgIHZh ciB0ZXh0ID0ic2hpZnRLZXkgPSAiK2V2ZW50LnNoaWZ0S2V5KyAiLCBhbHRLZXkgPSAiK2V2ZW50 LmFsdEtleSsgIiwgd2hpY2ggPSAiKyAgZXZlbnQud2hpY2g7CisKKyAgICBpZihldmVudC5zaGlm dEtleSA9PSB0cnVlICYmIGV2ZW50LmFsdEtleSA9PSB0cnVlICYmIGV2ZW50LndoaWNoID09IDE4 KSB7CisgICAgICAgIHRleHQgPSB0ZXh0ICsgIjxicj5URVNUIDogPGI+UEFTU0VEPC9iPiIKKyAg ICB9ZWxzZSB7CisgICAgICAgIHRleHQgPSB0ZXh0ICsgIjxicj5URVNUIDogPGI+RkFJTEVEPC9i PiIKKyAgICB9CisgICAgb3V0cHV0LmlubmVySFRNTD10ZXh0OworfQorCis8L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5PgorPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Pz8/Pz8iPmJ1ZyA/Pz8/PzwvYT46CitTaGlmdCArIEFsdCBrZXkg cHJlc3M8L3A+CisKKzxwPlRyeSBwcmVzcyBTaGlmdCB0aGVuIGFsdCBrZXkuCitUaGUgdGVzdCBw YXNzZXMgaWYgdGhlIHNoaWZ0S2V5LCBhbHRLZXkgdmFsdWVzIG9mIEpzS2V5RXZlbnQgYXJlIHRy dWUgYW5kIGtleWNvZGUvd2hpY2ggaXMgMTguPHA+CisKKzxpbnB1dCB0eXBlPSJ0ZXh0IiBpZD0i bXlpbnB1dCIgb25rZXlkb3duPSJteUZ1bmN0aW9uKGV2ZW50KSI+Cis8YnI+PGJyPgorPGRpdiBp ZD0iY29uc29sZSI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CisKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZTU3 NzI4Li5mMDMyMWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMDItMjggIENo YW5kcmEgU2hla2FyIFZhbGxhbGEgIDxicmszNzZAbW90b3JvbGEuY29tPgorCisgICAgICAgIEtl eWRvd24gZXZlbnQgZm9yICdzaGlmdCthbHQnIHJldHVybnMgd2luIGtleWNvZGUgaW5zdGVhZCBv ZiAnYWx0JworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTExMTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmV0dXJuIHdpbmRvd3Mga2V5Y29kZSBvZiBBbHQgaW5jYXNlIG9mIEdES19NRVRBX0wsIEdES19N RVRBX1IuCisKKyAgICAgICAgQWRkZWQgTWFudWFsIFRlc3QgOiBNYW51YWxUZXN0cy9zaGlmdC1h bHQta2V5LWV2ZW50Lmh0bWwKKyAgICAgICAgVHJ5IHByZXNzIFNoaWZ0IHRoZW4gYWx0IGtleS4g VGhlIHRlc3QgcGFzc2VzIGlmIHRoZSBzaGlmdEtleSwgYWx0S2V5IHZhbHVlcworICAgICAgICBv ZiBKU0tleUV2ZW50IGFyZSB0cnVlIGFuZCBrZXljb2RlL3doaWNoIGlzIDE4LgorCisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwOgorICAgICAgICAo V2ViQ29yZTo6d2luZG93c0tleUNvZGVGb3JLZXlFdmVudCk6CisKIDIwMTMtMDItMjYgIEFuZHJl dyBMbyAgPGFubG9AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQW5pbWF0ZWQgaW1h Z2VzIG5vdCBhbmltYXRpbmcgb24gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbGF5ZXJzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9LZXlDb2RlQ29udmVyc2lv bkd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9LZXlDb2RlQ29udmVy c2lvbkd0ay5jcHAKaW5kZXggZTdjMGUyMC4uOWE4YTE4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVDb252ZXJzaW9uR3RrLmNwcApA QCAtMTEyLDggKzExMiwxMCBAQCBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25l ZCBrZXljb2RlKQogICAgIGNhc2UgR0RLX01lbnU6CiAgICAgICAgIHJldHVybiBWS0VZX0FQUFM7 ICAvLyAoNUQpIEFwcGxpY2F0aW9ucyBrZXkgKE5hdHVyYWwga2V5Ym9hcmQpCiAgICAgY2FzZSBH REtfQWx0X0w6CisgICAgY2FzZSBHREtfTWV0YV9MOgogICAgICAgICByZXR1cm4gVktFWV9MTUVO VTsgLy8gKEE0KSBMZWZ0IEFMVCBrZXkKICAgICBjYXNlIEdES19BbHRfUjoKKyAgICBjYXNlIEdE S19NZXRhX1I6CiAgICAgICAgIHJldHVybiBWS0VZX1JNRU5VOyAvLyAoQTUpIFJpZ2h0IEFMVCBr ZXkKIAogICAgIGNhc2UgR0RLX1BhdXNlOgpAQCAtMjc4LDEwICsyODAsOCBAQCBpbnQgd2luZG93 c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBrZXljb2RlKQogICAgIGNhc2UgR0RLX3o6CiAg ICAgY2FzZSBHREtfWjoKICAgICAgICAgcmV0dXJuIFZLRVlfWjsgLy8gICg1QSkgWiBrZXkgY2Fz ZSAneic6IGNhc2UgJ1onOiByZXR1cm4gMHg1QTsKLSAgICBjYXNlIEdES19NZXRhX0w6CiAgICAg Y2FzZSBHREtfU3VwZXJfTDoKICAgICAgICAgcmV0dXJuIFZLRVlfTFdJTjsgLy8gKDVCKSBMZWZ0 IFdpbmRvd3Mga2V5IChNaWNyb3NvZnQgTmF0dXJhbCBrZXlib2FyZCkKLSAgICBjYXNlIEdES19N ZXRhX1I6CiAgICAgY2FzZSBHREtfU3VwZXJfUjoKICAgICAgICAgcmV0dXJuIFZLRVlfUldJTjsg Ly8gKDVDKSBSaWdodCBXaW5kb3dzIGtleSAoTmF0dXJhbCBrZXlib2FyZCkKICAgICAgICAgLy8g VktFWV9TTEVFUCAoNUYpIENvbXB1dGVyIFNsZWVwIGtleQo= 191592 2013-03-05 16:07:50 -0800 2013-03-05 17:13:27 -0800 patch 111112.patch text/plain 0 chandra.vallala 191610 2013-03-05 17:13:27 -0800 2013-03-08 14:48:39 -0800 updated patch 111112.patch text/plain 0 chandra.vallala 192288 2013-03-08 14:48:39 -0800 2013-03-08 15:29:21 -0800 rebased the patch 111112.patch text/plain 4058 chandra.vallala ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzMzllNzhmLi5lMzRlYThm IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTMtMDMtMDggIENoYW5kcmEgU2hla2FyIFZhbGxhbGEgIDxicmszNzZAbW90b3JvbGEuY29t PgorCisgICAgICAgIFtjaHJvbWl1bV0gS2V5ZG93biBldmVudCBmb3IgJ3NoaWZ0K2FsdCcgcmV0 dXJucyB3aW4ga2V5Y29kZSBpbnN0ZWFkIG9mICdhbHQnCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTExMTIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXR1cm4gd2luZG93cyBrZXljb2RlIG9mIEFsdCBp bmNhc2Ugb2YgR0RLX01FVEFfTCwgR0RLX01FVEFfUi4KKworICAgICAgICBUcnkgcHJlc3MgU2hp ZnQgdGhlbiBhbHQga2V5LiBUaGUgdGVzdCBwYXNzZXMgaWYgdGhlIHNoaWZ0S2V5LCBhbHRLZXkg dmFsdWVzCisgICAgICAgIG9mIEpTS2V5RXZlbnQgYXJlIHRydWUgYW5kIGtleWNvZGUvd2hpY2gg aXMgMTguCisKKyAgICAgICAgKiBNYW51YWxUZXN0cy9zaGlmdC1hbHQta2V5LWV2ZW50Lmh0bWw6 IEFkZGVkLgorCiAyMDEzLTAzLTA4ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBbQXV0b3Rvb2xzXSBSZW1vdmUgZGVmaW5pdGlvbnMgb2YgdW5uZWNlc3Nh cnkgQXV0b21ha2UgY29uZGl0aW9uYWxzCmRpZmYgLS1naXQgYS9NYW51YWxUZXN0cy9zaGlmdC1h bHQta2V5LWV2ZW50Lmh0bWwgYi9NYW51YWxUZXN0cy9zaGlmdC1hbHQta2V5LWV2ZW50Lmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uM2RhZmE0NwotLS0gL2Rldi9udWxs CisrKyBiL01hbnVhbFRlc3RzL3NoaWZ0LWFsdC1rZXktZXZlbnQuaHRtbApAQCAtMCwwICsxLDM1 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0Pgord2luZG93Lm9u bG9hZCA9IGZ1bmN0aW9uKCkgeworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJteWlucHV0 IikuZm9jdXMoKTsKK307CisKK2Z1bmN0aW9uIGtleURvd24oZXZlbnQpCit7CisgICAgdmFyIG91 dHB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIik7CisgICAgdmFyIHRleHQg PSAic2hpZnRLZXkgPSAiK2V2ZW50LnNoaWZ0S2V5KyAiLCBhbHRLZXkgPSAiK2V2ZW50LmFsdEtl eSsgIiwgd2hpY2ggPSAiKyAgZXZlbnQud2hpY2g7CisKKyAgICBpZiAoZXZlbnQuc2hpZnRLZXkg PT0gdHJ1ZSAmJiBldmVudC5hbHRLZXkgPT0gdHJ1ZSAmJiBldmVudC53aGljaCA9PSAxOCkgewor ICAgICAgICB0ZXh0ID0gdGV4dCArICI8YnI+VEVTVCA6IDxiPlBBU1NFRDwvYj4iCisgICAgfSBl bHNlIHsKKyAgICAgICAgdGV4dCA9IHRleHQgKyAiPGJyPlRFU1QgOiA8Yj5GQUlMRUQ8L2I+Igor ICAgIH0KKyAgICBvdXRwdXQuaW5uZXJIVE1MID0gdGV4dDsKK30KKworPC9zY3JpcHQ+Cis8L2hl YWQ+Cis8Ym9keT4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTExMiI+YnVnIDExMTExMjwvYT46CitTaGlmdCArIEFsdCBrZXkg cHJlc3M8L3A+CisKKzxwPlRyeSBwcmVzcyBTaGlmdCB0aGVuIGFsdCBrZXkuCitUaGUgdGVzdCBw YXNzZXMgaWYgdGhlIHNoaWZ0S2V5LCBhbHRLZXkgdmFsdWVzIG9mIEpzS2V5RXZlbnQgYXJlIHRy dWUgYW5kIGtleWNvZGUvd2hpY2ggaXMgMTguPHA+CisKKzxpbnB1dCB0eXBlPSJ0ZXh0IiBpZD0i bXlpbnB1dCIgb25rZXlkb3duPSJrZXlEb3duKGV2ZW50KSI+Cis8YnI+PGJyPgorPGRpdiBpZD0i Y29uc29sZSI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdkNzUzZS4u ZDA5NjEwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTA4ICBDaGFuZHJh IFNoZWthciBWYWxsYWxhICA8YnJrMzc2QG1vdG9yb2xhLmNvbT4KKworICAgICAgICBbY2hyb21p dW1dIEtleWRvd24gZXZlbnQgZm9yICdzaGlmdCthbHQnIHJldHVybnMgd2luIGtleWNvZGUgaW5z dGVhZCBvZiAnYWx0JworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTExMTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmV0dXJuIHdpbmRvd3Mga2V5Y29kZSBvZiBBbHQgaW5jYXNlIG9mIEdES19NRVRBX0ws IEdES19NRVRBX1IuIFRoaXMgbWF0Y2hlcworICAgICAgICB0aGUgZmlyZWZveCBiZWhhdmlvdXIg aW4gbGludXggcGxhdGZvcm0uCisKKyAgICAgICAgQWRkZWQgTWFudWFsIFRlc3QgOiBNYW51YWxU ZXN0cy9zaGlmdC1hbHQta2V5LWV2ZW50Lmh0bWwKKyAgICAgICAgVHJ5IHByZXNzIFNoaWZ0IHRo ZW4gYWx0IGtleS4gVGhlIHRlc3QgcGFzc2VzIGlmIHRoZSBzaGlmdEtleSwgYWx0S2V5IHZhbHVl cworICAgICAgICBvZiBKU0tleUV2ZW50IGFyZSB0cnVlIGFuZCBrZXljb2RlL3doaWNoIGlzIDE4 LgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6d2luZG93c0tleUNvZGVGb3JLZXlFdmVudCk6CisKIDIwMTMt MDMtMDggIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogUG9saXNoIFRhYmJlZEVkaXRvckNvbnRhbmVyIGFuZCBTY3JpcHRzTmF2 aWdhdG9yIGJlaGF2aW9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vS2V5Q29kZUNvbnZlcnNpb25HdGsuY3BwCmluZGV4IDA4NjJiNzYuLjRkY2Y5MmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0tleUNvZGVDb252 ZXJzaW9uR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9LZXlD b2RlQ29udmVyc2lvbkd0ay5jcHAKQEAgLTExOCw4ICsxMTgsMTAgQEAgaW50IHdpbmRvd3NLZXlD b2RlRm9yS2V5RXZlbnQodW5zaWduZWQga2V5Y29kZSkKICAgICBjYXNlIEdES19NZW51OgogICAg ICAgICByZXR1cm4gVktFWV9BUFBTOyAgLy8gKDVEKSBBcHBsaWNhdGlvbnMga2V5IChOYXR1cmFs IGtleWJvYXJkKQogICAgIGNhc2UgR0RLX0FsdF9MOgorICAgIGNhc2UgR0RLX01ldGFfTDoKICAg ICAgICAgcmV0dXJuIFZLRVlfTE1FTlU7IC8vIChBNCkgTGVmdCBBTFQga2V5CiAgICAgY2FzZSBH REtfQWx0X1I6CisgICAgY2FzZSBHREtfTWV0YV9SOgogICAgIGNhc2UgR0RLX0lTT19MZXZlbDNf U2hpZnQ6CiAgICAgICAgIHJldHVybiBWS0VZX1JNRU5VOyAvLyAoQTUpIFJpZ2h0IEFMVCBrZXkK IApAQCAtMjg1LDEwICsyODcsOCBAQCBpbnQgd2luZG93c0tleUNvZGVGb3JLZXlFdmVudCh1bnNp Z25lZCBrZXljb2RlKQogICAgIGNhc2UgR0RLX3o6CiAgICAgY2FzZSBHREtfWjoKICAgICAgICAg cmV0dXJuIFZLRVlfWjsgLy8gICg1QSkgWiBrZXkgY2FzZSAneic6IGNhc2UgJ1onOiByZXR1cm4g MHg1QTsKLSAgICBjYXNlIEdES19NZXRhX0w6CiAgICAgY2FzZSBHREtfU3VwZXJfTDoKICAgICAg ICAgcmV0dXJuIFZLRVlfTFdJTjsgLy8gKDVCKSBMZWZ0IFdpbmRvd3Mga2V5IChNaWNyb3NvZnQg TmF0dXJhbCBrZXlib2FyZCkKLSAgICBjYXNlIEdES19NZXRhX1I6CiAgICAgY2FzZSBHREtfU3Vw ZXJfUjoKICAgICAgICAgcmV0dXJuIFZLRVlfUldJTjsgLy8gKDVDKSBSaWdodCBXaW5kb3dzIGtl eSAoTmF0dXJhbCBrZXlib2FyZCkKICAgICAgICAgLy8gVktFWV9TTEVFUCAoNUYpIENvbXB1dGVy IFNsZWVwIGtleQo=