111106 2013-02-28 13:25:00 -0800 CodeBlock::valueProfile() has a bogus assertion 2013-02-28 13:33:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 844413 0 fpizlo 2013-02-28 13:25:00 -0800 <rdar://problem/13131427> 844418 1 190797 fpizlo 2013-02-28 13:29:08 -0800 Created attachment 190797 the patch 844419 2 190797 fpizlo 2013-02-28 13:30:01 -0800 Comment on attachment 190797 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=190797&action=review > Source/JavaScriptCore/ChangeLog:9 > + This was just a bad assertion: m_bytecodeOffset means that the value profile is constructed but not initialized. should say: This was just a bad assertion: m_bytecodeOffset == -1 means that the value profile is constructed but not initialized. 844420 3 190797 mhahnenberg 2013-02-28 13:30:46 -0800 Comment on attachment 190797 the patch r=me 844426 4 fpizlo 2013-02-28 13:33:21 -0800 Landed in http://trac.webkit.org/changeset/144356 190797 2013-02-28 13:29:08 -0800 2013-02-28 13:30:46 -0800 the patch blah.patch text/plain 2939 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ0MzU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDEzLTAyLTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q29kZUJsb2NrOjp2YWx1ZVByb2ZpbGUoKSBoYXMgYSBib2d1cyBhc3NlcnRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTEwNgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTMxMzE0Mjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICBUaGlzIHdhcyBqdXN0IGEgYmFkIGFzc2VydGlvbjog bV9ieXRlY29kZU9mZnNldCBtZWFucyB0aGF0IHRoZSB2YWx1ZSBwcm9maWxlIGlzIGNvbnN0cnVj dGVkIGJ1dCBub3QgaW5pdGlhbGl6ZWQuCisgICAgICAgIFZhbHVlUHJvZmlsZSBjb25zdHJ1Y3Rz IGl0c2VsZiBpbiBhIHNhZmUgd2F5OyB5b3UgY2FuIGNhbGwgYW55IG1ldGhvZCB5b3Ugd2FudCBv biBhIGNvbnN0cnVjdGVkIGJ1dCBub3QgaW5pdGlhbGl6ZWQKKyAgICAgICAgVmFsdWVQcm9maWxl LiBDb2RlQmxvY2sgZmlyc3QgY29uc3RydWN0cyBhbGwgVmFsdWVQcm9maWxlcyAoYnkgZ3Jvd2lu ZyB0aGUgVmFsdWVQcm9maWxlIHZlY3RvcikgYW5kIHRoZW4gaW5pdGlhbGl6ZXMKKyAgICAgICAg dGhlaXIgbV9ieXRlY29kZU9mZnNldCBsYXRlci4gVGhpcyBpcyBuZWNlc3NhcnkgYmVjYXVzZSB0 aGUgaW5pdGlhbGl6YXRpb24gaXMgbGlua2luZyBieXRlY29kZSBpbnN0cnVjdGlvbnMgdG8gdGhl aXIKKyAgICAgICAgVmFsdWVQcm9maWxlcywgc28gYXQgdGhhdCBwb2ludCB3ZSBkb24ndCB3YW50 IHRoZSBWYWx1ZVByb2ZpbGUgdmVjdG9yIHRvIHJlc2l6ZSwgd2hpY2ggaW1wbGllcyB0aGF0IHdl IHdhbnQgYWxsIG9mCisgICAgICAgIHRoZW0gdG8gYWxyZWFkeSBiZSBjb25zdHJ1Y3RlZC4gQSBH QyBjYW4gaGFwcGVuIGR1cmluZyB0aGlzIHBoYXNlLCBhbmQgdGhlIEdDIG1heSB3YW50IHRvIHdh bGsgYWxsIFZhbHVlUHJvZmlsZXMuCisgICAgICAgIFRoaXMgaXMgc2FmZSwgYnV0IG9uZSBvZiB0 aGUgVmFsdWVQcm9maWxlIGdldHRlcnMgKENvZGVCbG9jazo6dmFsdWVQcm9maWxlKCkpIHdhcyBh c3NlcnRpbmcgdGhhdCBhbnkgdmFsdWUgcHJvZmlsZQorICAgICAgICB5b3UgZ2V0IGhhcyBoYWQg aXRzIG1fYnl0ZWNvZGVPZmZzZXQgaW5pdGlhbGl6ZWQuIFRoaXMgbmVlZCBub3QgYmUgdGhlIGNh c2UgYW5kIG5vdGhpbmcgd2lsbCBnbyB3cm9uZyBpZiBpdCBpc24ndC4KKworICAgICAgICBUaGUg c29sdXRpb24gaXMgdG8gcmVtb3ZlIHRoZSBhc3NlcnRpb24sIHdoaWNoIEkgYmVsaWV2ZSB3YXMg cHV0IHRoZXJlIHRvIGVuc3VyZSB0aGF0IG15IG1fdmFsdWVQcm9maWxlcyByZWZhY3RvcmluZwor ICAgICAgICBhIGxvbmcgdGltZSBhZ28gd2FzIHNvdW5kOiBpdCB1c2VkIHRvIGJlIHRoYXQgYSBW YWx1ZVByb2ZpbGUgd2l0aCBtX2J5dGVjb2RlT2Zmc2V0ID09IC0xIHdhcyBhbiBhcmd1bWVudCBw cm9maWxlOyBub3cKKyAgICAgICAgYWxsIGFyZ3VtZW50IHByb2ZpbGVzIGFyZSBpbiBtX2FyZ3Vt ZW50VmFsdWVQcm9maWxlcyBpbnN0ZWFkLiBJIHRoaW5rIGl0J3Mgc2FmZSB0byBzYXkgdGhhdCB0 aGlzIHJlZmFjdG9yaW5nIHdhcyBkb25lCisgICAgICAgIHNvdW5kbHkgc2luY2UgaXQgd2FzIGEg bG9uZyB0aW1lIGFnby4gU28gd2Ugc2hvdWxkIGtpbGwgdGhlIGFzc2VydGlvbiAtIEkgZG9uJ3Qg c2VlIGFuIGVhc3kgd2F5IHRvIG1ha2UgdGhlIGFzc2VydGlvbgorICAgICAgICBzb3VuZCB3aXRo IHJlc3BlY3QgdG8gdGhlIEdDLWR1cmluZy1Db2RlQmxvY2stY29uc3RydWN0aW9uIGlzc3VlLCBh bmQgSSBkb24ndCBiZWxpZXZlIHRoYXQgdGhlIGFzc2VydGlvbiBpcyBidXlpbmcgdXMKKyAgICAg ICAgYW55dGhpbmcgYXQgdGhpcyBwb2ludC4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9j ay5oOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OnZhbHVlUHJvZmlsZSk6CisKIDIwMTMtMDIt MjcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgQ0ZBIHNo b3VsZCBsZWF2ZSBiZWhpbmQgaW5mb3JtYXRpb24gaW4gRWRnZSB0aGF0IHNheXMgaWYgdGhlIEVk Z2UncyB0eXBlIGNoZWNrIGlzIHByb3ZlbiB0byBzdWNjZWVkCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZpc2lvbiAxNDQxMTMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAg LTYwOCw3ICs2MDgsNiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgVmFsdWVQcm9maWxlKiB2 YWx1ZVByb2ZpbGUoaW50IGluZGV4KQogICAgICAgICB7CiAgICAgICAgICAgICBWYWx1ZVByb2Zp bGUqIHJlc3VsdCA9ICZtX3ZhbHVlUHJvZmlsZXNbaW5kZXhdOwotICAgICAgICAgICAgQVNTRVJU KHJlc3VsdC0+bV9ieXRlY29kZU9mZnNldCAhPSAtMSk7CiAgICAgICAgICAgICByZXR1cm4gcmVz dWx0OwogICAgICAgICB9CiAgICAgICAgIFZhbHVlUHJvZmlsZSogdmFsdWVQcm9maWxlRm9yQnl0 ZWNvZGVPZmZzZXQoaW50IGJ5dGVjb2RlT2Zmc2V0KQo=