111099 2013-02-28 12:12:17 -0800 XSSAuditor should use threadSafeMatch when relevant. 2013-03-01 00:49:21 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst abarth dbates esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 844335 0 mkwst 2013-02-28 12:12:17 -0800 In XSSAuditor::hasName, there's a use of equalIgnoringNullity that can be trivially replaced with threadSafeMatch. That seems like a good thing to do. We're also using equalIgnoringNullity in XSSAuditor::findAttributeWithName, but that usage seems safe, since we're creating a new string to do the comparison against. 844343 1 190779 mkwst 2013-02-28 12:19:08 -0800 Created attachment 190779 Patch 844893 2 190779 webkit.review.bot 2013-03-01 00:49:18 -0800 Comment on attachment 190779 Patch Clearing flags on attachment: 190779 Committed r144425: <http://trac.webkit.org/changeset/144425> 844894 3 webkit.review.bot 2013-03-01 00:49:21 -0800 All reviewed patches have been landed. Closing bug. 190779 2013-02-28 12:19:08 -0800 2013-03-01 00:49:18 -0800 Patch bug-111099-20130228211513.patch text/plain 2023 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODAxYWU3MTMwMDcyMDE0 MGFkMjYxYTkyZDQ0M2YzMWZmNTc3OTc5MC4uODZiMGRkZjY0ZWQ0ZTRjYTUyN2IwMzJiZDNmNGZh YmJjZGY4NzU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTI4ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgWFNTQXVkaXRvciBzaG91bGQg dXNlIHRocmVhZFNhZmVNYXRjaCB3aGVuIHJlbGV2YW50LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2l2ZW4gdGhlIHdvcmsgb24gYnJlYWtpbmcgcGFy c2luZyBvdXQgaW50byBhIGJhY2tncm91bmQgdGhyZWFkLCB3ZQorICAgICAgICBzaG91bGQgY29t cGFyZSBRdWFsaWZpZWROYW1lcyBpbiBhIHRocmVhZC1zYWZlIG1hbm5lci4gUmF0aGVyIHRoYW4K KyAgICAgICAgY2FzdGluZyB0aGUgcmVzdWx0IG9mIFF1YWxpZmllZE5hbWU6OmxvY2FsTmFtZSB0 byBhIFN0cmluZywgd2UgY2FuCisgICAgICAgIGNhbGwgb3V0IHRvIHRocmVhZFNhZmVNYXRjaCB0 byBkbyB0aGUgY29tcGFyaXNvbi4KKworICAgICAgICBUaGlzIHBhdGNoIGxlYXZlcyBvbmUgdXNl IG9mIGVxdWFsSWdub3JpbmdOdWxsaXR5IGluCisgICAgICAgIFhTU0F1ZGl0b3I6OmZpbmRBdHRy aWJ1dGVXaXRoTmFtZS4gVGhhdCB1c2FnZSBzZWVtcyBzYWZlLCBzaW5jZSB3ZSdyZQorICAgICAg ICBjcmVhdGluZyBhIG5ldyBzdHJpbmcgYWdhaW5zdCB3aGljaCB0byBjb21wYXJlLgorCisgICAg ICAgICogaHRtbC9wYXJzZXIvWFNTQXVkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYXNO YW1lKToKKyAgICAgICAgICAgIFJlcGxhY2UgY2FsbCB0byBlcXVhbElnbm9yaW5nTnVsbGl0eShW ZWN0b3I8VUNoYXIuLi4+LCBTdHJpbmcpCisgICAgICAgICAgICB3aXRoIHRocmVhZFNhZmVNYXRj aChTdHJpbmcsIFF1YWxpZmllZE5hbWUpLgorCiAyMDEzLTAyLTI2ICBFdWdlbmUgS2x5dWNobmlr b3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtSZXNv dXJjZXNdIENvb2tpZXMgdGFibGUgbG9va3MgZW1wdHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL3BhcnNlci9YU1NBdWRpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFy c2VyL1hTU0F1ZGl0b3IuY3BwCmluZGV4IGI2YjM0NmRlNGNlODVmYmVlMjg5ZTg0OTcxNzViZmIz YjVhZjMyYmEuLmRhYmYwZjg2M2MzY2NhNmFjYzU5YWRlYjljYzhmY2Y1NjYzNDFkYmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL1hTU0F1ZGl0b3IuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL1hTU0F1ZGl0b3IuY3BwCkBAIC0xMTUsNyArMTE1LDcg QEAgc3RhdGljIGJvb2wgc3RhcnRzTXVsdGlMaW5lQ29tbWVudEF0KGNvbnN0IFN0cmluZyYgc3Ry aW5nLCBzaXplX3Qgc3RhcnQpCiAKIHN0YXRpYyBib29sIGhhc05hbWUoY29uc3QgSFRNTFRva2Vu JiB0b2tlbiwgY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkKIHsKLSAgICByZXR1cm4gZXF1YWxJ Z25vcmluZ051bGxpdHkodG9rZW4ubmFtZSgpLCBzdGF0aWNfY2FzdDxjb25zdCBTdHJpbmcmPihu YW1lLmxvY2FsTmFtZSgpKSk7CisgICAgcmV0dXJuIHRocmVhZFNhZmVNYXRjaCh0b2tlbi5uYW1l U3RyaW5nKCksIG5hbWUpOwogfQogCiBzdGF0aWMgYm9vbCBmaW5kQXR0cmlidXRlV2l0aE5hbWUo Y29uc3QgSFRNTFRva2VuJiB0b2tlbiwgY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgc2l6ZV90 JiBpbmRleE9mTWF0Y2hpbmdBdHRyaWJ1dGUpCg==