<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>111094</bug_id>
          
          <creation_ts>2013-02-28 10:59:09 -0800</creation_ts>
          <short_desc>[Qt] QWebSettings::clearMemoryCaches should clear JS garbage</short_desc>
          <delta_ts>2013-03-07 09:31:43 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>111605</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Arunprasad">ararunprasad</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>allan.jensen</cc>
    
    <cc>ararunprasad</cc>
    
    <cc>arurajku</cc>
    
    <cc>bedupont</cc>
    
    <cc>buildbot</cc>
    
    <cc>hausmann</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>844230</commentid>
    <comment_count>0</comment_count>
      <attachid>190759</attachid>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-02-28 10:59:09 -0800</bug_when>
    <thetext>Created attachment 190759
Initial patch

In certain situations clearing the WebKit&apos;s MemoryCache using QWebSettings::clearMemoryCaches doesn&apos;t releases all CachedResource to system. It is due to holding of CachedResource by dead but yet to Garbage Collectable objects.

This is required for memory constrained environments(CE devices like set-top box) where deletion of QWebView object + QWebSettings::clearMemoryCaches() should release all the CachedResource like QPixmap.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>844240</commentid>
    <comment_count>1</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-02-28 11:07:12 -0800</bug_when>
    <thetext>Sorry, patch has a flaw.

-WebCore::gcController().garbageCollectSoon();
+WebCore::gcController().garbageCollectNow();

I will recreate soon with proper ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>844309</commentid>
    <comment_count>2</comment_count>
      <attachid>190772</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-02-28 11:49:51 -0800</bug_when>
    <thetext>Created attachment 190772
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>844885</commentid>
    <comment_count>3</comment_count>
      <attachid>190772</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2013-03-01 00:36:46 -0800</bug_when>
    <thetext>Comment on attachment 190772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190772&amp;action=review

It sounds to me that this is a reasonable thing to do. Allan, what do you think?

(r- because of #ifdefs that aren&apos;t needed)

&gt; Source/WebKit/qt/Api/qwebsettings.cpp:49
&gt; +#if USE(JSC)
&gt; +#include &quot;GCController.h&quot;
&gt; +#else    
&gt; +#include &quot;V8GCController.h&quot;
&gt; +#endif

We don&apos;t support v8 as underlying JS engine at this point, so I suggest to remove the USE(JSC) and just use it directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>844896</commentid>
    <comment_count>4</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-01 00:59:30 -0800</bug_when>
    <thetext>Thanks for reviewing it. I thought QtWebKit supporting v8 too.

/Tools/Scripts/build-webkit --help
..
..
--v8                              Use V8 as JavaScript engine (Qt only)
..
..


I will correct the change &amp; upload it soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>845140</commentid>
    <comment_count>5</comment_count>
      <attachid>190961</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-03-01 06:54:21 -0800</bug_when>
    <thetext>Created attachment 190961
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>845141</commentid>
    <comment_count>6</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-01 06:55:51 -0800</bug_when>
    <thetext>Modified to call only JSC&apos;s GC</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>845142</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-01 06:59:42 -0800</bug_when>
    <thetext>Attachment 190961 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebKit/qt/Api/qwebsettings.cpp&apos;, u&apos;Source/WebKit/qt/ChangeLog&apos;]&quot; exit_code: 1
Source/WebKit/qt/Api/qwebsettings.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>845158</commentid>
    <comment_count>8</comment_count>
      <attachid>190961</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-03-01 07:32:01 -0800</bug_when>
    <thetext>Comment on attachment 190961
Patch

Attachment 190961 did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16826474

New failing tests:
editing/selection/selection-invalid-offset.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>845167</commentid>
    <comment_count>9</comment_count>
      <attachid>190967</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-03-01 07:42:12 -0800</bug_when>
    <thetext>Created attachment 190967
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>845168</commentid>
    <comment_count>10</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-01 07:43:13 -0800</bug_when>
    <thetext>&gt;https://bugs.webkit.org/show_bug.cgi?id=111094#c7

Does it mandates included header file should be alphabetically sorted order?

I think it is a nice way of enforcing the self contained header :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>846216</commentid>
    <comment_count>11</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-04 01:17:43 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; We don&apos;t support v8 as underlying JS engine at this point, so I suggest to remove the USE(JSC) and just use it directly.

Corrected :). Please review it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847616</commentid>
    <comment_count>12</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-05 06:31:18 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 190772 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=190772&amp;action=review
&gt; 
&gt; It sounds to me that this is a reasonable thing to do. Allan, what do you think?
&gt; 
Yeah, looks good. I would use gcController().discardAllCompiledCode(). It is more powerfull if you really want to free all cached code (also frees cached JIT code blocks).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847624</commentid>
    <comment_count>13</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-05 06:39:22 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; (In reply to comment #3)
&gt; &gt; (From update of attachment 190772 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=190772&amp;action=review
&gt; &gt; 
&gt; &gt; It sounds to me that this is a reasonable thing to do. Allan, what do you think?
&gt; &gt; 
&gt; Yeah, looks good. I would use gcController().discardAllCompiledCode(). It is more powerfull if you really want to free all cached code (also frees cached JIT code blocks).

Actually I would suggest we took a look at and cleaned the same caches as MemoryPressureMac::releaseMemory() does. I am surprised we use such an agressive call to FontCache for instance.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847701</commentid>
    <comment_count>14</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-05 08:23:07 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #12)
&gt; &gt; (In reply to comment #3)
&gt; &gt; &gt; (From update of attachment 190772 [details] [details] [details])
&gt; &gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=190772&amp;action=review
&gt; &gt; &gt; 
&gt; &gt; &gt; It sounds to me that this is a reasonable thing to do. Allan, what do you think?
&gt; &gt; &gt; 
&gt; &gt; Yeah, looks good. I would use gcController().discardAllCompiledCode(). It is more powerfull if you really want to free all cached code (also frees cached JIT code blocks).
&gt; 
&gt; Actually I would suggest we took a look at and cleaned the same caches as MemoryPressureMac::releaseMemory() does. I am surprised we use such an agressive call to FontCache for instance.

I just go through the MemoryPressureHandler::releaseMemory @ MemoryPressureHandlerMac.mm. Looks nice and does more than expected :)

Can we introduce one more static member function QWebSettings::releaseMemory(bool critical)? Which does exactly like mac counterpart.?

(or) Just add it inside QWebSettings::clearMemoryCache()?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847736</commentid>
    <comment_count>15</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-05 09:13:05 -0800</bug_when>
    <thetext>(In reply to comment #14)
&gt; I just go through the MemoryPressureHandler::releaseMemory @ MemoryPressureHandlerMac.mm. Looks nice and does more than expected :)
&gt; 
&gt; Can we introduce one more static member function QWebSettings::releaseMemory(bool critical)? Which does exactly like mac counterpart.?
&gt; 
&gt; (or) Just add it inside QWebSettings::clearMemoryCache()?

I would just add the other caches inside clearMemoryCache(), it is already documented as clearing as much cache as possible.

If anything we need a less aggressive method for manual garbage collection. Similar to how you can call collectGarbage() on QScriptEngine or QJSEngine, but that is beyond this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847747</commentid>
    <comment_count>16</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-05 09:29:40 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; (In reply to comment #3)
&gt; &gt; (From update of attachment 190772 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=190772&amp;action=review
&gt; &gt; 
&gt; &gt; It sounds to me that this is a reasonable thing to do. Allan, what do you think?
&gt; &gt; 
&gt; Yeah, looks good. I would use gcController().discardAllCompiledCode(). It is more powerfull if you reaally want to free all cached code (also frees cached JIT code blocks).

Is it really needed? Because Script is also a part of CacheResource right? Compiled code will be equivalent to DecodedData?

    if (!WebCore::memoryCache()-&gt;disabled()) {
        WebCore::memoryCache()-&gt;setDisabled(true);
        WebCore::memoryCache()-&gt;setDisabled(false);
    }

I guess. Above should purge the compiled code as well.

Sorry in case I&apos;m wrong :)


Anyhow I will add all those things from MemoryPressureHandlerMac.mm</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847755</commentid>
    <comment_count>17</comment_count>
      <attachid>191508</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-03-05 09:43:37 -0800</bug_when>
    <thetext>Created attachment 191508
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847768</commentid>
    <comment_count>18</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-05 09:57:08 -0800</bug_when>
    <thetext>(In reply to comment #16)
&gt; Is it really needed? Because Script is also a part of CacheResource right? Compiled code will be equivalent to DecodedData?

The script source is a CacheResource, but the compiled JIT code is not. It has its own separate cache called ExecutableAllocator.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847773</commentid>
    <comment_count>19</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-05 10:03:00 -0800</bug_when>
    <thetext>(In reply to comment #18)
&gt; (In reply to comment #16)
&gt; &gt; Is it really needed? Because Script is also a part of CacheResource right? Compiled code will be equivalent to DecodedData?
&gt; 
&gt; The script source is a CacheResource, but the compiled JIT code is not. It has its own separate cache called ExecutableAllocator.

Understood. Thanks Allen :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>847856</commentid>
    <comment_count>20</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-05 11:24:54 -0800</bug_when>
    <thetext>(In reply to comment #17)
&gt; Created an attachment (id=191508) [details]
&gt; Patch

Please review the patch. It is updated as like MemoryPressureHandler::releaseMemory @ MemoryPressureHandlerMac.mm. Thanks :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>848812</commentid>
    <comment_count>21</comment_count>
      <attachid>191508</attachid>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-06 06:42:58 -0800</bug_when>
    <thetext>Comment on attachment 191508
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191508&amp;action=review

&gt; Source/WebKit/qt/Api/qwebsettings.cpp:853
&gt; +    // Garbage Collect to release the references of CachedResource from dead objects
&gt; +    WebCore::gcController().garbageCollectNow();

You don&apos;t need to call garbageCollect when you call discardAllCompiledCode. It does that as well.

&gt; Source/WebKit/qt/Api/qwebsettings.cpp:868
&gt; +    // FastMalloc has lock-free thread specific caches that can only be cleared from the thread itself.
&gt; +    WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads();
&gt; +#if ENABLE(WORKERS)
&gt; +    WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads();
&gt; +#endif
&gt; +#if ENABLE(THREADED_SCROLLING)
&gt; +    WebCore::ScrollingThread::dispatch(bind(WTF::releaseFastMallocFreeMemory));
&gt; +#endif
&gt; +    WTF::releaseFastMallocFreeMemory();    

I would skip these for now. They are not really caches, and we also don&apos;t support scrolling threads.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>848824</commentid>
    <comment_count>22</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-06 06:57:13 -0800</bug_when>
    <thetext>(In reply to comment #21)
&gt; (From update of attachment 191508 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=191508&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/qt/Api/qwebsettings.cpp:853
&gt; &gt; +    // Garbage Collect to release the references of CachedResource from dead objects
&gt; &gt; +    WebCore::gcController().garbageCollectNow();
&gt; 
&gt; You don&apos;t need to call garbageCollect when you call discardAllCompiledCode. It does that as well.

From Heap.cpp
void Heap::deleteAllCompiledCode()
{
    // If JavaScript is running, it&apos;s not safe to delete code, since we&apos;ll end
    // up deleting code that is live on the stack.
    if (m_globalData-&gt;dynamicGlobalObject)
        return;

    for (ExecutableBase* current = m_compiledCode.head(); current; current = current-&gt;next()) {
        if (!current-&gt;isFunctionExecutable())
            continue;
        static_cast&lt;FunctionExecutable*&gt;(current)-&gt;clearCodeIfNotCompiling();
    }

    m_dfgCodeBlocks.clearMarks();
    m_dfgCodeBlocks.deleteUnmarkedJettisonedCodeBlocks();
}


I think it is not calling GarbageCollector. Sorry incase i&apos;m wrong. Can you please show me where it is calling the GC?

&gt; 
&gt; &gt; Source/WebKit/qt/Api/qwebsettings.cpp:868
&gt; &gt; +    // FastMalloc has lock-free thread specific caches that can only be cleared from the thread itself.
&gt; &gt; +    WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads();
&gt; &gt; +#if ENABLE(WORKERS)
&gt; &gt; +    WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads();
&gt; &gt; +#endif
&gt; &gt; +#if ENABLE(THREADED_SCROLLING)
&gt; &gt; +    WebCore::ScrollingThread::dispatch(bind(WTF::releaseFastMallocFreeMemory));
&gt; &gt; +#endif
&gt; &gt; +    WTF::releaseFastMallocFreeMemory();    
&gt; 
&gt; I would skip these for now. They are not really caches, and we also don&apos;t support scrolling threads.

 +    WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads();
 +#if ENABLE(WORKERS)
 +    WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads();
 +#endif
 +    WTF::releaseFastMallocFreeMemory();

Anyhow releasing Workers and FastMalloc stuffs needed know?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>848932</commentid>
    <comment_count>23</comment_count>
      <attachid>191764</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-03-06 09:19:12 -0800</bug_when>
    <thetext>Created attachment 191764
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>849919</commentid>
    <comment_count>24</comment_count>
      <attachid>191764</attachid>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2013-03-07 02:49:35 -0800</bug_when>
    <thetext>Comment on attachment 191764
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>849925</commentid>
    <comment_count>25</comment_count>
      <attachid>191764</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-07 02:57:10 -0800</bug_when>
    <thetext>Comment on attachment 191764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191764&amp;action=review

&gt; Source/WebKit/qt/Api/qwebsettings.cpp:821
&gt; +    as page, object and font cache. It calls the JavaScript Garbage Collector to
&gt; +    release the references of CachedResource from dead objects and frees up memory to System
&gt; +    as much as possible.

Just a detail before this lands, this comment is going to be very cryptic for most users of QtWebKit.
&quot;CachedResource from dead objects&quot; is bound to the implementation and can be confusing.

I think that the garbage collector point is valuable though.
Could you update it with terms that mortals can understand?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850077</commentid>
    <comment_count>26</comment_count>
      <attachid>191995</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-03-07 07:35:52 -0800</bug_when>
    <thetext>Created attachment 191995
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850080</commentid>
    <comment_count>27</comment_count>
      <attachid>191996</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-03-07 07:38:55 -0800</bug_when>
    <thetext>Created attachment 191996
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850111</commentid>
    <comment_count>28</comment_count>
      <attachid>191996</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-07 08:28:12 -0800</bug_when>
    <thetext>Comment on attachment 191996
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191996&amp;action=review

&gt; Source/WebKit/qt/Api/qwebsettings.cpp:817
&gt; -    Frees up as much memory as possible by cleaning all memory caches such
&gt; +    Frees up as much memory as possible by calling JavaScript Garbager Collector, cleaning all memory caches such

Proper english please, the documentation is generated from this.
&quot;Frees up as much memory as possible by calling the JavaScript garbage collector and cleaning...&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850123</commentid>
    <comment_count>29</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-07 08:39:31 -0800</bug_when>
    <thetext>(In reply to comment #28)
&gt; (From update of attachment 191996 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=191996&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/qt/Api/qwebsettings.cpp:817
&gt; &gt; -    Frees up as much memory as possible by cleaning all memory caches such
&gt; &gt; +    Frees up as much memory as possible by calling JavaScript Garbager Collector, cleaning all memory caches such
&gt; 
&gt; Proper english please, the documentation is generated from this.
&gt; &quot;Frees up as much memory as possible by calling the JavaScript garbage collector and cleaning...&quot;

Sorry for the typo :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850126</commentid>
    <comment_count>30</comment_count>
      <attachid>192008</attachid>
    <who name="Arunprasad Rajkumar">arurajku</who>
    <bug_when>2013-03-07 08:42:12 -0800</bug_when>
    <thetext>Created attachment 192008
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850133</commentid>
    <comment_count>31</comment_count>
      <attachid>192008</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2013-03-07 08:55:36 -0800</bug_when>
    <thetext>Comment on attachment 192008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192008&amp;action=review

&gt; Source/WebKit/qt/Api/qwebsettings.cpp:818
&gt; +    Frees up as much memory as possible by calling the JavaScript garbage collector and cleaning all memory caches such
&gt;      as page, object and font cache.

The first line should have been cut but this is a minor issue. I should have told you earlier.
Thanks for fixing it, r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850148</commentid>
    <comment_count>32</comment_count>
      <attachid>192008</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-07 09:14:01 -0800</bug_when>
    <thetext>Comment on attachment 192008
Patch

Clearing flags on attachment: 192008

Committed r145085: &lt;http://trac.webkit.org/changeset/145085&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850149</commentid>
    <comment_count>33</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2013-03-07 09:14:06 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>850165</commentid>
    <comment_count>34</comment_count>
    <who name="Arunprasad">ararunprasad</who>
    <bug_when>2013-03-07 09:31:43 -0800</bug_when>
    <thetext>(In reply to comment #31)
&gt; (From update of attachment 192008 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=192008&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/qt/Api/qwebsettings.cpp:818
&gt; &gt; +    Frees up as much memory as possible by calling the JavaScript garbage collector and cleaning all memory caches such
&gt; &gt;      as page, object and font cache.
&gt; 
&gt; The first line should have been cut but this is a minor issue. I should have told you earlier.
&gt; Thanks for fixing it, r=me

Is it too long? I will avoid these kind of mistakes in future. Anyway thanks :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>190759</attachid>
            <date>2013-02-28 10:59:09 -0800</date>
            <delta_ts>2013-02-28 10:59:09 -0800</delta_ts>
            <desc>Initial patch</desc>
            <filename>Call_GC_After_ClearCache.patch</filename>
            <type>text/plain</type>
            <size>798</size>
            <attacher name="Arunprasad">ararunprasad</attacher>
            
              <data encoding="base64">SW5kZXg6IEFwaS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEFwaS9xd2Vic2V0dGlu
Z3MuY3BwCShyZXZpc2lvbiAxNDQzMjEpCisrKyBBcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2lu
ZyBjb3B5KQpAQCAtNDIsNiArNDIsMTEgQEAKICNpbmNsdWRlICJQbHVnaW5EYXRhYmFzZS5oIgog
I2luY2x1ZGUgIlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5o
IgorI2lmIFVTRShKU0MpCisjaW5jbHVkZSAiR0NDb250cm9sbGVyLmgiCisjZWxzZSAgICAKKyNp
bmNsdWRlICJWOEdDQ29udHJvbGxlci5oIgorI2VuZGlmCiAjaW5jbHVkZSA8UURpcj4KICNpbmNs
dWRlIDxRRmlsZUluZm8+CiAjaW5jbHVkZSA8UUZvbnQ+CkBAIC04NDAsNiArODQ1LDEzIEBACiAK
ICAgICAvLyBFbXB0eSB0aGUgQ3Jvc3MtT3JpZ2luIFByZWZsaWdodCBjYWNoZQogICAgIFdlYkNv
cmU6OkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGU6OnNoYXJlZCgpLmVtcHR5KCk7CisK
KyAgICAvLyBHYXJiYWdlIENvbGxlY3QgdG8gcmVsZWFzZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNo
ZWRSZXNvdXJjZSBmcm9tIGRlYWQgb2JqZWN0cworI2lmIFVTRShKU0MpCisgICAgV2ViQ29yZTo6
Z2NDb250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3RTb29uKCk7CisjZWxzZSAgICAKKyAgICBXZWJD
b3JlOjpWOEdDQ29udHJvbGxlcjo6Y29sbGVjdEdhcmJhZ2UoKTsKKyNlbmRpZgogfQogCiAvKiEK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>190772</attachid>
            <date>2013-02-28 11:49:51 -0800</date>
            <delta_ts>2013-03-01 06:54:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130301011559.patch</filename>
            <type>text/plain</type>
            <size>1571</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDQzNDApCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTI4ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
Y2xlYXJNZW1vcnlDYWNoZXMgb2YgUVdlYlNldHRpbmdzIHNob3VsZCBjYWxsIEdDIHRvIHJlbGVh
c2UgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAg
KFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMpOgorCiAyMDEzLTAyLTI0ICBBbmRyZWFz
IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHlsZWRFbGVtZW50OiBEb24n
dCBleHBvc2UgYSBtdXRhYmxlIGRpcmVjdCBpbnRlcmZhY2UgdG8gdGhlIGlubGluZSBzdHlsZS4K
SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkocmV2aXNpb24gMTQ0MzIx
KQorKysgU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2luZyBjb3B5
KQpAQCAtNDIsNiArNDIsMTEgQEAKICNpbmNsdWRlICJQbHVnaW5EYXRhYmFzZS5oIgogI2luY2x1
ZGUgIlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgorI2lm
IFVTRShKU0MpCisjaW5jbHVkZSAiR0NDb250cm9sbGVyLmgiCisjZWxzZSAgICAKKyNpbmNsdWRl
ICJWOEdDQ29udHJvbGxlci5oIgorI2VuZGlmCiAjaW5jbHVkZSA8UURpcj4KICNpbmNsdWRlIDxR
RmlsZUluZm8+CiAjaW5jbHVkZSA8UUZvbnQ+CkBAIC04NDAsNiArODQ1LDEzIEBAIHZvaWQgUVdl
YlNldHRpbmdzOjpjbGVhck1lbW9yeUNhY2hlcygpCiAKICAgICAvLyBFbXB0eSB0aGUgQ3Jvc3Mt
T3JpZ2luIFByZWZsaWdodCBjYWNoZQogICAgIFdlYkNvcmU6OkNyb3NzT3JpZ2luUHJlZmxpZ2h0
UmVzdWx0Q2FjaGU6OnNoYXJlZCgpLmVtcHR5KCk7CisKKyAgICAvLyBHYXJiYWdlIENvbGxlY3Qg
dG8gcmVsZWFzZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZSBmcm9tIGRlYWQgb2Jq
ZWN0cworI2lmIFVTRShKU0MpCisgICAgV2ViQ29yZTo6Z2NDb250cm9sbGVyKCkuZ2FyYmFnZUNv
bGxlY3ROb3coKTsKKyNlbHNlICAgIAorICAgIFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpjb2xs
ZWN0R2FyYmFnZSgpOworI2VuZGlmCiB9CiAKIC8qIQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>190961</attachid>
            <date>2013-03-01 06:54:21 -0800</date>
            <delta_ts>2013-03-01 07:42:05 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130301202028.patch</filename>
            <type>text/plain</type>
            <size>1404</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDQ0NTApCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTI4ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
Y2xlYXJNZW1vcnlDYWNoZXMgb2YgUVdlYlNldHRpbmdzIHNob3VsZCBjYWxsIEdDIHRvIHJlbGVh
c2UgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAg
KFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMpOgorCiAyMDEzLTAzLTAxICBTaGVyaWZm
IEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk
LCByb2xsaW5nIG91dCByMTQ0NDIyIGFuZCByMTQ0NDI0LgpJbmRleDogU291cmNlL1dlYktpdC9x
dC9BcGkvcXdlYnNldHRpbmdzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L0Fw
aS9xd2Vic2V0dGluZ3MuY3BwCShyZXZpc2lvbiAxNDQ0NTApCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0FwaS9xd2Vic2V0dGluZ3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw3IEBACiAj
aW5jbHVkZSAiUGx1Z2luRGF0YWJhc2UuaCIKICNpbmNsdWRlICJSdW50aW1lRW5hYmxlZEZlYXR1
cmVzLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKKyNpbmNsdWRlICJHQ0NvbnRyb2xsZXIuaCIK
ICNpbmNsdWRlIDxRRGlyPgogI2luY2x1ZGUgPFFGaWxlSW5mbz4KICNpbmNsdWRlIDxRRm9udD4K
QEAgLTg0MCw2ICs4NDEsOSBAQCB2b2lkIFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMo
KQogCiAgICAgLy8gRW1wdHkgdGhlIENyb3NzLU9yaWdpbiBQcmVmbGlnaHQgY2FjaGUKICAgICBX
ZWJDb3JlOjpDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlOjpzaGFyZWQoKS5lbXB0eSgp
OworCisgICAgLy8gR2FyYmFnZSBDb2xsZWN0IHRvIHJlbGVhc2UgdGhlIHJlZmVyZW5jZXMgb2Yg
Q2FjaGVkUmVzb3VyY2UgZnJvbSBkZWFkIG9iamVjdHMKKyAgICBXZWJDb3JlOjpnY0NvbnRyb2xs
ZXIoKS5nYXJiYWdlQ29sbGVjdE5vdygpOwogfQogCiAvKiEK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>190967</attachid>
            <date>2013-03-01 07:42:12 -0800</date>
            <delta_ts>2013-03-05 09:43:25 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130301210819.patch</filename>
            <type>text/plain</type>
            <size>1766</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDQ0NTApCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTI4ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
Y2xlYXJNZW1vcnlDYWNoZXMgb2YgUVdlYlNldHRpbmdzIHNob3VsZCBjYWxsIEdDIHRvIHJlbGVh
c2UgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAg
KFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMpOgorCiAyMDEzLTAzLTAxICBTaGVyaWZm
IEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk
LCByb2xsaW5nIG91dCByMTQ0NDIyIGFuZCByMTQ0NDI0LgpJbmRleDogU291cmNlL1dlYktpdC9x
dC9BcGkvcXdlYnNldHRpbmdzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L0Fw
aS9xd2Vic2V0dGluZ3MuY3BwCShyZXZpc2lvbiAxNDQ0NTApCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0FwaS9xd2Vic2V0dGluZ3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw2ICsyNyw3IEBACiAj
aW5jbHVkZSAiRGF0YWJhc2VNYW5hZ2VyLmgiCiAjaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgogI2lu
Y2x1ZGUgIkZvbnRDYWNoZS5oIgorI2luY2x1ZGUgIkdDQ29udHJvbGxlci5oIgogI2luY2x1ZGUg
Ikljb25EYXRhYmFzZS5oIgogI2luY2x1ZGUgIkltYWdlLmgiCiAjaWYgRU5BQkxFKElDT05EQVRB
QkFTRSkKQEAgLTgxNCw3ICs4MTUsOCBAQCBRUGl4bWFwIFFXZWJTZXR0aW5nczo6d2ViR3JhcGhp
YyhXZWJHcmFwCiAKIC8qIQogICAgIEZyZWVzIHVwIGFzIG11Y2ggbWVtb3J5IGFzIHBvc3NpYmxl
IGJ5IGNsZWFuaW5nIGFsbCBtZW1vcnkgY2FjaGVzIHN1Y2gKLSAgICBhcyBwYWdlLCBvYmplY3Qg
YW5kIGZvbnQgY2FjaGUuCisgICAgYXMgcGFnZSwgb2JqZWN0IGFuZCBmb250IGNhY2hlLiBJdCBh
bHNvIGNhbGxzIHRoZSBKYXZhU2NyaXB0IEdhcmJhZ2UgQ29sbGVjdG9yIHRvCisgICAgcmVsZWFz
ZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZSBmcm9tIGRlYWQgb2JqZWN0cy4KIAog
ICAgIFxzaW5jZSA0LjYKICAqLwpAQCAtODQwLDYgKzg0Miw5IEBAIHZvaWQgUVdlYlNldHRpbmdz
OjpjbGVhck1lbW9yeUNhY2hlcygpCiAKICAgICAvLyBFbXB0eSB0aGUgQ3Jvc3MtT3JpZ2luIFBy
ZWZsaWdodCBjYWNoZQogICAgIFdlYkNvcmU6OkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2Fj
aGU6OnNoYXJlZCgpLmVtcHR5KCk7CisKKyAgICAvLyBHYXJiYWdlIENvbGxlY3QgdG8gcmVsZWFz
ZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZSBmcm9tIGRlYWQgb2JqZWN0cworICAg
IFdlYkNvcmU6OmdjQ29udHJvbGxlcigpLmdhcmJhZ2VDb2xsZWN0Tm93KCk7CiB9CiAKIC8qIQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>191508</attachid>
            <date>2013-03-05 09:43:37 -0800</date>
            <delta_ts>2013-03-06 09:19:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130305230943.patch</filename>
            <type>text/plain</type>
            <size>3186</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDQ3NjkpCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA1ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
Y2xlYXJNZW1vcnlDYWNoZXMgb2YgUVdlYlNldHRpbmdzIHNob3VsZCBjYWxsIEdDIHRvIHJlbGVh
c2UgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAg
KFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMpOgorCiAyMDEzLTAzLTAzICBBZGFtIEJh
cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBhdHRlbXB0ZWQg
YnVpbGQgZml4LiBBZGRzIGJhY2sgc29tZSBpbmNsdWRlcyByZW1vdmVkIGluCkluZGV4OiBTb3Vy
Y2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHJldmlzaW9uIDE0NDc2MSkKKysrIFNvdXJj
ZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzLDEw
ICsyMywxMiBAQAogI2luY2x1ZGUgInF3ZWJwbHVnaW5kYXRhYmFzZV9wLmgiCiAKICNpbmNsdWRl
ICJBcHBsaWNhdGlvbkNhY2hlU3RvcmFnZS5oIgorI2luY2x1ZGUgIkNTU1ZhbHVlUG9vbC5oIgog
I2luY2x1ZGUgIkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUuaCIKICNpbmNsdWRlICJE
YXRhYmFzZU1hbmFnZXIuaCIKICNpbmNsdWRlICJGaWxlU3lzdGVtLmgiCiAjaW5jbHVkZSAiRm9u
dENhY2hlLmgiCisjaW5jbHVkZSAiR0NDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiSWNvbkRhdGFi
YXNlLmgiCiAjaW5jbHVkZSAiSW1hZ2UuaCIKICNpZiBFTkFCTEUoSUNPTkRBVEFCQVNFKQpAQCAt
NDEsNyArNDMsMTAgQEAKICNpbmNsdWRlICJQYWdlQ2FjaGUuaCIKICNpbmNsdWRlICJQbHVnaW5E
YXRhYmFzZS5oIgogI2luY2x1ZGUgIlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMuaCIKKyNpbmNsdWRl
ICJTY3JvbGxpbmdUaHJlYWQuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgorI2luY2x1ZGUgIlN0
b3JhZ2VUaHJlYWQuaCIKKyNpbmNsdWRlICJXb3JrZXJUaHJlYWQuaCIKICNpbmNsdWRlIDxRRGly
PgogI2luY2x1ZGUgPFFGaWxlSW5mbz4KICNpbmNsdWRlIDxRRm9udD4KQEAgLTUwLDEwICs1NSwx
MSBAQAogI2luY2x1ZGUgPFFTaGFyZWREYXRhPgogI2luY2x1ZGUgPFFTdGFuZGFyZFBhdGhzPgog
I2luY2x1ZGUgPFFVcmw+CisjaW5jbHVkZSA8d3RmL0Zhc3RNYWxsb2MuaD4KKyNpbmNsdWRlIDx3
dGYvRnVuY3Rpb25hbC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiAKLQog
UVdFQktJVF9FWFBPUlQgdm9pZCBxdF9uZXR3b3JrQWNjZXNzQWxsb3dlZChib29sIGlzQWxsb3dl
ZCkKIHsKICNpZm5kZWYgUVRfTk9fQkVBUkVSTUFOQUdFTUVOVApAQCAtODE0LDcgKzgyMCw5IEBA
IFFQaXhtYXAgUVdlYlNldHRpbmdzOjp3ZWJHcmFwaGljKFdlYkdyYXAKIAogLyohCiAgICAgRnJl
ZXMgdXAgYXMgbXVjaCBtZW1vcnkgYXMgcG9zc2libGUgYnkgY2xlYW5pbmcgYWxsIG1lbW9yeSBj
YWNoZXMgc3VjaAotICAgIGFzIHBhZ2UsIG9iamVjdCBhbmQgZm9udCBjYWNoZS4KKyAgICBhcyBw
YWdlLCBvYmplY3QgYW5kIGZvbnQgY2FjaGUuIEl0IGNhbGxzIHRoZSBKYXZhU2NyaXB0IEdhcmJh
Z2UgQ29sbGVjdG9yIHRvCisgICAgcmVsZWFzZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNv
dXJjZSBmcm9tIGRlYWQgb2JqZWN0cyBhbmQgZnJlZXMgdXAgbWVtb3J5IHRvIFN5c3RlbQorICAg
IGFzIG11Y2ggYXMgcG9zc2libGUuCiAKICAgICBcc2luY2UgNC42CiAgKi8KQEAgLTg0MCw2ICs4
NDgsMjQgQEAgdm9pZCBRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVzKCkKIAogICAgIC8v
IEVtcHR5IHRoZSBDcm9zcy1PcmlnaW4gUHJlZmxpZ2h0IGNhY2hlCiAgICAgV2ViQ29yZTo6Q3Jv
c3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZTo6c2hhcmVkKCkuZW1wdHkoKTsKKworICAgIC8v
IEdhcmJhZ2UgQ29sbGVjdCB0byByZWxlYXNlIHRoZSByZWZlcmVuY2VzIG9mIENhY2hlZFJlc291
cmNlIGZyb20gZGVhZCBvYmplY3RzCisgICAgV2ViQ29yZTo6Z2NDb250cm9sbGVyKCkuZ2FyYmFn
ZUNvbGxlY3ROb3coKTsKKworICAgIC8vIEJlbG93IHBvcnRpb24gb2YgY29kZSBjb3BpZWQgZnJv
bSBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnJlbGVhc2VNZW1vcnkgaW4gTWVtb3J5UHJlc3N1cmVI
YW5kbGVyTWFjLm1tLgorICAgIFdlYkNvcmU6OmNzc1ZhbHVlUG9vbCgpLmRyYWluKCk7CisKKyAg
ICBXZWJDb3JlOjpnY0NvbnRyb2xsZXIoKS5kaXNjYXJkQWxsQ29tcGlsZWRDb2RlKCk7CisKKyAg
ICAvLyBGYXN0TWFsbG9jIGhhcyBsb2NrLWZyZWUgdGhyZWFkIHNwZWNpZmljIGNhY2hlcyB0aGF0
IGNhbiBvbmx5IGJlIGNsZWFyZWQgZnJvbSB0aGUgdGhyZWFkIGl0c2VsZi4KKyAgICBXZWJDb3Jl
OjpTdG9yYWdlVGhyZWFkOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnlJbkFsbFRocmVhZHMo
KTsKKyNpZiBFTkFCTEUoV09SS0VSUykKKyAgICBXZWJDb3JlOjpXb3JrZXJUaHJlYWQ6OnJlbGVh
c2VGYXN0TWFsbG9jRnJlZU1lbW9yeUluQWxsVGhyZWFkcygpOworI2VuZGlmCisjaWYgRU5BQkxF
KFRIUkVBREVEX1NDUk9MTElORykKKyAgICBXZWJDb3JlOjpTY3JvbGxpbmdUaHJlYWQ6OmRpc3Bh
dGNoKGJpbmQoV1RGOjpyZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnkpKTsKKyNlbmRpZgorICAg
IFdURjo6cmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVtb3J5KCk7ICAgIAogfQogCiAvKiEK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>191764</attachid>
            <date>2013-03-06 09:19:12 -0800</date>
            <delta_ts>2013-03-07 07:35:46 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130306224516.patch</filename>
            <type>text/plain</type>
            <size>2090</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDQ5MzQpCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA2ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
IFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMgc2hvdWxkIGNsZWFyIEpTIGdhcmJhZ2UK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA5NAor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL3F3
ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVz
KToKKwogMjAxMy0wMy0wNiAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRp
Z2lhLmNvbT4KIAogICAgICAgICBbUXRdIElsbGVnYWwgbmFycm93aW5nIGluIHRzdF9xd2ViaGlz
dG9yeQpJbmRleDogU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCShyZXZpc2lvbiAx
NDQ5MzQpCisrKyBTb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCSh3b3JraW5n
IGNvcHkpCkBAIC0yMywxMCArMjMsMTIgQEAKICNpbmNsdWRlICJxd2VicGx1Z2luZGF0YWJhc2Vf
cC5oIgogCiAjaW5jbHVkZSAiQXBwbGljYXRpb25DYWNoZVN0b3JhZ2UuaCIKKyNpbmNsdWRlICJD
U1NWYWx1ZVBvb2wuaCIKICNpbmNsdWRlICJDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hl
LmgiCiAjaW5jbHVkZSAiRGF0YWJhc2VNYW5hZ2VyLmgiCiAjaW5jbHVkZSAiRmlsZVN5c3RlbS5o
IgogI2luY2x1ZGUgIkZvbnRDYWNoZS5oIgorI2luY2x1ZGUgIkdDQ29udHJvbGxlci5oIgogI2lu
Y2x1ZGUgIkljb25EYXRhYmFzZS5oIgogI2luY2x1ZGUgIkltYWdlLmgiCiAjaWYgRU5BQkxFKElD
T05EQVRBQkFTRSkKQEAgLTgxNCw3ICs4MTYsOSBAQCBRUGl4bWFwIFFXZWJTZXR0aW5nczo6d2Vi
R3JhcGhpYyhXZWJHcmFwCiAKIC8qIQogICAgIEZyZWVzIHVwIGFzIG11Y2ggbWVtb3J5IGFzIHBv
c3NpYmxlIGJ5IGNsZWFuaW5nIGFsbCBtZW1vcnkgY2FjaGVzIHN1Y2gKLSAgICBhcyBwYWdlLCBv
YmplY3QgYW5kIGZvbnQgY2FjaGUuCisgICAgYXMgcGFnZSwgb2JqZWN0IGFuZCBmb250IGNhY2hl
LiBJdCBjYWxscyB0aGUgSmF2YVNjcmlwdCBHYXJiYWdlIENvbGxlY3RvciB0bworICAgIHJlbGVh
c2UgdGhlIHJlZmVyZW5jZXMgb2YgQ2FjaGVkUmVzb3VyY2UgZnJvbSBkZWFkIG9iamVjdHMgYW5k
IGZyZWVzIHVwIG1lbW9yeSB0byBTeXN0ZW0KKyAgICBhcyBtdWNoIGFzIHBvc3NpYmxlLgogCiAg
ICAgXHNpbmNlIDQuNgogICovCkBAIC04NDAsNiArODQ0LDEzIEBAIHZvaWQgUVdlYlNldHRpbmdz
OjpjbGVhck1lbW9yeUNhY2hlcygpCiAKICAgICAvLyBFbXB0eSB0aGUgQ3Jvc3MtT3JpZ2luIFBy
ZWZsaWdodCBjYWNoZQogICAgIFdlYkNvcmU6OkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2Fj
aGU6OnNoYXJlZCgpLmVtcHR5KCk7CisKKyAgICAvLyBEcm9wIEpJVCBjb21waWxlZCBjb2RlIGZy
b20gRXhlY3V0YWJsZUFsbG9jYXRvci4KKyAgICBXZWJDb3JlOjpnY0NvbnRyb2xsZXIoKS5kaXNj
YXJkQWxsQ29tcGlsZWRDb2RlKCk7CisgICAgLy8gR2FyYmFnZSBDb2xsZWN0IHRvIHJlbGVhc2Ug
dGhlIHJlZmVyZW5jZXMgb2YgQ2FjaGVkUmVzb3VyY2UgZnJvbSBkZWFkIG9iamVjdHMuCisgICAg
V2ViQ29yZTo6Z2NDb250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3ROb3coKTsKKworICAgIFdlYkNv
cmU6OmNzc1ZhbHVlUG9vbCgpLmRyYWluKCk7CiB9CiAKIC8qIQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>191995</attachid>
            <date>2013-03-07 07:35:52 -0800</date>
            <delta_ts>2013-03-07 07:38:47 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130307210155.patch</filename>
            <type>text/plain</type>
            <size>1845</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDUwNzUpCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA3ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
IFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMgc2hvdWxkIGNsZWFyIEpTIGdhcmJhZ2UK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA5NAor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL3F3
ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVz
KToKKwogMjAxMy0wMy0wNiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+
CiAKICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5l
bGVtZW50RG9lc0F1dG9Db21wbGV0ZUZvckVsZW1lbnRXaXRoSWQKSW5kZXg6IFNvdXJjZS9XZWJL
aXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9x
dC9BcGkvcXdlYnNldHRpbmdzLmNwcAkocmV2aXNpb24gMTQ0OTM0KQorKysgU291cmNlL1dlYktp
dC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBA
QAogI2luY2x1ZGUgIkRhdGFiYXNlTWFuYWdlci5oIgogI2luY2x1ZGUgIkZpbGVTeXN0ZW0uaCIK
ICNpbmNsdWRlICJGb250Q2FjaGUuaCIKKyNpbmNsdWRlICJHQ0NvbnRyb2xsZXIuaCIKICNpbmNs
dWRlICJJY29uRGF0YWJhc2UuaCIKICNpbmNsdWRlICJJbWFnZS5oIgogI2lmIEVOQUJMRShJQ09O
REFUQUJBU0UpCkBAIC04MTMsNyArODE0LDcgQEAgUVBpeG1hcCBRV2ViU2V0dGluZ3M6OndlYkdy
YXBoaWMoV2ViR3JhcAogfQogCiAvKiEKLSAgICBGcmVlcyB1cCBhcyBtdWNoIG1lbW9yeSBhcyBw
b3NzaWJsZSBieSBjbGVhbmluZyBhbGwgbWVtb3J5IGNhY2hlcyBzdWNoCisgICAgRnJlZXMgdXAg
YXMgbXVjaCBtZW1vcnkgYXMgcG9zc2libGUgYnkgY2FsbGluZyBKYXZhU2NyaXB0IEdhcmJhZ2Vy
IENvbGxlY3RvciwgY2xlYW5pbmcgYWxsIG1lbW9yeSBjYWNoZXMgc3VjaAogICAgIGFzIHBhZ2Us
IG9iamVjdCBhbmQgZm9udCBjYWNoZS4KIAogICAgIFxzaW5jZSA0LjYKQEAgLTg0MCw2ICs4NDEs
MTEgQEAgdm9pZCBRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVzKCkKIAogICAgIC8vIEVt
cHR5IHRoZSBDcm9zcy1PcmlnaW4gUHJlZmxpZ2h0IGNhY2hlCiAgICAgV2ViQ29yZTo6Q3Jvc3NP
cmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZTo6c2hhcmVkKCkuZW1wdHkoKTsKKworICAgIC8vIERy
b3AgSklUIGNvbXBpbGVkIGNvZGUgZnJvbSBFeGVjdXRhYmxlQWxsb2NhdG9yLgorICAgIFdlYkNv
cmU6OmdjQ29udHJvbGxlcigpLmRpc2NhcmRBbGxDb21waWxlZENvZGUoKTsKKyAgICAvLyBHYXJi
YWdlIENvbGxlY3QgdG8gcmVsZWFzZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZSBm
cm9tIGRlYWQgb2JqZWN0cy4KKyAgICBXZWJDb3JlOjpnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29s
bGVjdE5vdygpOwogfQogCiAvKiEK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>191996</attachid>
            <date>2013-03-07 07:38:55 -0800</date>
            <delta_ts>2013-03-07 08:42:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130307210457.patch</filename>
            <type>text/plain</type>
            <size>1845</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDUwNzUpCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA3ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
IFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMgc2hvdWxkIGNsZWFyIEpTIGdhcmJhZ2UK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA5NAor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL3F3
ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVz
KToKKwogMjAxMy0wMy0wNiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+
CiAKICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5l
bGVtZW50RG9lc0F1dG9Db21wbGV0ZUZvckVsZW1lbnRXaXRoSWQKSW5kZXg6IFNvdXJjZS9XZWJL
aXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9x
dC9BcGkvcXdlYnNldHRpbmdzLmNwcAkocmV2aXNpb24gMTQ0OTM0KQorKysgU291cmNlL1dlYktp
dC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBA
QAogI2luY2x1ZGUgIkRhdGFiYXNlTWFuYWdlci5oIgogI2luY2x1ZGUgIkZpbGVTeXN0ZW0uaCIK
ICNpbmNsdWRlICJGb250Q2FjaGUuaCIKKyNpbmNsdWRlICJHQ0NvbnRyb2xsZXIuaCIKICNpbmNs
dWRlICJJY29uRGF0YWJhc2UuaCIKICNpbmNsdWRlICJJbWFnZS5oIgogI2lmIEVOQUJMRShJQ09O
REFUQUJBU0UpCkBAIC04MTMsNyArODE0LDcgQEAgUVBpeG1hcCBRV2ViU2V0dGluZ3M6OndlYkdy
YXBoaWMoV2ViR3JhcAogfQogCiAvKiEKLSAgICBGcmVlcyB1cCBhcyBtdWNoIG1lbW9yeSBhcyBw
b3NzaWJsZSBieSBjbGVhbmluZyBhbGwgbWVtb3J5IGNhY2hlcyBzdWNoCisgICAgRnJlZXMgdXAg
YXMgbXVjaCBtZW1vcnkgYXMgcG9zc2libGUgYnkgY2FsbGluZyBKYXZhU2NyaXB0IEdhcmJhZ2Vy
IENvbGxlY3RvciwgY2xlYW5pbmcgYWxsIG1lbW9yeSBjYWNoZXMgc3VjaAogICAgIGFzIHBhZ2Us
IG9iamVjdCBhbmQgZm9udCBjYWNoZS4KIAogICAgIFxzaW5jZSA0LjYKQEAgLTg0MCw2ICs4NDEs
MTEgQEAgdm9pZCBRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVzKCkKIAogICAgIC8vIEVt
cHR5IHRoZSBDcm9zcy1PcmlnaW4gUHJlZmxpZ2h0IGNhY2hlCiAgICAgV2ViQ29yZTo6Q3Jvc3NP
cmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZTo6c2hhcmVkKCkuZW1wdHkoKTsKKworICAgIC8vIERy
b3AgSklUIGNvbXBpbGVkIGNvZGUgZnJvbSBFeGVjdXRhYmxlQWxsb2NhdG9yLgorICAgIFdlYkNv
cmU6OmdjQ29udHJvbGxlcigpLmRpc2NhcmRBbGxDb21waWxlZENvZGUoKTsKKyAgICAvLyBHYXJi
YWdlIENvbGxlY3QgdG8gcmVsZWFzZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNvdXJjZSBm
cm9tIGRlYWQgb2JqZWN0cy4KKyAgICBXZWJDb3JlOjpnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29s
bGVjdE5vdygpOwogfQogCiAvKiEK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>192008</attachid>
            <date>2013-03-07 08:42:12 -0800</date>
            <delta_ts>2013-03-07 09:14:01 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-111094-20130307220814.patch</filename>
            <type>text/plain</type>
            <size>1851</size>
            <attacher name="Arunprasad Rajkumar">arurajku</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDUwNzkpCisrKyBTb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA3ICBB
cnVucHJhc2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBbUXRd
IFFXZWJTZXR0aW5nczo6Y2xlYXJNZW1vcnlDYWNoZXMgc2hvdWxkIGNsZWFyIEpTIGdhcmJhZ2UK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA5NAor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL3F3
ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVz
KToKKwogMjAxMy0wMy0wNiAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+
CiAKICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5l
bGVtZW50RG9lc0F1dG9Db21wbGV0ZUZvckVsZW1lbnRXaXRoSWQKSW5kZXg6IFNvdXJjZS9XZWJL
aXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9x
dC9BcGkvcXdlYnNldHRpbmdzLmNwcAkocmV2aXNpb24gMTQ1MDc5KQorKysgU291cmNlL1dlYktp
dC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBA
QAogI2luY2x1ZGUgIkRhdGFiYXNlTWFuYWdlci5oIgogI2luY2x1ZGUgIkZpbGVTeXN0ZW0uaCIK
ICNpbmNsdWRlICJGb250Q2FjaGUuaCIKKyNpbmNsdWRlICJHQ0NvbnRyb2xsZXIuaCIKICNpbmNs
dWRlICJJY29uRGF0YWJhc2UuaCIKICNpbmNsdWRlICJJbWFnZS5oIgogI2lmIEVOQUJMRShJQ09O
REFUQUJBU0UpCkBAIC04MTMsNyArODE0LDcgQEAgUVBpeG1hcCBRV2ViU2V0dGluZ3M6OndlYkdy
YXBoaWMoV2ViR3JhcAogfQogCiAvKiEKLSAgICBGcmVlcyB1cCBhcyBtdWNoIG1lbW9yeSBhcyBw
b3NzaWJsZSBieSBjbGVhbmluZyBhbGwgbWVtb3J5IGNhY2hlcyBzdWNoCisgICAgRnJlZXMgdXAg
YXMgbXVjaCBtZW1vcnkgYXMgcG9zc2libGUgYnkgY2FsbGluZyB0aGUgSmF2YVNjcmlwdCBnYXJi
YWdlIGNvbGxlY3RvciBhbmQgY2xlYW5pbmcgYWxsIG1lbW9yeSBjYWNoZXMgc3VjaAogICAgIGFz
IHBhZ2UsIG9iamVjdCBhbmQgZm9udCBjYWNoZS4KIAogICAgIFxzaW5jZSA0LjYKQEAgLTgzOSw2
ICs4NDAsMTEgQEAgdm9pZCBRV2ViU2V0dGluZ3M6OmNsZWFyTWVtb3J5Q2FjaGVzKCkKIAogICAg
IC8vIEVtcHR5IHRoZSBDcm9zcy1PcmlnaW4gUHJlZmxpZ2h0IGNhY2hlCiAgICAgV2ViQ29yZTo6
Q3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZTo6c2hhcmVkKCkuZW1wdHkoKTsKKworICAg
IC8vIERyb3AgSklUIGNvbXBpbGVkIGNvZGUgZnJvbSBFeGVjdXRhYmxlQWxsb2NhdG9yLgorICAg
IFdlYkNvcmU6OmdjQ29udHJvbGxlcigpLmRpc2NhcmRBbGxDb21waWxlZENvZGUoKTsKKyAgICAv
LyBHYXJiYWdlIENvbGxlY3QgdG8gcmVsZWFzZSB0aGUgcmVmZXJlbmNlcyBvZiBDYWNoZWRSZXNv
dXJjZSBmcm9tIGRlYWQgb2JqZWN0cy4KKyAgICBXZWJDb3JlOjpnY0NvbnRyb2xsZXIoKS5nYXJi
YWdlQ29sbGVjdE5vdygpOwogfQogCiAvKiEK
</data>

          </attachment>
      

    </bug>

</bugzilla>