111092 2013-02-28 10:39:32 -0800 [CSS Regions] Regions auto-height and absolute positioning bug 2013-06-13 09:49:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 0 gammon webkit-unassigned commit-queue esprehn+autocc glenn mihnea obzhirov WebkitBugTracker oldest_to_newest 844213 0 190755 gammon 2013-02-28 10:39:32 -0800 Created attachment 190755 reduced test demo of height auto error with absolute positioning when absolutely positioning a region at bottom: 0; it seems to not use the calculated height of the element when the height is auto. Instead it treats the element like it has no height for positioning. In this example I would expect the bottom of the element to be at the bottom of the screen, but as you can see it puts the top at the bottom of the screen. 892900 1 obzhirov 2013-05-23 08:34:53 -0700 I will try to fix this one - will take some time for me to catch up with css regions. 894938 2 203199 obzhirov 2013-05-29 07:14:06 -0700 Created attachment 203199 Patch 895785 3 mihnea 2013-05-30 23:42:08 -0700 (In reply to comment #2) > Created an attachment (id=203199) [details] > Patch Thanks for the attempt. I suggest that you should write a patch for review following the guidelines from WebKit. This should include a test for the patch, a changelog in which you should explain what was the problem and how your solution fixes the problem. 896355 4 obzhirov 2013-06-03 02:45:03 -0700 I will do that, I suppose I can reuse test demo attached as a basic for new layout test? 896375 5 mihnea 2013-06-03 04:14:11 -0700 (In reply to comment #4) > I will do that, I suppose I can reuse test demo attached as a basic for new layout test? Sure. Some of the layout tests in fast/regions use a script, check-layout.js, it may be a good idea to use it for this test instead of writing a ref test. 897317 6 203811 obzhirov 2013-06-05 05:38:18 -0700 Created attachment 203811 Patch 900042 7 203811 hyatt 2013-06-13 08:22:24 -0700 Comment on attachment 203811 Patch r=me 900136 8 203811 commit-queue 2013-06-13 09:49:30 -0700 Comment on attachment 203811 Patch Clearing flags on attachment: 203811 Committed r151554: <http://trac.webkit.org/changeset/151554> 900137 9 commit-queue 2013-06-13 09:49:33 -0700 All reviewed patches have been landed. Closing bug. 190755 2013-02-28 10:39:32 -0800 2013-04-21 11:48:17 -0700 reduced test demo of height auto error with absolute positioning index.html.zip application/zip 937 gammon UEsDBBQACAAIABJFXEIAAAAAAAAAAAAAAAAKABAAaW5kZXguaHRtbFVYDAAWiS9Rg4gvUfUBFADt Vs1uhCAYPONTfLVn193tpXGRp+gLoKKQyk/kM9Y0ffcKusk2PfVmExMSYWaAGS4OfWpsjbMTIFH3 LKHhAz03XZkKk7IkIVQK3rCEEKoFcqglH7zAMh2xzV6jglBU2AtmLHice2U6mq9IJAMmwgHkubYG hcHPsCDZJKp3hVnb2ylTBm0BYXoL5Fey6ftRm1XurFeorCmAV37BUUQlqSyi1QWc3ccKDKqT+LCe VIOygJfzIPTt983tEHY/3LxYzu+eab6lp5Vt5vgK8sLepPKwDA4x5iK6rNSV+bG6Y9eIOVBNmW7B 0/gMuG33VgsI50Jt3XwC+F/ELk0dMfZk6oixJ1NHjD2ZOmLsydSfiVgT3I9ffOgqWyGKDM3X0rB0 gViuvgFQSwcI993BMCMBAABtCQAAUEsDBAoAAAAAAIVFXEIAAAAAAAAAAAAAAAAJABAAX19NQUNP U1gvVVgMAFqJL1FaiS9R9QEUAFBLAwQUAAgACAASRVxCAAAAAAAAAAAAAAAAFQAQAF9fTUFDT1NY Ly5faW5kZXguaHRtbFVYDAAWiS9Rg4gvUfUBFABjYBVjZ2BiYPBNTFbwD1aIUIACkBgDJxAbAfEH IAbyGZUYiAKOISFBEBZYxw4gzkJTwgQVd2NgEE3Oz9VLLCjISdUrLE0sSswrycxLBan5B8QqUPnc xOSi/NzEktRiveTEotQShkJ9AwMTQ2tTg7TUFOOUJGv3/Pz0nNSYCiMD5wygylRrV0dTJ1MDS0td QxcjF10TNxMnXSdHQxNdZ3M3cyNTcxNHNxNDhmoukF+T83NKc/MUbBWMDAytwSI5QCcA+YbG1ly1 AFBLBwjwS3WFyAAAACIBAABQSwECFQMUAAgACAASRVxC993BMCMBAABtCQAACgAMAAAAAAAAAABA 7YEAAAAAaW5kZXguaHRtbFVYCAAWiS9Rg4gvUVBLAQIVAwoAAAAAAIVFXEIAAAAAAAAAAAAAAAAJ AAwAAAAAAAAAAED9QWsBAABfX01BQ09TWC9VWAgAWokvUVqJL1FQSwECFQMUAAgACAASRVxC8Et1 hcgAAAAiAQAAFQAMAAAAAAAAAABApIGiAQAAX19NQUNPU1gvLl9pbmRleC5odG1sVVgIABaJL1GD iC9RUEsFBgAAAAADAAMA1gAAAL0CAAAAAA== 203199 2013-05-29 07:14:06 -0700 2013-06-05 05:38:12 -0700 Patch bug-111092-20130529151331.patch text/plain 1594 obzhirov U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGExM2UwYjdkODEwN2Vl YjZlNGQ0OTViMzc3ZWRhY2JhNTQwNTZiNi4uMGY1OGJjN2YxYWMxMDQ2ZTBiMDVlM2JlMzQyODIz ZDIxMmE3YzZmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA1LTI5ICBBbnRv biBPYnpoaXJvdiAgPGEub2J6aGlyb3ZAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NTUyBSZWdp b25zXSBSZWdpb25zIGF1dG8taGVpZ2h0IGFuZCBhYnNvbHV0ZSBwb3NpdGlvbmluZyBidWcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA5MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlclJlZ2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJSZWdpb246OnVwZGF0 ZUxvZ2ljYWxIZWlnaHQpOgorCiAyMDEzLTA1LTI5ICBQZXRlciBHYWwgIDxnYWxwZXRlckBpbmYu dS1zemVnZWQuaHU+CiAKICAgICAgICAgW1F0XSBNaXNzaW5nIGZpbGVzIGZyb20gYnVpbGQgYWZ0 ZXIgcjE1MDg1MwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJl Z2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcAppbmRl eCAyNjExOWNiNzZjZjJmNWI5ODZjYzhmMWE4NzZhOWI5YzljZmU2YjI5Li5jNDYyYWYzZGM0ZGJk NThlNWY0ZGMyMzY5N2Q2ZDA2YWNjNzZjNzk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyUmVnaW9uLmNwcApAQCAtNjYzLDggKzY2MywxMiBAQCB2b2lkIFJlbmRlclJlZ2lvbjo6 dXBkYXRlTG9naWNhbEhlaWdodCgpCiAKICAgICBMYXlvdXRVbml0IG5ld0xvZ2ljYWxIZWlnaHQg PSBvdmVycmlkZUxvZ2ljYWxDb250ZW50SGVpZ2h0KCkgKyBib3JkZXJBbmRQYWRkaW5nTG9naWNh bEhlaWdodCgpOwogICAgIEFTU0VSVChuZXdMb2dpY2FsSGVpZ2h0IDwgTGF5b3V0VW5pdDo6bWF4 KCkgLyAyKTsKLSAgICBpZiAobmV3TG9naWNhbEhlaWdodCA+IGxvZ2ljYWxIZWlnaHQoKSkKKyAg ICBpZiAobmV3TG9naWNhbEhlaWdodCA+IGxvZ2ljYWxIZWlnaHQoKSkgewogICAgICAgICBzZXRM b2dpY2FsSGVpZ2h0KG5ld0xvZ2ljYWxIZWlnaHQpOworICAgICAgICAvLyBSZWNhbGN1bGF0ZSBw b3NpdGlvbiBvZiB0aGUgcmVuZGVyIGJsb2NrIGFmdGVyIG5ldyBsb2dpY2FsIGhlaWdodCBpcyBz ZXQuCisgICAgICAgIC8vIChuZWVkZWQgaW4gYWJzb2x1dGUgcG9zaXRpb25pbmcgY2FzZSB3aXRo IGJvdHRvbSBhbGlnbm1lbnQgZm9yIGV4YW1wbGUpCisgICAgICAgIFJlbmRlckJsb2NrOjp1cGRh dGVMb2dpY2FsSGVpZ2h0KCk7CisgICAgfQogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 203811 2013-06-05 05:38:18 -0700 2013-06-13 09:49:30 -0700 Patch bug-111092-20130605133737.patch text/plain 4020 obzhirov U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxMjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RmZmM0MTAwZTFjYzdj NDViZTc2MTY0ZWM3NTEwNjhlYzc0NjE4Ny4uYWQ4OGNkM2E2YTFiM2FmNWJlNDUwNzg0NGI0Y2Iw Y2I3ZGI4ODdlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA1LTI5ICBBbnRv biBPYnpoaXJvdiAgPGEub2J6aGlyb3ZAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NTUyBSZWdp b25zXSBSZWdpb25zIGF1dG8taGVpZ2h0IGFuZCBhYnNvbHV0ZSBwb3NpdGlvbmluZyBidWcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA5MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIER1cmluZyBsYXN0 IGxheW91dCB0aGF0IHNob3VsZCB1cGRhdGUgdGhlIGF1dG8taGVpZ2h0IHJlZ2lvbnMgbmV3IGF1 dG8taGVpZ2h0IHJlZ2lvbiBoZWlnaHQKKyAgICAgICAgaXMgY2FsY3VsYXRlZCBjb3JyZWN0bHkg YmFzZWQgb24gdGhlIHRleHQgY29udGVudCwgYnV0IGl0IHJlcXVpcmVzIGV4dHJhIHN0ZXAgCisg ICAgICAgIHRvIHJlcG9zaXRpb24gdGhlIHJlbmRlciBibG9jayBhZnRlciBuZXcgbG9naWNhbCBo ZWlnaHQgaXMgc2V0IChjb3JyZWN0IGxvZ2ljYWwgaGVpZ2h0IGJlY29tZXMKKyAgICAgICAgYXZh aWxhYmxlIG9ubHkgZHVyaW5nIGxhc3QgbGF5b3V0KS4gCisKKyAgICAgICAgVGVzdHM6IGZhc3Qv cmVnaW9ucy9hdXRvaGVpZ2h0LWFic3Bvcy1ib3R0b20tYWxpZ24uaHRtbAorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJSZWdp b246OnVwZGF0ZUxvZ2ljYWxIZWlnaHQpOgorCiAyMDEzLTA2LTA1ICBDaHJpc3RvcGhlIER1bWV6 ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBNZXJnZSBbTm9JbnRlcmZh Y2VPYmplY3RdIGFuZCBbT21pdENvbnN0cnVjdG9yXSBleHRlbmRlZCBhdHRyaWJ1dGVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwCmluZGV4IDI2MTE5Y2I3NmNmMmY1 Yjk4NmNjOGYxYTg3NmE5YjljOWNmZTZiMjkuLmM0NjJhZjNkYzRkYmQ1OGU1ZjRkYzIzNjk3ZDZk MDZhY2M3NmM3OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJS ZWdpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3Bw CkBAIC02NjMsOCArNjYzLDEyIEBAIHZvaWQgUmVuZGVyUmVnaW9uOjp1cGRhdGVMb2dpY2FsSGVp Z2h0KCkKIAogICAgIExheW91dFVuaXQgbmV3TG9naWNhbEhlaWdodCA9IG92ZXJyaWRlTG9naWNh bENvbnRlbnRIZWlnaHQoKSArIGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCk7CiAgICAg QVNTRVJUKG5ld0xvZ2ljYWxIZWlnaHQgPCBMYXlvdXRVbml0OjptYXgoKSAvIDIpOwotICAgIGlm IChuZXdMb2dpY2FsSGVpZ2h0ID4gbG9naWNhbEhlaWdodCgpKQorICAgIGlmIChuZXdMb2dpY2Fs SGVpZ2h0ID4gbG9naWNhbEhlaWdodCgpKSB7CiAgICAgICAgIHNldExvZ2ljYWxIZWlnaHQobmV3 TG9naWNhbEhlaWdodCk7CisgICAgICAgIC8vIFJlY2FsY3VsYXRlIHBvc2l0aW9uIG9mIHRoZSBy ZW5kZXIgYmxvY2sgYWZ0ZXIgbmV3IGxvZ2ljYWwgaGVpZ2h0IGlzIHNldC4KKyAgICAgICAgLy8g KG5lZWRlZCBpbiBhYnNvbHV0ZSBwb3NpdGlvbmluZyBjYXNlIHdpdGggYm90dG9tIGFsaWdubWVu dCBmb3IgZXhhbXBsZSkKKyAgICAgICAgUmVuZGVyQmxvY2s6OnVwZGF0ZUxvZ2ljYWxIZWlnaHQo KTsKKyAgICB9CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWFic3Bvcy1ib3R0b20tYWxpZ24tZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYWJzcG9zLWJvdHRv bS1hbGlnbi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTE0MGI4MjFlY2JhOTNlYjkxZTE0YmQw YTRkMTY1YWYxNzUyZmUxZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVn aW9ucy9hdXRvaGVpZ2h0LWFic3Bvcy1ib3R0b20tYWxpZ24tZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsNyBAQAorVGVzdCBmb3IgW0NTUyBSZWdpb25zXSBSZWdpb25zIGF1dG8taGVpZ2h0IGFuZCBh YnNvbHV0ZSBwb3NpdGlvbmluZyBidWcuCisKK09uIHN1Y2Nlc3MgeW91IHNob3VsZCBzZWUgUEFT UyBiZWxvdy4KKwordGhpcyBpcyBzb21lIGJvZHkgY29weS4KK3RoaXMgaXMgc29tZSBib2R5IGNv cHkuCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYXV0b2hlaWdo dC1hYnNwb3MtYm90dG9tLWFsaWduLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYXV0 b2hlaWdodC1hYnNwb3MtYm90dG9tLWFsaWduLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDUyNmNkZDZiY2E0 Nzk5MzFiMzcxMDU5YjMzNmJlYzc0MWEzNDM2OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWFic3Bvcy1ib3R0b20tYWxpZ24uaHRtbApAQCAt MCwwICsxLDIyIEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAg ICA8c3R5bGU+CQkKKyAgICAgICAgICAgICNjb250ZW50IHsgLXdlYmtpdC1mbG93LWludG86IGZs b3c7IH0KKyAgICAgICAgICAgICNyZWdpb24geyAtd2Via2l0LWZsb3ctZnJvbTogZmxvdzsgcG9z aXRpb246IGFic29sdXRlOyBib3R0b206IDBweDsgcmlnaHQ6IDBweDsgd2lkdGg6IDEwMHB4OyBi YWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTt9CisgICAgICAgICAgICAjcmVmZXJlbmNlIHsgcG9zaXRp b246IGFic29sdXRlOyBib3R0b206IDBweDsgcmlnaHQ6IDBweDsgd2lkdGg6IDEwMHB4OyBiYWNr Z3JvdW5kLWNvbG9yOiByZWQ7fQorICAgICAgICA8L3N0eWxlPgorICAgIDwvaGVhZD4KKyAgICA8 c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2NoZWNrLWxheW91dC5qcyI+PC9zY3JpcHQ+Cisg ICAgPGJvZHkgb25sb2FkPSJjaGVja0xheW91dCgnI3JlZ2lvbicpIj4KKyAgICAgICAgPHA+VGVz dCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTA5MiI+IFtDU1MgUmVnaW9uc10gUmVnaW9ucyBhdXRvLWhlaWdodCBhbmQgYWJzb2x1dGUgcG9z aXRpb25pbmcgYnVnPC9hPi48L3A+CisgICAgICAgIDxwPk9uIHN1Y2Nlc3MgeW91IHNob3VsZCBz ZWUgUEFTUyBiZWxvdy48L3A+CisgICAgICAgIDxkaXYgaWQ9ImNvbnRlbnQiPnRoaXMgaXMgc29t ZSBib2R5IGNvcHkuPC9kaXY+CisgICAgICAgIDxkaXYgaWQ9InJlZmVyZW5jZSI+dGhpcyBpcyBz b21lIGJvZHkgY29weS48L2Rpdj4gICAgICAgIAorICAgICAgICA8ZGl2IGlkPSJyZWdpb24iIGRh dGEtdG90YWwteT0wPjwvZGl2PgorICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgZG9jdW1l bnQuYm9keS5vZmZzZXRUb3A7IC8vIGZvcmNlIGxheW91dAorICAgICAgICAgICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInJlZ2lvbiIpLnNldEF0dHJpYnV0ZSgiZGF0YS10b3RhbC15IiwgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JlZmVyZW5jZScpLm9mZnNldFRvcCk7CisgICAgICAgIDwv c2NyaXB0PgorICAgIDwvYm9keT4KKzwvaHRtbD4K