111090 2013-02-28 10:32:28 -0800 [texmap] Remove redundant defines on TextureMapperGL 2013-02-28 13:39:45 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108716 1 bruno.abinader bruno.abinader cmarcelo igor.oliveira luiz noam tonikitoo webkit.review.bot oldest_to_newest 844202 0 bruno.abinader 2013-02-28 10:32:28 -0800 Used inside TextureMapperGL::updateContentsNoSwizzle(), the driverSupportsSubImage() function already uses OpenGL ES defines to return correct support, thus no need for additional defines. 844205 1 190753 bruno.abinader 2013-02-28 10:33:57 -0800 Created attachment 190753 Patch Proposed patch 844229 2 190753 tonikitoo 2013-02-28 10:58:42 -0800 Comment on attachment 190753 Patch Igor? 844367 3 igor.oliveira 2013-02-28 12:39:50 -0800 cq'ed 844397 4 190753 webkit.review.bot 2013-02-28 13:11:07 -0800 Comment on attachment 190753 Patch Rejecting attachment 190753 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190753, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://webkit-commit-queue.appspot.com/results/16666457 844406 5 190753 bruno.abinader 2013-02-28 13:17:07 -0800 Comment on attachment 190753 Patch Commit-queue seems sick, trying again... 844431 6 190753 webkit.review.bot 2013-02-28 13:39:42 -0800 Comment on attachment 190753 Patch Clearing flags on attachment: 190753 Committed r144359: <http://trac.webkit.org/changeset/144359> 844432 7 webkit.review.bot 2013-02-28 13:39:45 -0800 All reviewed patches have been landed. Closing bug. 190753 2013-02-28 10:33:57 -0800 2013-02-28 13:39:42 -0800 Patch bug-111090-20130228143008.patch text/plain 2877 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJjODBkMDMwZDUyMDZm OGU1OTY3OThmMzkxMmNkNmEwOTI4ZWZlOC4uNGVjN2UyZmM4MWFkMmY4YzdkYTA5ZDM1Nzg2ZWI2 Njg0NTFiNWQ1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTAyLTI4ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KIAor ICAgICAgICBbdGV4bWFwXSBSZW1vdmUgcmVkdW5kYW50IGRlZmluZXMgb24gVGV4dHVyZU1hcHBl ckdMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEw OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBkcml2 ZXJTdXBwb3J0c1N1YkltYWdlKCkgYWxyZWFkeSB1c2VzIE9wZW5HTCBFUyBkZWZpbmVzIHRvIHJl dHVybgorICAgICAgICBjb3JyZWN0IHN1cHBvcnQsIHRodXMgbm8gbmVlZCBmb3IgdGhlc2UgYWRk aXRpb25hbCBkZWZpbmVzLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZXMsIHRodXMgY292 ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Qml0bWFwVGV4dHVy ZUdMOjp1cGRhdGVDb250ZW50c05vU3dpenpsZSk6CisKKzIwMTMtMDItMjggIEJydW5vIGRlIE9s aXZlaXJhIEFiaW5hZGVyICA8YnJ1bm8uYWJpbmFkZXJAYmFzeXNrb20uY29tPgorCiAgICAgICAg IEFkZCBzdGF0ZSB2YXJpYWJsZXMgdG8gYXZvaWQgT3BlbkdMIHJlZHVuZGFudCBzdGF0ZSBjaGFu Z2VzIG9uIEdyYXBoaWNzQ29udGV4dDNECiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTA4ODMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAppbmRleCAxYjcy ZGI0MTExYTBkNGFlN2VlZTk2ODY2YzhhYzQ0N2NiOWEwOTAxLi5kYzk3Zjg5OTdjYzk0ZGI5YzA2 NTdmNzJmN2E3MzczYzFiNjI1NTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcApAQCAtNjM5LDIy ICs2MzksMTggQEAgdm9pZCBCaXRtYXBUZXh0dXJlR0w6OmRpZFJlc2V0KCkKIHZvaWQgQml0bWFw VGV4dHVyZUdMOjp1cGRhdGVDb250ZW50c05vU3dpenpsZShjb25zdCB2b2lkKiBzcmNEYXRhLCBj b25zdCBJbnRSZWN0JiB0YXJnZXRSZWN0LCBjb25zdCBJbnRQb2ludCYgc291cmNlT2Zmc2V0LCBp bnQgYnl0ZXNQZXJMaW5lLCB1bnNpZ25lZCBieXRlc1BlclBpeGVsLCBQbGF0Zm9ybTNET2JqZWN0 IGdsRm9ybWF0KQogewogICAgIG1fY29udGV4dDNELT5iaW5kVGV4dHVyZShHcmFwaGljc0NvbnRl eHQzRDo6VEVYVFVSRV8yRCwgbV9pZCk7Ci0jaWYgIWRlZmluZWQoVEVYTUFQX09QRU5HTF9FU18y KQogICAgIGlmIChkcml2ZXJTdXBwb3J0c1N1YkltYWdlKCkpIHsgLy8gRm9yIEVTIGRyaXZlcnMg dGhhdCBkb24ndCBzdXBwb3J0IHN1Yi1pbWFnZXMuCiAgICAgICAgIC8vIFVzZSB0aGUgT3BlbkdM IHN1Yi1pbWFnZSBleHRlbnNpb24sIG5vdyB0aGF0IHdlIGtub3cgaXQncyBhdmFpbGFibGUuCiAg ICAgICAgIG1fY29udGV4dDNELT5waXhlbFN0b3JlaShHTF9VTlBBQ0tfUk9XX0xFTkdUSCwgYnl0 ZXNQZXJMaW5lIC8gYnl0ZXNQZXJQaXhlbCk7CiAgICAgICAgIG1fY29udGV4dDNELT5waXhlbFN0 b3JlaShHTF9VTlBBQ0tfU0tJUF9ST1dTLCBzb3VyY2VPZmZzZXQueSgpKTsKICAgICAgICAgbV9j b250ZXh0M0QtPnBpeGVsU3RvcmVpKEdMX1VOUEFDS19TS0lQX1BJWEVMUywgc291cmNlT2Zmc2V0 LngoKSk7CiAgICAgfQotI2VuZGlmCiAgICAgbV9jb250ZXh0M0QtPnRleFN1YkltYWdlMkQoR3Jh cGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVfMkQsIDAsIHRhcmdldFJlY3QueCgpLCB0YXJnZXRSZWN0 LnkoKSwgdGFyZ2V0UmVjdC53aWR0aCgpLCB0YXJnZXRSZWN0LmhlaWdodCgpLCBnbEZvcm1hdCwg REVGQVVMVF9URVhUVVJFX1BJWEVMX1RSQU5TRkVSX1RZUEUsIHNyY0RhdGEpOwotI2lmICFkZWZp bmVkKFRFWE1BUF9PUEVOR0xfRVNfMikKICAgICBpZiAoZHJpdmVyU3VwcG9ydHNTdWJJbWFnZSgp KSB7IC8vIEZvciBFUyBkcml2ZXJzIHRoYXQgZG9uJ3Qgc3VwcG9ydCBzdWItaW1hZ2VzLgogICAg ICAgICBtX2NvbnRleHQzRC0+cGl4ZWxTdG9yZWkoR0xfVU5QQUNLX1JPV19MRU5HVEgsIDApOwog ICAgICAgICBtX2NvbnRleHQzRC0+cGl4ZWxTdG9yZWkoR0xfVU5QQUNLX1NLSVBfUk9XUywgMCk7 CiAgICAgICAgIG1fY29udGV4dDNELT5waXhlbFN0b3JlaShHTF9VTlBBQ0tfU0tJUF9QSVhFTFMs IDApOwogICAgIH0KLSNlbmRpZgogfQogCiB2b2lkIEJpdG1hcFRleHR1cmVHTDo6dXBkYXRlQ29u dGVudHMoY29uc3Qgdm9pZCogc3JjRGF0YSwgY29uc3QgSW50UmVjdCYgdGFyZ2V0UmVjdCwgY29u c3QgSW50UG9pbnQmIHNvdXJjZU9mZnNldCwgaW50IGJ5dGVzUGVyTGluZSwgVXBkYXRlQ29udGVu dHNGbGFnIHVwZGF0ZUNvbnRlbnRzRmxhZykK