111081 2013-02-28 08:19:30 -0800 [Qt][WK2] Double-tap during scroll animation leaves content in suspended state 2013-03-07 10:15:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 111751 P2 Normal --- 1 abecsi abecsi benjamin cmarcelo jturcotte menard webkit.review.bot oldest_to_newest 844115 0 abecsi 2013-02-28 08:19:30 -0800 [Qt][WK2] Double-tap during scroll animation leaves content in suspended state 844118 1 190733 abecsi 2013-02-28 08:22:15 -0800 Created attachment 190733 Patch 845023 2 190733 jturcotte 2013-03-01 03:31:21 -0800 Comment on attachment 190733 Patch It's for those "might have been" cases that the update deferrers were good at handling. r=me 845026 3 jturcotte 2013-03-01 03:32:43 -0800 Benjamin could you sign this off? Is this the kind of change that is considered trivial? 845051 4 abecsi 2013-03-01 04:16:21 -0800 (In reply to comment #2) > (From update of attachment 190733 [details]) > It's for those "might have been" cases that the update deferrers were good at handling. Yes, this bug was unfortunately present since we removed the deferrers. 845434 5 190733 benjamin 2013-03-01 13:00:48 -0800 Comment on attachment 190733 Patch Isn't panGestureCancelled() called when transitioning from a pan to another gesture? E.g.: pan->pinch; pan->double finger scroll If yes, this patch is wrong. 845435 6 190733 benjamin 2013-03-01 13:00:49 -0800 Comment on attachment 190733 Patch Isn't panGestureCancelled() called when transitioning from a pan to another gesture? E.g.: pan->pinch; pan->double finger scroll If yes, this patch is wrong. 845830 7 abecsi 2013-03-02 10:29:41 -0800 (In reply to comment #6) > (From update of attachment 190733 [details]) > Isn't panGestureCancelled() called when transitioning from a pan to another gesture? Yes. > E.g.: pan->pinch; pan->double finger scroll pan->pinch and pan->tap/double-tap, there is no double finger scroll in Qt. > > If yes, this patch is wrong. Could you elaborate? 846079 8 benjamin 2013-03-03 14:15:41 -0800 > > If yes, this patch is wrong. > > Could you elaborate? You would resume the content between two interactions. Let say you do pan->pinch->pan without ever lifting the first finger. You don't expect the content to resume at any point. 846405 9 abecsi 2013-03-04 06:17:36 -0800 (In reply to comment #8) > > > If yes, this patch is wrong. > > > > Could you elaborate? > > You would resume the content between two interactions. > Let say you do pan->pinch->pan without ever lifting the first finger. You don't expect the content to resume at any point. Currently we only explicitly prevent the content from resuming between subsequent pan gestures and do not enforce staying suspended between pan->pinch->pan. Although it's true that the case for the pan->pinch part of the chain is currently in most cases provided as the side effect of this bug, as it was also the case when we had update deferrers. To enforce suspended state for gesture chains when the finger is not lifted, without having corner cases where the content remains suspended, I think we need to bring back the update deferrers in some form. 850224 10 abecsi 2013-03-07 10:14:55 -0800 The issue is covered by a more comprehensive patch at https://bugs.webkit.org/show_bug.cgi?id=111751 *** This bug has been marked as a duplicate of bug 111751 *** 190733 2013-02-28 08:22:15 -0800 2013-03-07 10:15:25 -0800 Patch bug-111081-20130228171634.patch text/plain 2725 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2RmY2RiNjZjZGFhMDAz NjY3OWZiYmJkZTIwODc5MDEyNzYxMDQ3My4uMTQyMjcyOTZlOGZiNzYwMzJmM2UwODg2NzA0MTMw ZTY3NjIxMTQ0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTI4ICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBE b3VibGUtdGFwIGR1cmluZyBzY3JvbGwgYW5pbWF0aW9uIGxlYXZlcyBjb250ZW50IGluIHN1c3Bl bmRlZCBzdGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTExMDgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW4gUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0OjpmbGlja01vdmVFbmRlZCgpIG1f aXNVc2VySW50ZXJhY3RpbmcgcHJldmVudHMKKyAgICAgICAgdGhlIGNvbnRlbnQgZnJvbSByZXN1 bWluZyBpbiBiZXR3ZWVuIHR3byBwYW4gZ2VzdHVyZXMgYnV0IGl0IGFsc28gcHJldmVudHMgcmVz dW1lCisgICAgICAgIGlmIHRoZSBwYW4gZ2VzdHVyZSBpcyBjYW5jZWxsZWQgZHVyaW5nIGEgdHJh bnNpdGlvbiB0byBhbm90aGVyIGdlc3R1cmUuCisgICAgICAgIFRoaXMgd291bGQgbGVhdmUgdGhl IGNvbnRlbnQgaW4gYSBzdXNwZW5kZWQgc3RhdGUgZHVyaW5nIHRyYW5zaXRpb24gdG8gZG91Ymxl LXRhcCwKKyAgICAgICAgd2hpY2ggY2F1c2VzIGlzc3VlcyB3aXRoIHN1YnNlcXVlbnQgdGFwIGdl c3R1cmVzLgorICAgICAgICBQcmV2ZW50IHRoaXMgYnkgcmVzdW1pbmcgdGhlIGNvbnRlbnQgaW4g cGFuR2VzdHVyZUNhbmNlbGxlZCBzbyB0aGF0IHdlIHN0aWxsIGRvCisgICAgICAgIG5vdCByZXN1 bWUgdW5uZWNlc3NhcmlseSBiZXR3ZWVuIHN1Y2Nlc3NpdmUgcGFuIGdlc3R1cmVzLgorCisgICAg ICAgICogVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdDo6cGFuR2VzdHVy ZUNhbmNlbGxlZCk6CisKIDIwMTMtMDItMjcgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBbV0syXSBPbmUgbW9yZSB1bnJldmlld2VkIGJ1aWxkZml4IGZv ciBFRkwsIEdUSyBhbmQgUXQgYWZ0ZXIgcjE0NDIxOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9xdC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50UXQuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdC5j cHAKaW5kZXggNmVlMzk5N2Y1YWNkYmM3MjFkZjhmYTBjZjEzNWI1YWEzN2Q4ODMzYS4uZmJiM2Jh ZWNjOWUyNjUyYzhlZjI2Nzg4OGE5MWM0MDFlODJhMzAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdC5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGll bnRRdC5jcHAKQEAgLTM3NSwxMiArMzc1LDE1IEBAIHZvaWQgUGFnZVZpZXdwb3J0Q29udHJvbGxl ckNsaWVudFF0OjpwYW5HZXN0dXJlQ2FuY2VsbGVkKCkKIHsKICAgICAvLyBSZXNldCB0aGUgdmVs b2NpdHkgc2FtcGxlcyBvZiB0aGUgZmxpY2thYmxlLgogICAgIC8vIFRoaXMgc2hvdWxkIG9ubHkg YmUgY2FsbGVkIGJ5IHRoZSByZWNvZ25pemVyIGlmIHdlIGhhdmUgYSByZWNvZ25pemVkCi0gICAg Ly8gcGFuIGdlc3R1cmUgYW5kIHJlY2VpdmUgYSB0b3VjaCBldmVudCB3aXRoIG11bHRpcGxlIHRv dWNoIHBvaW50cwotICAgIC8vIChpZS4gdHJhbnNpdGlvbiB0byBhIHBpbmNoIGdlc3R1cmUpIGFz IGl0IGRvZXMgbm90IG1vdmUgdGhlIGNvbnRlbnQKLSAgICAvLyBiYWNrIGluc2lkZSB2YWxpZCBi b3VuZHMuCi0gICAgLy8gV2hlbiB0aGUgcGluY2ggZ2VzdHVyZSBlbmRzLCB0aGUgY29udGVudCBp cyBwb3NpdGlvbmVkIGFuZCBzY2FsZWQKKyAgICAvLyBwYW4gZ2VzdHVyZSBhbmQgcmVjZWl2ZSB0 b3VjaCBldmVudHMgdGhhdCByZXN1bHQgaW4gYSBkaWZmZXJlbnQgZ2VzdHVyZSwKKyAgICAvLyBh cyBpdCBkb2VzIG5vdCBtb3ZlIHRoZSBjb250ZW50IGJhY2sgaW5zaWRlIHZhbGlkIGJvdW5kcy4K KyAgICAvLyBUaGUgb3ZlcnRha2luZyBnZXN0dXJlIGlzIHJlc3Bvc2libGUgdG8gcG9zaXRpb24g YW5kIHNjYWxlIHRoZSBjb250ZW50CiAgICAgLy8gYmFjayB0byB2YWxpZCBib3VuZGFyaWVzLgog ICAgIG1fdmlld3BvcnRJdGVtLT5jYW5jZWxGbGljaygpOworCisgICAgLy8gUmVzdW1lIHRoZSBj b250ZW50IGhlcmUgc2luY2UgYSBzY3JvbGwgYW5pbWF0aW9uIG1pZ2h0IGhhdmUgYmVlbiBjYW5j ZWxsZWQKKyAgICAvLyB3aGlsZSB0aGUgdXNlciB3YXMgc3RpbGwgaW50ZXJhY3RpbmcuCisgICAg bV9jb250cm9sbGVyLT5yZXN1bWVDb250ZW50KCk7CiB9CiAKIGJvb2wgUGFnZVZpZXdwb3J0Q29u dHJvbGxlckNsaWVudFF0OjpzY2FsZUFuaW1hdGlvbkFjdGl2ZSgpIGNvbnN0Cg==