111061 2013-02-28 02:31:16 -0800 Web Inspector: Adding existing key in DOMStorageItemsView leaves it inconsistent state 2013-02-28 08:59:01 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vivekg vivekg apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 843917 0 vivekg 2013-02-28 02:31:16 -0800 Steps: 1. Create some local storage entries. e.g. { "item1": "value1", "item2": "value2", ... } 2. Navigate to Resources panel and localStorage view 3. Using the last row of the grid (creation node), just enter the value to be one of the existing keys [ "key1", "key2" ... ] 4. Press enter Expected outcome: Only one entry per key should be shown Actual Outcome: Multiple entries are listed Patch follows. 843922 1 190687 vivekg 2013-02-28 02:34:58 -0800 Created attachment 190687 Patch 843938 2 190687 apavlov 2013-02-28 03:08:17 -0800 Comment on attachment 190687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190687&action=review > Source/WebCore/inspector/front-end/DOMStorageItemsView.js:149 > + if (!keyFound) { Please use early returns as extensively as possible. It improves the code readability and makes it [a bit more] error-proof. if (keyFound) { childNode.removeSelf(); continue; } keyFound = true; childNode.data.value = storageData.newValue; childNode.refresh(); childNode.select(); childNode.reveal(); this.deleteButton.visible = true; 843944 3 190691 vivekg 2013-02-28 03:25:47 -0800 Created attachment 190691 Patch 843946 4 190691 apavlov 2013-02-28 03:31:30 -0800 Comment on attachment 190691 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190691&action=review > Source/WebCore/inspector/front-end/DOMStorageItemsView.js:150 > + childNode.parent.removeChild(childNode); Sorry for missing this. You can replace "childNode.parent" by "rootNode", right? 843948 5 190692 vivekg 2013-02-28 03:34:14 -0800 Created attachment 190692 Patch 843954 6 190694 vivekg 2013-02-28 03:39:52 -0800 Created attachment 190694 Patch 844135 7 190694 webkit.review.bot 2013-02-28 08:58:57 -0800 Comment on attachment 190694 Patch Clearing flags on attachment: 190694 Committed r144317: <http://trac.webkit.org/changeset/144317> 844136 8 webkit.review.bot 2013-02-28 08:59:01 -0800 All reviewed patches have been landed. Closing bug. 190687 2013-02-28 02:34:58 -0800 2013-02-28 03:25:41 -0800 Patch bug-111061-20130228160216.patch text/plain 2366 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRmNDMzZTE0ZDQ5NjA3 N2QzMjU1YTdhODNhZWEwYjJjOTQ3N2JkYi4uMTY4ZTg2ZWUzNGIwZTczZjQyMGE3MGRhMzZiNjg2 MzgzZjY5OTNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI4ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZGluZyBleGlzdGluZyBrZXkgaW4gRE9NU3RvcmFnZUl0ZW1zVmlldyBsZWF2ZXMgaXQg aW5jb25zaXN0ZW50IHN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTEwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgdmlldyBtdXN0IGJlIGNoZWNrZWQgZm9yIGFsbCB0aGUgcm93cyB3aXRo IHRoZSBtYXRjaGluZyBrZXlzLiBPbmx5IHRoZSBmaXJzdCBvbmUgd291bGQgYmUgdXBkYXRlZAor ICAgICAgICB3aXRoIHRoZSBuZXcgdmFsdWUgd2hpbGUgdGhlIG90aGVycyBtdXN0IGJlIHJlbW92 ZWQgZnJvbSB0aGUgZ3JpZC4gQWxzbyBpbiBjYXNlIHRoZXJlIGFyZSB2YXJpb3VzIGtleS92YWx1 ZQorICAgICAgICBwYWlycywgdGhlIGNoYW5nZWQgbm9kZSBzaG91bGQgYmUgc2VsZWN0ZWQgYW5k IHJldmVhbGVkIGluIHRoZSBncmlkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSByZWxh dGVkIG1pbm9yIGNoYW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRE9NU3Rv cmFnZUl0ZW1zVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01TdG9yYWdlSXRlbXNW aWV3LnByb3RvdHlwZS5fZG9tU3RvcmFnZUl0ZW1VcGRhdGVkKToKKwogMjAxMy0wMi0yNyAgS2Vp c2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgbW9udGggcG9w dXAgZm9yIG5ldyBjYWxlbmRhciBwaWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcwppbmRleCBmNWRiMWU5 MWM0ZGVkYTM0NzZjZmIzZGI4MjA4MWQ5MDI4ZDRiYzg0Li5lNTc3NjVhOGMxZDFiNjA4MDg3YjUw ZWEzNzFmOGI5MGQxZmNkNmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9ET01TdG9yYWdlSXRlbXNWaWV3LmpzCkBAIC0xNDIsMTMgKzE0Miwx OSBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUl0ZW1zVmlldy5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgZXZlbnQuY29uc3VtZSh0cnVlKTsKIAorICAgICAgICB2YXIga2V5Rm91bmQgPSBmYWxz ZTsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjaGlsZHJlbi5sZW5ndGg7ICsraSkgewog ICAgICAgICAgICAgdmFyIGNoaWxkTm9kZSA9IGNoaWxkcmVuW2ldOwogICAgICAgICAgICAgaWYg KGNoaWxkTm9kZS5kYXRhLmtleSA9PT0gc3RvcmFnZURhdGEua2V5KSB7Ci0gICAgICAgICAgICAg ICAgY2hpbGROb2RlLmRhdGEudmFsdWUgPSBzdG9yYWdlRGF0YS5uZXdWYWx1ZTsKLSAgICAgICAg ICAgICAgICBjaGlsZE5vZGUucmVmcmVzaCgpOwotICAgICAgICAgICAgICAgIHRoaXMuZGVsZXRl QnV0dG9uLnZpc2libGUgPSB0cnVlOwotICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg ICAgICAgICBpZiAoIWtleUZvdW5kKSB7CisgICAgICAgICAgICAgICAgICAgIGtleUZvdW5kID0g dHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgY2hpbGROb2RlLmRhdGEudmFsdWUgPSBzdG9yYWdl RGF0YS5uZXdWYWx1ZTsKKyAgICAgICAgICAgICAgICAgICAgY2hpbGROb2RlLnJlZnJlc2goKTsK KyAgICAgICAgICAgICAgICAgICAgY2hpbGROb2RlLnNlbGVjdCgpOworICAgICAgICAgICAgICAg ICAgICBjaGlsZE5vZGUucmV2ZWFsKCk7CisgICAgICAgICAgICAgICAgICAgIHRoaXMuZGVsZXRl QnV0dG9uLnZpc2libGUgPSB0cnVlOworICAgICAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAg ICAgICAgICAgICBjaGlsZE5vZGUucGFyZW50LnJlbW92ZUNoaWxkKGNoaWxkTm9kZSk7CiAgICAg ICAgICAgICB9CiAgICAgICAgIH0KICAgICB9LAo= 190691 2013-02-28 03:25:47 -0800 2013-02-28 03:34:09 -0800 Patch bug-111061-20130228165305.patch text/plain 2216 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRmNDMzZTE0ZDQ5NjA3 N2QzMjU1YTdhODNhZWEwYjJjOTQ3N2JkYi4uMTY4ZTg2ZWUzNGIwZTczZjQyMGE3MGRhMzZiNjg2 MzgzZjY5OTNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI4ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZGluZyBleGlzdGluZyBrZXkgaW4gRE9NU3RvcmFnZUl0ZW1zVmlldyBsZWF2ZXMgaXQg aW5jb25zaXN0ZW50IHN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTEwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgdmlldyBtdXN0IGJlIGNoZWNrZWQgZm9yIGFsbCB0aGUgcm93cyB3aXRo IHRoZSBtYXRjaGluZyBrZXlzLiBPbmx5IHRoZSBmaXJzdCBvbmUgd291bGQgYmUgdXBkYXRlZAor ICAgICAgICB3aXRoIHRoZSBuZXcgdmFsdWUgd2hpbGUgdGhlIG90aGVycyBtdXN0IGJlIHJlbW92 ZWQgZnJvbSB0aGUgZ3JpZC4gQWxzbyBpbiBjYXNlIHRoZXJlIGFyZSB2YXJpb3VzIGtleS92YWx1 ZQorICAgICAgICBwYWlycywgdGhlIGNoYW5nZWQgbm9kZSBzaG91bGQgYmUgc2VsZWN0ZWQgYW5k IHJldmVhbGVkIGluIHRoZSBncmlkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSByZWxh dGVkIG1pbm9yIGNoYW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRE9NU3Rv cmFnZUl0ZW1zVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01TdG9yYWdlSXRlbXNW aWV3LnByb3RvdHlwZS5fZG9tU3RvcmFnZUl0ZW1VcGRhdGVkKToKKwogMjAxMy0wMi0yNyAgS2Vp c2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgbW9udGggcG9w dXAgZm9yIG5ldyBjYWxlbmRhciBwaWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcwppbmRleCBmNWRiMWU5 MWM0ZGVkYTM0NzZjZmIzZGI4MjA4MWQ5MDI4ZDRiYzg0Li44ZGIxZThhMTIwZjU1NDVlZmFkMzc3 MTg1N2EzZmRiYmNmNWE4ZjVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9ET01TdG9yYWdlSXRlbXNWaWV3LmpzCkBAIC0xNDIsMTMgKzE0Miwy MCBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUl0ZW1zVmlldy5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgZXZlbnQuY29uc3VtZSh0cnVlKTsKIAorICAgICAgICB2YXIga2V5Rm91bmQgPSBmYWxz ZTsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjaGlsZHJlbi5sZW5ndGg7ICsraSkgewog ICAgICAgICAgICAgdmFyIGNoaWxkTm9kZSA9IGNoaWxkcmVuW2ldOwogICAgICAgICAgICAgaWYg KGNoaWxkTm9kZS5kYXRhLmtleSA9PT0gc3RvcmFnZURhdGEua2V5KSB7CisgICAgICAgICAgICAg ICAgaWYgKGtleUZvdW5kKSB7CisgICAgICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5wYXJlbnQu cmVtb3ZlQ2hpbGQoY2hpbGROb2RlKTsKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cisg ICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIGtleUZvdW5kID0gdHJ1ZTsKICAgICAg ICAgICAgICAgICBjaGlsZE5vZGUuZGF0YS52YWx1ZSA9IHN0b3JhZ2VEYXRhLm5ld1ZhbHVlOwog ICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5yZWZyZXNoKCk7CisgICAgICAgICAgICAgICAgY2hp bGROb2RlLnNlbGVjdCgpOworICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5yZXZlYWwoKTsKICAg ICAgICAgICAgICAgICB0aGlzLmRlbGV0ZUJ1dHRvbi52aXNpYmxlID0gdHJ1ZTsKLSAgICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9LAo= 190692 2013-02-28 03:34:14 -0800 2013-02-28 03:39:47 -0800 Patch bug-111061-20130228170133.patch text/plain 2208 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRmNDMzZTE0ZDQ5NjA3 N2QzMjU1YTdhODNhZWEwYjJjOTQ3N2JkYi4uMTY4ZTg2ZWUzNGIwZTczZjQyMGE3MGRhMzZiNjg2 MzgzZjY5OTNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI4ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZGluZyBleGlzdGluZyBrZXkgaW4gRE9NU3RvcmFnZUl0ZW1zVmlldyBsZWF2ZXMgaXQg aW5jb25zaXN0ZW50IHN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTEwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgdmlldyBtdXN0IGJlIGNoZWNrZWQgZm9yIGFsbCB0aGUgcm93cyB3aXRo IHRoZSBtYXRjaGluZyBrZXlzLiBPbmx5IHRoZSBmaXJzdCBvbmUgd291bGQgYmUgdXBkYXRlZAor ICAgICAgICB3aXRoIHRoZSBuZXcgdmFsdWUgd2hpbGUgdGhlIG90aGVycyBtdXN0IGJlIHJlbW92 ZWQgZnJvbSB0aGUgZ3JpZC4gQWxzbyBpbiBjYXNlIHRoZXJlIGFyZSB2YXJpb3VzIGtleS92YWx1 ZQorICAgICAgICBwYWlycywgdGhlIGNoYW5nZWQgbm9kZSBzaG91bGQgYmUgc2VsZWN0ZWQgYW5k IHJldmVhbGVkIGluIHRoZSBncmlkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSByZWxh dGVkIG1pbm9yIGNoYW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRE9NU3Rv cmFnZUl0ZW1zVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01TdG9yYWdlSXRlbXNW aWV3LnByb3RvdHlwZS5fZG9tU3RvcmFnZUl0ZW1VcGRhdGVkKToKKwogMjAxMy0wMi0yNyAgS2Vp c2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgbW9udGggcG9w dXAgZm9yIG5ldyBjYWxlbmRhciBwaWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcwppbmRleCBmNWRiMWU5 MWM0ZGVkYTM0NzZjZmIzZGI4MjA4MWQ5MDI4ZDRiYzg0Li5jZGFjMWFlMjNhMGI1NzIxNGVmNTUx ODQzMDQ0NzRmNTA1ZWRmMjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9ET01TdG9yYWdlSXRlbXNWaWV3LmpzCkBAIC0xNDIsMTMgKzE0Miwy MCBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUl0ZW1zVmlldy5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgZXZlbnQuY29uc3VtZSh0cnVlKTsKIAorICAgICAgICB2YXIga2V5Rm91bmQgPSBmYWxz ZTsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjaGlsZHJlbi5sZW5ndGg7ICsraSkgewog ICAgICAgICAgICAgdmFyIGNoaWxkTm9kZSA9IGNoaWxkcmVuW2ldOwogICAgICAgICAgICAgaWYg KGNoaWxkTm9kZS5kYXRhLmtleSA9PT0gc3RvcmFnZURhdGEua2V5KSB7CisgICAgICAgICAgICAg ICAgaWYgKGtleUZvdW5kKSB7CisgICAgICAgICAgICAgICAgICAgIHJvb3ROb2RlLnJlbW92ZUNo aWxkKGNoaWxkTm9kZSk7CisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAg ICAgICAgIH0KKyAgICAgICAgICAgICAgICBrZXlGb3VuZCA9IHRydWU7CiAgICAgICAgICAgICAg ICAgY2hpbGROb2RlLmRhdGEudmFsdWUgPSBzdG9yYWdlRGF0YS5uZXdWYWx1ZTsKICAgICAgICAg ICAgICAgICBjaGlsZE5vZGUucmVmcmVzaCgpOworICAgICAgICAgICAgICAgIGNoaWxkTm9kZS5z ZWxlY3QoKTsKKyAgICAgICAgICAgICAgICBjaGlsZE5vZGUucmV2ZWFsKCk7CiAgICAgICAgICAg ICAgICAgdGhpcy5kZWxldGVCdXR0b24udmlzaWJsZSA9IHRydWU7Ci0gICAgICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfSwK 190694 2013-02-28 03:39:52 -0800 2013-02-28 08:58:57 -0800 Patch bug-111061-20130228170710.patch text/plain 2206 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRmNDMzZTE0ZDQ5NjA3 N2QzMjU1YTdhODNhZWEwYjJjOTQ3N2JkYi4uMTY4ZTg2ZWUzNGIwZTczZjQyMGE3MGRhMzZiNjg2 MzgzZjY5OTNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI4ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZGluZyBleGlzdGluZyBrZXkgaW4gRE9NU3RvcmFnZUl0ZW1zVmlldyBsZWF2ZXMgaXQg aW5jb25zaXN0ZW50IHN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTEwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgdmlldyBtdXN0IGJlIGNoZWNrZWQgZm9yIGFsbCB0aGUgcm93cyB3aXRo IHRoZSBtYXRjaGluZyBrZXlzLiBPbmx5IHRoZSBmaXJzdCBvbmUgd291bGQgYmUgdXBkYXRlZAor ICAgICAgICB3aXRoIHRoZSBuZXcgdmFsdWUgd2hpbGUgdGhlIG90aGVycyBtdXN0IGJlIHJlbW92 ZWQgZnJvbSB0aGUgZ3JpZC4gQWxzbyBpbiBjYXNlIHRoZXJlIGFyZSB2YXJpb3VzIGtleS92YWx1 ZQorICAgICAgICBwYWlycywgdGhlIGNoYW5nZWQgbm9kZSBzaG91bGQgYmUgc2VsZWN0ZWQgYW5k IHJldmVhbGVkIGluIHRoZSBncmlkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSByZWxh dGVkIG1pbm9yIGNoYW5nZS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRE9NU3Rv cmFnZUl0ZW1zVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01TdG9yYWdlSXRlbXNW aWV3LnByb3RvdHlwZS5fZG9tU3RvcmFnZUl0ZW1VcGRhdGVkKToKKwogMjAxMy0wMi0yNyAgS2Vp c2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgbW9udGggcG9w dXAgZm9yIG5ldyBjYWxlbmRhciBwaWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRE9NU3RvcmFnZUl0ZW1zVmlldy5qcwppbmRleCBmNWRiMWU5 MWM0ZGVkYTM0NzZjZmIzZGI4MjA4MWQ5MDI4ZDRiYzg0Li5lYmJkODc0MzU3MzZiOTcwYjgyY2Vk YzdlNThiYmIyMmQ0NDdlNDEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RPTVN0b3JhZ2VJdGVtc1ZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9ET01TdG9yYWdlSXRlbXNWaWV3LmpzCkBAIC0xNDIsMTMgKzE0Miwy MCBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUl0ZW1zVmlldy5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgZXZlbnQuY29uc3VtZSh0cnVlKTsKIAorICAgICAgICB2YXIga2V5Rm91bmQgPSBmYWxz ZTsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjaGlsZHJlbi5sZW5ndGg7ICsraSkgewog ICAgICAgICAgICAgdmFyIGNoaWxkTm9kZSA9IGNoaWxkcmVuW2ldOwogICAgICAgICAgICAgaWYg KGNoaWxkTm9kZS5kYXRhLmtleSA9PT0gc3RvcmFnZURhdGEua2V5KSB7CisgICAgICAgICAgICAg ICAgaWYgKGtleUZvdW5kKSB7CisgICAgICAgICAgICAgICAgICAgIHJvb3ROb2RlLnJlbW92ZUNo aWxkKGNoaWxkTm9kZSk7CisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAg ICAgICB9CisgICAgICAgICAgICAgICAga2V5Rm91bmQgPSB0cnVlOwogICAgICAgICAgICAgICAg IGNoaWxkTm9kZS5kYXRhLnZhbHVlID0gc3RvcmFnZURhdGEubmV3VmFsdWU7CiAgICAgICAgICAg ICAgICAgY2hpbGROb2RlLnJlZnJlc2goKTsKKyAgICAgICAgICAgICAgICBjaGlsZE5vZGUuc2Vs ZWN0KCk7CisgICAgICAgICAgICAgICAgY2hpbGROb2RlLnJldmVhbCgpOwogICAgICAgICAgICAg ICAgIHRoaXMuZGVsZXRlQnV0dG9uLnZpc2libGUgPSB0cnVlOwotICAgICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0sCg==