111053 2013-02-28 01:33:43 -0800 Web Inspector: Evaluate removing fallback to old-style $() behavior. 2013-02-28 07:53:38 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED LATER P2 Normal --- 92648 1 mkwst mkwst apavlov graouts joepeck keishi loislo pfeldman pmuellr timothy vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 843872 0 mkwst 2013-02-28 01:33:43 -0800 In https://bugs.webkit.org/show_bug.cgi?id=92648, we changed the behavior of $ and $$ in the console. To ease developers into the change, we added a fallback to the previous behavior, along with console warning. It's been about 6 months since we landed that change. Perhaps we should falling back to the old behavior? 843911 1 190685 mkwst 2013-02-28 02:24:21 -0800 Created attachment 190685 Patch 843914 2 mkwst 2013-02-28 02:26:09 -0800 If there's agreement that it's been long enough for the warning to have done it's work, the attached patch should take care of things. 843945 3 190685 pfeldman 2013-02-28 03:30:01 -0800 Comment on attachment 190685 Patch I don't think the new way is popular enough yet. I'd leave it there for another year - it does not hurt. 843971 4 mkwst 2013-02-28 04:13:04 -0800 *sigh* 844077 5 timothy 2013-02-28 07:53:38 -0800 Some browsers also haven't shipped the original change yet… 190685 2013-02-28 02:24:21 -0800 2013-02-28 03:30:00 -0800 Patch bug-111053-20130228112033.patch text/plain 3458 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkxNmYyZWE0MjlhMjFi NzU1OTRkMjIzOWE3MGEzOTZlMjM2ZmQ1Ny4uOWYyN2QyYzkyZDNmMzA0NGExMTc3OTdiNzRhN2I3 NGQ0MmJiYjU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTI4ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRXZh bHVhdGUgcmVtb3ZpbmcgZmFsbGJhY2sgdG8gb2xkLXN0eWxlICQoKSBiZWhhdmlvci4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA1MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjY0OCwgd2UgY2hhbmdlZCB0aGUKKyAgICAg ICAgYmVoYXZpb3Igb2YgJCBhbmQgJCQgaW4gdGhlIGNvbnNvbGUuIFRvIGVhc2UgZGV2ZWxvcGVy cyBpbnRvIHRoZQorICAgICAgICBjaGFuZ2UsIHdlIGFkZGVkIGEgZmFsbGJhY2sgdG8gdGhlIHBy ZXZpb3VzIGJlaGF2aW9yLCBhbG9uZyB3aXRoCisgICAgICAgIGNvbnNvbGUgd2FybmluZy4KKwor ICAgICAgICBEZXZlbG9wZXJzIGhhdmUgbm93IGJlZW4gdXNpbmcgdGhlIG5ldy1zdHlsZSBtZXRo b2QgZm9yIG1vbnRocworICAgICAgICBhbmQgbW9udGhzLiBJdCBzZWVtcyBsaWtlIGEgc2FmZSB0 aW1lIHRvIHJlbW92ZSB0aGUgZmFsbGJhY2suCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0 ZWRTY3JpcHRTb3VyY2UuanM6CisgICAgICAgICAgICBEcm9wIGZhbGxiYWNrIHRvIG9sZC1zdHls ZSAkKCkgYmVoYXZpb3I7IG9ud2FyZCwgdG8gVGhlIEZ1dHVyZeKEoiEKKwogMjAxMy0wMi0yOCAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlc291cmNlUmVx dWVzdENGTmV0LmNwcCB3b24ndCBjb21waWxlIGFmdGVyIHIxNDQyMTYKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwppbmRleCBhMzhmNzc2NTVl NzJlMzE0MTY3M2IwZmI5YzcxNTAxOTI4OTVlZDRlLi45ZDRhNDc3MTIwZjBkMjEzMzU5NGNjZmE3 MjY2MzE4MTQ2NDU4YzNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5q ZWN0ZWRTY3JpcHRTb3VyY2UuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVj dGVkU2NyaXB0U291cmNlLmpzCkBAIC0xMTY0LDE1ICsxMTY0LDYgQEAgQ29tbWFuZExpbmVBUElJ bXBsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybiBzdGFydC5xdWVyeVNlbGVjdG9y KHNlbGVjdG9yKTsKIAogICAgICAgICB2YXIgcmVzdWx0ID0gaW5zcGVjdGVkV2luZG93LmRvY3Vt ZW50LnF1ZXJ5U2VsZWN0b3Ioc2VsZWN0b3IpOwotICAgICAgICBpZiAocmVzdWx0KQotICAgICAg ICAgICAgcmV0dXJuIHJlc3VsdDsKLSAgICAgICAgaWYgKHNlbGVjdG9yICYmIHNlbGVjdG9yWzBd ICE9PSAiIyIpIHsKLSAgICAgICAgICAgIHJlc3VsdCA9IGluc3BlY3RlZFdpbmRvdy5kb2N1bWVu dC5nZXRFbGVtZW50QnlJZChzZWxlY3Rvcik7Ci0gICAgICAgICAgICBpZiAocmVzdWx0KSB7Ci0g ICAgICAgICAgICAgICAgaW5zcGVjdGVkV2luZG93LmNvbnNvbGUud2FybigiVGhlIGNvbnNvbGUg ZnVuY3Rpb24gJCgpIGhhcyBjaGFuZ2VkIGZyb20gJD1nZXRFbGVtZW50QnlJZChpZCkgdG8gJD1x dWVyeVNlbGVjdG9yKHNlbGVjdG9yKS4gWW91IG1pZ2h0IHRyeSAkKFwiIyVzXCIpIiwgc2VsZWN0 b3IgKTsKLSAgICAgICAgICAgICAgICByZXR1cm4gbnVsbDsKLSAgICAgICAgICAgIH0KLSAgICAg ICAgfQogICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0sCiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2ZWE2ZDQ5Mjdl Y2I2ZGNiZGJhMzNkZjVkMjc4MGViZmFiMGQyOTA2Li5kY2QyNzQ4NGJkYWFiMmIzYmY0ZGMyYmM0 YTA1NmQzZTRmNGVmMzRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMDItMjggIE1pa2Ug V2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBFdmFs dWF0ZSByZW1vdmluZyBmYWxsYmFjayB0byBvbGQtc3R5bGUgJCgpIGJlaGF2aW9yLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMDUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY29u c29sZS9jb21tYW5kLWxpbmUtYXBpLWV4cGVjdGVkLnR4dDoKKwogMjAxMy0wMi0yOCAgVGFrYXNo aSBUb3lvc2hpbWEgIDx0b3lvc2hpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBnYXJkZW5pbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2Nv bW1hbmQtbGluZS1hcGktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNv bGUvY29tbWFuZC1saW5lLWFwaS1leHBlY3RlZC50eHQKaW5kZXggYTM4MGRmNGRiMGVlMWZlNTRl MjE1MjhmZjQzODcwMjA1ZDgxZjMwMi4uMWVhNzFjMDEzMTFkNjJiYjBjNDdhN2RmN2FiNzMyMzdh ZTU2M2RjNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29tbWFu ZC1saW5lLWFwaS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNv bGUvY29tbWFuZC1saW5lLWFwaS1leHBlY3RlZC50eHQKQEAgLTEsNCArMSwzIEBACi1DT05TT0xF IE1FU1NBR0U6IGxpbmUgMTE3MjogVGhlIGNvbnNvbGUgZnVuY3Rpb24gJCgpIGhhcyBjaGFuZ2Vk IGZyb20gJD1nZXRFbGVtZW50QnlJZChpZCkgdG8gJD1xdWVyeVNlbGVjdG9yKHNlbGVjdG9yKS4g WW91IG1pZ2h0IHRyeSAkKCIjJXMiKQogVGVzdHMgdGhhdCBjb21tYW5kIGxpbmUgYXBpIHdvcmtz LgogCiAKQEAgLTQ0LDUgKzQzLDUgQEAgU3RyaW5nKCQkKCdwI2ZvbycsIGRvY3VtZW50LmJvZHkp KQogCiAKIFN0cmluZygkKCdmb28nKSkKLVRoZSBjb25zb2xlIGZ1bmN0aW9uICQoKSBoYXMgY2hh bmdlZCBmcm9tICQ9Z2V0RWxlbWVudEJ5SWQoaWQpIHRvICQ9cXVlcnlTZWxlY3RvcihzZWxlY3Rv cikuIFlvdSBtaWdodCB0cnkgJCgiI2ZvbyIpCisibnVsbCIKIAo=