111049 2013-02-28 01:00:43 -0800 Cleanup: XSSAuditor form[action] tests should be manually executable. 2013-02-28 02:09:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P5 Trivial --- 1 mkwst mkwst dbates webkit.review.bot oldest_to_newest 843847 0 mkwst 2013-02-28 01:00:43 -0800 XSSAuditor form[action] tests should be manually executable. 843849 1 190674 mkwst 2013-02-28 01:03:36 -0800 Created attachment 190674 Patch 843852 2 mkwst 2013-02-28 01:06:14 -0800 Following up on dbates' recommendation in https://bugs.webkit.org/show_bug.cgi?id=110975, I'm splitting out this drive-by nit into a separate patch. In the future, migrating these tests to 'js-test-pre.js' seems like a good thing to do, but for the moment, simply ensuring that they work correctly when run manually is worthwhile (and trivial). 843870 3 190674 dbates 2013-02-28 01:32:02 -0800 Comment on attachment 190674 Patch Thank you Mike for splitting this off into a separate patch. 843876 4 mkwst 2013-02-28 01:34:22 -0800 (In reply to comment #3) > (From update of attachment 190674 [details]) > Thank you Mike for splitting this off into a separate patch. Tiny patches are cheap. :) Thanks for taking a look! 843903 5 190674 webkit.review.bot 2013-02-28 02:09:23 -0800 Comment on attachment 190674 Patch Clearing flags on attachment: 190674 Committed r144282: <http://trac.webkit.org/changeset/144282> 843904 6 webkit.review.bot 2013-02-28 02:09:26 -0800 All reviewed patches have been landed. Closing bug. 190674 2013-02-28 01:03:36 -0800 2013-02-28 02:09:23 -0800 Patch bug-111049-20130228095948.patch text/plain 1727 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjY5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWM5OWE3YmNhZmY5MzEyOGRkMjc0 NGY3ZDE2OTA2OGFkMDEyOTE5OC4uMjAwMzM5ZGVjNjMyODJiYjRhMmY5MjRiOGUzZWU5OTI5Mjc5 MWVjYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI4ICBNaWtlIFdlc3QgIDxta3dz dEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2xlYW51cDogWFNTQXVkaXRvcidzIGZvcm1bYWN0 aW9uXSB0ZXN0cyBzaG91bGQgYmUgbWFudWFsbHkgZXhlY3V0YWJsZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTA0OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRseSBjaGVjayB3aGV0 aGVyIHdlJ3JlIHJ1bm5pbmcgaW4gYSBEUlQtbGlrZSB3b3JsZCBiZWZvcmUKKyAgICAgICAgY3Jl YXRpbmcgdXNlci12aXNpYmxlIG91dHB1dCBmb3IgWFNTQXVkaXRvcidzIGZvcm1bYWN0aW9uXSB0 ZXN0cy4gVGhpcworICAgICAgICBwYXRjaCByZW1vdmVzIHRoYXQgcmVzdHJpY3Rpb24gaW4gb3Jk ZXIgdG8gYWxsb3cgbWFudWFsbHktcnVuIHRlc3RzCisgICAgICAgIHRvIHNob3cgc29tZSByZWFz b25hYmxlIG91dHB1dC4KKworICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkveHNzQXVkaXRv ci9yZXNvdXJjZXMvZWNoby1pbnRlcnRhZy5wbDoKKyAgICAgICAgICAgIERyb3AgdGhlICdpZiAo d2luZG93LnRlc3RSdW5uZXIpJyBmcm9tIHRoZSAnc2hvd0FjdGlvbicgYnJhbmNoIGluCisgICAg ICAgICAgICBvcmRlciB0byBhbGxvdyBtYW51YWxseSBydW5uaW5nIHRoZSB0ZXN0LgorCiAyMDEz LTAyLTI4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQXBwYXJl bnRseSBGYWlsdXJlIGRvZXMgbm90IGluY2x1ZGUgSW1hZ2VPbmx5RmFpbHVyZS4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkveHNzQXVkaXRvci9yZXNvdXJjZXMv ZWNoby1pbnRlcnRhZy5wbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkveHNzQXVk aXRvci9yZXNvdXJjZXMvZWNoby1pbnRlcnRhZy5wbAppbmRleCA2ZGY0YzM2MjFlNTU1ZDliNTI3 ZDM0NjczYzIzMzFkOGNjYzJkNzAwLi45M2VjZTQ1YWEyNjkwYjM2NDAzNWFhYThlN2JlY2ZiMDRk YjljNzdkIDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzc0F1 ZGl0b3IvcmVzb3VyY2VzL2VjaG8taW50ZXJ0YWcucGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9zZWN1cml0eS94c3NBdWRpdG9yL3Jlc291cmNlcy9lY2hvLWludGVydGFnLnBsCkBAIC05 NCw3ICs5NCw2IEBAIGlmICgkY2dpLT5wYXJhbSgncTInKSkgewogfQogaWYgKCRjZ2ktPnBhcmFt KCdzaG93QWN0aW9uJykpIHsKICAgICBwcmludCAiPHNjcmlwdD5cbiI7Ci0gICAgcHJpbnQgImlm ICh3aW5kb3cudGVzdFJ1bm5lcilcbiI7CiAgICAgcHJpbnQgIiAgICBhbGVydCgnRm9ybSBhY3Rp b24gc2V0IHRvICcgKyBkb2N1bWVudC5mb3Jtc1swXS5hY3Rpb24pO1xuIjsKICAgICBwcmludCAi PC9zY3JpcHQ+XG4iOwogfQo=