111037 2013-02-27 21:22:09 -0800 PerfTestRunner doesn't need _needs_http and _has_http_lock 2016-11-02 14:53:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 77037 1 rniwa webkit-unassigned abarth benjamin dpranke oldest_to_newest 843698 0 rniwa 2013-02-27 21:22:09 -0800 PerfTestRunner has _has_http_lock and _has_http_lock but they're only used in run() and two functions that are called by run(). We can easily eliminate these member variables. 843700 1 190647 rniwa 2013-02-27 21:25:39 -0800 Created attachment 190647 Cleanup 843793 2 190647 abarth 2013-02-27 23:43:02 -0800 Comment on attachment 190647 Cleanup ok 190647 2013-02-27 21:25:39 -0800 2016-11-02 14:53:45 -0700 Cleanup fix111037 text/plain 3183 rniwa SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3Rz cnVubmVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFu Y2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5CShyZXZpc2lvbiAxNDMzMDQpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQkod29y a2luZyBjb3B5KQpAQCAtNjcsOCArNjcsNiBAQAogICAgICAgICBzZWxmLl9iYXNlX3BhdGggPSBz ZWxmLl9wb3J0LnBlcmZfdGVzdHNfZGlyKCkKICAgICAgICAgc2VsZi5fcmVzdWx0cyA9IHt9CiAg ICAgICAgIHNlbGYuX3RpbWVzdGFtcCA9IHRpbWUudGltZSgpCi0gICAgICAgIHNlbGYuX25lZWRz X2h0dHAgPSBOb25lCi0gICAgICAgIHNlbGYuX2hhc19odHRwX2xvY2sgPSBGYWxzZQogCiAgICAg QHN0YXRpY21ldGhvZAogICAgIGRlZiBfcGFyc2VfYXJncyhhcmdzPU5vbmUpOgpAQCAtMTYwLDIx ICsxNTgsMTggQEAKIAogICAgICAgICByZXR1cm4gdGVzdHMKIAotICAgIGRlZiBfc3RhcnRfc2Vy dmVycyhzZWxmKToKLSAgICAgICAgaWYgc2VsZi5fbmVlZHNfaHR0cDoKLSAgICAgICAgICAgIHNl bGYuX3BvcnQuYWNxdWlyZV9odHRwX2xvY2soKQotICAgICAgICAgICAgc2VsZi5fcG9ydC5zdGFy dF9odHRwX3NlcnZlcihudW1iZXJfb2Zfc2VydmVycz0yKQotICAgICAgICAgICAgc2VsZi5faGFz X2h0dHBfbG9jayA9IFRydWUKKyAgICBkZWYgX3N0YXJ0X2h0dHBfc2VydmVycyhzZWxmKToKKyAg ICAgICAgc2VsZi5fcG9ydC5hY3F1aXJlX2h0dHBfbG9jaygpCisgICAgICAgIHNlbGYuX3BvcnQu c3RhcnRfaHR0cF9zZXJ2ZXIobnVtYmVyX29mX3NlcnZlcnM9MikKIAotICAgIGRlZiBfc3RvcF9z ZXJ2ZXJzKHNlbGYpOgotICAgICAgICBpZiBzZWxmLl9oYXNfaHR0cF9sb2NrOgotICAgICAgICAg ICAgc2VsZi5fcG9ydC5zdG9wX2h0dHBfc2VydmVyKCkKLSAgICAgICAgICAgIHNlbGYuX3BvcnQu cmVsZWFzZV9odHRwX2xvY2soKQorICAgIGRlZiBfc3RvcF9odHRwX3NlcnZlcnMoc2VsZik6Cisg ICAgICAgIHNlbGYuX3BvcnQuc3RvcF9odHRwX3NlcnZlcigpCisgICAgICAgIHNlbGYuX3BvcnQu cmVsZWFzZV9odHRwX2xvY2soKQogCiAgICAgZGVmIHJ1bihzZWxmKToKLSAgICAgICAgc2VsZi5f bmVlZHNfaHR0cCA9IHNlbGYuX3BvcnQucmVxdWlyZXNfaHR0cF9zZXJ2ZXIoKQorICAgICAgICBu ZWVkc19odHRwID0gc2VsZi5fcG9ydC5yZXF1aXJlc19odHRwX3NlcnZlcigpCiAKLSAgICAgICAg aWYgbm90IHNlbGYuX3BvcnQuY2hlY2tfYnVpbGQobmVlZHNfaHR0cD1zZWxmLl9uZWVkc19odHRw KToKKyAgICAgICAgaWYgbm90IHNlbGYuX3BvcnQuY2hlY2tfYnVpbGQobmVlZHNfaHR0cD1uZWVk c19odHRwKToKICAgICAgICAgICAgIF9sb2cuZXJyb3IoIkJ1aWxkIG5vdCB1cCB0byBkYXRlIGZv ciAlcyIgJSBzZWxmLl9wb3J0Ll9wYXRoX3RvX2RyaXZlcigpKQogICAgICAgICAgICAgcmV0dXJu IHNlbGYuRVhJVF9DT0RFX0JBRF9CVUlMRAogCkBAIC0xODYsMTEgKzE4MSwxMyBAQAogICAgICAg ICAgICAgICAgIHJldHVybiBzZWxmLkVYSVRfQ09ERV9CQURfUFJFUEFSQVRJT04KIAogICAgICAg ICB0cnk6Ci0gICAgICAgICAgICBzZWxmLl9zdGFydF9zZXJ2ZXJzKCkKKyAgICAgICAgICAgIGlm IG5lZWRzX2h0dHA6CisgICAgICAgICAgICAgICAgc2VsZi5fc3RhcnRfaHR0cF9zZXJ2ZXJzKCkK ICAgICAgICAgICAgIHVuZXhwZWN0ZWQgPSBzZWxmLl9ydW5fdGVzdHNfc2V0KHNvcnRlZChsaXN0 KHRlc3RzKSwga2V5PWxhbWJkYSB0ZXN0OiB0ZXN0LnRlc3RfbmFtZSgpKSwgc2VsZi5fcG9ydCkK IAogICAgICAgICBmaW5hbGx5OgotICAgICAgICAgICAgc2VsZi5fc3RvcF9zZXJ2ZXJzKCkKKyAg ICAgICAgICAgIGlmIG5lZWRzX2h0dHA6CisgICAgICAgICAgICAgICAgc2VsZi5fc3RvcF9odHRw X3NlcnZlcnMoKQogCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMuZ2VuZXJhdGVfcmVzdWx0cyBh bmQgbm90IHNlbGYuX29wdGlvbnMucHJvZmlsZToKICAgICAgICAgICAgIGV4aXRfY29kZSA9IHNl bGYuX2dlbmVyYXRlX2FuZF9zaG93X3Jlc3VsdHMoKQpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ0MjYwKQorKysgVG9vbHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTMtMDItMjcgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUGVyZlRlc3RSdW5uZXIg ZG9lc24ndCBuZWVkIF9uZWVkc19odHRwIGFuZCBfaGFzX2h0dHBfbG9jaworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMDM3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVsZXRlIHRoZXNlIHZhcmlhYmxl cyBpbiBmYXZvciBvZiB1c2luZyBhIGxvY2FsIHZhcmlhYmxlLgorCisgICAgICAgIE1lbWJlciB2 YXJpYWJsZXMgYXJlIGxpa2UgZ2xvYmFsIHZhcmlhYmxlcy4gVGhleSBpbnRyb2R1Y2UgaW1wbGlj aXQgZGVwZW5kZW5jaWVzCisgICAgICAgIGJldHdlZW4gbWVtYmVyIGZ1bmN0aW9ucy4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVy LnB5OgorICAgICAgICAoUGVyZlRlc3RzUnVubmVyLl9faW5pdF9fKToKKyAgICAgICAgKFBlcmZU ZXN0c1J1bm5lci5fc3RhcnRfaHR0cF9zZXJ2ZXJzKToKKyAgICAgICAgKFBlcmZUZXN0c1J1bm5l cik6CisgICAgICAgIChQZXJmVGVzdHNSdW5uZXIuX3N0b3BfaHR0cF9zZXJ2ZXJzKToKKyAgICAg ICAgKFBlcmZUZXN0c1J1bm5lci5ydW4pOgorCiAyMDEzLTAyLTI3ICBLaXJhbiBNdXBwYWxhICA8 Y211cHBhbGFAYXBwbGUuY29tPgogCiAgICAgICAgIEluaXRpYWxpemUgcGFnZSB2aXNpYmlsaXR5 IGFmdGVyIGNyZWF0aW5nIFdlYktpdFRlc3RSdW5uZXIgV2ViVmlldyBvbiBNYWMK