111036 2013-02-27 21:16:44 -0800 Web Inspector: Empty attribute name/value pair added in Elements panel should be removed 2014-12-13 10:40:09 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED MOVED P2 Normal --- 1 vivekg vivekg apavlov burg keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 843693 0 vivekg 2013-02-27 21:16:44 -0800 Steps: 1. Open the Elements panel 2. Try adding a new attribute using either way i.e. context menu, pressing tab key etc. 3. See that an editor is presented for editing the attribute name, value pair 4. Without any text change, simply commit the change by pressing either enter key or focus out event. 5. Repeat this for 4-5 times. Acutal outcome: The tree outline is shown with the empty spaces. Expected outcome: If the attribute name/value pair contents are empty, the list item in the elements tree outline shouldn't be shown with white spaces. Patch follows. 843696 1 190646 vivekg 2013-02-27 21:19:34 -0800 Created attachment 190646 Patch 844905 2 190646 pfeldman 2013-03-01 01:14:01 -0800 Comment on attachment 190646 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190646&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:-1057 > - I try to not mix changes to semantics with formatting changes. > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1551 > + if (attributeName.trim().length === 0 && newText.trim().length === 0) You should move this check to above the representedObject.setAttribute call to further emphasize you don't call setAttribute in that case. Also, moveToNextAttribute should be the last line of this method since it is a completion callback. 844916 3 190646 vivekg 2013-03-01 01:21:13 -0800 Comment on attachment 190646 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190646&action=review Thank you Pavel. >> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:-1057 >> - > > I try to not mix changes to semantics with formatting changes. Its my Sublime settings to auto trim the trailing spaces which caused these changes. Sure I will disable them. >> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1551 >> + if (attributeName.trim().length === 0 && newText.trim().length === 0) > > You should move this check to above the representedObject.setAttribute call to further emphasize you don't call setAttribute in that case. Also, moveToNextAttribute should be the last line of this method since it is a completion callback. Sure. 844960 4 190914 vivekg 2013-03-01 02:33:08 -0800 Created attachment 190914 Patch 844968 5 190914 pfeldman 2013-03-01 02:45:13 -0800 Comment on attachment 190914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190914&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1588 > + if (attributeName.trim().length === 0 && newText.trim().length === 0) it'd be great if it was showing that setAttribute is not called: if (!attributeName.trim() && !newText.trim()) { element.removeSelf(); moveToNextAttributeIfNeeded.call(this); return; } if (oldText !== newText) { this.representedObject.setAttribute(attributeName, newText, moveToNextAttributeIfNeeded.bind(this)); return; } moveToNextAttributeIfNeeded.call(this); 845004 6 190917 vivekg 2013-03-01 02:56:59 -0800 Created attachment 190917 Patch 845006 7 190917 vivekg 2013-03-01 02:59:00 -0800 Comment on attachment 190917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190917&action=review > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1590 > + if (!emptyNameValuePair && (oldText !== newText)) I understand, we use the early bailout, but I thought this is mostly the first block which would be hit most of the times. Hence added the '!' case first. 845008 8 190917 pfeldman 2013-03-01 03:06:21 -0800 Comment on attachment 190917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190917&action=review >> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1590 >> + if (!emptyNameValuePair && (oldText !== newText)) > > I understand, we use the early bailout, but I thought this is mostly the first block which would be hit most of the times. Hence added the '!' case first. To my taste, these nested conditions referring to the emptyNameValuePair are the opposite of readability. The three guards that I was suggesting are way more user-friendly. 845011 9 190919 vivekg 2013-03-01 03:08:58 -0800 Created attachment 190919 Patch 845013 10 vivekg 2013-03-01 03:09:53 -0800 (In reply to comment #8) > To my taste, these nested conditions referring to the emptyNameValuePair are the opposite of readability. The three guards that I was suggesting are way more user-friendly. Agreed. I realized it after submitting the patch. Sorry for these many versions :) 846357 11 190919 apavlov 2013-03-04 05:32:04 -0800 Comment on attachment 190919 Patch Please add a test, as agreed upon over IRC. 870610 12 vivekg 2013-04-07 21:28:34 -0700 (In reply to comment #11) > (From update of attachment 190919 [details]) > Please add a test, as agreed upon over IRC. I was not able to draft a test case correctly for the above case. Can we land this change without the test case as its only a UI related minor feature? 1055436 13 burg 2014-12-13 10:40:09 -0800 Re-filed over here: https://bugs.webkit.org/show_bug.cgi?id=139623 The bug does not occur for multiple spaces any more. 190646 2013-02-27 21:19:34 -0800 2013-03-01 02:33:02 -0800 Patch bug-111036-20130228104653.patch text/plain 3547 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRmNDMzZTE0ZDQ5NjA3 N2QzMjU1YTdhODNhZWEwYjJjOTQ3N2JkYi4uMDA3ZmM1NGM5YzQyZTI1NjM0NWMyYzA0M2VhMjE2 OWRjZmNlOThjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTI3ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEVtcHR5IGF0dHJpYnV0ZSBuYW1lL3ZhbHVlIHBhaXIgYWRkZWQgaW4gRWxlbWVudHMgcGFu ZWwgc2hvdWxkIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIHRoZSBlZGl0ZWQgYXR0cmlidXRlIG5hbWUgYW5kIHRoZSB2YWx1ZSBh cmUgZW1wdHkgaXQgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSB0aGUgbGlzdCBpdGVtCisgICAgICAg IHJlcHJlc2VudGluZyB0aGUgZWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgVUkg cmVsYXRlZCBtaW5vciBjaGFuZ2UuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0Vs ZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVl RWxlbWVudC5wcm90b3R5cGUuZXhwYW5kUmVjdXJzaXZlbHkpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9wb3B1bGF0ZVRhZ0NvbnRleHRNZW51 KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZS5f YXR0cmlidXRlRWRpdGluZ0NvbW1pdHRlZCk6CisKIDIwMTMtMDItMjcgIEtlaXNoaSBIYXR0b3Jp ICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIG1vbnRoIHBvcHVwIGZvciBuZXcg Y2FsZW5kYXIgcGlja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKaW5kZXggMDVkNzRmZDk3M2U0ODA5NzZm YmJkZGE4NzY1Y2FiOWYxNWRmNGVhYi4uMmI3ZTI2Y2RjZWM2OWQ1M2JmYmYwMTYyNDI0MmY0Njdk N2Y2ZmViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwpAQCAtMTA1NCw3ICsxMDU0LDcgQEAgV2ViSW5z cGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgICAgICB7CiAgICAg ICAgICAgICBUcmVlRWxlbWVudC5wcm90b3R5cGUuZXhwYW5kUmVjdXJzaXZlbHkuY2FsbCh0aGlz LCBOdW1iZXIuTUFYX1ZBTFVFKTsKICAgICAgICAgfQotICAgICAgICAKKwogICAgICAgICB0aGlz LnJlcHJlc2VudGVkT2JqZWN0LmdldFN1YnRyZWUoLTEsIGNhbGxiYWNrLmJpbmQodGhpcykpOwog ICAgIH0sCiAKQEAgLTEyMTAsNyArMTIxMCw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVF bGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy50cmVlT3V0bGluZS5fcG9wdWxhdGVD b250ZXh0TWVudShjb250ZXh0TWVudSwgdGhpcy5yZXByZXNlbnRlZE9iamVjdCk7CiAKICAgICAg ICAgY29udGV4dE1lbnUuYXBwZW5kU2VwYXJhdG9yKCk7Ci0gICAgICAgIGNvbnRleHRNZW51LmFw cGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKFdlYkluc3BlY3Rvci51c2VMb3dlckNhc2VN ZW51VGl0bGVzKCkgPyAiU2Nyb2xsIGludG8gdmlldyIgOiAiU2Nyb2xsIEludG8gVmlldyIpLCB0 aGlzLl9zY3JvbGxJbnRvVmlldy5iaW5kKHRoaXMpKTsgCisgICAgICAgIGNvbnRleHRNZW51LmFw cGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKFdlYkluc3BlY3Rvci51c2VMb3dlckNhc2VN ZW51VGl0bGVzKCkgPyAiU2Nyb2xsIGludG8gdmlldyIgOiAiU2Nyb2xsIEludG8gVmlldyIpLCB0 aGlzLl9zY3JvbGxJbnRvVmlldy5iaW5kKHRoaXMpKTsKICAgICB9LAogCiAgICAgX3BvcHVsYXRl Rm9yY2VkUHNldWRvU3RhdGVJdGVtczogZnVuY3Rpb24oc3ViTWVudSkKQEAgLTEzMjMsNyArMTMy Myw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAg ICAgICAgcmVtb3ZlWmVyb1dpZHRoU3BhY2VSZWN1cnNpdmUoYXR0cmlidXRlKTsKIAogICAgICAg ICB2YXIgY29uZmlnID0gbmV3IFdlYkluc3BlY3Rvci5FZGl0aW5nQ29uZmlnKHRoaXMuX2F0dHJp YnV0ZUVkaXRpbmdDb21taXR0ZWQuYmluZCh0aGlzKSwgdGhpcy5fZWRpdGluZ0NhbmNlbGxlZC5i aW5kKHRoaXMpLCBhdHRyaWJ1dGVOYW1lKTsKLSAgICAgICAgCisKICAgICAgICAgZnVuY3Rpb24g aGFuZGxlS2V5RG93bkV2ZW50cyhldmVudCkKICAgICAgICAgewogICAgICAgICAgICAgdmFyIGlz TWV0YU9yQ3RybCA9IFdlYkluc3BlY3Rvci5pc01hYygpID8KQEAgLTE1NDcsNiArMTU0Nyw5IEBA IFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgIHRoaXMucmVwcmVzZW50ZWRPYmplY3Quc2V0QXR0cmlidXRlKGF0dHJpYnV0ZU5hbWUsIG5l d1RleHQsIG1vdmVUb05leHRBdHRyaWJ1dGVJZk5lZWRlZC5iaW5kKHRoaXMpKTsKICAgICAgICAg ZWxzZQogICAgICAgICAgICAgbW92ZVRvTmV4dEF0dHJpYnV0ZUlmTmVlZGVkLmNhbGwodGhpcyk7 CisKKyAgICAgICAgaWYgKGF0dHJpYnV0ZU5hbWUudHJpbSgpLmxlbmd0aCA9PT0gMCAmJiBuZXdU ZXh0LnRyaW0oKS5sZW5ndGggPT09IDApCisgICAgICAgICAgICBlbGVtZW50LnBhcmVudEVsZW1l bnQucmVtb3ZlQ2hpbGQoZWxlbWVudCk7CiAgICAgfSwKIAogICAgIF90YWdOYW1lRWRpdGluZ0Nv bW1pdHRlZDogZnVuY3Rpb24oZWxlbWVudCwgbmV3VGV4dCwgb2xkVGV4dCwgdGFnTmFtZSwgbW92 ZURpcmVjdGlvbikKQEAgLTIwMzYsNyArMjAzOSw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1Ry ZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGlmIChvYmplY3QpCiAgICAgICAg ICAgICAgICAgb2JqZWN0LmNhbGxGdW5jdGlvbihzY3JvbGxJbnRvVmlldyk7CiAgICAgICAgIH0K LSAgICAgICAgCisKICAgICAgICAgdmFyIG5vZGUgPSAvKiogQHR5cGUge1dlYkluc3BlY3Rvci5E T01Ob2RlfSAqLyAodGhpcy5yZXByZXNlbnRlZE9iamVjdCk7CiAgICAgICAgIFdlYkluc3BlY3Rv ci5SZW1vdGVPYmplY3QucmVzb2x2ZU5vZGUobm9kZSwgIiIsIHNjcm9sbEludG9WaWV3Q2FsbGJh Y2spOwogICAgIH0sCg== 190914 2013-03-01 02:33:08 -0800 2013-03-01 02:56:54 -0800 Patch bug-111036-20130301160025.patch text/plain 1686 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZlOTZhYmFjM2M3NDdl YTIwYjE1YWM3MWE1OWNhYTlhMGQ0MWEwZi4uZTRkYTJiYTk0ZGRkZWZhYTQxY2NmODUwMDE3Y2Y5 NTMyOWZlOTBhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTAxICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEVtcHR5IGF0dHJpYnV0ZSBuYW1lL3ZhbHVlIHBhaXIgYWRkZWQgaW4gRWxlbWVudHMgcGFu ZWwgc2hvdWxkIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIHRoZSBlZGl0ZWQgYXR0cmlidXRlIG5hbWUgYW5kIHRoZSB2YWx1ZSBh cmUgZW1wdHkgaXQgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSB0aGUgbGlzdCBpdGVtCisgICAgICAg IHJlcHJlc2VudGluZyB0aGUgZWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgVUkg cmVsYXRlZCBtaW5vciBjaGFuZ2UuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0Vs ZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVl RWxlbWVudC5wcm90b3R5cGUuX2F0dHJpYnV0ZUVkaXRpbmdDb21taXR0ZWQpOgorCiAyMDEzLTAz LTAxICBNaWtlIFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgWFNTQXVkaXRv ciBzaG91bGQgdXNlIHRocmVhZFNhZmVNYXRjaCB3aGVuIHJlbGV2YW50LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5l LmpzCmluZGV4IGI2MmJlZjU2NzgwNzk4NDE0YTJmYzllOGYxYThiNzA1NzIyZjcyZTMuLmZjZTZm NDRiN2FiNzJjNWRkOWMxMWI4NDI3MTM5ZmM1ZDA2NjQ5MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMK QEAgLTE1ODUsNiArMTU4NSw5IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCisgICAgICAgIGlmIChhdHRy aWJ1dGVOYW1lLnRyaW0oKS5sZW5ndGggPT09IDAgJiYgbmV3VGV4dC50cmltKCkubGVuZ3RoID09 PSAwKQorICAgICAgICAgICAgZWxlbWVudC5yZW1vdmVTZWxmKCk7CisKICAgICAgICAgaWYgKG9s ZFRleHQgIT09IG5ld1RleHQpCiAgICAgICAgICAgICB0aGlzLnJlcHJlc2VudGVkT2JqZWN0LnNl dEF0dHJpYnV0ZShhdHRyaWJ1dGVOYW1lLCBuZXdUZXh0LCBtb3ZlVG9OZXh0QXR0cmlidXRlSWZO ZWVkZWQuYmluZCh0aGlzKSk7CiAgICAgICAgIGVsc2UK 190917 2013-03-01 02:56:59 -0800 2013-03-01 03:08:53 -0800 Patch bug-111036-20130301162417.patch text/plain 1968 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZlOTZhYmFjM2M3NDdl YTIwYjE1YWM3MWE1OWNhYTlhMGQ0MWEwZi4uZTRkYTJiYTk0ZGRkZWZhYTQxY2NmODUwMDE3Y2Y5 NTMyOWZlOTBhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTAxICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEVtcHR5IGF0dHJpYnV0ZSBuYW1lL3ZhbHVlIHBhaXIgYWRkZWQgaW4gRWxlbWVudHMgcGFu ZWwgc2hvdWxkIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIHRoZSBlZGl0ZWQgYXR0cmlidXRlIG5hbWUgYW5kIHRoZSB2YWx1ZSBh cmUgZW1wdHkgaXQgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSB0aGUgbGlzdCBpdGVtCisgICAgICAg IHJlcHJlc2VudGluZyB0aGUgZWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgVUkg cmVsYXRlZCBtaW5vciBjaGFuZ2UuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0Vs ZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVl RWxlbWVudC5wcm90b3R5cGUuX2F0dHJpYnV0ZUVkaXRpbmdDb21taXR0ZWQpOgorCiAyMDEzLTAz LTAxICBNaWtlIFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgWFNTQXVkaXRv ciBzaG91bGQgdXNlIHRocmVhZFNhZmVNYXRjaCB3aGVuIHJlbGV2YW50LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5l LmpzCmluZGV4IGI2MmJlZjU2NzgwNzk4NDE0YTJmYzllOGYxYThiNzA1NzIyZjcyZTMuLmJiYTQ5 Y2IwZDM0ZTI5N2I4OWMzZTk4YTI3ZGIwOWY3ODUwMGFiZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMK QEAgLTE1ODUsMTAgKzE1ODUsMTUgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQu cHJvdG90eXBlID0gewogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgaWYgKG9s ZFRleHQgIT09IG5ld1RleHQpCisgICAgICAgIHZhciBlbXB0eU5hbWVWYWx1ZVBhaXIgPSAoIWF0 dHJpYnV0ZU5hbWUudHJpbSgpICYmICFuZXdUZXh0LnRyaW0oKSk7CisKKyAgICAgICAgaWYgKCFl bXB0eU5hbWVWYWx1ZVBhaXIgJiYgKG9sZFRleHQgIT09IG5ld1RleHQpKQogICAgICAgICAgICAg dGhpcy5yZXByZXNlbnRlZE9iamVjdC5zZXRBdHRyaWJ1dGUoYXR0cmlidXRlTmFtZSwgbmV3VGV4 dCwgbW92ZVRvTmV4dEF0dHJpYnV0ZUlmTmVlZGVkLmJpbmQodGhpcykpOwotICAgICAgICBlbHNl CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgaWYgKGVtcHR5TmFtZVZhbHVlUGFpcikKKyAg ICAgICAgICAgICAgICBlbGVtZW50LnJlbW92ZVNlbGYoKTsKICAgICAgICAgICAgIG1vdmVUb05l eHRBdHRyaWJ1dGVJZk5lZWRlZC5jYWxsKHRoaXMpOworICAgICAgICB9CiAgICAgfSwKIAogICAg IF90YWdOYW1lRWRpdGluZ0NvbW1pdHRlZDogZnVuY3Rpb24oZWxlbWVudCwgbmV3VGV4dCwgb2xk VGV4dCwgdGFnTmFtZSwgbW92ZURpcmVjdGlvbikK 190919 2013-03-01 03:08:58 -0800 2013-03-04 05:32:04 -0800 Patch bug-111036-20130301163616.patch text/plain 2085 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZlOTZhYmFjM2M3NDdl YTIwYjE1YWM3MWE1OWNhYTlhMGQ0MWEwZi4uZTRkYTJiYTk0ZGRkZWZhYTQxY2NmODUwMDE3Y2Y5 NTMyOWZlOTBhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTAxICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEVtcHR5IGF0dHJpYnV0ZSBuYW1lL3ZhbHVlIHBhaXIgYWRkZWQgaW4gRWxlbWVudHMgcGFu ZWwgc2hvdWxkIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIHRoZSBlZGl0ZWQgYXR0cmlidXRlIG5hbWUgYW5kIHRoZSB2YWx1ZSBh cmUgZW1wdHkgaXQgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSB0aGUgbGlzdCBpdGVtCisgICAgICAg IHJlcHJlc2VudGluZyB0aGUgZWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgVUkg cmVsYXRlZCBtaW5vciBjaGFuZ2UuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0Vs ZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVl RWxlbWVudC5wcm90b3R5cGUuX2F0dHJpYnV0ZUVkaXRpbmdDb21taXR0ZWQpOgorCiAyMDEzLTAz LTAxICBNaWtlIFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgWFNTQXVkaXRv ciBzaG91bGQgdXNlIHRocmVhZFNhZmVNYXRjaCB3aGVuIHJlbGV2YW50LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpz IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5l LmpzCmluZGV4IGI2MmJlZjU2NzgwNzk4NDE0YTJmYzllOGYxYThiNzA1NzIyZjcyZTMuLmEzOTI1 YjY3YWEzYzFmODZhOTU4MjMwNzM2NjIwNmRmZDQwNGM1MDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMK QEAgLTE1ODUsMTAgKzE1ODUsMTggQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQu cHJvdG90eXBlID0gewogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgaWYgKG9s ZFRleHQgIT09IG5ld1RleHQpCi0gICAgICAgICAgICB0aGlzLnJlcHJlc2VudGVkT2JqZWN0LnNl dEF0dHJpYnV0ZShhdHRyaWJ1dGVOYW1lLCBuZXdUZXh0LCBtb3ZlVG9OZXh0QXR0cmlidXRlSWZO ZWVkZWQuYmluZCh0aGlzKSk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgaWYgKCFhdHRyaWJ1dGVO YW1lLnRyaW0oKSAmJiAhbmV3VGV4dC50cmltKCkpIHsKKyAgICAgICAgICAgIGVsZW1lbnQucmVt b3ZlU2VsZigpOwogICAgICAgICAgICAgbW92ZVRvTmV4dEF0dHJpYnV0ZUlmTmVlZGVkLmNhbGwo dGhpcyk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBpZiAob2xk VGV4dCAhPT0gbmV3VGV4dCkgeworICAgICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5z ZXRBdHRyaWJ1dGUoYXR0cmlidXRlTmFtZSwgbmV3VGV4dCwgbW92ZVRvTmV4dEF0dHJpYnV0ZUlm TmVlZGVkLmJpbmQodGhpcykpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAg ICAgICAgbW92ZVRvTmV4dEF0dHJpYnV0ZUlmTmVlZGVkLmNhbGwodGhpcyk7CiAgICAgfSwKIAog ICAgIF90YWdOYW1lRWRpdGluZ0NvbW1pdHRlZDogZnVuY3Rpb24oZWxlbWVudCwgbmV3VGV4dCwg b2xkVGV4dCwgdGFnTmFtZSwgbW92ZURpcmVjdGlvbikK