111032 2013-02-27 20:21:57 -0800 [BlackBerry] User credentials are not correctly handled for non-browser usage 2013-02-28 07:16:36 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 liachen liachen joenotcharles leoyang mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 843663 0 liachen 2013-02-27 20:21:57 -0800 In BlackBerry, some applications have no access to BlackBerry CertMgr, these application will save user credentials into their own database using SQLiteStatement. But SQLiteStatement::bindBlob cannot handle the encrypted password as a normal WTF::String correctly. We need to use the encrypted password as 8bit string when calling bSQLiteStatement::indBlob(). 843671 1 190640 liachen 2013-02-27 20:34:11 -0800 Created attachment 190640 patch for 111032. 844054 2 190640 webkit.review.bot 2013-02-28 07:16:32 -0800 Comment on attachment 190640 patch for 111032. Clearing flags on attachment: 190640 Committed r144307: <http://trac.webkit.org/changeset/144307> 844055 3 webkit.review.bot 2013-02-28 07:16:36 -0800 All reviewed patches have been landed. Closing bug. 190640 2013-02-27 20:34:11 -0800 2013-02-28 07:16:32 -0800 patch for 111032. 111032.patch text/plain 2991 liachen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YjhmMGI5Li45YWY5MmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDItMjcgIExpYW5naHVpIENoZW4gIDxsaWFjaGVuQHJpbS5jb20+CisKKyAgICAg ICAgW0JsYWNrQmVycnldIFVzZXIgY3JlZGVudGlhbHMgYXJlIG5vdCBjb3JyZWN0bHkgaGFuZGxl ZCBmb3Igbm9uLWJyb3dzZXIgdXNhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTAzMgorCisgICAgICAgIEludGVybmFsIFBSOiAyOTUxODEKKyAg ICAgICAgSW50ZXJuYWwgcmV2aWV3ZWQgYnkgSm9lIE1hc29uLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBlbmNyeXB0ZWQgcGFzc3dvcmQgYXMg YmluYXJ5IGRhdGEgd2hlbiBjYWxsaW5nIFNRTGl0ZVN0YXRlbWVudDo6YmluZEJsb2IoKSwgaW4K KyAgICAgICAgc3RlYWQgb2YgdXNpbmcgaXQgYXMgYSBub3JtYWwgV1RGOjpTdHJpbmcuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoaXMgY2F1c2VzIG5vIGV4cGVjdGVkIGJlaGF2aW91ciBj aGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvQ3JlZGVudGlh bEJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDcmVkZW50aWFsQmFja2luZ1N0 b3JlOjphZGRMb2dpbik6CisgICAgICAgIChXZWJDb3JlOjpDcmVkZW50aWFsQmFja2luZ1N0b3Jl Ojp1cGRhdGVMb2dpbik6CisKIDIwMTMtMDItMjcgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9i ZS5jb20+CiAKICAgICAgICAgW0NTUyBFeGNsdXNpb25zXSBFbmFibGUgc2hhcGUtaW5zaWRlIHJl Y3RhbmdsZSBzdXBwb3J0IGZvciBzaGFwZS1wYWRkaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvQ3JlZGVudGlhbEJhY2tpbmdTdG9yZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvQ3JlZGVudGlh bEJhY2tpbmdTdG9yZS5jcHAKaW5kZXggMjQ2M2Q3YS4uMGUxOTU4NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L0NyZWRlbnRpYWxCYWNraW5n U3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9DcmVkZW50aWFsQmFja2luZ1N0b3JlLmNwcApAQCAtMTcxLDcgKzE3MSwxMyBAQCBib29sIENy ZWRlbnRpYWxCYWNraW5nU3RvcmU6OmFkZExvZ2luKGNvbnN0IFByb3RlY3Rpb25TcGFjZSYgcHJv dGVjdGlvblNwYWNlLCBjbwogICAgIG1fYWRkTG9naW5TdGF0ZW1lbnQtPmJpbmRUZXh0KDQsIHBy b3RlY3Rpb25TcGFjZS5yZWFsbSgpKTsKICAgICBtX2FkZExvZ2luU3RhdGVtZW50LT5iaW5kSW50 KDUsIHN0YXRpY19jYXN0PGludD4ocHJvdGVjdGlvblNwYWNlLmF1dGhlbnRpY2F0aW9uU2NoZW1l KCkpKTsKICAgICBtX2FkZExvZ2luU3RhdGVtZW50LT5iaW5kVGV4dCg2LCBjcmVkZW50aWFsLnVz ZXIoKSk7Ci0gICAgbV9hZGRMb2dpblN0YXRlbWVudC0+YmluZEJsb2IoNywgY2VydE1ncldyYXBw ZXIoKS0+aXNSZWFkeSgpID8gIiIgOiBlbmNyeXB0ZWRTdHJpbmcoY3JlZGVudGlhbC5wYXNzd29y ZCgpKSk7CisgICAgaWYgKGNlcnRNZ3JXcmFwcGVyKCktPmlzUmVhZHkoKSkKKyAgICAgICAgbV9h ZGRMb2dpblN0YXRlbWVudC0+YmluZEJsb2IoNywgIiIpOworICAgIGVsc2UgeworICAgICAgICBT dHJpbmcgY2lwaGVydGV4dCA9IGVuY3J5cHRlZFN0cmluZyhjcmVkZW50aWFsLnBhc3N3b3JkKCkp OworICAgICAgICBBU1NFUlQoY2lwaGVydGV4dC5pczhCaXQoKSk7CisgICAgICAgIG1fYWRkTG9n aW5TdGF0ZW1lbnQtPmJpbmRCbG9iKDcsIGNpcGhlcnRleHQuY2hhcmFjdGVyczgoKSwgY2lwaGVy dGV4dC5sZW5ndGgoKSk7CisgICAgfQogCiAgICAgaW50IHJlc3VsdCA9IG1fYWRkTG9naW5TdGF0 ZW1lbnQtPnN0ZXAoKTsKICAgICBtX2FkZExvZ2luU3RhdGVtZW50LT5yZXNldCgpOwpAQCAtMTk2 LDcgKzIwMiwxMyBAQCBib29sIENyZWRlbnRpYWxCYWNraW5nU3RvcmU6OnVwZGF0ZUxvZ2luKGNv bnN0IFByb3RlY3Rpb25TcGFjZSYgcHJvdGVjdGlvblNwYWNlLAogICAgICAgICByZXR1cm4gZmFs c2U7CiAKICAgICBtX3VwZGF0ZUxvZ2luU3RhdGVtZW50LT5iaW5kVGV4dCgxLCBjcmVkZW50aWFs LnVzZXIoKSk7Ci0gICAgbV91cGRhdGVMb2dpblN0YXRlbWVudC0+YmluZEJsb2IoMiwgY2VydE1n cldyYXBwZXIoKS0+aXNSZWFkeSgpID8gIiIgOiBlbmNyeXB0ZWRTdHJpbmcoY3JlZGVudGlhbC5w YXNzd29yZCgpKSk7CisgICAgaWYgKGNlcnRNZ3JXcmFwcGVyKCktPmlzUmVhZHkoKSkKKyAgICAg ICAgbV91cGRhdGVMb2dpblN0YXRlbWVudC0+YmluZEJsb2IoMiwgIiIpOworICAgIGVsc2Ugewor ICAgICAgICBTdHJpbmcgY2lwaGVydGV4dCA9IGVuY3J5cHRlZFN0cmluZyhjcmVkZW50aWFsLnBh c3N3b3JkKCkpOworICAgICAgICBBU1NFUlQoY2lwaGVydGV4dC5pczhCaXQoKSk7CisgICAgICAg IG1fdXBkYXRlTG9naW5TdGF0ZW1lbnQtPmJpbmRCbG9iKDIsIGNpcGhlcnRleHQuY2hhcmFjdGVy czgoKSwgY2lwaGVydGV4dC5sZW5ndGgoKSk7CisgICAgfQogICAgIG1fdXBkYXRlTG9naW5TdGF0 ZW1lbnQtPmJpbmRUZXh0KDMsIHByb3RlY3Rpb25TcGFjZS5ob3N0KCkpOwogICAgIG1fdXBkYXRl TG9naW5TdGF0ZW1lbnQtPmJpbmRJbnQoNCwgcHJvdGVjdGlvblNwYWNlLnBvcnQoKSk7CiAgICAg bV91cGRhdGVMb2dpblN0YXRlbWVudC0+YmluZEludCg1LCBzdGF0aWNfY2FzdDxpbnQ+KHByb3Rl Y3Rpb25TcGFjZS5zZXJ2ZXJUeXBlKCkpKTsK