111021 2013-02-27 15:47:42 -0800 Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options 2013-02-27 17:35:45 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 eric eric abarth dpranke rniwa webkit.review.bot oldest_to_newest 843576 0 eric 2013-02-27 15:47:42 -0800 Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options 843577 1 190621 eric 2013-02-27 15:48:29 -0800 Created attachment 190621 Patch 843581 2 190621 dpranke 2013-02-27 15:50:40 -0800 Comment on attachment 190621 Patch looks fine. is there any way to test this (and is it worth it)? 843582 3 eric 2013-02-27 15:51:05 -0800 We still can't meaningfully run most of the perf tests in the threaded parser as they use document.write instead of urls to load, but this at least plumbs the option. 843585 4 dpranke 2013-02-27 15:54:02 -0800 I was more wondering if there's some way to stub out / mock some of the calls just to check that the flag is making it through to the driver. 843588 5 190623 eric 2013-02-27 15:55:16 -0800 Created attachment 190623 Patch for landing 843589 6 eric 2013-02-27 15:56:28 -0800 Good question. Added a very basic test. I didn't see any other tests using a mock driver for run-perf-tests. This option depends on the driver reading the option, rather than pushing it to the driver, making using a mock driver much less useful anyway. We could use a driver with a MockExecutive and that could work, but I decided this was sufficient for now. If you disagree I can revisit. 843591 7 dpranke 2013-02-27 16:01:02 -0800 Ah. I probably wouldn't have bothered with that test, although it is perhaps better than nothing. It looks like it wouldn't be too hard to add something to perftestsrunner_integrationtest.py that does get all the way through to a mocked-out driver, but I don't know if it's really worth it or important since, as you say, the plumbing was already pretty much there. 843594 8 eric 2013-02-27 16:05:50 -0800 I don't think adding flags to DRT is particularly common. I think it should be. :) But I think the threaded parser is the first to do this for a feature in a long time. Next time this comes up we can make this support even more awesome. 843600 9 dpranke 2013-02-27 16:13:49 -0800 If we do start adding more flags to DRT, we should probably at least make --help work :). 843626 10 190623 webkit.review.bot 2013-02-27 17:35:41 -0800 Comment on attachment 190623 Patch for landing Clearing flags on attachment: 190623 Committed r144253: <http://trac.webkit.org/changeset/144253> 843627 11 webkit.review.bot 2013-02-27 17:35:45 -0800 All reviewed patches have been landed. Closing bug. 190621 2013-02-27 15:48:29 -0800 2013-02-27 15:55:14 -0800 Patch bug-111021-20130227154442.patch text/plain 1908 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzkxZGFiMzk0ZGZhZDZhNGE4YjE1NTkyYTg0ZjU1OThh Yzk0ZDJkZi4uNDBhNWFmYjk3MGVhNzM3ODk1NDBhY2I3MmE2YzBkMzk2NzUyZmJlMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAyLTI3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBBZGQgLS1hZGRpdGlvbmFsLWRydC1mbGFnIG9wdGlvbiB0byBydW4tcGVyZi10ZXN0cyB0byBt YWtlIGl0IGVhc3kgdG8gdGVzdCBydW50aW1lIG9wdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTAyMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB1bmRlcmx5aW5nIGNvZGUgKHdoaWNoIGlz IHNoYXJlZCB3aXRoIHJ1bi13ZWJraXQtdGVzdHMpCisgICAgICAgIGFscmVhZHkga25ldyBob3cg dG8gc3VwcG9ydCB0aGlzIG9wdGlvbiwgaXQganVzdCB3YXNuJ3QgZXhwb3NlZAorICAgICAgICB2 aWEgdGhlIHJ1bi1wZXJmLXRlc3RzIGZyb250LWVuZC4gIFRoaXMgcGF0Y2ggZml4ZXMgdGhhdC4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3Rz cnVubmVyLnB5OgorICAgICAgICAoUGVyZlRlc3RzUnVubmVyLl9wYXJzZV9hcmdzKToKKwogMjAx My0wMi0yNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAg IEFYOiBNYWMgcGxhdGZvcm0gc2hvdWxkIHN1cHBvcnQgYWJpbGl0eSB0byBzY3JvbGwgYW4gZWxl bWVudCBpbnRvIHZpc2libGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVy Zm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKaW5kZXggNmFlNmYyZTI3ZDU2 NTk5ZDNlMjA2YTA5NGNlZmYyMTdiZTM4N2VkOS4uMzM5ZGZiMzljYjAzOTgxNjZhNWE5YjdlOGZi MWRiMzg5ZTAwYTA3NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3Jt YW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKQEAgLTEyNCw2ICsxMjQsOSBA QCBjbGFzcyBQZXJmVGVzdHNSdW5uZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICBoZWxwPSJP dXRwdXQgcGVyLXRlc3QgcHJvZmlsZSBpbmZvcm1hdGlvbi4iKSwKICAgICAgICAgICAgIG9wdHBh cnNlLm1ha2Vfb3B0aW9uKCItLXByb2ZpbGVyIiwgYWN0aW9uPSJzdG9yZSIsCiAgICAgICAgICAg ICAgICAgaGVscD0iT3V0cHV0IHBlci10ZXN0IHByb2ZpbGUgaW5mb3JtYXRpb24sIHVzaW5nIHRo ZSBzcGVjaWZpZWQgcHJvZmlsZXIuIiksCisgICAgICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlv bigiLS1hZGRpdGlvbmFsLWRydC1mbGFnIiwgYWN0aW9uPSJhcHBlbmQiLAorICAgICAgICAgICAg ICAgIGRlZmF1bHQ9W10sIGhlbHA9IkFkZGl0aW9uYWwgY29tbWFuZCBsaW5lIGZsYWcgdG8gcGFz cyB0byBEdW1wUmVuZGVyVHJlZSAiCisgICAgICAgICAgICAgICAgICAgICAiU3BlY2lmeSBtdWx0 aXBsZSB0aW1lcyB0byBhZGQgbXVsdGlwbGUgZmxhZ3MuIiksCiAgICAgICAgICAgICBdCiAgICAg ICAgIHJldHVybiBvcHRwYXJzZS5PcHRpb25QYXJzZXIob3B0aW9uX2xpc3Q9KHBlcmZfb3B0aW9u X2xpc3QpKS5wYXJzZV9hcmdzKGFyZ3MpCiAK 190623 2013-02-27 15:55:16 -0800 2013-02-27 17:35:41 -0800 Patch for landing bug-111021-20130227155130.patch text/plain 3227 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MjQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzkxZGFiMzk0ZGZhZDZhNGE4YjE1NTkyYTg0ZjU1OThh Yzk0ZDJkZi4uYTVkOWE3NmZmNWEzZWY3ZTA4ZTUyZDk0MTYyZDZlZWNkMjM5Y2I1MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTAyLTI3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBBZGQgLS1hZGRpdGlvbmFsLWRydC1mbGFnIG9wdGlvbiB0byBydW4tcGVyZi10ZXN0cyB0byBt YWtlIGl0IGVhc3kgdG8gdGVzdCBydW50aW1lIG9wdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTAyMQorCisgICAgICAgIFJldmlld2VkIGJ5 IERpcmsgUHJhbmtlLgorCisgICAgICAgIFRoZSB1bmRlcmx5aW5nIGNvZGUgKHdoaWNoIGlzIHNo YXJlZCB3aXRoIHJ1bi13ZWJraXQtdGVzdHMpCisgICAgICAgIGFscmVhZHkga25ldyBob3cgdG8g c3VwcG9ydCB0aGlzIG9wdGlvbiwgaXQganVzdCB3YXNuJ3QgZXhwb3NlZAorICAgICAgICB2aWEg dGhlIHJ1bi1wZXJmLXRlc3RzIGZyb250LWVuZC4gIFRoaXMgcGF0Y2ggZml4ZXMgdGhhdC4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVu bmVyLnB5OgorICAgICAgICAoUGVyZlRlc3RzUnVubmVyLl9wYXJzZV9hcmdzKToKKwogMjAxMy0w Mi0yNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFY OiBNYWMgcGxhdGZvcm0gc2hvdWxkIHN1cHBvcnQgYWJpbGl0eSB0byBzY3JvbGwgYW4gZWxlbWVu dCBpbnRvIHZpc2libGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVyZm9y bWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w ZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKaW5kZXggNmFlNmYyZTI3ZDU2NTk5 ZDNlMjA2YTA5NGNlZmYyMTdiZTM4N2VkOS4uMzM5ZGZiMzljYjAzOTgxNjZhNWE5YjdlOGZiMWRi Mzg5ZTAwYTA3NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5j ZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w ZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKQEAgLTEyNCw2ICsxMjQsOSBAQCBj bGFzcyBQZXJmVGVzdHNSdW5uZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICBoZWxwPSJPdXRw dXQgcGVyLXRlc3QgcHJvZmlsZSBpbmZvcm1hdGlvbi4iKSwKICAgICAgICAgICAgIG9wdHBhcnNl Lm1ha2Vfb3B0aW9uKCItLXByb2ZpbGVyIiwgYWN0aW9uPSJzdG9yZSIsCiAgICAgICAgICAgICAg ICAgaGVscD0iT3V0cHV0IHBlci10ZXN0IHByb2ZpbGUgaW5mb3JtYXRpb24sIHVzaW5nIHRoZSBz cGVjaWZpZWQgcHJvZmlsZXIuIiksCisgICAgICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigi LS1hZGRpdGlvbmFsLWRydC1mbGFnIiwgYWN0aW9uPSJhcHBlbmQiLAorICAgICAgICAgICAgICAg IGRlZmF1bHQ9W10sIGhlbHA9IkFkZGl0aW9uYWwgY29tbWFuZCBsaW5lIGZsYWcgdG8gcGFzcyB0 byBEdW1wUmVuZGVyVHJlZSAiCisgICAgICAgICAgICAgICAgICAgICAiU3BlY2lmeSBtdWx0aXBs ZSB0aW1lcyB0byBhZGQgbXVsdGlwbGUgZmxhZ3MuIiksCiAgICAgICAgICAgICBdCiAgICAgICAg IHJldHVybiBvcHRwYXJzZS5PcHRpb25QYXJzZXIob3B0aW9uX2xpc3Q9KHBlcmZfb3B0aW9uX2xp c3QpKS5wYXJzZV9hcmdzKGFyZ3MpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyX3VuaXR0ZXN0LnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXJfdW5pdHRl c3QucHkKaW5kZXggMjk3M2Y3Nzg4NzhhYTg2NzViNzY1MmNmMDVkMTQ0Mjc1OGMzMWVjNy4uYTg4 ZWVmNTEzMDY2MmJmNjU4ZDdhYzVjNTQwMTAyOGM2MmY3MDcwYiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXJfdW5pdHRl c3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJm dGVzdHNydW5uZXJfdW5pdHRlc3QucHkKQEAgLTEzNSw2ICsxMzUsOCBAQCBjbGFzcyBNYWluVGVz dCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAgICAgJy0tb3V0cHV0LWpzb24tcGF0 aD1hL291dHB1dC5qc29uJywKICAgICAgICAgICAgICAgICAnLS1zbGF2ZS1jb25maWctanNvbi1w YXRoPWEvc291cmNlLmpzb24nLAogICAgICAgICAgICAgICAgICctLXRlc3QtcmVzdWx0cy1zZXJ2 ZXI9c29tZWhvc3QnLAorICAgICAgICAgICAgICAgICctLWFkZGl0aW9uYWwtZHJ0LWZsYWc9LS1l bmFibGUtdGhyZWFkZWQtcGFyc2VyJywKKyAgICAgICAgICAgICAgICAnLS1hZGRpdGlvbmFsLWRy dC1mbGFnPS0tYXdlc29tZXNhdWNlJywKICAgICAgICAgICAgICAgICAnLS1kZWJ1ZyddKQogICAg ICAgICBzZWxmLmFzc2VydFRydWUob3B0aW9ucy5idWlsZCkKICAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChvcHRpb25zLmJ1aWxkX2RpcmVjdG9yeSwgJ2ZvbGRlcjQyJykKQEAgLTE0OCw2ICsxNTAs NyBAQCBjbGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwob3B0aW9ucy5vdXRwdXRfanNvbl9wYXRoLCAnYS9vdXRwdXQuanNvbicpCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwob3B0aW9ucy5zbGF2ZV9jb25maWdfanNvbl9wYXRoLCAnYS9z b3VyY2UuanNvbicpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwob3B0aW9ucy50ZXN0X3Jlc3Vs dHNfc2VydmVyLCAnc29tZWhvc3QnKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKG9wdGlvbnMu YWRkaXRpb25hbF9kcnRfZmxhZywgWyctLWVuYWJsZS10aHJlYWRlZC1wYXJzZXInLCAnLS1hd2Vz b21lc2F1Y2UnXSkKIAogICAgIGRlZiB0ZXN0X3VwbG9hZF9qc29uKHNlbGYpOgogICAgICAgICBy dW5uZXIsIHBvcnQgPSBzZWxmLmNyZWF0ZV9ydW5uZXIoKQo=