111013 2013-02-27 14:45:40 -0800 check-webkit-style should not check within SHADER(...) macros 2014-03-02 09:20:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P4 Normal --- 1 michelangelo michelangelo krit mvujovic oldest_to_newest 843525 0 michelangelo 2013-02-27 14:45:40 -0800 We often use SHADER(..) macros in CSS CustomFilters; this macro wraps GLSL code which does not necessarily follows the same convention we have in C++. 866208 1 195757 michelangelo 2013-03-29 10:01:05 -0700 Created attachment 195757 Simple example 866211 2 195757 michelangelo 2013-03-29 10:02:52 -0700 Comment on attachment 195757 Simple example Adding a shader function such as "css_StyleTestDummyFunction" within a SHADER() macro triggers the style-checker with the following error: css_StyleTestDummyFunction is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] 195757 2013-03-29 10:01:05 -0700 2013-03-29 10:02:51 -0700 Simple example 0001-Example.patch text/plain 1109 michelangelo RnJvbSBhMmRmMmZiY2VlZjFlNjFlMmQwNWVmOWJhMGFiZWUzODAzZjMzYmVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoZWxhbmdlbG8gRGUgU2ltb25lIDxtaWNoZWxhbmdlbG9A d2Via2l0Lm9yZz4KRGF0ZTogRnJpLCAyOSBNYXIgMjAxMyAxNzo1OTo0OCArMDEwMApTdWJqZWN0 OiBbUEFUQ0hdIEV4YW1wbGUKCi0tLQogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3Vz dG9tRmlsdGVyVmFsaWRhdGVkUHJvZ3JhbS5jcHAgICAgICAgIHwgNCArKysrCiAxIGZpbGUgY2hh bmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJWYWxpZGF0ZWRQcm9ncmFtLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvQ3VzdG9tRmlsdGVyVmFsaWRh dGVkUHJvZ3JhbS5jcHAKaW5kZXggNDBkYTlmOC4uODI0ODcxZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9DdXN0b21GaWx0ZXJWYWxpZGF0ZWRQ cm9ncmFtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJz L0N1c3RvbUZpbHRlclZhbGlkYXRlZFByb2dyYW0uY3BwCkBAIC00NTgsNiArNDU4LDEwIEBAIFN0 cmluZyBDdXN0b21GaWx0ZXJWYWxpZGF0ZWRQcm9ncmFtOjpibGVuZEZ1bmN0aW9uU3RyaW5nKEJs ZW5kTW9kZSBibGVuZE1vZGUpCiAKICAgICBpZiAobmVlZHNTYXR1cmF0aW9uSGVscGVyRnVuY3Rp b25zKSB7CiAgICAgICAgIGJsZW5kRnVuY3Rpb25TdHJpbmcuYXBwZW5kKFNIQURFUigKKyAgICAg ICAgICAgIHZvaWQgY3NzX1N0eWxlVGVzdER1bW15RnVuY3Rpb24obWVkaXVtcCB2ZWMzIEMpCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgcmV0dXJuIEM7CisgICAgICAgICAgICB9CiAg ICAgICAgICAgICBtZWRpdW1wIGZsb2F0IGNzc19TYXQobWVkaXVtcCB2ZWMzIEMpCiAgICAgICAg ICAgICB7CiAgICAgICAgICAgICAgICAgbWVkaXVtcCBmbG9hdCBjTWluID0gbWluKG1pbihDLnIs IEMuZyksIEMuYik7Ci0tIAoxLjguMS41Cgo=