111006 2013-02-27 13:12:55 -0800 [BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled. 2013-02-28 07:19:09 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 liachen liachen joenotcharles leoyang mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 843421 0 liachen 2013-02-27 13:12:55 -0800 Before we would never save user credential when auto-form-fill is not enabled. But that prevents us from saving user credential for http authentication. To fix this http authentication issue, we now allow saving user credential even when auto-form-fill is not enabled. But right now there are 2 places that will auto fill form when user credential is saved, we need to fix that. These 2 places are: * FrameLoaderClientBlackBerry::dispatchDidFinishLoad() * FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent(). These 2 places need to be fixed so there will be no auto password filling when auto-form-fill is disabled. 843464 1 190596 liachen 2013-02-27 13:47:38 -0800 Created attachment 190596 patch for 111006 843473 2 190598 liachen 2013-02-27 13:57:35 -0800 Created attachment 190598 Updated patch with internal PR info 844058 3 190598 webkit.review.bot 2013-02-28 07:19:06 -0800 Comment on attachment 190598 Updated patch with internal PR info Clearing flags on attachment: 190598 Committed r144309: <http://trac.webkit.org/changeset/144309> 844059 4 webkit.review.bot 2013-02-28 07:19:09 -0800 All reviewed patches have been landed. Closing bug. 190596 2013-02-27 13:47:38 -0800 2013-02-27 13:57:35 -0800 patch for 111006 111006.patch text/plain 2596 liachen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGJjZDkzNmYuLmM2MmRjMDYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTI3ICBM aWFuZ2h1aSBDaGVuICA8bGlhY2hlbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBE aXNhYmxlIGF1dG8tZmlsbGluZyBwYXNzd29yZCBpbiBmb3JtcyB3aGVuIGF1dG8tZm9ybS1maWxs aW5nIGlzIG5vdCBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTExMDA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hlY2sgV2ViU2V0dGluZ3M6OmlzRm9ybUF1dG9maWxsRW5hYmxlZCgpIGJl Zm9yZSBkb2luZyB1c2VyIGNyZWRlbnRpYWwgZm9ybSBmaWxsIHN0dWZmLgorCisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hEaWRGaW5pc2hM b2FkKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlz cGF0Y2hXaWxsU2VuZFN1Ym1pdEV2ZW50KToKKwogMjAxMy0wMi0yNyAgSm9obiBHcmlnZ3MgIDxq Z3JpZ2dzQHJpbS5jb20+CiAKICAgICAgICAgMjAxMy0wMi0yNyAgSm9obiBHcmlnZ3MgIDxqZ3Jp Z2dzQHJpbS5jb20+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29y ZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3Bw CmluZGV4IGNiNjhjZWQuLjBiOTRkOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEJsYWNrQmVycnkuY3BwCkBAIC02NjMsNyArNjYzLDggQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVu dEJsYWNrQmVycnk6OmRpc3BhdGNoRGlkRmluaXNoTG9hZCgpCiAgICAgfQogCiAjaWYgRU5BQkxF KEJMQUNLQkVSUllfQ1JFREVOVElBTF9QRVJTSVNUKQotICAgIGlmIChtX3dlYlBhZ2VQcml2YXRl LT5tX3dlYlNldHRpbmdzLT5pc0NyZWRlbnRpYWxBdXRvZmlsbEVuYWJsZWQoKQorICAgIGlmICht X3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNldHRpbmdzLT5pc0Zvcm1BdXRvZmlsbEVuYWJsZWQoKQor ICAgICAgICAmJiBtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNldHRpbmdzLT5pc0NyZWRlbnRpYWxB dXRvZmlsbEVuYWJsZWQoKQogICAgICAgICAmJiAhbV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJTZXR0 aW5ncy0+aXNQcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCiAgICAgICAgIGNyZWRlbnRpYWxNYW5h Z2VyKCkuYXV0b2ZpbGxQYXNzd29yZEZvcm1zKG1fZnJhbWUtPmRvY3VtZW50KCktPmZvcm1zKCkp OwogI2VuZGlmCkBAIC03ODQsMTIgKzc4NSwxMyBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeTo6ZGlzcGF0Y2hXaWxsU2VuZFN1Ym1pdEV2ZW50KFBhc3NSZWZQdHI8Rm9ybVN0YQog ICAgIG1fZm9ybUNyZWRlbnRpYWxzID0gQ3JlZGVudGlhbFRyYW5zZm9ybURhdGEoKTsKICNlbmRp ZgogICAgIGlmICghbV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJTZXR0aW5ncy0+aXNQcml2YXRlQnJv d3NpbmdFbmFibGVkKCkpIHsKLSAgICAgICAgaWYgKG1fd2ViUGFnZVByaXZhdGUtPm1fd2ViU2V0 dGluZ3MtPmlzRm9ybUF1dG9maWxsRW5hYmxlZCgpKQorICAgICAgICBpZiAobV93ZWJQYWdlUHJp dmF0ZS0+bV93ZWJTZXR0aW5ncy0+aXNGb3JtQXV0b2ZpbGxFbmFibGVkKCkpIHsKICAgICAgICAg ICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fYXV0b2ZpbGxNYW5hZ2VyLT5zYXZlVGV4dEZpZWxkcyhw cnBGb3JtU3RhdGUtPmZvcm0oKSk7CiAjaWYgRU5BQkxFKEJMQUNLQkVSUllfQ1JFREVOVElBTF9Q RVJTSVNUKQotICAgICAgICBpZiAobV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJTZXR0aW5ncy0+aXND cmVkZW50aWFsQXV0b2ZpbGxFbmFibGVkKCkpCi0gICAgICAgICAgICBtX2Zvcm1DcmVkZW50aWFs cyA9IENyZWRlbnRpYWxUcmFuc2Zvcm1EYXRhKHBycEZvcm1TdGF0ZS0+Zm9ybSgpLCB0cnVlKTsK KyAgICAgICAgICAgIGlmIChtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNldHRpbmdzLT5pc0NyZWRl bnRpYWxBdXRvZmlsbEVuYWJsZWQoKSkKKyAgICAgICAgICAgICAgICBtX2Zvcm1DcmVkZW50aWFs cyA9IENyZWRlbnRpYWxUcmFuc2Zvcm1EYXRhKHBycEZvcm1TdGF0ZS0+Zm9ybSgpLCB0cnVlKTsK ICNlbmRpZgorICAgICAgICB9CiAgICAgfQogfQogCg== 190598 2013-02-27 13:57:35 -0800 2013-02-28 07:19:05 -0800 Updated patch with internal PR info 111006.patch text/plain 2668 liachen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGJjZDkzNmYuLjA5NjRmZjkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI3ICBM aWFuZ2h1aSBDaGVuICA8bGlhY2hlbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBE aXNhYmxlIGF1dG8tZmlsbGluZyBwYXNzd29yZCBpbiBmb3JtcyB3aGVuIGF1dG8tZm9ybS1maWxs aW5nIGlzIG5vdCBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTExMDA2CisKKyAgICAgICAgSW50ZXJuYWwgUFI6IDI5NTE4MQorICAgICAg ICBJbnRlcm5hbCByZXZpZXdlZCBieSBKb2UgTWFzb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgV2ViU2V0dGluZ3M6OmlzRm9ybUF1dG9m aWxsRW5hYmxlZCgpIGJlZm9yZSBkb2luZyB1c2VyIGNyZWRlbnRpYWwgZm9ybSBmaWxsIHN0dWZm LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlz cGF0Y2hEaWRGaW5pc2hMb2FkKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50 QmxhY2tCZXJyeTo6ZGlzcGF0Y2hXaWxsU2VuZFN1Ym1pdEV2ZW50KToKKwogMjAxMy0wMi0yNyAg Sm9obiBHcmlnZ3MgIDxqZ3JpZ2dzQHJpbS5jb20+CiAKICAgICAgICAgMjAxMy0wMi0yNyAgSm9o biBHcmlnZ3MgIDxqZ3JpZ2dzQHJpbS5jb20+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEJsYWNrQmVycnkuY3BwCmluZGV4IGNiNjhjZWQuLjBiOTRkOWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNr QmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9G cmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC02NjMsNyArNjYzLDggQEAgdm9pZCBG cmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNoRGlkRmluaXNoTG9hZCgpCiAgICAg fQogCiAjaWYgRU5BQkxFKEJMQUNLQkVSUllfQ1JFREVOVElBTF9QRVJTSVNUKQotICAgIGlmICht X3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNldHRpbmdzLT5pc0NyZWRlbnRpYWxBdXRvZmlsbEVuYWJs ZWQoKQorICAgIGlmIChtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNldHRpbmdzLT5pc0Zvcm1BdXRv ZmlsbEVuYWJsZWQoKQorICAgICAgICAmJiBtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNldHRpbmdz LT5pc0NyZWRlbnRpYWxBdXRvZmlsbEVuYWJsZWQoKQogICAgICAgICAmJiAhbV93ZWJQYWdlUHJp dmF0ZS0+bV93ZWJTZXR0aW5ncy0+aXNQcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCiAgICAgICAg IGNyZWRlbnRpYWxNYW5hZ2VyKCkuYXV0b2ZpbGxQYXNzd29yZEZvcm1zKG1fZnJhbWUtPmRvY3Vt ZW50KCktPmZvcm1zKCkpOwogI2VuZGlmCkBAIC03ODQsMTIgKzc4NSwxMyBAQCB2b2lkIEZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hXaWxsU2VuZFN1Ym1pdEV2ZW50KFBhc3NS ZWZQdHI8Rm9ybVN0YQogICAgIG1fZm9ybUNyZWRlbnRpYWxzID0gQ3JlZGVudGlhbFRyYW5zZm9y bURhdGEoKTsKICNlbmRpZgogICAgIGlmICghbV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJTZXR0aW5n cy0+aXNQcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpIHsKLSAgICAgICAgaWYgKG1fd2ViUGFnZVBy aXZhdGUtPm1fd2ViU2V0dGluZ3MtPmlzRm9ybUF1dG9maWxsRW5hYmxlZCgpKQorICAgICAgICBp ZiAobV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJTZXR0aW5ncy0+aXNGb3JtQXV0b2ZpbGxFbmFibGVk KCkpIHsKICAgICAgICAgICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fYXV0b2ZpbGxNYW5hZ2VyLT5z YXZlVGV4dEZpZWxkcyhwcnBGb3JtU3RhdGUtPmZvcm0oKSk7CiAjaWYgRU5BQkxFKEJMQUNLQkVS UllfQ1JFREVOVElBTF9QRVJTSVNUKQotICAgICAgICBpZiAobV93ZWJQYWdlUHJpdmF0ZS0+bV93 ZWJTZXR0aW5ncy0+aXNDcmVkZW50aWFsQXV0b2ZpbGxFbmFibGVkKCkpCi0gICAgICAgICAgICBt X2Zvcm1DcmVkZW50aWFscyA9IENyZWRlbnRpYWxUcmFuc2Zvcm1EYXRhKHBycEZvcm1TdGF0ZS0+ Zm9ybSgpLCB0cnVlKTsKKyAgICAgICAgICAgIGlmIChtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNl dHRpbmdzLT5pc0NyZWRlbnRpYWxBdXRvZmlsbEVuYWJsZWQoKSkKKyAgICAgICAgICAgICAgICBt X2Zvcm1DcmVkZW50aWFscyA9IENyZWRlbnRpYWxUcmFuc2Zvcm1EYXRhKHBycEZvcm1TdGF0ZS0+ Zm9ybSgpLCB0cnVlKTsKICNlbmRpZgorICAgICAgICB9CiAgICAgfQogfQogCg==