110993 2013-02-27 10:22:47 -0800 ImageDocument 's incorrect zoom behavior. 2024-03-29 22:50:31 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) All All UNCONFIRMED P2 Normal --- 0 kkimlabs webkit-unassigned ahmad.saleem792 esprehn+autocc kkimlabs ojan.autocc thorton webkit.review.bot oldest_to_newest 843213 0 kkimlabs 2013-02-27 10:22:47 -0800 To reproduce the bug: 1. Visit an image e.g., https://www.webkit.org/images/icon-gold.png 2. Make the browser window(rendering area)'s height and width about 3 times bigger than the image. 3. Zoom in several times using keyboard shortcut (e.g., ctrl + '+' in Linux Chrome) 4. Zoom back to the original state (100%) using keyboard shortcut (e.g., ctrl + '-' in Linux Chrome) Expected behavior: The image size after Step 4. is identical to the image size at Step 1. Observed behavior: The image size after Step 4. is bigger than the image size at Step 1. This is a bug in ImageDocument.cpp so it is reproducible on any browser and any platform. 843223 1 kkimlabs 2013-02-27 10:26:50 -0800 I fixed the bug, and it will be submitted soon. 844399 2 190791 kkimlabs 2013-02-28 13:13:59 -0800 Created attachment 190791 Patch 844417 3 190791 kkimlabs 2013-02-28 13:28:05 -0800 Comment on attachment 190791 Patch I tried to make a testcase under LayoutTests but I couldn't, because ImageDocument class is used when browser opens an image, not html, and also it behaves differently if it is inside <iframe>. So I just attached a manual test. 862072 4 190791 thorton 2013-03-22 18:39:46 -0700 Comment on attachment 190791 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190791&action=review > Source/WebCore/ChangeLog:3 > + Fix ImageDocument 's zoom bug. This is not a great title. It should be more descriptive. ImageDocument could easily have many "zoom bugs", I'm not sure how this title tells me which one you're fixing. > Source/WebCore/ChangeLog:7 > + Please add a comment here explaining why your change makes sense. 2024909 5 ahmad.saleem792 2024-03-29 22:50:31 -0700 Blink commit - https://chromium.googlesource.com/chromium/blink/+/a0a9d50d5a3c886cbbd2f8599d237e332e0ce5fa 190791 2013-02-28 13:13:59 -0800 2013-03-22 18:39:45 -0700 Patch bug-110993-20130228131011.patch text/plain 3128 kkimlabs U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUwMWE4ZTM5ZWQ1NjM5 NTk0YWNiYWM2MzU5Y2VkZTAyZTRlNjU2ZC4uMWM4ZTk4OGU1OWY0ZDcwYzNhNDljM2M0YjQ1Nzhi MDhjYmY2YzhjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAyLTI4ICBLaWJl b20gS2ltICA8a2tpbWxhYnNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBJbWFnZURvY3Vt ZW50ICdzIHpvb20gYnVnLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTEwOTkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBodG1sL0ltYWdlRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1h Z2VEb2N1bWVudDo6cmVzdG9yZUltYWdlU2l6ZSk6CisKIDIwMTMtMDItMjggIERhdmlkIEdyb2dh biAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogSU8gZXJyb3Ig d2hlbiBjaGVja2luZyBzY2hlbWEgc2hvdWxkIGRlc3Ryb3kgTGV2ZWxEQiBkaXJlY3RvcnkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VEb2N1bWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0ltYWdlRG9jdW1lbnQuY3BwCmluZGV4IGM2MzUyZmNiYTRiMWZkNDg1ZTQ3 MjdjMzQzOTFjYWExYTQxNTc0YTEuLjM3NjUyZjdmY2M3MGMwMzQ2MmZkZWUxMTFhMjc5MTEyNDVh NWRjZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VEb2N1bWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZURvY3VtZW50LmNwcApAQCAtMzAyLDcgKzMw Miw3IEBAIHZvaWQgSW1hZ2VEb2N1bWVudDo6cmVzdG9yZUltYWdlU2l6ZSgpCiAgICAgaWYgKCFt X2ltYWdlRWxlbWVudCB8fCAhbV9pbWFnZVNpemVJc0tub3duKQogICAgICAgICByZXR1cm47CiAg ICAgCi0gICAgTGF5b3V0U2l6ZSBpbWFnZVNpemUgPSBtX2ltYWdlRWxlbWVudC0+Y2FjaGVkSW1h Z2UoKS0+aW1hZ2VTaXplRm9yUmVuZGVyZXIobV9pbWFnZUVsZW1lbnQtPnJlbmRlcmVyKCksIHBh Z2Vab29tRmFjdG9yKHRoaXMpKTsKKyAgICBMYXlvdXRTaXplIGltYWdlU2l6ZSA9IG1faW1hZ2VF bGVtZW50LT5jYWNoZWRJbWFnZSgpLT5pbWFnZVNpemVGb3JSZW5kZXJlcihtX2ltYWdlRWxlbWVu dC0+cmVuZGVyZXIoKSwgMS4wZik7CiAgICAgbV9pbWFnZUVsZW1lbnQtPnNldFdpZHRoKGltYWdl U2l6ZS53aWR0aCgpKTsKICAgICBtX2ltYWdlRWxlbWVudC0+c2V0SGVpZ2h0KGltYWdlU2l6ZS5o ZWlnaHQoKSk7CiAgICAgCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg OTAwNGQwNjk4ZDA4NzQ3ZmZmN2Y1MzRkMmQ3MmJjNmFhYmViNDk2MC4uMzFhMDlhYmIyNjhiMzdk YzM2MjZiZmU5N2EyNGM3NWM0ZjU1M2MxYyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTI4ICBLaWJlb20gS2ltICA8a2tpbWxh YnNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBJbWFnZURvY3VtZW50ICdzIHpvb20gYnVn LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTkz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNYW51 YWxUZXN0cy9pbWFnZS1kb2N1bWVudC16b29tLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAyLTI3ICBa YW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBEaXNh YmxlIE1hdGhNTCBzdXBwb3J0IGluIHJlbGVhc2UgYnVpbGRzCmRpZmYgLS1naXQgYS9NYW51YWxU ZXN0cy9pbWFnZS1kb2N1bWVudC16b29tLmh0bWwgYi9NYW51YWxUZXN0cy9pbWFnZS1kb2N1bWVu dC16b29tLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzVhNDYwZmZhZGE0Nzc3YTg3ZGY1NDE4ZGI5N2I0MmEy MjI3MGYzMgotLS0gL2Rldi9udWxsCisrKyBiL01hbnVhbFRlc3RzL2ltYWdlLWRvY3VtZW50LXpv b20uaHRtbApAQCAtMCwwICsxLDE3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sIGxhbmc9ImVu Ij4KKyAgPGhlYWQ+CisgICAgPG1ldGEgY2hhcnNldD0idXRmLTgiLz4KKyAgICA8dGl0bGU+YnVn IDExMDk5MyA6IEltYWdlRG9jdW1lbnQgJ3MgaW5jb3JyZWN0IHpvb20gYmVoYXZpb3IuPC90aXRs ZT4KKyAgPC9oZWFkPgorICA8Ym9keT4KKyAgICA8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTkzIj5idWcgMTEwOTkzPC9hPiA6 IEltYWdlRG9jdW1lbnQgJ3MgaW5jb3JyZWN0IHpvb20gYmVoYXZpb3IuPC9wPgorICAgIDxvbD4K KyAgICAgIDxsaT5PcGVuIHRoaXMgaW1hZ2UgbGluayBvbiB5b3VyIGJyb3dzZXIuIDxhIGhyZWY9 InJlc291cmNlcy8yMDB4MjAwLnBuZyI+cmVzb3VyY2VzLzIwMHgyMDAucG5nPC9hPjwvbGk+Cisg ICAgICA8bGk+TWFrZSB0aGUgYnJvd3NlciB3aW5kb3cocmVuZGVyaW5nIGFyZWEpJ3MgaGVpZ2h0 IGFuZCB3aWR0aCBhYm91dCAzIHRpbWVzIGJpZ2dlciB0aGFuIHRoZSBpbWFnZS48L2xpPgorICAg ICAgPGxpPlpvb20gaW4gc2V2ZXJhbCB0aW1lcyB1c2luZyBrZXlib2FyZCBzaG9ydGN1dCAoZS5n LiwgY3RybCArICcrJyBpbiBMaW51eCBDaHJvbWUpPC9saT4KKyAgICAgIDxsaT5ab29tIGJhY2sg dG8gdGhlIG9yaWdpbmFsIHN0YXRlICgxMDAlKSB1c2luZyBrZXlib2FyZCBzaG9ydGN1dCAoZS5n LiwgY3RybCArICctJyBpbiBMaW51eCBDaHJvbWUpPC9saT4KKyAgICAgIDxsaT5JZiB0aGUgaW1h Z2Ugc2l6ZSBpcyAyMDB4MjAwLCBwYXNzLCBvdGhlcndpc2UsIGZhaWwuPC9saT4KKyAgICA8L29s PgorICA8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=