11099 2006-09-30 10:19:07 -0700 HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND 2006-10-03 18:14:11 -0700 1 1 1 Unclassified WebKit Platform 420+ PC Windows XP RESOLVED FIXED P2 Normal --- 1 fishd webkit-unassigned oldest_to_newest 56838 0 fishd 2006-09-30 10:19:07 -0700 I've noticed that HttpSendRequestEx sometimes returns ERROR_HTTP_HEADER_NOT_FOUND, which I believe is caused by the lpcszHeader member of the INTERNET_BUFFERS struct being a garbage pointer. Note: the CString object returned by headers.latin1() is a temporary, and ResourceLoaderWin is making the mistake of using it beyond its lifetime. Patch coming up... 56980 1 10875 fishd 2006-10-02 18:51:56 -0700 Created attachment 10875 minimal patch 56981 2 10875 darin 2006-10-02 19:36:05 -0700 Comment on attachment 10875 minimal patch r=me 55132 3 mrowe 2006-10-03 18:14:11 -0700 Landed in r16757. 10875 2006-10-02 18:51:56 -0700 2006-10-02 19:36:05 -0700 minimal patch fix-1.diff text/plain 1582 fishd SW5kZXg6IHBsYXRmb3JtL3dpbi9SZXNvdXJjZUxvYWRlcldpbi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g cGxhdGZvcm0vd2luL1Jlc291cmNlTG9hZGVyV2luLmNwcAkocmV2aXNpb24gMTY3MjkpCisrKyBw bGF0Zm9ybS93aW4vUmVzb3VyY2VMb2FkZXJXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjcs MTEgKzE2NywxMiBAQAogICAgICAgICBoZWFkZXJzICs9ICJSZWZlcmVyOiAiOwogICAgICAgICBo ZWFkZXJzICs9IGQtPm1fcG9zdFJlZmVycmVyOwogICAgICAgICBoZWFkZXJzICs9ICJcbiI7Cisg ICAgICAgIGNvbnN0IENTdHJpbmcmIGhlYWRlcnNMYXRpbjEgPSBoZWFkZXJzLmxhdGluMSgpOwog ICAgICAgICBTdHJpbmcgZm9ybURhdGEgPSBwb3N0RGF0YSgpLmZsYXR0ZW5Ub1N0cmluZygpOwog ICAgICAgICBJTlRFUk5FVF9CVUZGRVJTQSBidWZmZXJzOwogICAgICAgICBtZW1zZXQoJmJ1ZmZl cnMsIDAsIHNpemVvZihidWZmZXJzKSk7CiAgICAgICAgIGJ1ZmZlcnMuZHdTdHJ1Y3RTaXplID0g c2l6ZW9mKElOVEVSTkVUX0JVRkZFUlNBKTsKLSAgICAgICAgYnVmZmVycy5scGNzekhlYWRlciA9 IGhlYWRlcnMubGF0aW4xKCk7CisgICAgICAgIGJ1ZmZlcnMubHBjc3pIZWFkZXIgPSBoZWFkZXJz TGF0aW4xOwogICAgICAgICBidWZmZXJzLmR3SGVhZGVyc0xlbmd0aCA9IGhlYWRlcnMubGVuZ3Ro KCk7CiAgICAgICAgIGJ1ZmZlcnMuZHdCdWZmZXJUb3RhbCA9IGZvcm1EYXRhLmxlbmd0aCgpOwog ICAgICAgICAKQEAgLTE4MSw2ICsxODIsNyBAQAogICAgICAgICBzdHJuY3B5KGQtPm1fZm9ybURh dGFTdHJpbmcsIGZvcm1EYXRhLmxhdGluMSgpLCBmb3JtRGF0YS5sZW5ndGgoKSk7CiAgICAgICAg IGQtPm1fd3JpdGluZyA9IHRydWU7CiAgICAgICAgIEh0dHBTZW5kUmVxdWVzdEV4QShkLT5tX3Nl Y29uZGFyeUhhbmRsZSwgJmJ1ZmZlcnMsIDAsIDAsIChEV09SRF9QVFIpZC0+bV9qb2JJZCk7Cisg ICAgICAgIC8vIEZJWE1FOiBhZGQgcHJvcGVyIGVycm9yIGhhbmRsaW5nCiAgICAgfQogfQogCklu ZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjcyOSkK KysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDA2LTEwLTAy ICBNb3JnYW5MICA8bW9yZ2FubC53ZWJraXRAeWFob28uY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzOiBodHRwOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5OQorCisgICAgICAgICogcGxhdGZvcm0vd2luL1Jlc291 cmNlTG9hZGVyV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyOjpvbkhh bmRsZUNyZWF0ZWQpOgorCiAyMDA2LTEwLTAyICBKdXN0aW4gR2FyY2lhICA8anVzdGluLmdhcmNp YUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgYW5kZXJzCg==