110979 2013-02-27 07:12:41 -0800 Selection direction is not preserved when applying styles 2017-12-15 01:35:26 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 114612 1 shezbaig.wk sukolsak buildbot commit-queue dglazkov jfernandez mifenton rniwa webkit-bug-importer webkit.review.bot oldest_to_newest 843030 0 shezbaig.wk 2013-02-27 07:12:41 -0800 ApplyStyleCommand::updateStartEnd does not preserve the original selection's direction 843084 1 190525 shezbaig.wk 2013-02-27 08:22:24 -0800 Created attachment 190525 Patch 843139 2 190525 webkit.review.bot 2013-02-27 09:09:21 -0800 Comment on attachment 190525 Patch Attachment 190525 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16668112 New failing tests: editing/style/block-style-005.html 843225 3 190525 rniwa 2013-02-27 10:28:09 -0800 Comment on attachment 190525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190525&action=review > Source/WebCore/editing/ApplyStyleCommand.cpp:189 > + Position base = wasBaseFirst ? newStart : newEnd; > + Position extent = wasBaseFirst ? newEnd : newStart; I would have put this directly in the line below but okay. > LayoutTests/editing/style/preserve-selection-direction-expected.txt:7 > +PASS sel.anchorOffset is 0 > +PASS sel.focusOffset is 5 By just looking at this output, it's not clear why these numbers should be correct. > LayoutTests/editing/style/preserve-selection-direction.html:14 > + var sel = window.getSelection(); Please don't use abbreviations like sel. > LayoutTests/editing/style/preserve-selection-direction.html:16 > + // test forward selection direction I don't think this comment is useful. > LayoutTests/editing/style/preserve-selection-direction.html:19 > + sel.collapse(editable.firstChild, 3); > + sel.extend(editable.firstChild, 8); > + document.execCommand('foreColor', false, 'green'); I would have put all of this inside evalAndLog. > LayoutTests/editing/style/preserve-selection-direction.html:23 > + // reset and test backwards selection direction I don't think this comment is useful. > LayoutTests/editing/style/preserve-selection-direction.html:27 > + editable.innerHTML = "This is some sample text"; > + sel.collapse(editable.firstChild, 8); > + sel.extend(editable.firstChild, 3); > + document.execCommand('foreColor', false, 'green'); Ditto. 843226 4 190525 rniwa 2013-02-27 10:28:30 -0800 Comment on attachment 190525 Patch r=me with me that. 843258 5 shezbaig.wk 2013-02-27 10:54:44 -0800 Thanks, I will incorporate your comments, and I'm also looking into the failing test: block-style-005.html 843271 6 190525 buildbot 2013-02-27 11:07:38 -0800 Comment on attachment 190525 Patch Attachment 190525 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16791116 New failing tests: editing/execCommand/remove-format-orphaned-list-item.html editing/execCommand/4920488.html editing/execCommand/4920742-1.html editing/style/apply-style-atomic.html fast/events/autoscroll-in-textarea.html canvas/philip/tests/2d.text.draw.fontface.notinpage.html fast/frames/sandboxed-iframe-scripting.html fast/history/visited-link-background-color.html editing/style/apple-style-editable-mix.html editing/execCommand/remove-format-background-color.html editing/execCommand/4786404-1.html editing/execCommand/5049671.html editing/style/remove-styled-element-with-style-span.html editing/execCommand/5573879.html editing/inserting/space-after-removeformat.html fast/events/event-sender-mouse-moved.html editing/execCommand/4786404-2.html editing/execCommand/remove-formatting.html http/tests/cookies/third-party-cookie-relaxing.html editing/style/style-text-node-without-editable-parent.html 844008 7 190525 buildbot 2013-02-28 05:20:05 -0800 Comment on attachment 190525 Patch Attachment 190525 did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16855052 New failing tests: editing/execCommand/remove-format-orphaned-list-item.html editing/execCommand/4920488.html editing/execCommand/4920742-1.html editing/style/apply-style-atomic.html editing/style/apple-style-editable-mix.html platform/mac/editing/input/bold-node.html editing/execCommand/4786404-2.html editing/execCommand/remove-format-background-color.html editing/execCommand/4786404-1.html editing/execCommand/5049671.html editing/execCommand/5573879.html editing/inserting/space-after-removeformat.html editing/execCommand/remove-formatting.html editing/style/remove-styled-element-with-style-span.html editing/style/style-text-node-without-editable-parent.html 875244 8 197960 sukolsak 2013-04-13 16:18:55 -0700 Created attachment 197960 Patch 875270 9 197960 commit-queue 2013-04-13 20:54:14 -0700 Comment on attachment 197960 Patch Clearing flags on attachment: 197960 Committed r148378: <http://trac.webkit.org/changeset/148378> 875319 10 shezbaig.wk 2013-04-14 05:27:16 -0700 Thanks Sukolsak! 1382100 11 webkit-bug-importer 2017-12-15 01:35:26 -0800 <rdar://problem/36070206> 190525 2013-02-27 08:22:24 -0800 2013-02-28 05:20:05 -0800 Patch bug-110979-20130227111703.patch text/plain 5090 shezbaig.wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZjZGJiZGVmYzk5NWNi M2Q5Yzc5YzY0ZmJjNjBmMjEwODk3ZmQ2YS4uNDcxNzNmODcxZTIyYTIwYjZjYWJmNWQ0YWMwYWM4 YTQ5ZjAyYmQwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI3ICBTaGV6 YW4gQmFpZyAgPHNiYWlnMUBibG9vbWJlcmcubmV0PgorCisgICAgICAgIFNlbGVjdGlvbiBkaXJl Y3Rpb24gaXMgbm90IHByZXNlcnZlZCB3aGVuIGFwcGx5aW5nIHN0eWxlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTc5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIGJhc2Ugd2FzIGZpcnN0 IGluIHRoZSBzdGFydGluZyBzZWxlY3Rpb24sIHRoZW4gdGhlcmUgaXMgbm8KKyAgICAgICAgY2hh bmdlLiAgSG93ZXZlciwgaWYgdGhlIGJhc2Ugd2FzIG5vdCBmaXJzdCBpbiB0aGUgc3RhcnRpbmcg c2VsZWN0aW9uLAorICAgICAgICB0aGVuIHN3aXRjaCBhbmQgbmV3U3RhcnQgYW5kIG5ld0VuZCB3 aGVuIHNldHRpbmcgdGhlIGVuZGluZyBzZWxlY3Rpb24uCisKKyAgICAgICAgVGVzdDogZWRpdGlu Zy9zdHlsZS9wcmVzZXJ2ZS1zZWxlY3Rpb24tZGlyZWN0aW9uLmh0bWwKKworICAgICAgICAqIGVk aXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwbHlTdHls ZUNvbW1hbmQ6OnVwZGF0ZVN0YXJ0RW5kKToKKwogMjAxMy0wMi0yNiAgSm9zaHVhIEJlbGwgIDxq c2JlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogSURCT2JqZWN0U3RvcmUu aW5kZXgoKSBkb2Vzbid0IHJlcG9ydCBlcnJvcnMgYWZ0ZXIgZGVsZXRlSW5kZXgoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAppbmRleCA1YjZiMTJhYzE1 MmQ1ZjFlNTQ0NDZiNTg0YTZiM2NlZDI3NmEyZWU1Li5lYzI1NGM5NWZhMTA1ZGI2OGU4ZmQ1ZWUy NTU5MDJjNjJjZWJjY2YwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5 U3R5bGVDb21tYW5kLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVD b21tYW5kLmNwcApAQCAtMTg0LDcgKzE4NCwxMCBAQCB2b2lkIEFwcGx5U3R5bGVDb21tYW5kOjp1 cGRhdGVTdGFydEVuZChjb25zdCBQb3NpdGlvbiYgbmV3U3RhcnQsIGNvbnN0IFBvc2l0aW9uJgog ICAgIGlmICghbV91c2VFbmRpbmdTZWxlY3Rpb24gJiYgKG5ld1N0YXJ0ICE9IG1fc3RhcnQgfHwg bmV3RW5kICE9IG1fZW5kKSkKICAgICAgICAgbV91c2VFbmRpbmdTZWxlY3Rpb24gPSB0cnVlOwog Ci0gICAgc2V0RW5kaW5nU2VsZWN0aW9uKFZpc2libGVTZWxlY3Rpb24obmV3U3RhcnQsIG5ld0Vu ZCwgVlBfREVGQVVMVF9BRkZJTklUWSwgZW5kaW5nU2VsZWN0aW9uKCkuaXNEaXJlY3Rpb25hbCgp KSk7CisgICAgYm9vbCB3YXNCYXNlRmlyc3QgPSBzdGFydGluZ1NlbGVjdGlvbigpLmlzQmFzZUZp cnN0KCkgJiYgc3RhcnRpbmdTZWxlY3Rpb24oKS5pc0RpcmVjdGlvbmFsKCk7CisgICAgUG9zaXRp b24gYmFzZSA9IHdhc0Jhc2VGaXJzdCA/IG5ld1N0YXJ0IDogbmV3RW5kOworICAgIFBvc2l0aW9u IGV4dGVudCA9IHdhc0Jhc2VGaXJzdCA/IG5ld0VuZCA6IG5ld1N0YXJ0OworICAgIHNldEVuZGlu Z1NlbGVjdGlvbihWaXNpYmxlU2VsZWN0aW9uKGJhc2UsIGV4dGVudCwgVlBfREVGQVVMVF9BRkZJ TklUWSwgZW5kaW5nU2VsZWN0aW9uKCkuaXNEaXJlY3Rpb25hbCgpKSk7CiAgICAgbV9zdGFydCA9 IG5ld1N0YXJ0OwogICAgIG1fZW5kID0gbmV3RW5kOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGEyYmFkN2RjYzlmNmQ3 M2Q5ZmRmY2UyMDIwODc1ODM0OWNlOGFjZDcuLjY2MjhiYzFhMGMzY2ZjMDM5MmJlZmNiNzA3ODVl NjgzNTA3YzhlY2EgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wMi0yNyAgU2hlemFuIEJh aWcgIDxzYmFpZzFAYmxvb21iZXJnLm5ldD4KKworICAgICAgICBTZWxlY3Rpb24gZGlyZWN0aW9u IGlzIG5vdCBwcmVzZXJ2ZWQgd2hlbiBhcHBseWluZyBzdHlsZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDk3OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9zdHlsZS9wcmVzZXJ2ZS1z ZWxlY3Rpb24tZGlyZWN0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGlu Zy9zdHlsZS9wcmVzZXJ2ZS1zZWxlY3Rpb24tZGlyZWN0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDEz LTAyLTI2ICBKb3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5k ZXhlZERCOiBJREJPYmplY3RTdG9yZS5pbmRleCgpIGRvZXNuJ3QgcmVwb3J0IGVycm9ycyBhZnRl ciBkZWxldGVJbmRleCgpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3N0eWxlL3By ZXNlcnZlLXNlbGVjdGlvbi1kaXJlY3Rpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRp dGluZy9zdHlsZS9wcmVzZXJ2ZS1zZWxlY3Rpb24tZGlyZWN0aW9uLWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi4wMGY2YjJjNzI3MWZkOTk5ZDFlNTgyZGQ1NDM3OTYzN2Q3NmM4YjU5Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9wcmVzZXJ2ZS1zZWxlY3Rpb24t ZGlyZWN0aW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEzIEBACitCdWcgMTEwOTc5OiBTZWxl Y3Rpb24gZGlyZWN0aW9uIGlzIG5vdCBwcmVzZXJ2ZWQgd2hlbiBhcHBseWluZyBzdHlsZXMKKwor VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgc2VsZWN0aW9uIGRpcmVjdGlvbiBpcyBwcmVzZXJ2ZWQg d2hlbiBhcHBseWluZyBzdHlsZXMuCisKK1RoaXMgaXMgc29tZSBzYW1wbGUgdGV4dAorUEFTUyBz ZWwuYW5jaG9yT2Zmc2V0IGlzIDAKK1BBU1Mgc2VsLmZvY3VzT2Zmc2V0IGlzIDUKK1BBU1Mgc2Vs LmFuY2hvck9mZnNldCBpcyA1CitQQVNTIHNlbC5mb2N1c09mZnNldCBpcyAwCitQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9wcmVzZXJ2ZS1zZWxlY3Rpb24tZGlyZWN0aW9uLmh0bWwg Yi9MYXlvdXRUZXN0cy9lZGl0aW5nL3N0eWxlL3ByZXNlcnZlLXNlbGVjdGlvbi1kaXJlY3Rpb24u aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5kZTA1ODFkNDAxYzNlYmVhODgyZmY4N2ExOThkZTYxZWMzMDkxNjAz Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9wcmVzZXJ2ZS1z ZWxlY3Rpb24tZGlyZWN0aW9uLmh0bWwKQEAgLTAsMCArMSwzMyBAQAorPCFkb2N0eXBlIGh0bWw+ Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPlByZXNlcnZlIHNlbGVjdGlvbiBkaXJlY3Rpb248L3Rp dGxlPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPjwvc2NyaXB0PgorPGJvZHk+Cis8cD4gQnVnIDxhIGhy ZWY9Imh0dHA6Ly93ZWJraXQub3JnL2IvMTEwOTc5Ij4xMTA5Nzk8L2E+OiBTZWxlY3Rpb24gZGly ZWN0aW9uIGlzIG5vdCBwcmVzZXJ2ZWQgd2hlbiBhcHBseWluZyBzdHlsZXM8L3A+Cis8cD5UaGlz IHRlc3QgdmVyaWZpZXMgdGhhdCBzZWxlY3Rpb24gZGlyZWN0aW9uIGlzIHByZXNlcnZlZCB3aGVu IGFwcGx5aW5nIHN0eWxlcy48L3A+Cis8ZGl2IGlkPSJlZGl0YWJsZSIgY29udGVudGVkaXRhYmxl PlRoaXMgaXMgc29tZSBzYW1wbGUgdGV4dDwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+ Cis8L2JvZHk+Cis8c2NyaXB0PgorICAgIHZhciBlZGl0YWJsZSA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJlZGl0YWJsZSIpOworICAgIHZhciBzZWwgPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7 CisKKyAgICAvLyB0ZXN0IGZvcndhcmQgc2VsZWN0aW9uIGRpcmVjdGlvbgorICAgIHNlbC5jb2xs YXBzZShlZGl0YWJsZS5maXJzdENoaWxkLCAzKTsKKyAgICBzZWwuZXh0ZW5kKGVkaXRhYmxlLmZp cnN0Q2hpbGQsIDgpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdmb3JlQ29sb3InLCBmYWxz ZSwgJ2dyZWVuJyk7CisgICAgc2hvdWxkQmUoInNlbC5hbmNob3JPZmZzZXQiLCAiMCIpOworICAg IHNob3VsZEJlKCJzZWwuZm9jdXNPZmZzZXQiLCAiNSIpOworCisgICAgLy8gcmVzZXQgYW5kIHRl c3QgYmFja3dhcmRzIHNlbGVjdGlvbiBkaXJlY3Rpb24KKyAgICBlZGl0YWJsZS5pbm5lckhUTUwg PSAiVGhpcyBpcyBzb21lIHNhbXBsZSB0ZXh0IjsKKyAgICBzZWwuY29sbGFwc2UoZWRpdGFibGUu Zmlyc3RDaGlsZCwgOCk7CisgICAgc2VsLmV4dGVuZChlZGl0YWJsZS5maXJzdENoaWxkLCAzKTsK KyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnZm9yZUNvbG9yJywgZmFsc2UsICdncmVlbicpOwor ICAgIHNob3VsZEJlKCJzZWwuYW5jaG9yT2Zmc2V0IiwgIjUiKTsKKyAgICBzaG91bGRCZSgic2Vs LmZvY3VzT2Zmc2V0IiwgIjAiKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3Qv anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3Nj cmlwdD4KKzwvaHRtbD4KKwo= 197960 2013-04-13 16:18:55 -0700 2013-04-13 20:54:14 -0700 Patch bug-110979-20130413161835.patch text/plain 5240 sukolsak SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA0LTEzICBTdWtvbHNh ayBTYWtzaHV3b25nICA8c3Vrb2xzYWtAZ21haWwuY29tPgorCisgICAgICAgIFNlbGVjdGlvbiBk aXJlY3Rpb24gaXMgbm90IHByZXNlcnZlZCB3aGVuIGFwcGx5aW5nIHN0eWxlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTc5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBhdGNoIGlzIGJhc2Vk IG9uIHRoZSBvbmUgc3VibWl0dGVkIGJ5IFNoZXphbiBCYWlnLgorCisgICAgICAgIElmIHRoZSBz dGFydGluZyBzZWxlY3Rpb24gd2FzIGRpcmVjdGlvbmFsIGFuZCBpdHMgYmFzZSB3YXMgbm90IGZp cnN0LAorICAgICAgICBzd2l0Y2ggbmV3U3RhcnQgYW5kIG5ld0VuZCB3aGVuIHNldHRpbmcgdGhl IGVuZGluZyBkaXJlY3Rpb24uIE90aGVyd2lzZSwKKyAgICAgICAgbGVhdmUgdGhlIG9yZGVyIHVu Y2hhbmdlZC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL3N0eWxlL3ByZXNlcnZlLXNlbGVjdGlv bi1kaXJlY3Rpb24uaHRtbAorCisgICAgICAgICogZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBseVN0eWxlQ29tbWFuZDo6dXBkYXRlU3RhcnRFbmQp OgorCiAyMDEzLTA0LTEzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIGZvcm0gZGVsZWdhdGUgbWV0aG9kIHRoYXQncyBpbnZva2VkIHJpZ2h0IGJl Zm9yZSBzZW5kaW5nIGEgc3VibWl0IGV2ZW50IHRvIGEgZm9ybSBlbGVtZW50CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAkocmV2aXNpb24gMTQ4 MzY4KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE4NCw3ICsxODQsOCBAQCB2b2lkIEFwcGx5U3R5bGVDb21tYW5kOjp1 cGRhdGVTdGFydEVuZChjCiAgICAgaWYgKCFtX3VzZUVuZGluZ1NlbGVjdGlvbiAmJiAobmV3U3Rh cnQgIT0gbV9zdGFydCB8fCBuZXdFbmQgIT0gbV9lbmQpKQogICAgICAgICBtX3VzZUVuZGluZ1Nl bGVjdGlvbiA9IHRydWU7CiAKLSAgICBzZXRFbmRpbmdTZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlv bihuZXdTdGFydCwgbmV3RW5kLCBWUF9ERUZBVUxUX0FGRklOSVRZLCBlbmRpbmdTZWxlY3Rpb24o KS5pc0RpcmVjdGlvbmFsKCkpKTsKKyAgICBib29sIHdhc0Jhc2VGaXJzdCA9IHN0YXJ0aW5nU2Vs ZWN0aW9uKCkuaXNCYXNlRmlyc3QoKSB8fCAhc3RhcnRpbmdTZWxlY3Rpb24oKS5pc0RpcmVjdGlv bmFsKCk7CisgICAgc2V0RW5kaW5nU2VsZWN0aW9uKFZpc2libGVTZWxlY3Rpb24od2FzQmFzZUZp cnN0ID8gbmV3U3RhcnQgOiBuZXdFbmQsIHdhc0Jhc2VGaXJzdCA/IG5ld0VuZCA6IG5ld1N0YXJ0 LCBWUF9ERUZBVUxUX0FGRklOSVRZLCBlbmRpbmdTZWxlY3Rpb24oKS5pc0RpcmVjdGlvbmFsKCkp KTsKICAgICBtX3N0YXJ0ID0gbmV3U3RhcnQ7CiAgICAgbV9lbmQgPSBuZXdFbmQ7CiB9CkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNDgzNjgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wNC0xMyAgU3Vrb2xzYWsgU2Frc2h1d29uZyAg PHN1a29sc2FrQGdtYWlsLmNvbT4KKworICAgICAgICBTZWxlY3Rpb24gZGlyZWN0aW9uIGlzIG5v dCBwcmVzZXJ2ZWQgd2hlbiBhcHBseWluZyBzdHlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDk3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHRlc3QsIGJhc2VkIG9uIHRoZSB3b3JrIGJ5 IFNoZXphbiBCYWlnCisKKyAgICAgICAgKiBlZGl0aW5nL3N0eWxlL3ByZXNlcnZlLXNlbGVjdGlv bi1kaXJlY3Rpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3N0eWxl L3ByZXNlcnZlLXNlbGVjdGlvbi1kaXJlY3Rpb24uaHRtbDogQWRkZWQuCisKIDIwMTMtMDMtMDQg IFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFdoaXRlc3BhY2Ug YmV0d2VlbiBub3dyYXAgZWxlbWVudHMgaWdub3JlZCBhZnRlciBjb2xsYXBzZWQgdHJhaWxpbmcg c3BhY2UgaW4gYSB0ZXh0IHJ1bgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9wcmVz ZXJ2ZS1zZWxlY3Rpb24tZGlyZWN0aW9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9lZGl0aW5nL3N0eWxlL3ByZXNlcnZlLXNlbGVjdGlvbi1kaXJlY3Rpb24tZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9wcmVzZXJ2 ZS1zZWxlY3Rpb24tZGlyZWN0aW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwyMCBAQAorQnVnIDExMDk3OTogU2VsZWN0aW9uIGRpcmVjdGlvbiBpcyBub3QgcHJlc2VydmVk IHdoZW4gYXBwbHlpbmcgc3R5bGVzCisKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IHNlbGVjdGlv biBkaXJlY3Rpb24gaXMgcHJlc2VydmVkIHdoZW4gYXBwbHlpbmcgc3R5bGVzLgorCitUaGlzIGlz IHNvbWUgc2FtcGxlIHRleHQKK3NlbGVjdGlvbi5jb2xsYXBzZShlZGl0YWJsZS5maXJzdENoaWxk LCAzKTsKK3NlbGVjdGlvbi5leHRlbmQoZWRpdGFibGUuZmlyc3RDaGlsZCwgOCk7Citkb2N1bWVu dC5leGVjQ29tbWFuZCgnZm9yZUNvbG9yJywgZmFsc2UsICdncmVlbicpOworUEFTUyBzZWxlY3Rp b24uYW5jaG9yT2Zmc2V0IGlzIDAKK1BBU1Mgc2VsZWN0aW9uLmZvY3VzT2Zmc2V0IGlzIDUKK2Vk aXRhYmxlLmlubmVySFRNTCA9ICdUaGlzIGlzIHNvbWUgc2FtcGxlIHRleHQnOworc2VsZWN0aW9u LmNvbGxhcHNlKGVkaXRhYmxlLmZpcnN0Q2hpbGQsIDgpOworc2VsZWN0aW9uLmV4dGVuZChlZGl0 YWJsZS5maXJzdENoaWxkLCAzKTsKK2RvY3VtZW50LmV4ZWNDb21tYW5kKCdmb3JlQ29sb3InLCBm YWxzZSwgJ2dyZWVuJyk7CitQQVNTIHNlbGVjdGlvbi5hbmNob3JPZmZzZXQgaXMgNQorUEFTUyBz ZWxlY3Rpb24uZm9jdXNPZmZzZXQgaXMgMAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1 ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc3R5bGUvcHJl c2VydmUtc2VsZWN0aW9uLWRpcmVjdGlvbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2VkaXRpbmcvc3R5bGUvcHJlc2VydmUtc2VsZWN0aW9uLWRpcmVjdGlvbi5odG1sCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9wcmVzZXJ2ZS1zZWxlY3Rpb24tZGly ZWN0aW9uLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzEgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5QcmVzZXJ2ZSBzZWxlY3Rpb24gZGlyZWN0aW9uPC90 aXRsZT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHA+ QnVnIDExMDk3OTogU2VsZWN0aW9uIGRpcmVjdGlvbiBpcyBub3QgcHJlc2VydmVkIHdoZW4gYXBw bHlpbmcgc3R5bGVzPC9wPgorPHA+VGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgc2VsZWN0aW9uIGRp cmVjdGlvbiBpcyBwcmVzZXJ2ZWQgd2hlbiBhcHBseWluZyBzdHlsZXMuPC9wPgorPGRpdiBpZD0i ZWRpdGFibGUiIGNvbnRlbnRlZGl0YWJsZT5UaGlzIGlzIHNvbWUgc2FtcGxlIHRleHQ8L2Rpdj4K KzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KK3ZhciBlZGl0YWJsZSA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJlZGl0YWJsZSIpOwordmFyIHNlbGVjdGlvbiA9IHdpbmRvdy5n ZXRTZWxlY3Rpb24oKTsKKworZXZhbEFuZExvZygic2VsZWN0aW9uLmNvbGxhcHNlKGVkaXRhYmxl LmZpcnN0Q2hpbGQsIDMpOyIpOworZXZhbEFuZExvZygic2VsZWN0aW9uLmV4dGVuZChlZGl0YWJs ZS5maXJzdENoaWxkLCA4KTsiKTsKK2V2YWxBbmRMb2coImRvY3VtZW50LmV4ZWNDb21tYW5kKCdm b3JlQ29sb3InLCBmYWxzZSwgJ2dyZWVuJyk7Iik7CitzaG91bGRCZSgic2VsZWN0aW9uLmFuY2hv ck9mZnNldCIsICIwIik7CitzaG91bGRCZSgic2VsZWN0aW9uLmZvY3VzT2Zmc2V0IiwgIjUiKTsK KworZXZhbEFuZExvZygiZWRpdGFibGUuaW5uZXJIVE1MID0gJ1RoaXMgaXMgc29tZSBzYW1wbGUg dGV4dCc7Iik7CitldmFsQW5kTG9nKCJzZWxlY3Rpb24uY29sbGFwc2UoZWRpdGFibGUuZmlyc3RD aGlsZCwgOCk7Iik7CitldmFsQW5kTG9nKCJzZWxlY3Rpb24uZXh0ZW5kKGVkaXRhYmxlLmZpcnN0 Q2hpbGQsIDMpOyIpOworZXZhbEFuZExvZygiZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ2ZvcmVDb2xv cicsIGZhbHNlLCAnZ3JlZW4nKTsiKTsKK3Nob3VsZEJlKCJzZWxlY3Rpb24uYW5jaG9yT2Zmc2V0 IiwgIjUiKTsKK3Nob3VsZEJlKCJzZWxlY3Rpb24uZm9jdXNPZmZzZXQiLCAiMCIpOworPC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=