110949 2013-02-26 23:44:39 -0800 HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT(m_speculations.isEmpty()) 2013-02-27 01:23:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 abarth abarth eric esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 842741 0 abarth 2013-02-26 23:44:39 -0800 HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser can trigger ASSERT(m_speculations.isEmpty()) 842745 1 eric 2013-02-26 23:46:39 -0800 Unpossible! There can be no bügs! 842748 2 190454 abarth 2013-02-26 23:50:37 -0800 Created attachment 190454 Patch 842760 3 190454 eric 2013-02-26 23:59:45 -0800 Comment on attachment 190454 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190454&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:311 > + if (isWaitingForScripts() || !m_speculations.isEmpty()) { I see. So we've yielded all the way out to the event loop and are getting more data from teh background parser. I'm sure we hit this all the time in the wild and may be a source of all sorts of bad behavior! 842762 4 abarth 2013-02-27 00:02:24 -0800 Yep. 842831 5 190454 webkit.review.bot 2013-02-27 01:23:50 -0800 Comment on attachment 190454 Patch Clearing flags on attachment: 190454 Committed r144158: <http://trac.webkit.org/changeset/144158> 842832 6 webkit.review.bot 2013-02-27 01:23:54 -0800 All reviewed patches have been landed. Closing bug. 190454 2013-02-26 23:50:37 -0800 2013-02-27 01:23:50 -0800 Patch bug-110949-20130226234651.patch text/plain 1791 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDE0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAyLTI2ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSFRNTERvY3VtZW50UGFyc2VyOjpk aWRSZWNlaXZlUGFyc2VkQ2h1bmtGcm9tQmFja2dyb3VuZFBhcnNlciBjYW4gdHJpZ2dlciBBU1NF UlQobV9zcGVjdWxhdGlvbnMuaXNFbXB0eSgpKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2UgY2FuIGhpdCB0aGlzIEFTU0VSVCBpZiBkaWRSZWNlaXZl UGFyc2VkQ2h1bmtGcm9tQmFja2dyb3VuZFBhcnNlciBpcworICAgICAgICBjYWxsZWQgZnJvbSB0 aGUgYmFja2dyb3VuZCB0aHJlYWQgd2hpbGUgd2UncmUgcHJvY2Vzc2luZworICAgICAgICBtX3Nw ZWN1bGF0aW9ucyAoaS5lLiwgaWYgcHJvY2Vzc2luZyBtX3NwZWN1bGF0aW9ucyBpcyB0YWtpbmcg YSB3aGlsZQorICAgICAgICBhbmQgd2UndmUgeWllbGRlZCB0byB0aGUgZXZlbnQgbG9vcCkuCisK KyAgICAgICAgSXQncyBoYXJkIHRvIHdyaXRlIGEgZGV0ZXJtaW5pc3RpYyB0ZXN0IGZvciB0aGlz IHBhdGNoLCBidXQgaXQncyBoaXQKKyAgICAgICAgcXVpdGUgb2Z0ZW4gd2l0aCBleGlzdGluZyBM YXlvdXRUZXN0cy4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRG9jdW1lbnRQYXJzZXI6OmRpZFJlY2VpdmVQYXJz ZWRDaHVua0Zyb21CYWNrZ3JvdW5kUGFyc2VyKToKKwogMjAxMy0wMi0yNiAgVWRheSBLaXJhbiAg PHVkYXlraXJhbkBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgZ2V0UHJvcGVydHlWYWx1ZSBmb3Ig LXdlYmtpdC1jb2x1bW4tcnVsZSByZXR1cm5zIG51bGwsIHNob3VsZCBjb21wdXRlIHRoZSBzaG9y dGhhbmQgdmFsdWUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVu dFBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRN TERvY3VtZW50UGFyc2VyLmNwcAkocmV2aXNpb24gMTQ0MTQ4KQorKysgU291cmNlL1dlYkNvcmUv aHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzA4 LDcgKzMwOCw3IEBAIGJvb2wgSFRNTERvY3VtZW50UGFyc2VyOjpjYW5UYWtlTmV4dFRva2UKIAog dm9pZCBIVE1MRG9jdW1lbnRQYXJzZXI6OmRpZFJlY2VpdmVQYXJzZWRDaHVua0Zyb21CYWNrZ3Jv dW5kUGFyc2VyKFBhc3NPd25QdHI8UGFyc2VkQ2h1bms+IGNodW5rKQogewotICAgIGlmIChpc1dh aXRpbmdGb3JTY3JpcHRzKCkpIHsKKyAgICBpZiAoaXNXYWl0aW5nRm9yU2NyaXB0cygpIHx8ICFt X3NwZWN1bGF0aW9ucy5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9wcmVsb2FkZXItPnRha2VBbmRQ cmVsb2FkKGNodW5rLT5wcmVsb2Fkcyk7CiAgICAgICAgIG1fc3BlY3VsYXRpb25zLmFwcGVuZChj aHVuayk7CiAgICAgICAgIHJldHVybjsK