110942 2013-02-26 21:50:40 -0800 We should record the JITCodeMap for the JS function that could be inlined but not directly compiled with DFG 2013-02-26 23:00:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 109036 P2 Normal --- 1 yuqiang.xian webkit-unassigned barraclough fpizlo oldest_to_newest 842678 0 yuqiang.xian 2013-02-26 21:50:40 -0800 In particular, if the JS function contains the op_call_varargs bytecode, it cannot be directly compiled but can be inlined (in certain cases) with DFG. In this case if we don't record the JITCodeMap for this function, we will have problems if OSR exit happens inside this function. This problem is exposed in a build with LLInt disabled but DFG JIT enabled, when browsing and clicking around www.android.com. Patch forthcoming. 842681 1 190439 yuqiang.xian 2013-02-26 21:56:05 -0800 Created attachment 190439 patch 842688 2 yuqiang.xian 2013-02-26 22:01:22 -0800 Ah... Just noticed Filip's commit of http://trac.webkit.org/changeset/144137. It should have been fixed! So this should be invalid. 842720 3 yuqiang.xian 2013-02-26 23:00:28 -0800 *** This bug has been marked as a duplicate of bug 109036 *** 190439 2013-02-26 21:56:05 -0800 2013-02-26 22:02:10 -0800 patch 110942.0.patch text/plain 3990 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ0MTQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDEzLTAyLTI2ICBZdXFpYW5nIFhpYW4gIDx5dXFpYW5nLnhpYW5AaW50ZWwuY29tPgorCisg ICAgICAgIFdlIHNob3VsZCByZWNvcmQgdGhlIEpJVENvZGVNYXAgZm9yIHRoZSBKUyBmdW5jdGlv biB0aGF0IGNvdWxkIGJlIGlubGluZWQgYnV0IG5vdCBkaXJlY3RseSBjb21waWxlZCB3aXRoIERG RworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTQy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gcGFy dGljdWxhciwgaWYgdGhlIEpTIGZ1bmN0aW9uIGNvbnRhaW5zIHRoZSBvcF9jYWxsX3ZhcmFyZ3MK KyAgICAgICAgYnl0ZWNvZGUsIGl0IGNhbm5vdCBiZSBkaXJlY3RseSBjb21waWxlZCBidXQgY2Fu IGJlIGlubGluZWQgKGluCisgICAgICAgIGNlcnRhaW4gY2FzZXMpIHdpdGggREZHLiBJbiB0aGlz IGNhc2UgaWYgd2UgZG9uJ3QgcmVjb3JkIHRoZQorICAgICAgICBKSVRDb2RlTWFwIGZvciB0aGlz IGZ1bmN0aW9uLCB3ZSB3aWxsIGhhdmUgcHJvYmxlbXMgaWYgT1NSIGV4aXQKKyAgICAgICAgaGFw cGVucyBpbnNpZGUgdGhpcyBmdW5jdGlvbi4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9j ay5jcHA6CisgICAgICAgIChKU0M6OkZ1bmN0aW9uQ29kZUJsb2NrOjpjYW5JbmxpbmVXaXRoREZH SW50ZXJuYWwpOgorICAgICAgICAoSlNDKToKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2su aDoKKyAgICAgICAgKENvZGVCbG9jayk6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6Y2FuSW5s aW5lV2l0aERGRyk6CisgICAgICAgIChKU0M6OlByb2dyYW1Db2RlQmxvY2s6OmNhbklubGluZVdp dGhERkdJbnRlcm5hbCk6CisgICAgICAgIChKU0M6OkV2YWxDb2RlQmxvY2s6OmNhbklubGluZVdp dGhERkdJbnRlcm5hbCk6CisgICAgICAgIChGdW5jdGlvbkNvZGVCbG9jayk6CisgICAgICAgICog aml0L0pJVC5jcHA6CisgICAgICAgIChKU0M6OkpJVDo6cHJpdmF0ZUNvbXBpbGUpOgorCiAyMDEz LTAyLTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIE9T UiBleGl0IGRvZXNuJ3Qga25vdyB3aGljaCB2aXJ0dWFsIHJlZ2lzdGVyIHRvIHVzZSBmb3IgdGhl IGxhc3QgcmVzdWx0IHJlZ2lzdGVyIGZvciBwb3N0X2luYyBhbmQgcG9zdF9kZWMKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAx NDQxMzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjg2NCw2ICsyODY0LDEzIEBAIERGRzo6Q2FwYWJpbGl0eUxldmVs IEZ1bmN0aW9uQ29kZUJsb2NrOjoKICAgICByZXR1cm4gREZHOjpjYW5Db21waWxlRnVuY3Rpb25G b3JDYWxsKHRoaXMpOwogfQogCitib29sIEZ1bmN0aW9uQ29kZUJsb2NrOjpjYW5JbmxpbmVXaXRo REZHSW50ZXJuYWwoKQoreworICAgIGlmIChtX2lzQ29uc3RydWN0b3IpCisgICAgICAgIHJldHVy biBERkc6OmNhbklubGluZUZ1bmN0aW9uRm9yQ29uc3RydWN0KHRoaXMpOworICAgIHJldHVybiBE Rkc6OmNhbklubGluZUZ1bmN0aW9uRm9yQ2FsbCh0aGlzKTsKK30KKwogdm9pZCBQcm9ncmFtQ29k ZUJsb2NrOjpqZXR0aXNvbigpCiB7CiAgICAgQVNTRVJUKEpJVENvZGU6OmlzT3B0aW1pemluZ0pJ VChnZXRKSVRUeXBlKCkpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9D b2RlQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv Q29kZUJsb2NrLmgJKHJldmlzaW9uIDE0NDEzMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9Db2RlQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtNDY1LDYgKzQ2NSw5IEBAIG5h bWVzcGFjZSBKU0MgewogICAgICAgICB9CiAgICAgICAgIERGRzo6Q2FwYWJpbGl0eUxldmVsIGNh bkNvbXBpbGVXaXRoREZHU3RhdGUoKSB7IHJldHVybiBtX2NhbkNvbXBpbGVXaXRoREZHU3RhdGU7 IH0KIAorICAgICAgICB2aXJ0dWFsIGJvb2wgY2FuSW5saW5lV2l0aERGR0ludGVybmFsKCkgPSAw OworICAgICAgICBib29sIGNhbklubGluZVdpdGhERkcoKSB7IHJldHVybiBjYW5JbmxpbmVXaXRo REZHSW50ZXJuYWwoKTsgfQorCiAgICAgICAgIGJvb2wgaGFzT3B0aW1pemVkUmVwbGFjZW1lbnQo KQogICAgICAgICB7CiAgICAgICAgICAgICBBU1NFUlQoSklUQ29kZTo6aXNCYXNlbGluZUNvZGUo Z2V0SklUVHlwZSgpKSk7CkBAIC0xMzI1LDYgKzEzMjgsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgdmlydHVhbCBib29sIGppdENvbXBpbGVJbXBsKEV4ZWNTdGF0ZSopOwogICAgICAgICB2 aXJ0dWFsIENvZGVCbG9jayogcmVwbGFjZW1lbnQoKTsKICAgICAgICAgdmlydHVhbCBERkc6OkNh cGFiaWxpdHlMZXZlbCBjYW5Db21waWxlV2l0aERGR0ludGVybmFsKCk7CisgICAgICAgIHZpcnR1 YWwgYm9vbCBjYW5JbmxpbmVXaXRoREZHSW50ZXJuYWwoKSB7IHJldHVybiBmYWxzZTsgfQogI2Vu ZGlmCiAgICAgfTsKIApAQCAtMTM1MCw2ICsxMzU0LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAg ICAgIHZpcnR1YWwgYm9vbCBqaXRDb21waWxlSW1wbChFeGVjU3RhdGUqKTsKICAgICAgICAgdmly dHVhbCBDb2RlQmxvY2sqIHJlcGxhY2VtZW50KCk7CiAgICAgICAgIHZpcnR1YWwgREZHOjpDYXBh YmlsaXR5TGV2ZWwgY2FuQ29tcGlsZVdpdGhERkdJbnRlcm5hbCgpOworICAgICAgICB2aXJ0dWFs IGJvb2wgY2FuSW5saW5lV2l0aERGR0ludGVybmFsKCkgeyByZXR1cm4gZmFsc2U7IH0KICNlbmRp ZgogCiAgICAgcHJpdmF0ZToKQEAgLTEzNzUsNiArMTM4MCw3IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgICAgICB2aXJ0dWFsIGJvb2wgaml0Q29tcGlsZUltcGwoRXhlY1N0YXRlKik7CiAgICAgICAg IHZpcnR1YWwgQ29kZUJsb2NrKiByZXBsYWNlbWVudCgpOwogICAgICAgICB2aXJ0dWFsIERGRzo6 Q2FwYWJpbGl0eUxldmVsIGNhbkNvbXBpbGVXaXRoREZHSW50ZXJuYWwoKTsKKyAgICAgICAgdmly dHVhbCBib29sIGNhbklubGluZVdpdGhERkdJbnRlcm5hbCgpOwogI2VuZGlmCiAgICAgfTsKIApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAkocmV2aXNpb24gMTQ0MTMxKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MTUsNyAr ODE1LDcgQEAgSklUQ29kZSBKSVQ6OnByaXZhdGVDb21waWxlKENvZGVQdHIqIGZ1bgogICAgIH0K IAogI2lmIEVOQUJMRShERkdfSklUKSB8fCBFTkFCTEUoTExJTlQpCi0gICAgaWYgKGNhbkJlT3B0 aW1pemVkKCkKKyAgICBpZiAoY2FuQmVPcHRpbWl6ZWQoKSB8fCBtX2NvZGVCbG9jay0+Y2FuSW5s aW5lV2l0aERGRygpCiAjaWYgRU5BQkxFKExMSU5UKQogICAgICAgICB8fCB0cnVlCiAjZW5kaWYK