110941 2013-02-26 21:21:33 -0800 MediaStream constructor test should cover ended MediaStreamTrack. 2013-02-27 03:53:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 li.yin li.yin abarth eric.carlson feature-media-reviews haraken hta jer.noble tommyw webkit.review.bot oldest_to_newest 842670 0 li.yin 2013-02-26 21:21:33 -0800 Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastream If tracks has ended, it should skip this track and continue with the next one. 842675 1 190437 li.yin 2013-02-26 21:33:59 -0800 Created attachment 190437 Patch 842768 2 190437 haraken 2013-02-27 00:24:03 -0800 Comment on attachment 190437 Patch Looks reasonable. 842769 3 190437 tommyw 2013-02-27 00:26:56 -0800 Comment on attachment 190437 Patch Looks fine to me too. 842911 4 190437 webkit.review.bot 2013-02-27 03:53:03 -0800 Comment on attachment 190437 Patch Clearing flags on attachment: 190437 Committed r144166: <http://trac.webkit.org/changeset/144166> 842912 5 webkit.review.bot 2013-02-27 03:53:07 -0800 All reviewed patches have been landed. Closing bug. 190437 2013-02-26 21:33:59 -0800 2013-02-27 03:53:03 -0800 Patch bug-110941-20130227133011.patch text/plain 3873 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MTI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWNiYWJjMmFhMDE2MWY4NGM0MWEy NzhlNzgwZGU0NmQ1ZDljNmVkNy4uYWI1NjEzNjMyM2ZlZGQ5MzI0YjU0Mjg0YTFjMjkwMTI0NDJl MTYwMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTI2ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFtIGNvbnN0cnVjdG9yIHRlc3Qgc2hvdWxk IGNvdmVyIGVuZGVkIE1lZGlhU3RyZWFtVHJhY2suCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjOiBodHRwOi8vZGV2LnczLm9yZy8yMDExL3dlYnJ0 Yy9lZGl0b3IvZ2V0dXNlcm1lZGlhLmh0bWwjbWVkaWFzdHJlYW0KKyAgICAgICAgSWYgdHJhY2tz IGhhcyBlbmRlZCwgaXQgc2hvdWxkIHNraXAgdGhlc2UgdHJhY2tzIGFuZCBjb250aW51ZSB3aXRo IHRoZSBuZXh0IG9uZS4KKworICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1D b25zdHJ1Y3Rvci1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9tZWRpYXN0cmVhbS9NZWRp YVN0cmVhbUNvbnN0cnVjdG9yLmh0bWw6CisKIDIwMTMtMDItMjYgIFN0ZXBoZW4gQ2hlbm5leSAg PHNjaGVubmV5QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFRlc3RFeHBlY3Rh dGlvbnMgYWRkaXRpb24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0v TWVkaWFTdHJlYW1Db25zdHJ1Y3Rvci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L21l ZGlhc3RyZWFtL01lZGlhU3RyZWFtQ29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CmluZGV4IDJkNTcw Zjg5NjYxNjA5Y2ExY2UwYWNkMmM4ZTZlZWRlOTE3NzQwYzcuLjJjNDA1MzY0ZjMyZGI0ZTNjN2Zh Y2E5MjFmZjUyZGIzM2E1ZWQ2YzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFz dHJlYW0vTWVkaWFTdHJlYW1Db25zdHJ1Y3Rvci1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbUNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dApA QCAtNTYsNiArNTYsMzAgQEAgUEFTUyBbb2JqZWN0IE1lZGlhU3RyZWFtXSBpcyBkZWZpbmVkLgog UEFTUyBuZXdTdHJlYW0uY29uc3RydWN0b3IubmFtZSBpcyAnTWVkaWFTdHJlYW0nCiBQQVNTIG5l d1N0cmVhbS5nZXRBdWRpb1RyYWNrcygpLmxlbmd0aCBpcyBuQXVkaW8KIFBBU1MgbmV3U3RyZWFt LmdldFZpZGVvVHJhY2tzKCkubGVuZ3RoIGlzIG5WaWRlbworUEFTUyBTdHJlYW0gY29uc3RydWN0 ZWQKK1BBU1MgW29iamVjdCBNZWRpYVN0cmVhbV0gaXMgbm9uLW51bGwuCitQQVNTIFtvYmplY3Qg TWVkaWFTdHJlYW1dIGlzIGRlZmluZWQuCitQQVNTIG5ld1N0cmVhbS5jb25zdHJ1Y3Rvci5uYW1l IGlzICdNZWRpYVN0cmVhbScKK1BBU1MgbmV3U3RyZWFtLmdldEF1ZGlvVHJhY2tzKCkubGVuZ3Ro IGlzIG5BdWRpbworUEFTUyBuZXdTdHJlYW0uZ2V0VmlkZW9UcmFja3MoKS5sZW5ndGggaXMgblZp ZGVvCitQQVNTIFN0cmVhbSBjb25zdHJ1Y3RlZAorUEFTUyBbb2JqZWN0IE1lZGlhU3RyZWFtXSBp cyBub24tbnVsbC4KK1BBU1MgW29iamVjdCBNZWRpYVN0cmVhbV0gaXMgZGVmaW5lZC4KK1BBU1Mg bmV3U3RyZWFtLmNvbnN0cnVjdG9yLm5hbWUgaXMgJ01lZGlhU3RyZWFtJworUEFTUyBuZXdTdHJl YW0uZ2V0QXVkaW9UcmFja3MoKS5sZW5ndGggaXMgbkF1ZGlvCitQQVNTIG5ld1N0cmVhbS5nZXRW aWRlb1RyYWNrcygpLmxlbmd0aCBpcyBuVmlkZW8KK1BBU1MgU3RyZWFtIGNvbnN0cnVjdGVkCitQ QVNTIFtvYmplY3QgTWVkaWFTdHJlYW1dIGlzIG5vbi1udWxsLgorUEFTUyBbb2JqZWN0IE1lZGlh U3RyZWFtXSBpcyBkZWZpbmVkLgorUEFTUyBuZXdTdHJlYW0uY29uc3RydWN0b3IubmFtZSBpcyAn TWVkaWFTdHJlYW0nCitQQVNTIG5ld1N0cmVhbS5nZXRBdWRpb1RyYWNrcygpLmxlbmd0aCBpcyBu QXVkaW8KK1BBU1MgbmV3U3RyZWFtLmdldFZpZGVvVHJhY2tzKCkubGVuZ3RoIGlzIG5WaWRlbwor UEFTUyBTdHJlYW0gY29uc3RydWN0ZWQKK1BBU1MgW29iamVjdCBNZWRpYVN0cmVhbV0gaXMgbm9u LW51bGwuCitQQVNTIFtvYmplY3QgTWVkaWFTdHJlYW1dIGlzIGRlZmluZWQuCitQQVNTIG5ld1N0 cmVhbS5jb25zdHJ1Y3Rvci5uYW1lIGlzICdNZWRpYVN0cmVhbScKK1BBU1MgbmV3U3RyZWFtLmdl dEF1ZGlvVHJhY2tzKCkubGVuZ3RoIGlzIG5BdWRpbworUEFTUyBuZXdTdHJlYW0uZ2V0VmlkZW9U cmFja3MoKS5sZW5ndGggaXMgblZpZGVvCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVl CiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJl YW0vTWVkaWFTdHJlYW1Db25zdHJ1Y3Rvci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0 cmVhbS9NZWRpYVN0cmVhbUNvbnN0cnVjdG9yLmh0bWwKaW5kZXggNjA2OTI1YTUwODFlOWVhMTIz ZTcyODNkYTQ1NzJiNDU5YTkyOTc5ZC4uNTZhNTU4OWJhNTkyYjUzOTZlYzMyODMyNzY0ZTMzMGU2 ZjdiYjM0YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0 cmVhbUNvbnN0cnVjdG9yLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9N ZWRpYVN0cmVhbUNvbnN0cnVjdG9yLmh0bWwKQEAgLTM5LDggKzM5LDYgQEAgZnVuY3Rpb24gZ290 U3RyZWFtKHMpIHsKICAgICBzaG91bGRCZVRydWUoInR5cGVvZiB3ZWJraXRNZWRpYVN0cmVhbSA9 PT0gJ2Z1bmN0aW9uJyIpOwogCiAgICAgdGVzdENvbnN0cnVjdG9yKGxvY2FsU3RyZWFtKTsKLQot ICAgIGZpbmlzaEpTVGVzdCgpOwogfQogCiBmdW5jdGlvbiB0ZXN0Q29uc3RydWN0b3IocykgewpA QCAtNjIsNiArNjAsMTcgQEAgZnVuY3Rpb24gdGVzdENvbnN0cnVjdG9yKHMpIHsKICAgICB2ZXJp ZnlTdHJlYW0obmV3IHdlYmtpdE1lZGlhU3RyZWFtKFtzLmdldFZpZGVvVHJhY2tzKClbMF1dKSwg MCwgMSk7CiAgICAgdmVyaWZ5U3RyZWFtKG5ldyB3ZWJraXRNZWRpYVN0cmVhbShbcy5nZXRBdWRp b1RyYWNrcygpWzBdLCBzLmdldFZpZGVvVHJhY2tzKClbMF1dKSwgMSwgMSk7CiAgICAgdmVyaWZ5 U3RyZWFtKG5ldyB3ZWJraXRNZWRpYVN0cmVhbShbcy5nZXRWaWRlb1RyYWNrcygpWzBdLCBzLmdl dEF1ZGlvVHJhY2tzKClbMF0sIHMuZ2V0VmlkZW9UcmFja3MoKVswXV0pLCAxLCAxKTsKKworICAg IHMub25lbmRlZCA9IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgdmVyaWZ5U3RyZWFtKG5ldyB3ZWJr aXRNZWRpYVN0cmVhbShbcy5nZXRBdWRpb1RyYWNrcygpWzBdXSksIDAsIDApOworICAgICAgICB2 ZXJpZnlTdHJlYW0obmV3IHdlYmtpdE1lZGlhU3RyZWFtKFtzLmdldFZpZGVvVHJhY2tzKClbMF1d KSwgMCwgMCk7CisgICAgICAgIHZlcmlmeVN0cmVhbShuZXcgd2Via2l0TWVkaWFTdHJlYW0oW3Mu Z2V0QXVkaW9UcmFja3MoKVswXSwgcy5nZXRWaWRlb1RyYWNrcygpWzBdXSksIDAsIDApOworICAg ICAgICB2ZXJpZnlTdHJlYW0obmV3IHdlYmtpdE1lZGlhU3RyZWFtKHMpLCAwLCAwKTsKKworICAg ICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICB9OworCisgICAgcy5zdG9wKCk7CiB9CiAKIGZ1bmN0 aW9uIHZlcmlmeVN0cmVhbShzLCBudW1BdWRpb1RyYWNrcywgbnVtVmlkZW9UcmFja3MpIHsK