110928 2013-02-26 17:00:51 -0800 [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame 2013-04-08 16:35:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 jamesr jamesr enne schenney vsevik webkit.review.bot oldest_to_newest 842531 0 jamesr 2013-02-26 17:00:51 -0800 [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame 842532 1 190396 jamesr 2013-02-26 17:01:04 -0800 Created attachment 190396 Patch 842535 2 190396 enne 2013-02-26 17:04:09 -0800 Comment on attachment 190396 Patch R=me. 842544 3 jamesr 2013-02-26 17:11:38 -0800 Committed r144129: <http://trac.webkit.org/changeset/144129> 842725 4 vsevik 2013-02-26 23:14:52 -0800 This patch has broken compilation on mac/win FAILED: clang++ -MMD -MF ... ../../webkit/compositor_bindings/web_layer_tree_view_unittest.cc -o obj/webkit/compositor_bindings/webkit_compositor_bindings_unittests.web_layer_tree_view_unittest.o ../../webkit/compositor_bindings/web_layer_tree_view_unittest.cc:28:16:error: 'didBeginFrame' marked 'override' but does not override any member functions virtual void didBeginFrame() OVERRIDE { ^ 1 error generated. ninja: build stopped: subcommand failed. 842729 5 webkit.review.bot 2013-02-26 23:17:36 -0800 Re-opened since this is blocked by bug 110947 842730 6 vsevik 2013-02-26 23:17:56 -0800 http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/35456 http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/16661 842732 7 vsevik 2013-02-26 23:18:20 -0800 . 190396 2013-02-26 17:01:04 -0800 2013-02-26 17:04:09 -0800 Patch bug-110928-20130226165719.patch text/plain 4915 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA3NGVhMGFkOTA2YzJi NjIxZDZkNGEyODc2YTliNmJmYTg5NDAxNzdjLi5iMjJmOTViMzA5NGUxOTQxOTk3Y2IwYzJkMWQy NDU1MTYzZDM4OWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxMy0wMi0yNiAg SmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFtjaHJvbWl1 bV0gUmVtb3ZlIFdlYkxheWVyVHJlZVZpZXdDbGllbnQ6Oih3aWxsfGRpZClCZWdpbkZyYW1lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5MjgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNocm9taXVt L3B1YmxpYy9XZWJMYXllclRyZWVWaWV3Q2xpZW50Lmg6CisKKzIwMTMtMDItMjYgIEphbWVzIFJv Ymluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbY2hyb21pdW1dIFJlbW92 ZSB1bnVzZWQgV2ViTGF5ZXJUcmVlVmlld0NsaWVudCBjYWxscwogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTIzCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKaW5kZXggMzQ2ZmE5ZGRkMDE5YjQ1NGM1OTY3MjVjYTc5MDQxYWNhM2FjZWEzMS4uYjg2 OTQzMmM5NWIwMjQ5YWQyNTVkMzA2MjAwNGM0MDQ1OTM1MDk2YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxMy0wMi0yNiAgSmFtZXMgUm9iaW5zb24gIDxq YW1lc3JAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIFdlYkxheWVy VHJlZVZpZXdDbGllbnQ6Oih3aWxsfGRpZClCZWdpbkZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5MjgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAg ICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisgICAgICAgICogdGVzdHMvV2ViTGF5ZXJUcmVlVmll d1Rlc3RDb21tb24uaDoKKworMjAxMy0wMi0yNiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hy b21pdW0ub3JnPgorCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIHVudXNlZCBXZWJMYXllclRy ZWVWaWV3Q2xpZW50IGNhbGxzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTA5MjMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJMYXllclRyZWVWaWV3Q2xpZW50LmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21p dW0vcHVibGljL1dlYkxheWVyVHJlZVZpZXdDbGllbnQuaAppbmRleCBhZGE1ODljMWNkNTYyMjM5 MGM4YWQyYzM3MDg3NWJiMzVhNWY5ZjE5Li5kYWI2NTAyNGYwMDc3OTUyMGRlZmRmNTk0NDA2YjZm ZjAxNGRkYjFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dl YkxheWVyVHJlZVZpZXdDbGllbnQuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVi bGljL1dlYkxheWVyVHJlZVZpZXdDbGllbnQuaApAQCAtMzcsMTcgKzM3LDYgQEAgc3RydWN0IFdl YlNpemU7CiAKIGNsYXNzIFdlYkxheWVyVHJlZVZpZXdDbGllbnQgewogcHVibGljOgotICAgIC8v IEluZGljYXRlcyB0byB0aGUgZW1iZWRkZXIgdGhhdCB0aGUgY29tcG9zaXRvciBpcyBhYm91dCB0 byBiZWdpbiBhCi0gICAgLy8gZnJhbWUuIFRoaXMgaXMgaXMgYSBzaWduYWwgdG8gZmxvdyBjb250 cm9sIG1lY2hhbmlzbXMgdGhhdCBhIGZyYW1lIGlzCi0gICAgLy8gYmVnaW5uaW5nLiBUaGlzIGNh bGwgd2lsbCBiZSBmb2xsb3dlZCBieSB1cGRhdGVBbmltYXRpb25zIGFuZCB0aGVuCi0gICAgLy8g bGF5b3V0LCB3aGljaCBzaG91bGQgYmUgdXNlZCBmb3IgYWN0dWFsIGFuaW1hdGlvbiBvciB0cmVl IG1hbmlwdWxhdGlvbgotICAgIC8vIHRhc2tzLiAgRklYTUU6IG1ha2UgcHVyZSB2aXJ0dWFsIG9u Y2UgdXBzdHJlYW0gZGVwcyBhcmUgc2F0aXNmaWVkLgotICAgIHZpcnR1YWwgdm9pZCB3aWxsQmVn aW5GcmFtZSgpIHsgfQotCi0gICAgLy8gSW5kaWNhdGVzIHRoYXQgbWFpbiB0aHJlYWQgdGFza3Mg YXNzb2NpYXRlZCB3aXRoIGZyYW1lIHJlbmRlcmluZyBoYXZlIGNvbXBsZXRlZC4KLSAgICAvLyBJ c3N1ZWQgdW5jb25kaXRpb25hbGx5LCBldmVuIGlmIHRoZSBjb250ZXh0IHdhcyBsb3N0IGluIHRo ZSBwcm9jZXNzLgotICAgIHZpcnR1YWwgdm9pZCBkaWRCZWdpbkZyYW1lKCkgeyB9Ci0KICAgICAv LyBVcGRhdGVzIGFuaW1hdGlvbiBhbmQgbGF5b3V0LiBUaGVzZSBhcmUgY2FsbGVkIGJlZm9yZSB0 aGUgY29tcG9zaXRpbmcKICAgICAvLyBwYXNzIHNvIHRoYXQgbGF5ZXJzIGNhbiBiZSB1cGRhdGVk IGF0IHRoZSBnaXZlbiBmcmFtZSB0aW1lLgogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVBbmltYXRp b25zKGRvdWJsZSBtb25vdG9uaWNGcmFtZUJlZ2luVGltZSkgPSAwOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDIyZWI4YWRiM2Y3YTdiZDE3MzFjYjk0 OThjZWI0MTNmMjdkODAxZTUuLmVjM2I2MTE5OTdiNjdhMTUxMTdhNTQzNzg3YWJkYmUxODM3OTlm N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE4 MzEsMTcgKzE4MzEsNiBAQCB2b2lkIFdlYlZpZXdJbXBsOjphbmltYXRlKGRvdWJsZSkKICNlbmRp ZgogfQogCi12b2lkIFdlYlZpZXdJbXBsOjp3aWxsQmVnaW5GcmFtZSgpCi17Ci0gICAgbV9jbGll bnQtPndpbGxCZWdpbkNvbXBvc2l0b3JGcmFtZSgpOwotfQotCi12b2lkIFdlYlZpZXdJbXBsOjpk aWRCZWdpbkZyYW1lKCkKLXsKLSAgICBpZiAobV9kZXZUb29sc0FnZW50KQotICAgICAgICBtX2Rl dlRvb2xzQWdlbnQtPmRpZENvbXBvc2l0ZSgpOwotfQotCiB2b2lkIFdlYlZpZXdJbXBsOjp1cGRh dGVBbmltYXRpb25zKGRvdWJsZSBtb25vdG9uaWNGcmFtZUJlZ2luVGltZSkKIHsKICNpZiBFTkFC TEUoUkVRVUVTVF9BTklNQVRJT05fRlJBTUUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuaAppbmRleCA2Njk5MGYzMzg0MjI4MDQ5MTI2MjFhMjE3NDc5MTdiN2IyMTM0MTI5 Li40YzQ3ZTk3ZjQ3YWQ3NTM0ZDNiYWUzZjA3MmIyNTEyMzVmZDEyOTY5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAgLTMxNSw4ICszMTUsNiBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIHNldENvbnRpbnVvdXNQYWludGluZ0VuYWJsZWQoYm9vbCk7CiAK ICAgICAvLyBXZWJMYXllclRyZWVWaWV3Q2xpZW50Ci0gICAgdmlydHVhbCB2b2lkIHdpbGxCZWdp bkZyYW1lKCk7Ci0gICAgdmlydHVhbCB2b2lkIGRpZEJlZ2luRnJhbWUoKTsKICAgICB2aXJ0dWFs IHZvaWQgdXBkYXRlQW5pbWF0aW9ucyhkb3VibGUgbW9ub3RvbmljRnJhbWVCZWdpblRpbWUpOwog ICAgIHZpcnR1YWwgdm9pZCBhcHBseVNjcm9sbEFuZFNjYWxlKGNvbnN0IFdlYlNpemUmLCBmbG9h dCk7CiAgICAgdmlydHVhbCBXZWJDb21wb3NpdG9yT3V0cHV0U3VyZmFjZSogY3JlYXRlT3V0cHV0 U3VyZmFjZSgpIE9WRVJSSURFOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9XZWJMYXllclRyZWVWaWV3VGVzdENvbW1vbi5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9XZWJMYXllclRyZWVWaWV3VGVzdENvbW1vbi5oCmluZGV4IDE4YTU2Yzk2NTlmOTQ5 ZmRmOTgwOWU0YTBlMTJkMjQzNDk2MzI3ZWEuLmFmMjBjNmU2NDdkZTE4ZjgwYzE2YjIyZTZlYzI4 ZGMyYjExZjRhMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2Vi TGF5ZXJUcmVlVmlld1Rlc3RDb21tb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL1dlYkxheWVyVHJlZVZpZXdUZXN0Q29tbW9uLmgKQEAgLTM3LDggKzM3LDYgQEAgY2xhc3Mg TW9ja1dlYkxheWVyVHJlZVZpZXdDbGllbnQgOiBwdWJsaWMgV2ViTGF5ZXJUcmVlVmlld0NsaWVu dCB7CiBwdWJsaWM6CiAgICAgTU9DS19NRVRIT0QwKHNjaGVkdWxlQ29tcG9zaXRlLCB2b2lkKCkp OwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVBbmltYXRpb25zKGRvdWJsZSBmcmFtZUJlZ2luVGlt ZSkgT1ZFUlJJREUgeyB9Ci0gICAgTU9DS19NRVRIT0QwKHdpbGxCZWdpbkZyYW1lLCB2b2lkKCkp OwotICAgIE1PQ0tfTUVUSE9EMChkaWRCZWdpbkZyYW1lLCB2b2lkKCkpOwogICAgIHZpcnR1YWwg dm9pZCBsYXlvdXQoKSBPVkVSUklERSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgYXBwbHlTY3JvbGxB bmRTY2FsZShjb25zdCBXZWJTaXplJiBzY3JvbGxEZWx0YSwgZmxvYXQgc2NhbGVGYWN0b3IpIE9W RVJSSURFIHsgfQogCg==