110925 2013-02-26 16:49:31 -0800 PDFPlugin: PDF orientation isn't respected when printing or print-previewing 2013-02-28 11:19:08 -0800 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton webkit-unassigned ap oldest_to_newest 842517 0 thorton 2013-02-26 16:49:31 -0800 <rdar://problem/13008621> 842554 1 190400 thorton 2013-02-26 17:32:07 -0800 Created attachment 190400 print 842555 2 190401 thorton 2013-02-26 17:32:07 -0800 Created attachment 190401 842609 3 190400 ap 2013-02-26 19:16:06 -0800 Comment on attachment 190400 print View in context: https://bugs.webkit.org/attachment.cgi?id=190400&action=review > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:812 > + NSInteger rotation = [pdfPage rotation]; > + if (rotation == 90 || rotation == 270) > + std::swap(cropBox.size.width, cropBox.size.height); Please add a comment about why this is the right thing to do (which is because we always autorotate). When we looked at this code previously, we both agreed that it was wrong, so it's not at all obvious what's going on. 844249 4 thorton 2013-02-28 11:19:08 -0800 http://trac.webkit.org/changeset/144333 190400 2013-02-26 17:32:07 -0800 2013-02-26 19:16:06 -0800 print print.diff text/plain 1656 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMThiODc5Li5mYzY3M2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDItMjYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUERGUGx1Z2luOiBQREYgb3JpZW50YXRpb24gaXNuJ3QgcmVzcGVjdGVkIHdoZW4g cHJpbnRpbmcgb3IgcHJpbnQtcHJldmlld2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwOTI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzAw ODYyMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6 ZHJhd1BERlBhZ2UpOiBUZWFjaCBkcmF3UERGUGFnZSBhYm91dCBQREZQYWdlJ3Mgcm90YXRpb24g cHJvcGVydHksIGFuZCB1c2UgaXQKKyAgICAgICAgdG8gc3dhcCB0aGUgUERGJ3MgY3JvcGJveC4g UGFpbnRpbmcgbm93IG1hdGNoZXMgUERGVmlld0NvbnRyb2xsZXIncyBoaXN0b3JpY2FsIGJlaGF2 aW9yLgorCiAyMDEzLTAyLTIyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIFtXSzJdIFRoZSByb290IGFuZCBwYWdlIG92ZXJsYXkgbGF5ZXJzIHNob3Vs ZCBiZSB0aGUgc2l6ZSBvZiB0aGUgdmlldywgbm90IHRoZSBjb250ZW50CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0gYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0KaW5kZXggYmUw ZGU3OS4uNDNiMTJkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9XZWJQYWdlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvV2ViUGFnZU1hYy5tbQpAQCAtODA3LDYgKzgwNywxMCBAQCBzdGF0aWMgdm9pZCBk cmF3UERGUGFnZShQREZEb2N1bWVudCAqcGRmRG9jdW1lbnQsIENGSW5kZXggcGFnZUluZGV4LCBD R0NvbnRleHRSZQogICAgIGVsc2UKICAgICAgICAgY3JvcEJveCA9IE5TSW50ZXJzZWN0aW9uUmVj dChjcm9wQm94LCBbcGRmUGFnZSBib3VuZHNGb3JCb3g6a1BERkRpc3BsYXlCb3hNZWRpYUJveF0p OwogCisgICAgTlNJbnRlZ2VyIHJvdGF0aW9uID0gW3BkZlBhZ2Ugcm90YXRpb25dOworICAgIGlm IChyb3RhdGlvbiA9PSA5MCB8fCByb3RhdGlvbiA9PSAyNzApCisgICAgICAgIHN0ZDo6c3dhcChj cm9wQm94LnNpemUud2lkdGgsIGNyb3BCb3guc2l6ZS5oZWlnaHQpOworCiAgICAgYm9vbCBzaG91 bGRSb3RhdGUgPSAocGFwZXJTaXplLndpZHRoIDwgcGFwZXJTaXplLmhlaWdodCkgIT0gKGNyb3BC b3guc2l6ZS53aWR0aCA8IGNyb3BCb3guc2l6ZS5oZWlnaHQpOwogICAgIGlmIChzaG91bGRSb3Rh dGUpCiAgICAgICAgIHN3YXAoY3JvcEJveC5zaXplLndpZHRoLCBjcm9wQm94LnNpemUuaGVpZ2h0 KTsK