11092 2006-09-29 15:34:29 -0700 Windows build busted 2006-09-29 18:54:01 -0700 1 1 1 Unclassified WebKit Platform 420+ PC Windows XP RESOLVED FIXED P2 Major --- 0 fishd webkit-unassigned oldest_to_newest 56811 0 fishd 2006-09-29 15:34:29 -0700 Windows build busted Problems with ScrollViewWin.cpp referencing an undefined variable and Widget having undefined symbols. Patch coming up... 56812 1 10841 fishd 2006-09-29 15:39:54 -0700 Created attachment 10841 patch This fixes the build bustage. I went for "#if !PLATFORM(MAC)" in Widget.cpp since the code should work for all other platforms. I can also move the code into WidgetWin.cpp if that is preferred. 56814 2 10841 mjs 2006-09-29 16:39:09 -0700 Comment on attachment 10841 patch r=me 56815 3 hyatt 2006-09-29 16:42:05 -0700 Actually should just move that code into WidgetWin.cpp rather than leaving it in Widget 56817 4 10843 fishd 2006-09-29 18:13:47 -0700 Created attachment 10843 patch per hyatt OK, this patch simply moves the methods to WidgetWin.cpp as recommended by hyatt. I did not complete the other changes he suggested over IRC, but I didn't want to leave the tree broken, so I'm posting this simple patch. 10841 2006-09-29 15:39:54 -0700 2006-09-29 18:13:47 -0700 patch fix-1.diff text/plain 1652 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjU5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMDkt MjkgIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXM6IGh0dHA6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDkyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9XaWRnZXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0Ojpjb252ZXJ0VG9Db250YWluaW5nV2luZG93 KToKKyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6Y29udmVydEZyb21Db250YWluaW5nV2luZG93 KToKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vU2Nyb2xsVmlld1dpbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxWaWV3Ojpjb252ZXJ0VG9Db250YWluaW5nV2luZG93KToKKwogMjAwNi0w OS0yOSAgU2FtIFdlaW5pZyAgPHNhbS53ZWluaWdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFRpbSBILgpJbmRleDogcGxhdGZvcm0vV2lkZ2V0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBw bGF0Zm9ybS9XaWRnZXQuY3BwCShyZXZpc2lvbiAxNjYzMikKKysrIHBsYXRmb3JtL1dpZGdldC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNyw0ICsxMDcsMTYgQEAgSW50UmVjdCBXaWRnZXQ6OmNv bnZlcnRUb0NvbnRhaW5pbmdXaW5kbwogICAgIHJldHVybiBjb252ZXJ0ZWRSZWN0OwogfQogCisj aWYgIVBMQVRGT1JNKE1BQykKK0ludFBvaW50IFdpZGdldDo6Y29udmVydFRvQ29udGFpbmluZ1dp bmRvdyhjb25zdCBJbnRQb2ludCYgcG9pbnQpIGNvbnN0Cit7CisgIHJldHVybiBwb2ludDsKK30K KworSW50UG9pbnQgV2lkZ2V0Ojpjb252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3coY29uc3QgSW50 UG9pbnQmIHBvaW50KSBjb25zdAoreworICByZXR1cm4gcG9pbnQ7Cit9CisjZW5kaWYKKwogfQpJ bmRleDogcGxhdGZvcm0vd2luL1Njcm9sbFZpZXdXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRm b3JtL3dpbi9TY3JvbGxWaWV3V2luLmNwcAkocmV2aXNpb24gMTY2MzIpCisrKyBwbGF0Zm9ybS93 aW4vU2Nyb2xsVmlld1dpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MSw3ICsxNDEsNyBAQCBp bnQgU2Nyb2xsVmlldzo6Y29udGVudHNIZWlnaHQoKSBjb25zdAogCiBJbnRQb2ludCBTY3JvbGxW aWV3Ojpjb252ZXJ0VG9Db250YWluaW5nV2luZG93KGNvbnN0IEludFBvaW50JiBwb2ludCkgY29u c3QKIHsKLSAgICByZXR1cm4gY29udGVudHNQb2ludCAtIHNjcm9sbE9mZnNldCgpOworICAgIHJl dHVybiBwb2ludCAtIHNjcm9sbE9mZnNldCgpOwogfQogCiBJbnRQb2ludCBTY3JvbGxWaWV3Ojpj b252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3coY29uc3QgSW50UG9pbnQmIHBvaW50KSBjb25zdAo= 10843 2006-09-29 18:13:47 -0700 2006-09-29 18:52:20 -0700 patch per hyatt fix-1.1.diff text/plain 1916 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2Njc1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDYtMDkt MjkgIE1vcmdhbkwgIDxtb3JnYW5sLndlYmtpdEB5YWhvby5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXM6IGh0dHA6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDkyCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vU2Ny b2xsVmlld1dpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojpjb252ZXJ0VG9D b250YWluaW5nV2luZG93KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OmNvbnZlcnRG cm9tQ29udGFpbmluZ1dpbmRvdyk6CisgICAgICAgICogcGxhdGZvcm0vd2luL1dpZGdldFdpbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6OmNvbnZlcnRUb0NvbnRhaW5pbmdXaW5kb3cp OgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0Ojpjb252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3cp OgorCiAyMDA2LTA5LTI5ICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBIeWF0dC4KSW5kZXg6IHBsYXRmb3JtL3dpbi9TY3JvbGxWaWV3V2lu LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS93aW4vU2Nyb2xsVmlld1dpbi5jcHAJKHJldmlz aW9uIDE2NjMyKQorKysgcGxhdGZvcm0vd2luL1Njcm9sbFZpZXdXaW4uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNDEsMTIgKzE0MSwxMiBAQCBpbnQgU2Nyb2xsVmlldzo6Y29udGVudHNIZWlnaHQo KSBjb25zdAogCiBJbnRQb2ludCBTY3JvbGxWaWV3Ojpjb252ZXJ0VG9Db250YWluaW5nV2luZG93 KGNvbnN0IEludFBvaW50JiBwb2ludCkgY29uc3QKIHsKLSAgICByZXR1cm4gY29udGVudHNQb2lu dCAtIHNjcm9sbE9mZnNldCgpOworICAgIHJldHVybiBwb2ludCAtIHNjcm9sbE9mZnNldCgpOwog fQogCiBJbnRQb2ludCBTY3JvbGxWaWV3Ojpjb252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3coY29u c3QgSW50UG9pbnQmIHBvaW50KSBjb25zdAogewotICAgIHJldHVybiBJbnRQb2ludChwb2ludCkg KyBzY3JvbGxPZmZzZXQoKTsKKyAgICByZXR1cm4gcG9pbnQgKyBzY3JvbGxPZmZzZXQoKTsKIH0K IAogSW50U2l6ZSBTY3JvbGxWaWV3OjpzY3JvbGxPZmZzZXQoKSBjb25zdApJbmRleDogcGxhdGZv cm0vd2luL1dpZGdldFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vd2luL1dpZGdldFdp bi5jcHAJKHJldmlzaW9uIDE2NjMyKQorKysgcGxhdGZvcm0vd2luL1dpZGdldFdpbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEzNyw0ICsxMzcsMTQgQEAgdm9pZCBXaWRnZXQ6OnNldEZyYW1lR2Vv bWV0cnkoY29uc3QgSW50UgogICAgIE1vdmVXaW5kb3coZGF0YS0+Y29udGFpbmluZ1dpbmRvdywg cmVjdC54KCksIHJlY3QueSgpLCByZWN0LndpZHRoKCksIHJlY3QuaGVpZ2h0KCksIGZhbHNlKTsK IH0KIAorSW50UG9pbnQgV2lkZ2V0Ojpjb252ZXJ0VG9Db250YWluaW5nV2luZG93KGNvbnN0IElu dFBvaW50JiBwb2ludCkgY29uc3QKK3sKKyAgcmV0dXJuIHBvaW50OworfQorCitJbnRQb2ludCBX aWRnZXQ6OmNvbnZlcnRGcm9tQ29udGFpbmluZ1dpbmRvdyhjb25zdCBJbnRQb2ludCYgcG9pbnQp IGNvbnN0Cit7CisgIHJldHVybiBwb2ludDsKK30KKwogfQo=