110903 2013-02-26 13:02:34 -0800 getPropertyValue for -webkit-margin-collapse returns null, should compute the shorthand value 2013-02-27 15:21:21 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103244 0 udaykiran4u webkit-unassigned apavlov esprehn+autocc macpherson menard ojan.autocc udaykiran4u webkit.review.bot oldest_to_newest 842289 0 udaykiran4u 2013-02-26 13:02:34 -0800 getPropertyValue("-webkit-margin-collapse") should not return null when -webkit-margin-collapse is specified in CSS. 842301 1 190349 udaykiran4u 2013-02-26 13:12:27 -0800 Created attachment 190349 Patch 842691 2 190349 apavlov 2013-02-26 22:05:15 -0800 Comment on attachment 190349 Patch r=me 842698 3 190349 webkit.review.bot 2013-02-26 22:16:09 -0800 Comment on attachment 190349 Patch Clearing flags on attachment: 190349 Committed r144145: <http://trac.webkit.org/changeset/144145> 842699 4 webkit.review.bot 2013-02-26 22:16:12 -0800 All reviewed patches have been landed. Closing bug. 843560 5 udaykiran4u 2013-02-27 15:21:21 -0800 Thanks for review and cq+. 190349 2013-02-26 13:12:27 -0800 2013-02-26 22:16:09 -0800 Patch bug-110903-20130226130842.patch text/plain 6085 udaykiran4u U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzZkNmY5NTRjYWE0OTM2 ODlmYjE2NDUwMThhMWM3YzY1YzFiNzA3Yy4uM2IyZDExYmM2ZmYyMGQ0ZTFhOTE1MjA2ODZmNGVi NzNiZmYyNjg5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTI2ICBVZGF5 IEtpcmFuICA8dWRheWtpcmFuQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBnZXRQcm9wZXJ0eVZh bHVlIGZvciAtd2Via2l0LW1hcmdpbi1jb2xsYXBzZSByZXR1cm5zIG51bGwsIHNob3VsZCBjb21w dXRlIHRoZSBzaG9ydGhhbmQgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMDkwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGdldFByb3BlcnR5VmFsdWUoIi13ZWJraXQtbWFyZ2luLWNvbGxhcHNl Iikgc2hvdWxkIGNvbXB1dGUgc2hvcnRoYW5kIHZhbHVlCisgICAgICAgIHdoZW4gLXdlYmtpdC1t YXJnaW4tY29sbGFwc2UgaXMgc3BlY2lmaWVkIGluIENTUy4KKworICAgICAgICBUZXN0OiBmYXN0 L2Nzcy9nZXRQcm9wZXJ0eVZhbHVlLXdlYmtpdC1tYXJnaW4tY29sbGFwc2UuaHRtbAorCisgICAg ICAgICogY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVQ cm9wZXJ0eVNldDo6Z2V0UHJvcGVydHlWYWx1ZSk6CisKIDIwMTMtMDItMjMgIElseWEgVGlraG9u b3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5h dGl2ZSBNZW1vcnkgSW5zdHJ1bWVudGF0aW9uOiByZXBsYWNlIFN0cmluZyB3aXRoIGNvbnN0IGNo YXIqIGluIE1lbW9yeU9iamVjdEluZm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVByb3BlcnR5U2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0 LmNwcAppbmRleCBiZGRhYzA1NGNlZDdjOTJkOWU2NzcxYWNkYjE5NDIwOWY4YzBlMWIxLi4wZDE3 MTc1Yzg4NDdlMTJiODRiODRjZDk1ZTBlNTg2ODkyN2Q0MDNlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUHJvcGVydHlTZXQuY3BwCkBAIC0xNjgsNiArMTY4LDggQEAgU3RyaW5nIFN0eWxlUHJv cGVydHlTZXQ6OmdldFByb3BlcnR5VmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKSBjb25z dAogICAgICAgICByZXR1cm4gZm9udFZhbHVlKCk7CiAgICAgY2FzZSBDU1NQcm9wZXJ0eU1hcmdp bjoKICAgICAgICAgcmV0dXJuIGdldDRWYWx1ZXMobWFyZ2luU2hvcnRoYW5kKCkpOworICAgIGNh c2UgQ1NTUHJvcGVydHlXZWJraXRNYXJnaW5Db2xsYXBzZToKKyAgICAgICAgcmV0dXJuIGdldFNo b3J0aGFuZFZhbHVlKHdlYmtpdE1hcmdpbkNvbGxhcHNlU2hvcnRoYW5kKCkpOwogICAgIGNhc2Ug Q1NTUHJvcGVydHlPdmVyZmxvdzoKICAgICAgICAgcmV0dXJuIGdldENvbW1vblZhbHVlKG92ZXJm bG93U2hvcnRoYW5kKCkpOwogICAgIGNhc2UgQ1NTUHJvcGVydHlQYWRkaW5nOgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVi YzdhNmUyYzMyM2QzMjdiMmQzMjUwYjViNGY5ZGQ0MDU2MGIxOTguLmI3NjM2NTc2OThkNGUxNmVm YjUzODMyMjg3ZDJhYTYxZmQ1MTA4ZGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wMi0y NiAgVWRheSBLaXJhbiAgPHVkYXlraXJhbkBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgZ2V0UHJv cGVydHlWYWx1ZSBmb3IgLXdlYmtpdC1tYXJnaW4tY29sbGFwc2UgcmV0dXJucyBudWxsLCBzaG91 bGQgY29tcHV0ZSB0aGUgc2hvcnRoYW5kIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCB0ZXN0IGZvciBnZXRQcm9wZXJ0eVZhbHVlKCIt d2Via2l0LW1hcmdpbi1jb2xsYXBzZSIpLgorCisgICAgICAgICogZmFzdC9jc3MvZ2V0UHJvcGVy dHlWYWx1ZS13ZWJraXQtbWFyZ2luLWNvbGxhcHNlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9jc3MvZ2V0UHJvcGVydHlWYWx1ZS13ZWJraXQtbWFyZ2luLWNvbGxhcHNlLmh0 bWw6IEFkZGVkLgorCiAyMDEzLTAyLTI1ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgY2hyb21pdW0gdGVzdCBleHBlY3RhdGlvbnMg dXBkYXRlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZ2V0UHJvcGVydHlWYWx1 ZS13ZWJraXQtbWFyZ2luLWNvbGxhcHNlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL2dldFByb3BlcnR5VmFsdWUtd2Via2l0LW1hcmdpbi1jb2xsYXBzZS1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOTAyOWUyMTc1Mzk3OWQzNzRmODMxZGE3MDY5MjlmNDllMDAyYzdiMgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2dldFByb3BlcnR5VmFsdWUtd2Vi a2l0LW1hcmdpbi1jb2xsYXBzZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNiBAQAorQnVnIDEx MDkwMzogZ2V0UHJvcGVydHlWYWx1ZSBmb3IgLXdlYmtpdC1tYXJnaW4tY29sbGFwc2UgcmV0dXJu cyBudWxsLCBzaG91bGQgY29tcHV0ZSB0aGUgc2hvcnRoYW5kIHZhbHVlCisKK09uIHN1Y2Nlc3Ms IHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJU RVNUIENPTVBMRVRFIi4KKworCitQQVNTIHdlYmtpdE1hcmdpbkNvbGxhcHNlVmFsdWUoIm1hcmdp bi1jb2xsYXBzZTEiKSBpcyAnY29sbGFwc2Ugc2VwYXJhdGUnCitQQVNTIHdlYmtpdE1hcmdpbkNv bGxhcHNlVmFsdWUoIm1hcmdpbi1jb2xsYXBzZTIiKSBpcyAnZGlzY2FyZCBkaXNjYXJkJworUEFT UyB3ZWJraXRNYXJnaW5Db2xsYXBzZVZhbHVlKCJtYXJnaW4tY29sbGFwc2UzIikgaXMgJ2Rpc2Nh cmQgc2VwYXJhdGUnCitOT1RFOiAnZm9vJyBpcyBhbiBpbGxlZ2FsIENTUyB2YWx1ZSBmb3IgJy13 ZWJraXQtbWFyZ2luLWNvbGxhcHNlJy4KK1BBU1Mgd2Via2l0TWFyZ2luQ29sbGFwc2VWYWx1ZSgi bWFyZ2luLWNvbGxhcHNlNCIpIGlzIG51bGwKK05PVEU6IElmIG9ubHkgZmV3IGxvbmdoYW5kIHBy b3BlcnRpZXMgYXJlIHNwZWNpZmllZCwgZ2V0UHJvcGVydHlWYWx1ZSBmb3Igc2hvcnRoYW5kIHBy b3BlcnR5IHJldHVybnMgbnVsbC4KK1BBU1Mgd2Via2l0TWFyZ2luQ29sbGFwc2VWYWx1ZSgibWFy Z2luLWNvbGxhcHNlNSIpIGlzIG51bGwKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorICAgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv Z2V0UHJvcGVydHlWYWx1ZS13ZWJraXQtbWFyZ2luLWNvbGxhcHNlLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy9nZXRQcm9wZXJ0eVZhbHVlLXdlYmtpdC1tYXJnaW4tY29sbGFwc2UuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4xN2YyZWQ4MmIwZDNiZTMyYmVmMzllNzNiZThmMjEzNGZhMTYyY2I1Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZ2V0UHJvcGVydHlWYWx1ZS13ZWJr aXQtbWFyZ2luLWNvbGxhcHNlLmh0bWwKQEAgLTAsMCArMSw0MiBAQAorPCFET0NUWVBFIEhUTUw+ Cis8L2h0bWw+CisgIDxoZWFkPgorICAgIDx0aXRsZT4td2Via2l0LW1hcmdpbi1jb2xsYXBzZSBz aG9ydGhhbmQgZ2V0UHJvcGVydHlWYWx1ZSB0ZXN0PC90aXRsZT4KKyAgICA8c3R5bGU+CisgICAg ICAudGVzdCB7CisgICAgICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKKyAgICAgICAgd2lkdGg6 IDVlbTsKKyAgICAgICAgaGVpZ2h0OiAxMGVtOworICAgICAgfQorICAgIDwvc3R5bGU+CisgICAg PHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cisg ICAgPHNjcmlwdD4KKyAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1 bm5lci5kdW1wQXNUZXh0KCk7CisgICAgPC9zY3JpcHQ+CisgIDwvaGVhZD4KKyAgPGJvZHk+Cisg ICAgPGRpdiBpZD0ibWFyZ2luLWNvbGxhcHNlMSIgY2xhc3M9InRlc3QiIHN0eWxlPSItd2Via2l0 LW1hcmdpbi1jb2xsYXBzZTogY29sbGFwc2Ugc2VwYXJhdGU7Ij48L2Rpdj4KKyAgICA8ZGl2IGlk PSJtYXJnaW4tY29sbGFwc2UyIiBjbGFzcz0idGVzdCIgc3R5bGU9Ii13ZWJraXQtbWFyZ2luLWNv bGxhcHNlOiBkaXNjYXJkOyI+PC9kaXY+CisgICAgPGRpdiBpZD0ibWFyZ2luLWNvbGxhcHNlMyIg Y2xhc3M9InRlc3QiIHN0eWxlPSItd2Via2l0LW1hcmdpbi1iZWZvcmUtY29sbGFwc2U6IGRpc2Nh cmQ7IC13ZWJraXQtbWFyZ2luLWFmdGVyLWNvbGxhcHNlOiBzZXBhcmF0ZTsiPjwvZGl2PgorICAg IDxkaXYgaWQ9Im1hcmdpbi1jb2xsYXBzZTQiIGNsYXNzPSJ0ZXN0IiBzdHlsZT0iLXdlYmtpdC1t YXJnaW4tY29sbGFwc2U6IGZvbzsiPjwvZGl2PgorICAgIDxkaXYgaWQ9Im1hcmdpbi1jb2xsYXBz ZTUiIGNsYXNzPSJ0ZXN0IiBzdHlsZT0iLXdlYmtpdC1tYXJnaW4tYmVmb3JlLWNvbGxhcHNlOiBj b2xsYXBzZTsiPjwvZGl2PgorICAgIDxzY3JpcHQ+CisgICAgICBkZXNjcmlwdGlvbigiPGEgaHJl Zj1cImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA5MDNcIj5CdWcg MTEwOTAzOiBnZXRQcm9wZXJ0eVZhbHVlIGZvciAtd2Via2l0LW1hcmdpbi1jb2xsYXBzZSByZXR1 cm5zIG51bGwsIHNob3VsZCBjb21wdXRlIHRoZSBzaG9ydGhhbmQgdmFsdWU8L2E+Iik7CisKKyAg ICAgIGZ1bmN0aW9uIHdlYmtpdE1hcmdpbkNvbGxhcHNlVmFsdWUoaWQpIHsKKyAgICAgICAgdmFy IGVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZChpZCk7CisgICAgICAgIHJldHVybiBl bGVtZW50LnN0eWxlLmdldFByb3BlcnR5VmFsdWUoIi13ZWJraXQtbWFyZ2luLWNvbGxhcHNlIik7 CisgICAgICB9CisKKyAgICAgIHNob3VsZEJlKCd3ZWJraXRNYXJnaW5Db2xsYXBzZVZhbHVlKCJt YXJnaW4tY29sbGFwc2UxIiknLCAiJ2NvbGxhcHNlIHNlcGFyYXRlJyIpOworICAgICAgc2hvdWxk QmUoJ3dlYmtpdE1hcmdpbkNvbGxhcHNlVmFsdWUoIm1hcmdpbi1jb2xsYXBzZTIiKScsICInZGlz Y2FyZCBkaXNjYXJkJyIpOworICAgICAgc2hvdWxkQmUoJ3dlYmtpdE1hcmdpbkNvbGxhcHNlVmFs dWUoIm1hcmdpbi1jb2xsYXBzZTMiKScsICInZGlzY2FyZCBzZXBhcmF0ZSciKTsKKyAgICAgIGRl YnVnKCJOT1RFOiAnZm9vJyBpcyBhbiBpbGxlZ2FsIENTUyB2YWx1ZSBmb3IgJy13ZWJraXQtbWFy Z2luLWNvbGxhcHNlJy4iKTsKKyAgICAgIHNob3VsZEJlKCd3ZWJraXRNYXJnaW5Db2xsYXBzZVZh bHVlKCJtYXJnaW4tY29sbGFwc2U0IiknLCAibnVsbCIpOworICAgICAgZGVidWcoIk5PVEU6IElm IG9ubHkgZmV3IGxvbmdoYW5kIHByb3BlcnRpZXMgYXJlIHNwZWNpZmllZCwgZ2V0UHJvcGVydHlW YWx1ZSBmb3Igc2hvcnRoYW5kIHByb3BlcnR5IHJldHVybnMgbnVsbC4iKQorICAgICAgc2hvdWxk QmUoJ3dlYmtpdE1hcmdpbkNvbGxhcHNlVmFsdWUoIm1hcmdpbi1jb2xsYXBzZTUiKScsICJudWxs Iik7CisgICAgPC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorICA8L2JvZHk+Cis8L2h0bWw+Cg==