110876 2013-02-26 05:48:42 -0800 Multiple html5lib Layout Tests are slow since r144032 2013-03-14 14:41:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111389 112381 1 vsevik eric alancutter dcarney eric kbr rafaelw webkit.review.bot oldest_to_newest 841928 0 vsevik 2013-02-26 05:48:42 -0800 Multiple html5lib Layout Tests are timing out on chromium since r144032 html5lib/generated/run-doctype01-data.html html5lib/generated/run-domjs-unsafe-data.html html5lib/generated/run-entities01-data.html html5lib/generated/run-plain-text-unsafe-data.html html5lib/generated/run-scriptdata01-data.html html5lib/generated/run-template-data.html html5lib/generated/run-tests1-data.html html5lib/generated/run-tests10-data.html html5lib/generated/run-tests16-data.html html5lib/generated/run-tests19-data.html html5lib/generated/run-tests2-data.html html5lib/generated/run-tests20-data.html html5lib/generated/run-tests6-data.html html5lib/generated/run-tests7-data.html html5lib/generated/run-tests9-data.html html5lib/generated/run-webkit01-data.html Caused by http://trac.webkit.org/changeset/144032/ 841932 1 vsevik 2013-02-26 05:54:11 -0800 Marked as flaky: http://trac.webkit.org/changeset/144050 842217 2 eric 2013-02-26 11:31:00 -0800 These should just be marked as slow. They complete fine for me on my linux machine. 842813 3 eric 2013-02-27 01:04:19 -0800 I'm sure we could look at ways to improve the data: url harness for this test to not be so slow. But it's likely these tests will just be marked as "slow" for the forseeable future. What they test is extremely valuable. :) 842816 4 vsevik 2013-02-27 01:05:15 -0800 Marked as slow http://trac.webkit.org/changeset/144156 842939 5 vsevik 2013-02-27 04:38:26 -0800 Some of them still fail when marked as slow, some html5lib/ started failing when others were made slow. I am going to add more information in this bug. 842940 6 vsevik 2013-02-27 04:42:11 -0800 These tests are timing out even when marked as slow: html5lib/generated/run-entities01-data.html html5lib/generated/run-template-data.html html5lib/generated/run-tests1-data.html html5lib/generated/run-tests10-data.html html5lib/generated/run-tests16-data.html html5lib/generated/run-tests19-data.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=html5lib%2Fgenerated%2Frun-entities01-data.html%2Chtml5lib%2Fgenerated%2Frun-template-data.html%2Chtml5lib%2Fgenerated%2Frun-tests1-data.html%2Chtml5lib%2Fgenerated%2Frun-tests10-data.html%2Chtml5lib%2Fgenerated%2Frun-tests16-data.html%2Chtml5lib%2Fgenerated%2Frun-tests19-data.html 842941 7 vsevik 2013-02-27 04:42:25 -0800 Updated expectations: http://trac.webkit.org/changeset/144171 842946 8 vsevik 2013-02-27 04:51:32 -0800 These are also failing: html5lib/generated/run-tests10-write.html html5lib/generated/run-tests16-write.html html5lib/generated/run-tests19-write.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=html5lib%2Fgenerated%2Frun-tests10-write.html%2Chtml5lib%2Fgenerated%2Frun-tests16-write.html%2Chtml5lib%2Fgenerated%2Frun-tests19-write.html Updated expectations: http://trac.webkit.org/changeset/144172 846956 9 rafaelw 2013-03-04 15:54:27 -0800 Marked all html5lib/generated as crashing here: http://trac.webkit.org/changeset/144692 Note that I removed all the more specific expectations in this patch. 847033 10 eric 2013-03-04 16:52:44 -0800 Profiling an individual test, you can see parts of WebCore working. But profiling all the tests in aggregate, seems to show all our time being spent in V8 creating the window object each time we call document.open(). :) + 6.69% DumpRenderTree [kernel.kallsyms] [k] 0xffffffff8103b51a + 4.09% DumpRenderTree DumpRenderTree [.] v8::internal::Scanner::ScanIdentifierOrKeyword() + 2.33% DumpRenderTree DumpRenderTree [.] v8::internal::Scanner::Scan() + 1.63% DumpRenderTree DumpRenderTree [.] v8::internal::Scanner::Next() + 1.54% DumpRenderTree DumpRenderTree [.] v8::internal::RelocIterator::next() + 1.48% DumpRenderTree DumpRenderTree [.] v8::internal::TemplateHashMapImpl<v8::internal::ZoneAllocationPolicy>::Lookup(void*, unsigne + 1.38% DumpRenderTree DumpRenderTree [.] v8::internal::DescriptorArray::Append(v8::internal::Descriptor*) + 1.33% DumpRenderTree DumpRenderTree [.] v8::internal::Parser::ParseBinaryExpression(int, bool, bool*) + 1.25% DumpRenderTree DumpRenderTree [.] v8::internal::Parser::ParseAssignmentExpression(bool, bool*) + 1.23% DumpRenderTree perf-16889.map [.] 0xf48aab3592e + 1.23% DumpRenderTree DumpRenderTree [.] v8::internal::SymbolTable::LookupOneByteSymbol(v8::internal::Vector<unsigned char const>, v8 + 1.17% DumpRenderTree DumpRenderTree [.] v8::internal::Zone::New(int) + 1.09% DumpRenderTree DumpRenderTree [.] v8::internal::Parser::ParsePrimaryExpression(bool*) + 1.04% DumpRenderTree DumpRenderTree [.] v8::internal::FlexibleBodyVisitor<v8::internal::MarkCompactMarkingVisitor, v8::internal::Fix + 0.99% DumpRenderTree [unknown] [.] 0xf48aaa5ecb2 847037 11 eric 2013-03-04 16:55:45 -0800 I'm using bug 111384 to check the perf of these tests. 847072 12 eric 2013-03-04 17:21:12 -0800 (In reply to comment #10) > Profiling an individual test, you can see parts of WebCore working. But profiling all the tests in aggregate, seems to show all our time being spent in V8 creating the window object each time we call document.open(). :) After further investigation, this V8 start-up time is dominant only in the data url versions of the tests. 847073 13 eric 2013-03-04 17:22:36 -0800 But it is *so* dominant, that it pushes the top symbol from the write versions down to < 1% of total time. :) The write() versions only create/load 1 iframe (repeatedly calling open(), write(), end() on said iframe), the data versions set the same iframe to a different src=data: url for each subtest. 847074 14 eric 2013-03-04 17:23:20 -0800 The crashes which rafael is seeing only seem to occur on mac/win. I'm not able to repro them on linux. 847492 15 eric 2013-03-05 02:48:02 -0800 (In reply to comment #9) > Marked all html5lib/generated as crashing here: > > http://trac.webkit.org/changeset/144692 > > Note that I removed all the more specific expectations in this patch. Thanks. I think the crashes are likely some side-effect of the way we're timing out. Since we're only seeing these troubles on Debug, I am going to post a patch to Skip all of these tests on Debug until the V8 per-document boot time is faster. 847554 16 191465 eric 2013-03-05 04:25:32 -0800 Created attachment 191465 Patch 847920 17 rafaelw 2013-03-05 12:34:05 -0800 lgtm 847922 18 eric 2013-03-05 12:34:59 -0800 I filed a v8 bug as well https://code.google.com/p/v8/issues/detail?id=2567 847990 19 191465 webkit.review.bot 2013-03-05 13:16:19 -0800 Comment on attachment 191465 Patch Clearing flags on attachment: 191465 Committed r144807: <http://trac.webkit.org/changeset/144807> 847991 20 webkit.review.bot 2013-03-05 13:16:23 -0800 All reviewed patches have been landed. Closing bug. 852040 21 alancutter 2013-03-10 21:58:40 -0700 The run-tests16-data.html test has been timing out on the Chromium Linux release build now. http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r144809%20(45627)/results.html Should this test be marked as flaky in release as well given a V8 issue exists for it? 852050 22 eric 2013-03-10 22:30:01 -0700 (In reply to comment #21) > The run-tests16-data.html test has been timing out on the Chromium Linux release build now. > http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r144809%20(45627)/results.html > > Should this test be marked as flaky in release as well given a V8 issue exists for it? That's unfortunate. Yes, I expect some of the data- tests with lots of subtests will hit the timeout. 191465 2013-03-05 04:25:32 -0800 2013-03-05 13:16:19 -0800 Patch bug-110876-20130305042155.patch text/plain 2114 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzQxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2QxYmQyOTY2YTI2NGRlOWJjOTIw YzNlOTRjMzI3YjI5NDUyMDMwYS4uMjc2NzY2NjVhYzU1MGEyYmUxYjFhYjdkZWY1NzgxMDQ4MjJk ZWI3YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTA1ICBFcmljIFNlaWRlbCAgPGVy aWNAd2Via2l0Lm9yZz4KKworICAgICAgICBNdWx0aXBsZSBodG1sNWxpYiBMYXlvdXQgVGVzdHMg YXJlIHNsb3cgc2luY2UgcjE0NDAzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTEwODc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2tpcCB0aGUgaHRtbDVsaWIgdGVzdHMgd2hlbiBpbiBkZWJ1ZyBtb2Rl LiAgVGhlIC1kYXRhIHZhcmlhbnRzCisgICAgICAgIGFsbW9zdCBhbHdheXMgdGltZW91dCBkdWUg dG8gdjggYm9vdC11cCB0aW1lOgorICAgICAgICBodHRwczovL2NvZGUuZ29vZ2xlLmNvbS9wL3Y4 L2lzc3Vlcy9kZXRhaWw/aWQ9MjU2NworCisgICAgICAgIFRoZXNlIHRpbWVvdXRzIHNvbWV0aW1l cyBtYW5pZmVzdCBhcyBmYWlsdXJlcywgYW5kIHdlJ3ZlIGV2ZW4KKyAgICAgICAgc2VlbiBjcmFz aGVzICh3aXRoIGVtcHR5IHN0YWNrcyE/KSBvZiB0aGVzZSB0ZXN0cyBvbiBXaW4gYW5kIE1hYyBp biBEZWJ1Zywgc28KKyAgICAgICAgc2tpcHBpbmcgdGhlbSB1bnRpbCB0aGV5IHJ1biBpbiBhIHJl YXNvbmFibGUgdGltZSBhbmQgY2FuCisgICAgICAgIGJlIGRlYnVnZ2VkIGZ1cnRoZXIuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEzLTAzLTA1 ICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAaW50ZWwuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIEVGTCBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwppbmRleCAyMzlmYThjZWE1NTJlODdiYzk1YTZk MTFiNzM0YmFiOTZlM2MzNTg3Li5iODZkNDA1MThhYzU4ZGE1MzE4NDA0NWIwYmI5OTI5OTQzODk5 YTE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTQ0MDEsOCArNDQwMSw4IEBAIHdlYmtpdC5vcmcvYi8xMTExOTkgWyBEZWJ1ZyBXaW4g TWFjIF0gcGxhdGZvcm0vY2hyb21pdW0vdmlydHVhbC9zb2Z0d2FyZWNvbXBvc2l0CiB3ZWJraXQu b3JnL2IvMTExMTk5IFsgRGVidWcgTWFjIF0gY29tcG9zaXRpbmcvcnRsL3J0bC1pZnJhbWUtZml4 ZWQtb3ZlcmZsb3cuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTExMTk5IFsg RGVidWcgV2luIE1hYyBdIHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvc29mdHdhcmVjb21wb3Np dGluZy9ydGwvcnRsLWlmcmFtZS1maXhlZC1vdmVyZmxvdy5odG1sIFsgUGFzcyBGYWlsdXJlIF0K IAotIyBUaGVzZSB0ZXN0cyBhcmUgdGltaW5nIG91dCBhbmQgY3Jhc2hpbmcgc2luY2UgcjE0NDAz Mgotd2Via2l0Lm9yZy9iLzExMDg3NiBodG1sNWxpYi9nZW5lcmF0ZWQvIFsgUGFzcyBTbG93IENy YXNoIF0KKyMgVGhlIGh0bWw1bGliIHRlc3RzIGFyZSBhbGwgdG9vIHNsb3cgdG8gcnVuIGluIERl YnVnLCBsYXJnZWx5IGR1ZSB0byB2OCBwZXItZG9jdW1lbnQgYm9vdC11cC4KK3dlYmtpdC5vcmcv Yi8xMTA4NzYgWyBEZWJ1ZyBdIGh0bWw1bGliL2dlbmVyYXRlZC8gWyBTa2lwIF0KIAogIyBIQUxG X0ZMT0FUX09FUyBpcyBub3QgeWV0IHdvcmtpbmcgaW4gY2hyb21pdW0uCiBjcmJ1Zy5jb20vMTc5 NTAzIGZhc3QvY2FudmFzL3dlYmdsL29lcy10ZXh0dXJlLWhhbGYtZmxvYXQuaHRtbCBbIEZhaWx1 cmUgXQo=