110862 2013-02-26 02:12:36 -0800 Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node 2013-02-26 05:45:02 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vivekg vivekg apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 841813 0 vivekg 2013-02-26 02:12:36 -0800 DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node. Patch follows. 841817 1 190247 vivekg 2013-02-26 02:16:16 -0800 Created attachment 190247 Patch 841847 2 190247 eustas 2013-02-26 03:34:03 -0800 Comment on attachment 190247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190247&action=review > Source/WebCore/inspector/front-end/DataGrid.js:821 > + handled = nextSelectedNode ? true : false; Why deleting last row doesn't count as "handled" case? 841848 3 190247 vivekg 2013-02-26 03:35:52 -0800 Comment on attachment 190247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190247&action=review >> Source/WebCore/inspector/front-end/DataGrid.js:821 >> + handled = nextSelectedNode ? true : false; > > Why deleting last row doesn't count as "handled" case? yes its wrong above. It should be handled always as long as there is a valid selectedNode. 841864 4 190256 vivekg 2013-02-26 04:02:07 -0800 Created attachment 190256 Patch 841925 5 190256 webkit.review.bot 2013-02-26 05:44:59 -0800 Comment on attachment 190256 Patch Clearing flags on attachment: 190256 Committed r144047: <http://trac.webkit.org/changeset/144047> 841926 6 webkit.review.bot 2013-02-26 05:45:02 -0800 All reviewed patches have been landed. Closing bug. 190247 2013-02-26 02:16:16 -0800 2013-02-26 04:02:00 -0800 Patch bug-110862-20130226154336.patch text/plain 2977 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBhZDg1OGMxZTAyMjdi NmYzNmEyNzI3NzZmYTYwNWNkYzNkZTFhNS4uMTVlYTI0MDYzOGZjYmI4YWM0ZmYwODA3NzI0NzM0 YWE1ZWNhNTgyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTI2ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IERhdGFHcmlkIHNob3VsZCByZXZlYWwgYW5kIHNlbGVjdCBuZXh0L3ByZXZpb3VzIERhdGFH cmlkTm9kZSB1cG9uIGRlbGV0aW9uIG9mIHNlbGVjdGVkIG5vZGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDg2MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIGRlbGV0aW5nIGVudHJpZXMgaW4g dGhlIERhdGFHcmlkLCBkZWxldGluZyBvZiBzZWxlY3RlZCBub2RlIHNob3VsZCB0cmlnZ2VyIHNl bGVjdGlvbiBvZgorICAgICAgICBuZXh0IHBvc3NpYmxlIChiYWNrd2FyZC9mb3J3YXJkKSBEYXRh R3JpZE5vZGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5fa2V5RG93bik6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZS5nZXQgbGVmdFBhZGRpbmcp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkTm9kZS5wcm90b3R5cGUuaXNFdmVudFdp dGhpbkRpc2Nsb3N1cmVUcmlhbmdsZSk6CisKIDIwMTMtMDItMjYgIEFsZXhhbmRlciBQYXZsb3Yg IDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDU1NBZ2Vu dC5zZXRTdHlsZVNoZWV0VGV4dCBjcmFzaGVzIG9uIGlubGluZSBzdHlsZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzCmluZGV4IDgwY2Y3NzQ3N2Ez YjhmNjEyYzFiZjEwOGRmYWNiOTY1NDQwMDVjNTUuLjU4NGJhMGU4ZTFmNTI4MGRiZGU0ZjkwYTY5 NTBjNmEzYWI5OTM2NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9EYXRhR3JpZC5qcwpAQCAtODA4LDYgKzgwOCwxNyBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQu cHJvdG90eXBlID0gewogICAgICAgICAgICAgaWYgKHRoaXMuX2RlbGV0ZUNhbGxiYWNrKSB7CiAg ICAgICAgICAgICAgICAgaGFuZGxlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAgdGhpcy5fZGVs ZXRlQ2FsbGJhY2sodGhpcy5zZWxlY3RlZE5vZGUpOworCisgICAgICAgICAgICAgICAgbmV4dFNl bGVjdGVkTm9kZSA9IHRoaXMuc2VsZWN0ZWROb2RlLnRyYXZlcnNlTmV4dE5vZGUodHJ1ZSk7Cisg ICAgICAgICAgICAgICAgd2hpbGUgKG5leHRTZWxlY3RlZE5vZGUgJiYgIW5leHRTZWxlY3RlZE5v ZGUuc2VsZWN0YWJsZSkKKyAgICAgICAgICAgICAgICAgICAgbmV4dFNlbGVjdGVkTm9kZSA9IG5l eHRTZWxlY3RlZE5vZGUudHJhdmVyc2VOZXh0Tm9kZSh0cnVlKTsKKworICAgICAgICAgICAgICAg IGlmICghbmV4dFNlbGVjdGVkTm9kZSB8fCBuZXh0U2VsZWN0ZWROb2RlLmlzQ3JlYXRpb25Ob2Rl KSB7CisgICAgICAgICAgICAgICAgICAgIG5leHRTZWxlY3RlZE5vZGUgPSB0aGlzLnNlbGVjdGVk Tm9kZS50cmF2ZXJzZVByZXZpb3VzTm9kZSh0cnVlKTsKKyAgICAgICAgICAgICAgICAgICAgd2hp bGUgKG5leHRTZWxlY3RlZE5vZGUgJiYgIW5leHRTZWxlY3RlZE5vZGUuc2VsZWN0YWJsZSkKKyAg ICAgICAgICAgICAgICAgICAgICAgIG5leHRTZWxlY3RlZE5vZGUgPSBuZXh0U2VsZWN0ZWROb2Rl LnRyYXZlcnNlUHJldmlvdXNOb2RlKHRydWUpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAg ICAgICAgICBoYW5kbGVkID0gbmV4dFNlbGVjdGVkTm9kZSA/IHRydWUgOiBmYWxzZTsKICAgICAg ICAgICAgIH0KICAgICAgICAgfSBlbHNlIGlmIChpc0VudGVyS2V5KGV2ZW50KSkgewogICAgICAg ICAgICAgaWYgKHRoaXMuX2VkaXRDYWxsYmFjaykgewpAQCAtMTE5Miw3ICsxMjAzLDcgQEAgV2Vi SW5zcGVjdG9yLkRhdGFHcmlkTm9kZS5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBpZiAo dHlwZW9mIHRoaXMuX2xlZnRQYWRkaW5nID09PSAibnVtYmVyIikKICAgICAgICAgICAgIHJldHVy biB0aGlzLl9sZWZ0UGFkZGluZzsKLSAgICAgICAgCisKICAgICAgICAgdGhpcy5fbGVmdFBhZGRp bmcgPSB0aGlzLmRlcHRoICogdGhpcy5kYXRhR3JpZC5pbmRlbnRXaWR0aDsKICAgICAgICAgcmV0 dXJuIHRoaXMuX2xlZnRQYWRkaW5nOwogICAgIH0sCkBAIC0xNjM2LDcgKzE2NDcsNyBAQCBXZWJJ bnNwZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGNlbGwgPSBl dmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFtZSgidGQiKTsKICAgICAg ICAgaWYgKCFjZWxsLmhhc1N0eWxlQ2xhc3MoImRpc2Nsb3N1cmUiKSkKICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKLSAgICAgICAgCisKICAgICAgICAgdmFyIGxlZnQgPSBjZWxsLnRvdGFsT2Zm c2V0TGVmdCgpICsgdGhpcy5sZWZ0UGFkZGluZzsKICAgICAgICAgcmV0dXJuIGV2ZW50LnBhZ2VY ID49IGxlZnQgJiYgZXZlbnQucGFnZVggPD0gbGVmdCArIHRoaXMuZGlzY2xvc3VyZVRvZ2dsZVdp ZHRoOwogICAgIH0sCg== 190256 2013-02-26 04:02:07 -0800 2013-02-26 05:44:58 -0800 Patch bug-110862-20130226172927.patch text/plain 2917 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjBhZDg1OGMxZTAyMjdi NmYzNmEyNzI3NzZmYTYwNWNkYzNkZTFhNS4uMTVlYTI0MDYzOGZjYmI4YWM0ZmYwODA3NzI0NzM0 YWE1ZWNhNTgyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTI2ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IERhdGFHcmlkIHNob3VsZCByZXZlYWwgYW5kIHNlbGVjdCBuZXh0L3ByZXZpb3VzIERhdGFH cmlkTm9kZSB1cG9uIGRlbGV0aW9uIG9mIHNlbGVjdGVkIG5vZGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDg2MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIGRlbGV0aW5nIGVudHJpZXMgaW4g dGhlIERhdGFHcmlkLCBkZWxldGluZyBvZiBzZWxlY3RlZCBub2RlIHNob3VsZCB0cmlnZ2VyIHNl bGVjdGlvbiBvZgorICAgICAgICBuZXh0IHBvc3NpYmxlIChiYWNrd2FyZC9mb3J3YXJkKSBEYXRh R3JpZE5vZGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5fa2V5RG93bik6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZS5nZXQgbGVmdFBhZGRpbmcp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkTm9kZS5wcm90b3R5cGUuaXNFdmVudFdp dGhpbkRpc2Nsb3N1cmVUcmlhbmdsZSk6CisKIDIwMTMtMDItMjYgIEFsZXhhbmRlciBQYXZsb3Yg IDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDU1NBZ2Vu dC5zZXRTdHlsZVNoZWV0VGV4dCBjcmFzaGVzIG9uIGlubGluZSBzdHlsZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanMgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzCmluZGV4IDgwY2Y3NzQ3N2Ez YjhmNjEyYzFiZjEwOGRmYWNiOTY1NDQwMDVjNTUuLmQ4MGU0MTI1NzRkNWI3Y2QxN2MwZTlmNjRh Y2VjZjc5ODRhNjJmNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9EYXRhR3JpZC5qcwpAQCAtODA4LDYgKzgwOCwxNiBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQu cHJvdG90eXBlID0gewogICAgICAgICAgICAgaWYgKHRoaXMuX2RlbGV0ZUNhbGxiYWNrKSB7CiAg ICAgICAgICAgICAgICAgaGFuZGxlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAgdGhpcy5fZGVs ZXRlQ2FsbGJhY2sodGhpcy5zZWxlY3RlZE5vZGUpOworCisgICAgICAgICAgICAgICAgbmV4dFNl bGVjdGVkTm9kZSA9IHRoaXMuc2VsZWN0ZWROb2RlLnRyYXZlcnNlTmV4dE5vZGUodHJ1ZSk7Cisg ICAgICAgICAgICAgICAgd2hpbGUgKG5leHRTZWxlY3RlZE5vZGUgJiYgIW5leHRTZWxlY3RlZE5v ZGUuc2VsZWN0YWJsZSkKKyAgICAgICAgICAgICAgICAgICAgbmV4dFNlbGVjdGVkTm9kZSA9IG5l eHRTZWxlY3RlZE5vZGUudHJhdmVyc2VOZXh0Tm9kZSh0cnVlKTsKKworICAgICAgICAgICAgICAg IGlmICghbmV4dFNlbGVjdGVkTm9kZSB8fCBuZXh0U2VsZWN0ZWROb2RlLmlzQ3JlYXRpb25Ob2Rl KSB7CisgICAgICAgICAgICAgICAgICAgIG5leHRTZWxlY3RlZE5vZGUgPSB0aGlzLnNlbGVjdGVk Tm9kZS50cmF2ZXJzZVByZXZpb3VzTm9kZSh0cnVlKTsKKyAgICAgICAgICAgICAgICAgICAgd2hp bGUgKG5leHRTZWxlY3RlZE5vZGUgJiYgIW5leHRTZWxlY3RlZE5vZGUuc2VsZWN0YWJsZSkKKyAg ICAgICAgICAgICAgICAgICAgICAgIG5leHRTZWxlY3RlZE5vZGUgPSBuZXh0U2VsZWN0ZWROb2Rl LnRyYXZlcnNlUHJldmlvdXNOb2RlKHRydWUpOworICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIH0KICAgICAgICAgfSBlbHNlIGlmIChpc0VudGVyS2V5KGV2ZW50KSkgewogICAgICAgICAg ICAgaWYgKHRoaXMuX2VkaXRDYWxsYmFjaykgewpAQCAtMTE5Miw3ICsxMjAyLDcgQEAgV2ViSW5z cGVjdG9yLkRhdGFHcmlkTm9kZS5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBpZiAodHlw ZW9mIHRoaXMuX2xlZnRQYWRkaW5nID09PSAibnVtYmVyIikKICAgICAgICAgICAgIHJldHVybiB0 aGlzLl9sZWZ0UGFkZGluZzsKLSAgICAgICAgCisKICAgICAgICAgdGhpcy5fbGVmdFBhZGRpbmcg PSB0aGlzLmRlcHRoICogdGhpcy5kYXRhR3JpZC5pbmRlbnRXaWR0aDsKICAgICAgICAgcmV0dXJu IHRoaXMuX2xlZnRQYWRkaW5nOwogICAgIH0sCkBAIC0xNjM2LDcgKzE2NDYsNyBAQCBXZWJJbnNw ZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGNlbGwgPSBldmVu dC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFtZSgidGQiKTsKICAgICAgICAg aWYgKCFjZWxsLmhhc1N0eWxlQ2xhc3MoImRpc2Nsb3N1cmUiKSkKICAgICAgICAgICAgIHJldHVy biBmYWxzZTsKLSAgICAgICAgCisKICAgICAgICAgdmFyIGxlZnQgPSBjZWxsLnRvdGFsT2Zmc2V0 TGVmdCgpICsgdGhpcy5sZWZ0UGFkZGluZzsKICAgICAgICAgcmV0dXJuIGV2ZW50LnBhZ2VYID49 IGxlZnQgJiYgZXZlbnQucGFnZVggPD0gbGVmdCArIHRoaXMuZGlzY2xvc3VyZVRvZ2dsZVdpZHRo OwogICAgIH0sCg==