110861 2013-02-26 01:30:38 -0800 new-commit-bot: Some IRC clients doesn't linkify rollout messages 2013-02-26 09:11:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekg vivekg abarth dpranke eric rakuco rniwa webkit.review.bot oldest_to_newest 841778 0 vivekg 2013-02-26 01:30:38 -0800 The link to the rollout is suffixed with ':' which makes it invalid URL. e.g. Vsevolod Vlasov (vsevik) rolled out r144016 in https://trac.webkit.org/r144021: Breaks compilation on chromium mac Removing the ':' from the WKR message. Patch follows. 841781 1 190239 vivekg 2013-02-26 01:33:05 -0800 Created attachment 190239 Patch 841783 2 190239 rniwa 2013-02-26 01:36:23 -0800 Comment on attachment 190239 Patch Sounds like you have a bug in your IRC client. : is a reserved word in URL. It shouldn't be treated like a part of URL. 841788 3 rniwa 2013-02-26 01:43:03 -0800 Oops, apparently colon is allowed to appear in paths of an URL: http://tools.ietf.org/html/rfc3986 841789 4 190239 rniwa 2013-02-26 01:43:33 -0800 Comment on attachment 190239 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190239&action=review > Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:150 > - return '%s rolled out %s in %s: %s' % (author, rollout.group('revisions'), > + return '%s rolled out %s in %s %s' % (author, rollout.group('revisions'), Instead of removing the colon, please insert a space before it. 841792 5 190242 vivekg 2013-02-26 01:49:14 -0800 Created attachment 190242 Patch 841797 6 190242 rniwa 2013-02-26 01:59:15 -0800 Comment on attachment 190242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190242&action=review > Tools/ChangeLog:3 > + [Tools - WKR]Fix the links shown for rollouts by WKR I've updated the bug title to be more describe. Please update the change log accordingly. 841805 7 190243 vivekg 2013-02-26 02:02:28 -0800 Created attachment 190243 Patch 841890 8 190243 webkit.review.bot 2013-02-26 04:54:28 -0800 Comment on attachment 190243 Patch Clearing flags on attachment: 190243 Committed r144040: <http://trac.webkit.org/changeset/144040> 841891 9 webkit.review.bot 2013-02-26 04:54:31 -0800 All reviewed patches have been landed. Closing bug. 841973 10 rakuco 2013-02-26 07:21:01 -0800 This has caused a regression in the Python tests. See <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/5360/steps/webkitpy-test/logs/stdio>. 842070 11 vivekg 2013-02-26 09:11:37 -0800 (In reply to comment #10) > This has caused a regression in the Python tests. See <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/5360/steps/webkitpy-test/logs/stdio>. https://bugs.webkit.org/attachment.cgi?id=190299&action=review should fix this failure. Thank you. 190239 2013-02-26 01:33:05 -0800 2013-02-26 01:49:09 -0800 Patch bug-110861-20130226150024.patch text/plain 1773 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTIzNGFlODNmOTlhYWI5NjRkNGYyZjZlZjBhMWRlMDE2 MWMyYzM4Ny4uZjgwODNhYmM2NWIwNzk3MzNiZjI3ZjcxNjQ1ZDBhM2ZkYWQyOTYzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAyLTI2ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtUb29scyAtIFdLUl1SZW1vdmUgc3RyYXkgJzonIGZyb20gdGhlIHRoZSByb2xs b3V0IGxpbmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTA4NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmluZyB0aGUgJzonIGZyb20gdGhlIFdLUiBtZXNzYWdlIGluIG9yZGVyIHRvIGZpeCB0 aGUgbGlua3Mgc2hvd24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvbmV3Y29tbWl0Ym90LnB5OgorICAgICAgICAoTmV3Q29tbWl0Qm90Ll9zdW1tYXJpemVfY29t bWl0X2xvZyk6CisKIDIwMTMtMDItMjUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgQW5vdGhlciBmaXggYXR0ZW1wdCBhZnRlciByMTQzOTkxIHNpbmNlIGhhdmlu ZyBccj8gYWZ0ZXIgYSBncmVlZHkgbWF0Y2ggZG9lc24ndCBoZWxwLgpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkKaW5kZXggNjQ3 MDE5MTM1NThiYTBkNWU2ZThiYjYxZTUxODVlYjcwMzY0MzMyNC4uYjg2NjVmMmYwMDJiYjM1YWZh YzgzOTM5MGIzNTYyMDA2ZmU1YWNjZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5CkBAIC0xNDcsNyArMTQ3LDcgQEAgY2xh c3MgTmV3Q29tbWl0Qm90KEFic3RyYWN0UXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcik6 CiAgICAgICAgICAgICAgICAgY29udHJpYnV0b3IgPSBjb21taXR0ZXJfbGlzdC5jb250cmlidXRv cl9ieV9pcmNfbmlja25hbWUoYXV0aG9yKQogICAgICAgICAgICAgICAgIGlmIGNvbnRyaWJ1dG9y OgogICAgICAgICAgICAgICAgICAgICBhdXRob3IgPSAiJXMgKCVzKSIgJSAoY29udHJpYnV0b3Iu ZnVsbF9uYW1lLCBjb250cmlidXRvci5pcmNfbmlja25hbWVzWzBdKQotICAgICAgICAgICAgICAg IHJldHVybiAnJXMgcm9sbGVkIG91dCAlcyBpbiAlczogJXMnICUgKGF1dGhvciwgcm9sbG91dC5n cm91cCgncmV2aXNpb25zJyksCisgICAgICAgICAgICAgICAgcmV0dXJuICclcyByb2xsZWQgb3V0 ICVzIGluICVzICVzJyAlIChhdXRob3IsIHJvbGxvdXQuZ3JvdXAoJ3JldmlzaW9ucycpLAogICAg ICAgICAgICAgICAgICAgICBsaW5raWZpZWRfcmV2aXNpb24sIHJlcXVlc3RlZF9ieS5ncm91cCgn cmVhc29uJykpCiAgICAgICAgICAgICBsaW5lc1swXSA9ICclcyByb2xsZWQgb3V0ICVzIGluICVz JyAlIChhdXRob3IsIHJvbGxvdXQuZ3JvdXAoJ3JldmlzaW9ucycpLCBsaW5raWZpZWRfcmV2aXNp b24pCiAK 190242 2013-02-26 01:49:14 -0800 2013-02-26 02:02:22 -0800 Patch bug-110861-20130226151634.patch text/plain 1785 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTIzNGFlODNmOTlhYWI5NjRkNGYyZjZlZjBhMWRlMDE2 MWMyYzM4Ny4uMzUyOWJhYzgwYWRjNTFiOWVhZGRmMDZjNzhjOThlOGI1NGFiN2RiOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAyLTI2ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtUb29scyAtIFdLUl1GaXggdGhlIGxpbmtzIHNob3duIGZvciByb2xsb3V0cyBi eSBXS1IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MDg2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZGluZyB0aGUgc3BhY2UgYmVmb3JlICc6JyBpbiBvcmRlciB0byBmaXggdGhlIGxpbmtzIHNob3du IGZvciB0aGUgcm9sbG91dCBtZXNzYWdlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weToKKyAgICAgICAgKE5ld0NvbW1pdEJvdC5fc3Vt bWFyaXplX2NvbW1pdF9sb2cpOgorCiAyMDEzLTAyLTI1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIEFub3RoZXIgZml4IGF0dGVtcHQgYWZ0ZXIgcjE0Mzk5MSBz aW5jZSBoYXZpbmcgXHI/IGFmdGVyIGEgZ3JlZWR5IG1hdGNoIGRvZXNuJ3QgaGVscC4KZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3Qu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5 CmluZGV4IDY0NzAxOTEzNTU4YmEwZDVlNmU4YmI2MWU1MTg1ZWI3MDM2NDMzMjQuLjE2NDM0Y2Yz ZjQ4YTIyNTg0ZjgzN2VhOTUwMGQ2NWZhMTFlNGNiYTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdjb21taXRib3QucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weQpAQCAtMTQ3LDcgKzE0 Nyw3IEBAIGNsYXNzIE5ld0NvbW1pdEJvdChBYnN0cmFjdFF1ZXVlLCBTdGVwU2VxdWVuY2VFcnJv ckhhbmRsZXIpOgogICAgICAgICAgICAgICAgIGNvbnRyaWJ1dG9yID0gY29tbWl0dGVyX2xpc3Qu Y29udHJpYnV0b3JfYnlfaXJjX25pY2tuYW1lKGF1dGhvcikKICAgICAgICAgICAgICAgICBpZiBj b250cmlidXRvcjoKICAgICAgICAgICAgICAgICAgICAgYXV0aG9yID0gIiVzICglcykiICUgKGNv bnRyaWJ1dG9yLmZ1bGxfbmFtZSwgY29udHJpYnV0b3IuaXJjX25pY2tuYW1lc1swXSkKLSAgICAg ICAgICAgICAgICByZXR1cm4gJyVzIHJvbGxlZCBvdXQgJXMgaW4gJXM6ICVzJyAlIChhdXRob3Is IHJvbGxvdXQuZ3JvdXAoJ3JldmlzaW9ucycpLAorICAgICAgICAgICAgICAgIHJldHVybiAnJXMg cm9sbGVkIG91dCAlcyBpbiAlcyA6ICVzJyAlIChhdXRob3IsIHJvbGxvdXQuZ3JvdXAoJ3Jldmlz aW9ucycpLAogICAgICAgICAgICAgICAgICAgICBsaW5raWZpZWRfcmV2aXNpb24sIHJlcXVlc3Rl ZF9ieS5ncm91cCgncmVhc29uJykpCiAgICAgICAgICAgICBsaW5lc1swXSA9ICclcyByb2xsZWQg b3V0ICVzIGluICVzJyAlIChhdXRob3IsIHJvbGxvdXQuZ3JvdXAoJ3JldmlzaW9ucycpLCBsaW5r aWZpZWRfcmV2aXNpb24pCiAK 190243 2013-02-26 02:02:28 -0800 2013-02-26 04:54:28 -0800 Patch bug-110861-20130226152948.patch text/plain 1796 vivekg U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTIzNGFlODNmOTlhYWI5NjRkNGYyZjZlZjBhMWRlMDE2 MWMyYzM4Ny4uY2IyZmE0YjFkYzdlYzQwYzczZGI5OGRjYTJhMmY5OTU0MWMyNjNmZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTAyLTI2ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIG5ldy1jb21taXQtYm90OiBTb21lIElSQyBjbGllbnRzIGRvZXNuJ3QgbGlua2lm eSByb2xsb3V0IG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTA4NjEKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisK KyAgICAgICAgQWRkaW5nIHRoZSBzcGFjZSBiZWZvcmUgJzonIGluIG9yZGVyIHRvIGZpeCB0aGUg bGlua3Mgc2hvd24gZm9yIHRoZSByb2xsb3V0IG1lc3NhZ2UuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5OgorICAgICAgICAoTmV3Q29t bWl0Qm90Ll9zdW1tYXJpemVfY29tbWl0X2xvZyk6CisKIDIwMTMtMDItMjUgIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQW5vdGhlciBmaXggYXR0ZW1wdCBhZnRl ciByMTQzOTkxIHNpbmNlIGhhdmluZyBccj8gYWZ0ZXIgYSBncmVlZHkgbWF0Y2ggZG9lc24ndCBo ZWxwLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25l d2NvbW1pdGJvdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9uZXdj b21taXRib3QucHkKaW5kZXggNjQ3MDE5MTM1NThiYTBkNWU2ZThiYjYxZTUxODVlYjcwMzY0MzMy NC4uMTY0MzRjZjNmNDhhMjI1ODRmODM3ZWE5NTAwZDY1ZmExMWU0Y2JhMiAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL25ld2NvbW1pdGJvdC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvbmV3Y29tbWl0Ym90LnB5CkBA IC0xNDcsNyArMTQ3LDcgQEAgY2xhc3MgTmV3Q29tbWl0Qm90KEFic3RyYWN0UXVldWUsIFN0ZXBT ZXF1ZW5jZUVycm9ySGFuZGxlcik6CiAgICAgICAgICAgICAgICAgY29udHJpYnV0b3IgPSBjb21t aXR0ZXJfbGlzdC5jb250cmlidXRvcl9ieV9pcmNfbmlja25hbWUoYXV0aG9yKQogICAgICAgICAg ICAgICAgIGlmIGNvbnRyaWJ1dG9yOgogICAgICAgICAgICAgICAgICAgICBhdXRob3IgPSAiJXMg KCVzKSIgJSAoY29udHJpYnV0b3IuZnVsbF9uYW1lLCBjb250cmlidXRvci5pcmNfbmlja25hbWVz WzBdKQotICAgICAgICAgICAgICAgIHJldHVybiAnJXMgcm9sbGVkIG91dCAlcyBpbiAlczogJXMn ICUgKGF1dGhvciwgcm9sbG91dC5ncm91cCgncmV2aXNpb25zJyksCisgICAgICAgICAgICAgICAg cmV0dXJuICclcyByb2xsZWQgb3V0ICVzIGluICVzIDogJXMnICUgKGF1dGhvciwgcm9sbG91dC5n cm91cCgncmV2aXNpb25zJyksCiAgICAgICAgICAgICAgICAgICAgIGxpbmtpZmllZF9yZXZpc2lv biwgcmVxdWVzdGVkX2J5Lmdyb3VwKCdyZWFzb24nKSkKICAgICAgICAgICAgIGxpbmVzWzBdID0g JyVzIHJvbGxlZCBvdXQgJXMgaW4gJXMnICUgKGF1dGhvciwgcm9sbG91dC5ncm91cCgncmV2aXNp b25zJyksIGxpbmtpZmllZF9yZXZpc2lvbikKIAo=