110843 2013-02-25 21:34:07 -0800 SelectorQuery should not ever use ResolvingStyle mode. 2013-02-26 20:36:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov allan.jensen eric esprehn+autocc kling koivisto ojan.autocc webkit.review.bot oldest_to_newest 841605 0 dglazkov 2013-02-25 21:34:07 -0800 SelectorQuery should not ever use ResolvingStyle mode. 841609 1 190199 dglazkov 2013-02-25 21:36:44 -0800 Created attachment 190199 Patch 841663 2 190199 eric 2013-02-25 22:57:00 -0800 Comment on attachment 190199 Patch So this is just a perf improvement? Do we have microbenchmarks which would be effected by this? 841994 3 dglazkov 2013-02-26 07:49:43 -0800 I goess it could be viewed as performance optimization. For instance, when computing webkitMatchesSelector(":first-line"), in ResolvingStyle mode, we would be creating ElementRareData, as opposed to QueryingRules, where we wouldn't be: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/WebCore/dom/Element.cpp&sq=package:chromium&type=cs&rcl=1361871648&l=2071 There's tons of similar things that would do the same types of things in querySelector. Not sure if we have a microbench that would be affected. 842651 4 190199 webkit.review.bot 2013-02-26 20:36:21 -0800 Comment on attachment 190199 Patch Clearing flags on attachment: 190199 Committed r144140: <http://trac.webkit.org/changeset/144140> 842652 5 webkit.review.bot 2013-02-26 20:36:25 -0800 All reviewed patches have been landed. Closing bug. 190199 2013-02-25 21:36:44 -0800 2013-02-26 20:36:21 -0800 Patch bug-110843-20130225213259.patch text/plain 2105 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk0MzNjMTcwY2M1Y2Mx Y2JiMmY4MDIzNDhkY2JlOTQ4NDFmYmQ4OC4uMTIzNGI2NDEyNTg5ZmYzZDc4ZTAyNTY4NDFjNjQw MWIxZTVjODc4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI1ICBEaW1p dHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU2VsZWN0b3JR dWVyeSBzaG91bGQgbm90IGV2ZXIgdXNlIFJlc29sdmluZ1N0eWxlIG1vZGUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA4NDMKKworICAgICAgICBJ dCBsb29rcyBsaWtlIHdlIGFjY2lkZW50YWxseSB1c2VkIFJlc29sdmluZ1N0eWxlIG1vZGUgZm9y IHdlYmtpdE1hdGNoZXNTZWxlY3RvciwgYW5kIEkgZXhhY2VyYmF0ZWQgdGhlIHByb2JsZW0KKyAg ICAgICAgaW4gcjE0Mzg1OCBieSBzd2l0Y2hpbmcgYWxsIG9mIFNlbGVjdG9yUXVlcnkgdG8gdXNl IGl0LiBUaGVyZSBhcmVuJ3QgYW55IHZpc2libGUgZWZmZWN0cywgYnV0IHRoZSBzdHlsZSBiaXRz CisgICAgICAgIG9mIGVsZW1lbnRzIGFyZSB1bm5lY2Vzc2FyaWx5IHR3aWRkbGVkIHdoZW4gaWYg d2UgZG8gdGhhdC4gTGV0J3Mgbm90IGRvIGl0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIHB1YmxpYy1mYWNpbmcgYmVoYXZpb3IgY2hhbmdlLCBj b3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogZG9tL1NlbGVjdG9yUXVlcnku Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0b3JEYXRhTGlzdDo6c2VsZWN0b3JNYXRjaGVz KTogU3dpdGNoZWQgdG8gYWx3YXlzIHVzZSBRdWVyeWluZ1J1bGVzIG1vZGUuCisKIDIwMTMtMDIt MjUgIEJydW5vIGRlIE9saXZlaXJhIEFiaW5hZGVyICA8YnJ1bm8uYWJpbmFkZXJAYmFzeXNrb20u Y29tPgogCiAgICAgICAgIFt0ZXhtYXBdIFJlbmFtZSBUZXh0dXJlTWFwcGVyR0w6OkNsaXBTdGFj azo6aW5pdCB0byByZXNldApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdG9y UXVlcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdG9yUXVlcnkuY3BwCmluZGV4IDJk OTBmOGQ2Zjg2OGRiMTc4MTdkYjA5MjhmYTI5YTY4ZTcwZjRiYzcuLjM2ZGQ5Nzc4ZGE1Y2U2Mzg4 NThjYWUyYzliYjY2OTNiMGNjYzliNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9T ZWxlY3RvclF1ZXJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0b3JRdWVyeS5j cHAKQEAgLTU5LDcgKzU5LDcgQEAgaW5saW5lIGJvb2wgU2VsZWN0b3JEYXRhTGlzdDo6c2VsZWN0 b3JNYXRjaGVzKGNvbnN0IFNlbGVjdG9yRGF0YSYgc2VsZWN0b3JEYXRhLAogICAgICAgICByZXR1 cm4gc2VsZWN0b3JDaGVja2VyRmFzdFBhdGgubWF0Y2hlcygpOwogICAgIH0KIAotICAgIFNlbGVj dG9yQ2hlY2tlciBzZWxlY3RvckNoZWNrZXIoZWxlbWVudC0+ZG9jdW1lbnQoKSwgU2VsZWN0b3JD aGVja2VyOjpSZXNvbHZpbmdTdHlsZSk7CisgICAgU2VsZWN0b3JDaGVja2VyIHNlbGVjdG9yQ2hl Y2tlcihlbGVtZW50LT5kb2N1bWVudCgpLCBTZWxlY3RvckNoZWNrZXI6OlF1ZXJ5aW5nUnVsZXMp OwogICAgIFNlbGVjdG9yQ2hlY2tlcjo6U2VsZWN0b3JDaGVja2luZ0NvbnRleHQgc2VsZWN0b3JD aGVja2luZ0NvbnRleHQoc2VsZWN0b3JEYXRhLnNlbGVjdG9yLCBlbGVtZW50LCBTZWxlY3RvckNo ZWNrZXI6OlZpc2l0ZWRNYXRjaERpc2FibGVkKTsKICAgICBQc2V1ZG9JZCBpZ25vcmVEeW5hbWlj UHNldWRvID0gTk9QU0VVRE87CiAgICAgcmV0dXJuIHNlbGVjdG9yQ2hlY2tlci5tYXRjaChzZWxl Y3RvckNoZWNraW5nQ29udGV4dCwgaWdub3JlRHluYW1pY1BzZXVkbywgRE9NU2libGluZ1RyYXZl cnNhbFN0cmF0ZWd5KCkpID09IFNlbGVjdG9yQ2hlY2tlcjo6U2VsZWN0b3JNYXRjaGVzOwo=