110813 2013-02-25 15:18:46 -0800 [JSC] Upstream iOS Stack bound checking 2013-02-26 01:11:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 110858 1 benjamin benjamin fpizlo ggaren oliver oldest_to_newest 841338 0 benjamin 2013-02-25 15:18:46 -0800 [JSC] Upstream iOS Stack bound checking 841342 1 190137 benjamin 2013-02-25 15:20:57 -0800 Created attachment 190137 Patch 841567 2 190137 benjamin 2013-02-25 20:15:15 -0800 Comment on attachment 190137 Patch Clearing flags on attachment: 190137 Committed r144004: <http://trac.webkit.org/changeset/144004> 841568 3 benjamin 2013-02-25 20:15:17 -0800 All reviewed patches have been landed. Closing bug. 841581 4 oliver 2013-02-25 20:42:31 -0800 I'm sure the stack bounds used to be thread local, i'm not sure why that can't just be the rule.. 841585 5 ggaren 2013-02-25 20:52:50 -0800 I must be missing something obvious, but I don't understand why the Parser and BytecodeGenerator can't cache the stack bounds. Those are temporary, stack-local objects. Even though WebKit in general may run on the main or web thread, we shouldn't every start parsing on one thread and then switch to another, right? 841587 6 oliver 2013-02-25 20:55:26 -0800 (In reply to comment #5) > I must be missing something obvious, but I don't understand why the Parser and BytecodeGenerator can't cache the stack bounds. Those are temporary, stack-local objects. Even though WebKit in general may run on the main or web thread, we shouldn't every start parsing on one thread and then switch to another, right? That was my thought. Many moons ago that's essentially what they did. Then gavin refactored, then the thread local disappeared. I'm not sure why exactly. 841588 7 oliver 2013-02-25 20:55:54 -0800 (In reply to comment #5) > I must be missing something obvious, but I don't understand why the Parser and BytecodeGenerator can't cache the stack bounds. Those are temporary, stack-local objects. Even though WebKit in general may run on the main or web thread, we shouldn't every start parsing on one thread and then switch to another, right? (Also workers _do_ only run on a single thread) 841674 8 benjamin 2013-02-25 23:20:18 -0800 Sorry, I do not have a clue, I did not work on the original bug. I did this change to avoid an horrible workaround in StackBounds. I'll try to find the original radar tomorrow. 841694 9 benjamin 2013-02-26 00:02:54 -0800 After looking at why that was needed in the first place, I think this is wrong. Can you guys confirm we never enter the event loop or a WebKit callback from BytecodeGenerator and Parser? If that is the case, I will remove the iOS changes on both side. 841722 10 ggaren 2013-02-26 00:40:51 -0800 > Can you guys confirm we never enter the event loop or a WebKit callback from BytecodeGenerator and Parser? Confirmed. 841763 11 benjamin 2013-02-26 01:11:02 -0800 And done. Thank you for double checking this. 190137 2013-02-25 15:20:57 -0800 2013-02-25 20:15:14 -0800 Patch bug-110813-20130225151712.patch text/plain 6635 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MGUyMmNmYmQwMWUwM2NkZmVmYjhhNmFmY2Y0YjU1YjQxZWM3MWFmLi4xZTY0OGIzZjZlNjg3NzQ5 NDVjZTNjZTA4YzdmMDAwMWYyYzQ2MDVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxMy0wMi0yNSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBVcHN0cmVhbSBpT1MgU3RhY2sgYm91bmQgY2hlY2tpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDgxMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIGlPUywg dGhlIFN0YWNrQm91bmRzIGNhbm5vdCBiZSBjYWNoZWQgYmVjYXVzZSB0aGUgc3RhY2sKKyAgICAg ICAgY2FuIGJlIGluIG9uZSBvZiB0d28gdGhyZWFkcyAodGhlIHdlYiB0aHJlYWQgb3IgdGhlIFVJ IHRocmVhZCkuCisKKyAgICAgICAgV2Ugc2ltcGx5IGFsd2F5cyBjb25zaWRlciB0aGUgY3VycmVu dCBzdGFjayBib3VuZCB3aGVuIHRlc3RpbmcKKyAgICAgICAgc3RhY2sgYm91bmRhcmllcy4KKwor ICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHA6CisgICAgICAgIChK U0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjpCeXRlY29kZUdlbmVyYXRvcik6CisgICAgICAgICogYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmg6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2Vu ZXJhdG9yOjplbWl0Tm9kZSk6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0 Tm9kZUluQ29uZGl0aW9uQ29udGV4dCk6CisgICAgICAgIChCeXRlY29kZUdlbmVyYXRvcik6Cisg ICAgICAgICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6Ojo6UGFyc2VyKToKKyAg ICAgICAgKiBwYXJzZXIvUGFyc2VyLmg6CisgICAgICAgIChKU0M6OlBhcnNlcjo6Y2FuUmVjdXJz ZSk6CisgICAgICAgIChQYXJzZXIpOgorCiAyMDEzLTAyLTI1ICBSb2dlciBGb25nICA8cm9nZXJf Zm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVlMyMDEwIHNvbHV0aW9uIGJ1 aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIv Qnl0ZWNvZGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxl ci9CeXRlY29kZUdlbmVyYXRvci5jcHAKaW5kZXggZDY1MjE3OTA0NDkwMWJhNTdiOGNmMWYxOGU0 NTEzODFkODZjMGI2ZS4uMWI2MjM1OThmYzY4YjM0ZmNiNTNiODQzMWE5MGY4MzU5NGQ0NGQ2NCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdl bmVyYXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRl Y29kZUdlbmVyYXRvci5jcHAKQEAgLTI0OCw3ICsyNDgsOSBAQCBCeXRlY29kZUdlbmVyYXRvcjo6 Qnl0ZWNvZGVHZW5lcmF0b3IoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBQcm9ncmFtTm9kZSog cHJvZwogI2lmbmRlZiBOREVCVUcKICAgICAsIG1fbGFzdE9wY29kZVBvc2l0aW9uKDApCiAjZW5k aWYKKyNpZiAhVVNFKFdFQl9USFJFQUQpCiAgICAgLCBtX3N0YWNrKHd0ZlRocmVhZERhdGEoKS5z dGFjaygpKQorI2VuZGlmCiAgICAgLCBtX3VzZXNFeGNlcHRpb25zKGZhbHNlKQogICAgICwgbV9l eHByZXNzaW9uVG9vRGVlcChmYWxzZSkKIHsKQEAgLTI5NSw3ICsyOTcsOSBAQCBCeXRlY29kZUdl bmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBGdW5j dGlvbkJvZHlOb2RlKgogI2lmbmRlZiBOREVCVUcKICAgICAsIG1fbGFzdE9wY29kZVBvc2l0aW9u KDApCiAjZW5kaWYKKyNpZiAhVVNFKFdFQl9USFJFQUQpCiAgICAgLCBtX3N0YWNrKHd0ZlRocmVh ZERhdGEoKS5zdGFjaygpKQorI2VuZGlmCiAgICAgLCBtX3VzZXNFeGNlcHRpb25zKGZhbHNlKQog ICAgICwgbV9leHByZXNzaW9uVG9vRGVlcChmYWxzZSkKIHsKQEAgLTQ5MCw3ICs0OTQsOSBAQCBC eXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IoSlNHbG9iYWxEYXRhJiBnbG9iYWxE YXRhLCBFdmFsTm9kZSogZXZhbE5vZAogI2lmbmRlZiBOREVCVUcKICAgICAsIG1fbGFzdE9wY29k ZVBvc2l0aW9uKDApCiAjZW5kaWYKKyNpZiAhVVNFKFdFQl9USFJFQUQpCiAgICAgLCBtX3N0YWNr KHd0ZlRocmVhZERhdGEoKS5zdGFjaygpKQorI2VuZGlmCiAgICAgLCBtX3VzZXNFeGNlcHRpb25z KGZhbHNlKQogICAgICwgbV9leHByZXNzaW9uVG9vRGVlcChmYWxzZSkKIHsKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaApp bmRleCBkZDAxMzJjYTY4OGQ2NjZkYjRhMzE4NzE4YmFlMDVjNTExMWE0NmJkLi4zY2U4ZTkxOGVm MTViMmQ2ZWU2OTk0OTFjNDc4YzZmZmE1ZDNhNDNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCkBAIC00Nyw2ICs0 Nyw3IEBACiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvU2VnbWVu dGVkVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgorI2luY2x1ZGUgPHd0Zi9XVEZU aHJlYWREYXRhLmg+CiAKIG5hbWVzcGFjZSBKU0MgewogCkBAIC0zMTEsOSArMzEyLDEyIEBAIG5h bWVzcGFjZSBKU0MgewogICAgICAgICAgICAgLy8gTm9kZTo6ZW1pdENvZGUgYXNzdW1lcyB0aGF0 IGRzdCwgaWYgcHJvdmlkZWQsIGlzIGVpdGhlciBhIGxvY2FsIG9yIGEgcmVmZXJlbmNlZCB0ZW1w b3JhcnkuCiAgICAgICAgICAgICBBU1NFUlQoIWRzdCB8fCBkc3QgPT0gaWdub3JlZFJlc3VsdCgp IHx8ICFkc3QtPmlzVGVtcG9yYXJ5KCkgfHwgZHN0LT5yZWZDb3VudCgpKTsKICAgICAgICAgICAg IGFkZExpbmVJbmZvKG4tPmxpbmVObygpKTsKLSAgICAgICAgICAgIHJldHVybiBtX3N0YWNrLmlz U2FmZVRvUmVjdXJzZSgpCi0gICAgICAgICAgICAgICAgPyBuLT5lbWl0Qnl0ZWNvZGUoKnRoaXMs IGRzdCkKLSAgICAgICAgICAgICAgICA6IGVtaXRUaHJvd0V4cHJlc3Npb25Ub29EZWVwRXhjZXB0 aW9uKCk7CisjaWYgVVNFKFdFQl9USFJFQUQpCisgICAgICAgICAgICBib29sIGlzU2FmZVRvUmVj dXJzZSA9IHd0ZlRocmVhZERhdGEoKS5zdGFjaygpLmlzU2FmZVRvUmVjdXJzZSgpOworI2Vsc2UK KyAgICAgICAgICAgIGJvb2wgaXNTYWZlVG9SZWN1cnNlID0gbV9zdGFjay5pc1NhZmVUb1JlY3Vy c2UoKTsKKyNlbmRpZgorICAgICAgICAgICAgcmV0dXJuIGlzU2FmZVRvUmVjdXJzZSA/IG4tPmVt aXRCeXRlY29kZSgqdGhpcywgZHN0KSA6IGVtaXRUaHJvd0V4cHJlc3Npb25Ub29EZWVwRXhjZXB0 aW9uKCk7CiAgICAgICAgIH0KIAogICAgICAgICBSZWdpc3RlcklEKiBlbWl0Tm9kZShOb2RlKiBu KQpAQCAtMzI0LDcgKzMyOCwxMiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdm9pZCBlbWl0 Tm9kZUluQ29uZGl0aW9uQ29udGV4dChFeHByZXNzaW9uTm9kZSogbiwgTGFiZWwqIHRydWVUYXJn ZXQsIExhYmVsKiBmYWxzZVRhcmdldCwgYm9vbCBmYWxsVGhyb3VnaE1lYW5zVHJ1ZSkKICAgICAg ICAgewogICAgICAgICAgICAgYWRkTGluZUluZm8obi0+bGluZU5vKCkpOwotICAgICAgICAgICAg aWYgKG1fc3RhY2suaXNTYWZlVG9SZWN1cnNlKCkpCisjaWYgVVNFKFdFQl9USFJFQUQpCisgICAg ICAgICAgICBib29sIGlzU2FmZVRvUmVjdXJzZSA9IHd0ZlRocmVhZERhdGEoKS5zdGFjaygpLmlz U2FmZVRvUmVjdXJzZSgpOworI2Vsc2UKKyAgICAgICAgICAgIGJvb2wgaXNTYWZlVG9SZWN1cnNl ID0gbV9zdGFjay5pc1NhZmVUb1JlY3Vyc2UoKTsKKyNlbmRpZgorICAgICAgICAgICAgaWYgKGlz U2FmZVRvUmVjdXJzZSkKICAgICAgICAgICAgICAgICBuLT5lbWl0Qnl0ZWNvZGVJbkNvbmRpdGlv bkNvbnRleHQoKnRoaXMsIHRydWVUYXJnZXQsIGZhbHNlVGFyZ2V0LCBmYWxsVGhyb3VnaE1lYW5z VHJ1ZSk7CiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgZW1pdFRocm93RXhwcmVz c2lvblRvb0RlZXBFeGNlcHRpb24oKTsKQEAgLTc3NCw4ICs3ODMsOSBAQCBuYW1lc3BhY2UgSlND IHsKICNpZm5kZWYgTkRFQlVHCiAgICAgICAgIHNpemVfdCBtX2xhc3RPcGNvZGVQb3NpdGlvbjsK ICNlbmRpZgotCisjaWYgIVVTRShXRUJfVEhSRUFEKQogICAgICAgICBTdGFja0JvdW5kcyBtX3N0 YWNrOworI2VuZGlmCiAKICAgICAgICAgYm9vbCBtX3VzZXNFeGNlcHRpb25zOwogICAgICAgICBi b29sIG1fZXhwcmVzc2lvblRvb0RlZXA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL1BhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNl ci5jcHAKaW5kZXggNmZmMTI4ODllN2E2NDc3NmE1ZTRmMjJiYzVlYTJjYTZjM2ZmOTU0Zi4uZmVm YTBhNmY2OGEzNjI1NjUyMGFmM2Y1MGUxNWUzYWMzZTJiYTM4NSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtMzMsNyArMzMsNiBAQAogI2luY2x1ZGUgPHV0aWxp dHk+CiAjaW5jbHVkZSA8d3RmL0hhc2hGdW5jdGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvT3duUHRy Lmg+Ci0jaW5jbHVkZSA8d3RmL1dURlRocmVhZERhdGEuaD4KIAogI2RlZmluZSBmYWlsKCkgZG8g eyBpZiAoIW1fZXJyb3IpIHVwZGF0ZUVycm9yTWVzc2FnZSgpOyByZXR1cm4gMDsgfSB3aGlsZSAo MCkKICNkZWZpbmUgZmFpbFdpdGhUb2tlbih0b2spIGRvIHsgaWYgKCFtX2Vycm9yKSB1cGRhdGVF cnJvck1lc3NhZ2UodG9rKTsgcmV0dXJuIDA7IH0gd2hpbGUgKDApCkBAIC02NSw3ICs2NCw5IEBA IHRlbXBsYXRlIDx0eXBlbmFtZSBMZXhlclR5cGU+CiBQYXJzZXI8TGV4ZXJUeXBlPjo6UGFyc2Vy KEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSwgY29uc3QgU291cmNlQ29kZSYgc291cmNlLCBGdW5j dGlvblBhcmFtZXRlcnMqIHBhcmFtZXRlcnMsIGNvbnN0IElkZW50aWZpZXImIG5hbWUsIEpTUGFy c2VyU3RyaWN0bmVzcyBzdHJpY3RuZXNzLCBKU1BhcnNlck1vZGUgcGFyc2VyTW9kZSkKICAgICA6 IG1fZ2xvYmFsRGF0YShnbG9iYWxEYXRhKQogICAgICwgbV9zb3VyY2UoJnNvdXJjZSkKKyNpZiAh VVNFKFdFQl9USFJFQUQpCiAgICAgLCBtX3N0YWNrKHd0ZlRocmVhZERhdGEoKS5zdGFjaygpKQor I2VuZGlmCiAgICAgLCBtX2hhc1N0YWNrT3ZlcmZsb3coZmFsc2UpCiAgICAgLCBtX2Vycm9yKGZh bHNlKQogICAgICwgbV9lcnJvck1lc3NhZ2UoIlBhcnNlIGVycm9yIikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL1BhcnNlci5oCmluZGV4IGQ0ZTE2NTQxOTA5MjUwY2RmNmFiNjNlOTM2NjgwN2Uw ZWJkNzI0ZmEuLmNiMTJhOWY3YzJjZDcyNTllZGRjNjFjZDQ1MmUwYWYzOTk3Mjk0ZDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuaApAQCAtMzksNiArMzksNyBAQAogI2luY2x1 ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KICNpbmNsdWRl IDx3dGYvUmVmUHRyLmg+CisjaW5jbHVkZSA8d3RmL1dURlRocmVhZERhdGEuaD4KIG5hbWVzcGFj ZSBKU0Mgewogc3RydWN0IFNjb3BlOwogfQpAQCAtODgxLDcgKzg4MiwxMSBAQCBwcml2YXRlOgog ICAgIAogICAgIGJvb2wgY2FuUmVjdXJzZSgpCiAgICAgeworI2lmIFVTRShXRUJfVEhSRUFEKQor ICAgICAgICByZXR1cm4gd3RmVGhyZWFkRGF0YSgpLnN0YWNrKCkuaXNTYWZlVG9SZWN1cnNlKCk7 CisjZWxzZQogICAgICAgICByZXR1cm4gbV9zdGFjay5pc1NhZmVUb1JlY3Vyc2UoKTsKKyNlbmRp ZgogICAgIH0KICAgICAKICAgICBpbnQgbGFzdFRva2VuRW5kKCkgY29uc3QKQEAgLTg5Myw4ICs4 OTgsMTAgQEAgcHJpdmF0ZToKICAgICBjb25zdCBTb3VyY2VDb2RlKiBtX3NvdXJjZTsKICAgICBQ YXJzZXJBcmVuYSogbV9hcmVuYTsKICAgICBPd25QdHI8TGV4ZXJUeXBlPiBtX2xleGVyOwotICAg IAorCisjaWYgIVVTRShXRUJfVEhSRUFEKQogICAgIFN0YWNrQm91bmRzIG1fc3RhY2s7CisjZW5k aWYKICAgICBib29sIG1faGFzU3RhY2tPdmVyZmxvdzsKICAgICBib29sIG1fZXJyb3I7CiAgICAg U3RyaW5nIG1fZXJyb3JNZXNzYWdlOwo=