110807 2013-02-25 14:41:40 -0800 Page::m_isInWindow is uninitialized 2013-02-25 15:37:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 841300 0 thorton 2013-02-25 14:41:40 -0800 Should be false by default, we'll get put into a window later. 841303 1 190132 thorton 2013-02-25 14:43:09 -0800 Created attachment 190132 patch 841306 2 190132 thorton 2013-02-25 14:45:27 -0800 Comment on attachment 190132 patch View in context: https://bugs.webkit.org/attachment.cgi?id=190132&action=review > Source/WebCore/page/Page.cpp:164 > , m_isOnscreen(true) Hmm, that's odd. 841308 3 190132 simon.fraser 2013-02-25 14:46:31 -0800 Comment on attachment 190132 patch View in context: https://bugs.webkit.org/attachment.cgi?id=190132&action=review >> Source/WebCore/page/Page.cpp:164 >> , m_isOnscreen(true) > > Hmm, that's odd. Should we change this? 841320 4 thorton 2013-02-25 15:02:59 -0800 I think we should. A Page shouldn't be onscreen (or in-window) by default - until it's added to a platform view/window/etc. Any ports that see fallout from such a change should probably make sure that they're calling setIsInWindow/willMoveOffscreen/didMoveOnscreen at the appropriate times... 841347 5 thorton 2013-02-25 15:25:23 -0800 Ugh, none of the other ports bother to update onscreen or in-window state. Instead of implementing this for all the ports, I'm going to (unfortunately) match m_isOnscreen and default to true. WK2 sets it to the correct value very quickly anyway, so this isn't a big deal. 841349 6 190141 thorton 2013-02-25 15:25:46 -0800 Created attachment 190141 sad patch 841351 7 190141 simon.fraser 2013-02-25 15:28:09 -0800 Comment on attachment 190141 sad patch r=me but please justify your odd choice more in the Changelog. 841357 8 thorton 2013-02-25 15:37:23 -0800 http://trac.webkit.org/changeset/143979 190132 2013-02-25 14:43:09 -0800 2013-02-25 15:25:46 -0800 patch init.diff text/plain 1121 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZTM2YTcwLi41OTY0NDgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDItMjUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUGFnZTo6bV9pc0luV2luZG93IGlzIHVuaW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDgwNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhZ2U6OlBhZ2UpOiBJbml0aWFsaXplIG1faXNJbldpbmRvdyB0byBm YWxzZS4KKwogMjAxMy0wMi0yMiAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBGYWN0b3IgTWVkaWFTb3VyY2UgbWV0aG9kcyBvdXQgb2YgTWVkaWFQbGF5 ZXIgJiBNZWRpYVBsYXllclByaXZhdGUgYW5kIGludG8gYSBuZXcgTWVkaWFTb3VyY2VQcml2YXRl IGludGVyZmFjZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCmluZGV4IDUxMzM1NjcuLmI0MzBmNDQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9QYWdlLmNwcApAQCAtMTYyLDYgKzE2Miw3IEBAIFBhZ2U6OlBhZ2UoUGFnZUNsaWVudHMm IHBhZ2VDbGllbnRzKQogICAgICwgbV90aW1lckFsaWdubWVudEludGVydmFsKFNldHRpbmdzOjpk ZWZhdWx0RE9NVGltZXJBbGlnbm1lbnRJbnRlcnZhbCgpKQogICAgICwgbV9pc0VkaXRhYmxlKGZh bHNlKQogICAgICwgbV9pc09uc2NyZWVuKHRydWUpCisgICAgLCBtX2lzSW5XaW5kb3coZmFsc2Up CiAjaWYgRU5BQkxFKFBBR0VfVklTSUJJTElUWV9BUEkpCiAgICAgLCBtX3Zpc2liaWxpdHlTdGF0 ZShQYWdlVmlzaWJpbGl0eVN0YXRlVmlzaWJsZSkKICNlbmRpZgo= 190141 2013-02-25 15:25:46 -0800 2013-02-25 15:28:09 -0800 sad patch init.diff text/plain 1119 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZTM2YTcwLi41OTY0NDgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDItMjUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUGFnZTo6bV9pc0luV2luZG93IGlzIHVuaW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDgwNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhZ2U6OlBhZ2UpOiBJbml0aWFsaXplIG1faXNJbldpbmRvdyB0byB0 cnVlLgorCiAyMDEzLTAyLTIyICBBYXJvbiBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEZhY3RvciBNZWRpYVNvdXJjZSBtZXRob2RzIG91dCBvZiBNZWRpYVBsYXll ciAmIE1lZGlhUGxheWVyUHJpdmF0ZSBhbmQgaW50byBhIG5ldyBNZWRpYVNvdXJjZVByaXZhdGUg aW50ZXJmYWNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggNTEzMzU2Ny4uYmZmOGRjZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BhZ2UuY3BwCkBAIC0xNjIsNiArMTYyLDcgQEAgUGFnZTo6UGFnZShQYWdlQ2xpZW50cyYg cGFnZUNsaWVudHMpCiAgICAgLCBtX3RpbWVyQWxpZ25tZW50SW50ZXJ2YWwoU2V0dGluZ3M6OmRl ZmF1bHRET01UaW1lckFsaWdubWVudEludGVydmFsKCkpCiAgICAgLCBtX2lzRWRpdGFibGUoZmFs c2UpCiAgICAgLCBtX2lzT25zY3JlZW4odHJ1ZSkKKyAgICAsIG1faXNJbldpbmRvdyh0cnVlKQog I2lmIEVOQUJMRShQQUdFX1ZJU0lCSUxJVFlfQVBJKQogICAgICwgbV92aXNpYmlsaXR5U3RhdGUo UGFnZVZpc2liaWxpdHlTdGF0ZVZpc2libGUpCiAjZW5kaWYK