110802 2013-02-25 14:26:59 -0800 Kill another analyzer warning in javascriptcore 2013-02-26 01:49:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver webkit.review.bot oldest_to_newest 841283 0 oliver 2013-02-25 14:26:59 -0800 The LegacyProfiler::{start,stop}Profiling methods try to handle a null exec, but then ignore the possibility of null later. We just exit early on a null exec now, on the basis that we would have crashed anyway had we not. 841284 1 190127 oliver 2013-02-25 14:27:42 -0800 Created attachment 190127 Patch 841793 2 190127 webkit.review.bot 2013-02-26 01:49:48 -0800 Comment on attachment 190127 Patch Clearing flags on attachment: 190127 Committed r144026: <http://trac.webkit.org/changeset/144026> 841794 3 webkit.review.bot 2013-02-26 01:49:51 -0800 All reviewed patches have been landed. Closing bug. 190127 2013-02-25 14:27:42 -0800 2013-02-26 01:49:48 -0800 Patch bug-110802-20130225142357.patch text/plain 2294 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx OWU5MTUwODM4ZWNmMjkyYzBhMGQyZTU2OTAzNmY1ZmMzNDVhYTJjLi5lM2I2ZGQxZGE5ZDVkMzNj ODBkYzQ5ZjdjMDc5NDJjNmMyZTA0YjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wMi0yNSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEtpbGwgYW5vdGhlciBhbmFseXplciB3YXJuaW5nIGluIGphdmFzY3JpcHRjb3Jl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA4MDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbnVs bCBjaGVja3MuCisgICAgICAgIAorICAgICAgICAqIHByb2ZpbGVyL0xlZ2FjeVByb2ZpbGVyLmNw cDoKKyAgICAgICAgKEpTQzo6TGVnYWN5UHJvZmlsZXI6OnN0YXJ0UHJvZmlsaW5nKToKKyAgICAg ICAgKEpTQzo6TGVnYWN5UHJvZmlsZXI6OnN0b3BQcm9maWxpbmcpOgorCiAyMDEzLTAyLTI1ICBH ZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gb25lIGxvb2t1 cCBwZXIgY29kZSBjYWNoZSBpbnNlcnRpb24gaW5zdGVhZCBvZiB0d28KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9wcm9maWxlci9MZWdhY3lQcm9maWxlci5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcHJvZmlsZXIvTGVnYWN5UHJvZmlsZXIuY3BwCmluZGV4IDIyZDRhNDI5 ZGJkYzAyZjg5OTQ5NDU5OTQ1MjY1NWJmNWM1YThjMzQuLmFmMTY3OGYwYjdiNDQwYmZlNTZlYmU0 NzE2MDNmZDI1NjZkN2UwOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wcm9m aWxlci9MZWdhY3lQcm9maWxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Byb2Zp bGVyL0xlZ2FjeVByb2ZpbGVyLmNwcApAQCAtNjMsOSArNjMsMTIgQEAgdm9pZCBMZWdhY3lQcm9m aWxlcjo6c3RhcnRQcm9maWxpbmcoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBTdHJpbmcmIHRpdGxl KQogewogICAgIEFTU0VSVF9BUkcodGl0bGUsICF0aXRsZS5pc051bGwoKSk7CiAKKyAgICBpZiAo IWV4ZWMpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIENoZWNrIGlmIHdlIGN1cnJlbnRseSBo YXZlIGEgUHJvZmlsZSBmb3IgdGhpcyBnbG9iYWwgRXhlY1N0YXRlIGFuZCB0aXRsZS4KICAgICAv LyBJZiBzbyByZXR1cm4gZWFybHkgYW5kIGRvbid0IGNyZWF0ZSBhIG5ldyBQcm9maWxlLgotICAg IEpTR2xvYmFsT2JqZWN0KiBvcmlnaW4gPSBleGVjID8gZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVj dCgpIDogMDsKKyAgICBKU0dsb2JhbE9iamVjdCogb3JpZ2luID0gZXhlYy0+bGV4aWNhbEdsb2Jh bE9iamVjdCgpOwogCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2N1cnJlbnRQcm9maWxl cy5zaXplKCk7ICsraSkgewogICAgICAgICBQcm9maWxlR2VuZXJhdG9yKiBwcm9maWxlR2VuZXJh dG9yID0gbV9jdXJyZW50UHJvZmlsZXNbaV0uZ2V0KCk7CkBAIC04MCw3ICs4MywxMCBAQCB2b2lk IExlZ2FjeVByb2ZpbGVyOjpzdGFydFByb2ZpbGluZyhFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IFN0 cmluZyYgdGl0bGUpCiAKIFBhc3NSZWZQdHI8UHJvZmlsZT4gTGVnYWN5UHJvZmlsZXI6OnN0b3BQ cm9maWxpbmcoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBTdHJpbmcmIHRpdGxlKQogewotICAgIEpT R2xvYmFsT2JqZWN0KiBvcmlnaW4gPSBleGVjID8gZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgp IDogMDsKKyAgICBpZiAoIWV4ZWMpCisgICAgICAgIHJldHVybiAwOworCisgICAgSlNHbG9iYWxP YmplY3QqIG9yaWdpbiA9IGV4ZWMtPmxleGljYWxHbG9iYWxPYmplY3QoKTsKICAgICBmb3IgKHB0 cmRpZmZfdCBpID0gbV9jdXJyZW50UHJvZmlsZXMuc2l6ZSgpIC0gMTsgaSA+PSAwOyAtLWkpIHsK ICAgICAgICAgUHJvZmlsZUdlbmVyYXRvciogcHJvZmlsZUdlbmVyYXRvciA9IG1fY3VycmVudFBy b2ZpbGVzW2ldLmdldCgpOwogICAgICAgICBpZiAocHJvZmlsZUdlbmVyYXRvci0+b3JpZ2luKCkg PT0gb3JpZ2luICYmICh0aXRsZS5pc051bGwoKSB8fCBwcm9maWxlR2VuZXJhdG9yLT50aXRsZSgp ID09IHRpdGxlKSkgewo=