110799 2013-02-25 14:16:09 -0800 [V8] Overloaded constructors don't need header declarations 2013-02-26 01:08:07 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110667 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 841273 0 haraken 2013-02-25 14:16:09 -0800 They are implemented as static functions in cpp files. Header declarations are not needed. 841274 1 190124 haraken 2013-02-25 14:17:37 -0800 Created attachment 190124 Patch 841757 2 190124 webkit.review.bot 2013-02-26 01:08:03 -0800 Comment on attachment 190124 Patch Clearing flags on attachment: 190124 Committed r144022: <http://trac.webkit.org/changeset/144022> 841758 3 webkit.review.bot 2013-02-26 01:08:07 -0800 All reviewed patches have been landed. Closing bug. 190124 2013-02-25 14:17:37 -0800 2013-02-26 01:08:03 -0800 Patch bug-110799-20130225141353.patch text/plain 3036 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFkNjQ2ZWI4ODU1MTgy ZTY3ZDliMGU2ZDY5NTg0OGJlYzJkY2Y4NC4uYTJlNjM2YTg0MTI5ZGZhMjIxY2ViYzdhOTNmYTA1 NTJlMGJkNjg5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTAyLTI1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIE92ZXJsb2Fk ZWQgY29uc3RydWN0b3JzIGRvbid0IG5lZWQgaGVhZGVyIGRlY2xhcmF0aW9ucworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTEwNzk5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhleSBhcmUgaW1wbGVtZW50 ZWQgYXMgc3RhdGljIGZ1bmN0aW9ucyBpbiBjcHAgZmlsZXMuCisgICAgICAgIEhlYWRlciBkZWNs YXJhdGlvbnMgYXJlIG5vdCBuZWVkZWQuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtOgorICAgICAgICAoR2VuZXJhdGVIZWFkZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvdGVzdC9WOC9WOFRlc3RPdmVybG9hZGVkQ29uc3RydWN0b3JzLmg6CisKKzIwMTMtMDItMjUg IEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtWOF0gR2Vu ZXJhdGUgYSB3cmFwcGVyIGZ1bmN0aW9uIGZvciBtZXRob2QgY2FsbGJhY2tzCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA3NjkKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCA1 ODlhYjJkOGZjZjNiZjM3NDE3ZTc5ZTExMzFiODMzYWU5MzJiMGZjLi5mMmVkY2UxNGNkNzZkMmY1 ODY1NjRjNzYyMzRhYjRlMmVmYjQ0ZDE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtNTAzLDE0ICs1MDMsNiBAQCBFTkQK IHByaXZhdGU6CiBFTkQKIAotICAgIGlmIChJc0NvbnN0cnVjdGFibGUoJGludGVyZmFjZSkgJiYg QHskaW50ZXJmYWNlLT5jb25zdHJ1Y3RvcnN9ID4gMSkgewotICAgICAgICBmb3IgKG15ICRpID0g MTsgJGkgPD0gQHskaW50ZXJmYWNlLT5jb25zdHJ1Y3RvcnN9OyAkaSsrKSB7Ci0gICAgICAgICAg IHB1c2goQGhlYWRlckNvbnRlbnQsIDw8RU5EKTsKLSAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6 VmFsdWU+IGNvbnN0cnVjdG9yJHtpfUNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmKTsKLUVO RAotICAgICAgICB9Ci0gICAgfQotCiAgICAgbXkgJG5vVG9WOCA9ICRpbnRlcmZhY2UtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJTdXBwcmVzc1RvSlNPYmplY3QifTsKICAgICBteSAkbm9XcmFwID0g JGludGVyZmFjZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4Tm9XcmFwcGVyQ2FjaGUifSB8fCAk bm9Ub1Y4OwogICAgIGlmICghJG5vV3JhcCkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE92ZXJsb2FkZWRDb25zdHJ1Y3RvcnMuaCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3RPdmVybG9hZGVk Q29uc3RydWN0b3JzLmgKaW5kZXggN2FlZjQ5NzE1NTgxMjY5YzMxNmQzMWRmOTJhZWU1ZWFlZDYx YzRiZC4uMWZlMTgxNDI3ZTUxNjcyNGEyYmM2NWJhZTIyNGM0YmFjODdmZGE1MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE92ZXJsb2Fk ZWRDb25zdHJ1Y3RvcnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvVjgvVjhUZXN0T3ZlcmxvYWRlZENvbnN0cnVjdG9ycy5oCkBAIC00OCwxMCArNDgsNiBAQCBw dWJsaWM6CiAgICAgc3RhdGljIHZvaWQgaW5zdGFsbFBlckNvbnRleHRQcm9wZXJ0aWVzKHY4OjpI YW5kbGU8djg6Ok9iamVjdD4sIFRlc3RPdmVybG9hZGVkQ29uc3RydWN0b3JzKiwgdjg6Oklzb2xh dGUqKSB7IH0KICAgICBzdGF0aWMgdm9pZCBpbnN0YWxsUGVyQ29udGV4dFByb3RvdHlwZVByb3Bl cnRpZXModjg6OkhhbmRsZTx2ODo6T2JqZWN0Piwgdjg6Oklzb2xhdGUqKSB7IH0KIHByaXZhdGU6 Ci0gICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjb25zdHJ1Y3RvcjFDYWxsYmFjayhj b25zdCB2ODo6QXJndW1lbnRzJik7Ci0gICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBj b25zdHJ1Y3RvcjJDYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJik7Ci0gICAgc3RhdGljIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBjb25zdHJ1Y3RvcjNDYWxsYmFjayhjb25zdCB2ODo6QXJndW1l bnRzJik7Ci0gICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjb25zdHJ1Y3RvcjRDYWxs YmFjayhjb25zdCB2ODo6QXJndW1lbnRzJik7CiAgICAgZnJpZW5kIHY4OjpIYW5kbGU8djg6Ok9i amVjdD4gd3JhcChUZXN0T3ZlcmxvYWRlZENvbnN0cnVjdG9ycyosIHY4OjpIYW5kbGU8djg6Ok9i amVjdD4gY3JlYXRpb25Db250ZXh0LCB2ODo6SXNvbGF0ZSopOwogICAgIHN0YXRpYyB2ODo6SGFu ZGxlPHY4OjpPYmplY3Q+IGNyZWF0ZVdyYXBwZXIoUGFzc1JlZlB0cjxUZXN0T3ZlcmxvYWRlZENv bnN0cnVjdG9ycz4sIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gY3JlYXRpb25Db250ZXh0LCB2ODo6 SXNvbGF0ZSopOwogfTsK