110792 2013-02-25 13:50:36 -0800 IndexedDB: IDBObjectStore.index() doesn't report errors after deleteIndex() 2013-02-26 10:46:07 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell alecflett dgrogan tony webkit.review.bot oldest_to_newest 841258 0 jsbell 2013-02-25 13:50:36 -0800 First reported at: https://code.google.com/p/chromium/issues/detail?id=177963 Basic repro: 1. Create a database with an object store and an index. Close the connection. 2. Open another connection with a higher version. During upgradeneed handling... 3. Use store.deleteIndex('indexname') to delete the index 4. Use store.index('indexname') to try and access it. Expected: The last step should fire a DOMException of type "NotFoundError". Actual: An IDBIndex is returned Critical to the repro is that from step 2 through step 3, store.index('indexname') is not called (e.g. to assert that the index is present before the delete). Otherwise, the exception is thrown as expected. 841262 1 190121 jsbell 2013-02-25 14:01:03 -0800 Created attachment 190121 Patch 841263 2 jsbell 2013-02-25 14:01:48 -0800 alecflett@ - can you take a look? 841526 3 alecflett 2013-02-25 19:05:54 -0800 Lgtm 841528 4 jsbell 2013-02-25 19:08:13 -0800 Tony@ - r? 842168 5 190121 webkit.review.bot 2013-02-26 10:46:04 -0800 Comment on attachment 190121 Patch Clearing flags on attachment: 190121 Committed r144075: <http://trac.webkit.org/changeset/144075> 842169 6 webkit.review.bot 2013-02-26 10:46:07 -0800 All reviewed patches have been landed. Closing bug. 190121 2013-02-25 14:01:03 -0800 2013-02-26 10:46:04 -0800 Patch bug-110792-20130225135718.patch text/plain 6028 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzOTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzZkNmY5NTRjYWE0OTM2 ODlmYjE2NDUwMThhMWM3YzY1YzFiNzA3Yy4uZGQ0MTZjNmI5Y2Q3MGMwZmU1ODdiY2E4MThlYjVh MmZjNWVkMDI1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAyLTI1ICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBJREJP YmplY3RTdG9yZS5pbmRleCgpIGRvZXNuJ3QgcmVwb3J0IGVycm9ycyBhZnRlciBkZWxldGVJbmRl eCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTA3 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg b2JqZWN0IHN0b3JlJ3MgbWV0YWRhdGEgd2Fzbid0IHVwZGF0ZWQgaWYgdGhlIGluZGV4IGhhZG4n dCBiZWVuIGFjY2Vzc2VkCisgICAgICAgIGJ5IHNjcmlwdCBhbmQgaGVuY2UgcGxhY2VkIGluIHRo ZSBuYW1lLT5vYmplY3QgbWFwLiBNYWtlIHN1cmUgdGhlIG1ldGFkYXRhCisgICAgICAgIGlzIGFs d2F5cyB1cGRhdGVkLgorCisgICAgICAgIFRlc3Q6IHN0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZUlu ZGV4LWJ1ZzExMDc5Mi5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJPYmpl Y3RTdG9yZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJPYmplY3RTdG9yZTo6ZGVsZXRlSW5k ZXgpOiBBbHdheXMgdXBkYXRlIHRoZSBvYmplY3Qgc3RvcmUncyBtZXRhZGF0YS4KKwogMjAxMy0w Mi0yMyAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogTmF0aXZlIE1lbW9yeSBJbnN0cnVtZW50YXRpb246IHJlcGxhY2UgU3Ry aW5nIHdpdGggY29uc3QgY2hhciogaW4gTWVtb3J5T2JqZWN0SW5mbwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCT2JqZWN0U3RvcmUuY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCT2JqZWN0U3RvcmUuY3BwCmluZGV4IDNjZjU0 OTY3MjRiNzcwYWQ0ZmFhZjViYjcwMzNjYWY1OTEyY2QyMGEuLmZhYTVjYmUyNjFjY2IwNGQ0Yzg5 Mzk3ZDZjZmMzYjJmZTI3YThhM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL0lEQk9iamVjdFN0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9JREJPYmplY3RTdG9yZS5jcHAKQEAgLTQ2OSw2ICs0NjksNyBAQCBQYXNzUmVm UHRyPElEQkluZGV4PiBJREJPYmplY3RTdG9yZTo6aW5kZXgoY29uc3QgU3RyaW5nJiBuYW1lLCBF eGNlcHRpb25Db2RlJiBlYwogCiB2b2lkIElEQk9iamVjdFN0b3JlOjpkZWxldGVJbmRleChjb25z dCBTdHJpbmcmIG5hbWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogeworICAgIElEQl9UUkFDRSgiSURC T2JqZWN0U3RvcmU6OmRlbGV0ZUluZGV4Iik7CiAgICAgaWYgKCFtX3RyYW5zYWN0aW9uLT5pc1Zl cnNpb25DaGFuZ2UoKSB8fCBtX2RlbGV0ZWQpIHsKICAgICAgICAgZWMgPSBJREJEYXRhYmFzZUV4 Y2VwdGlvbjo6SW52YWxpZFN0YXRlRXJyb3I7CiAgICAgICAgIHJldHVybjsKQEAgLTQ4NSw5ICs0 ODYsOSBAQCB2b2lkIElEQk9iamVjdFN0b3JlOjpkZWxldGVJbmRleChjb25zdCBTdHJpbmcmIG5h bWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogCiAgICAgYmFja2VuZERCKCktPmRlbGV0ZUluZGV4KG1f dHJhbnNhY3Rpb24tPmlkKCksIGlkKCksIGluZGV4SWQpOwogCisgICAgbV9tZXRhZGF0YS5pbmRl eGVzLnJlbW92ZShpbmRleElkKTsKICAgICBJREJJbmRleE1hcDo6aXRlcmF0b3IgaXQgPSBtX2lu ZGV4TWFwLmZpbmQobmFtZSk7CiAgICAgaWYgKGl0ICE9IG1faW5kZXhNYXAuZW5kKCkpIHsKLSAg ICAgICAgbV9tZXRhZGF0YS5pbmRleGVzLnJlbW92ZShpdC0+dmFsdWUtPmlkKCkpOwogICAgICAg ICBpdC0+dmFsdWUtPm1hcmtEZWxldGVkKCk7CiAgICAgICAgIG1faW5kZXhNYXAucmVtb3ZlKG5h bWUpOwogICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA1YmM3YTZlMmMzMjNkMzI3YjJkMzI1MGI1YjRmOWRkNDA1NjBi MTk4Li4yNjRlNmI1MjAwMDBiOWQyZjA0NDcyOTFiN2VkOTlkNzY4ZTRlMWQzIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTMtMDItMjUgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9y Zz4KKworICAgICAgICBJbmRleGVkREI6IElEQk9iamVjdFN0b3JlLmluZGV4KCkgZG9lc24ndCBy ZXBvcnQgZXJyb3JzIGFmdGVyIGRlbGV0ZUluZGV4KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDc5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHJlZ3Jlc3Npb24gdGVzdCBmb3IgYnVnLgor CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvZGVsZXRlSW5kZXgtYnVnMTEwNzkyLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvZGVsZXRlSW5kZXgt YnVnMTEwNzkyLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAyLTI1ICBWc2V2b2xvZCBWbGFzb3YgIDx2 c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgY2hyb21pdW0gdGVzdCBl eHBlY3RhdGlvbnMgdXBkYXRlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRl eGVkZGIvZGVsZXRlSW5kZXgtYnVnMTEwNzkyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZUluZGV4LWJ1ZzExMDc5Mi1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZjgwZjNlOTEwOTU2MGMzOWVhYzZmNDJlOWRhMjRmMjRkYWUwYzBkNwotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZUluZGV4LWJ1ZzEx MDc5Mi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzMyBAQAorRW5zdXJlIEluZGV4ZWREQidzIElE Qk9iamVjdFN0b3JlLmRlbGV0ZUluZGV4KCkgd29ya3MgaWYgSURCSW5kZXggb2JqZWN0IGhhcyBu b3QgYmVlbiBmZXRjaGVkIC0gcmVncmVzc2lvbiB0ZXN0IGZvciBidWcgMTEwNzkyLgorCitPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworaW5kZXhlZERCID0gc2VsZi5pbmRleGVkREIgfHwg c2VsZi53ZWJraXRJbmRleGVkREIgfHwgc2VsZi5tb3pJbmRleGVkREIgfHwgc2VsZi5tc0luZGV4 ZWREQiB8fCBzZWxmLk9JbmRleGVkREI7CisKK2RibmFtZSA9ICJkZWxldGVJbmRleC1idWcxMTA3 OTIuaHRtbCIKK2luZGV4ZWREQi5kZWxldGVEYXRhYmFzZShkYm5hbWUpCitpbmRleGVkREIub3Bl bihkYm5hbWUsIDEpCisKK29uRmlyc3RVcGdyYWRlTmVlZGVkKCk6CitkYiA9IGV2ZW50LnRhcmdl dC5yZXN1bHQKK3N0b3JlID0gZGIuY3JlYXRlT2JqZWN0U3RvcmUoJ3N0b3JlJykKK3N0b3JlLmNy ZWF0ZUluZGV4KCdpbmRleCcsICdrZXlQYXRoJykKKworY2xvc2VBbmRSZU9wZW4oKToKK2RiLmNs b3NlKCkKKworaW5kZXhlZERCLm9wZW4oZGJuYW1lLCAyKQorCitvblNlY29uZFVwZ3JhZGVOZWVk ZWQoKToKK2RiID0gZXZlbnQudGFyZ2V0LnJlc3VsdAorc3RvcmUgPSBldmVudC50YXJnZXQudHJh bnNhY3Rpb24ub2JqZWN0U3RvcmUoJ3N0b3JlJykKK3N0b3JlLmRlbGV0ZUluZGV4KCdpbmRleCcp CitFeHBlY3RpbmcgZXhjZXB0aW9uIGZyb20gc3RvcmUuaW5kZXgoJ2luZGV4JykKK1BBU1MgRXhj ZXB0aW9uIHdhcyB0aHJvd24uCitQQVNTIGNvZGUgaXMgRE9NRXhjZXB0aW9uLk5PVF9GT1VORF9F UlIKK1BBU1MgZW5hbWUgaXMgJ05vdEZvdW5kRXJyb3InCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvZGVsZXRlSW5kZXgtYnVnMTEwNzkyLmh0bWwgYi9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9kZWxldGVJbmRleC1idWcxMTA3OTIuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44 YmQ0YTQ2MjMyMjEyMGQ2NWE3ZTM3ZWUzMDA3ODk4MTMzMTk5MDBjCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGVsZXRlSW5kZXgtYnVnMTEwNzkyLmh0 bWwKQEAgLTAsMCArMSw0MiBAQAorPCFET0NUWVBFIGh0bWw+Cis8c2NyaXB0IHNyYz0iLi4vLi4v ZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 InJlc291cmNlcy9zaGFyZWQuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworZGVzY3JpcHRpb24o IkVuc3VyZSBJbmRleGVkREIncyBJREJPYmplY3RTdG9yZS5kZWxldGVJbmRleCgpIHdvcmtzIGlm IElEQkluZGV4IG9iamVjdCBoYXMgbm90IGJlZW4gZmV0Y2hlZCAtIHJlZ3Jlc3Npb24gdGVzdCBm b3IgYnVnIDExMDc5Mi4iKTsKKworaW5kZXhlZERCVGVzdChvbkZpcnN0VXBncmFkZU5lZWRlZCwg Y2xvc2VBbmRSZU9wZW4sIHt2ZXJzaW9uOiAxfSk7CisKK2Z1bmN0aW9uIG9uRmlyc3RVcGdyYWRl TmVlZGVkKGV2dCkKK3sKKyAgICBwcmVhbWJsZShldnQpOworICAgIGV2YWxBbmRMb2coImRiID0g ZXZlbnQudGFyZ2V0LnJlc3VsdCIpOworICAgIGV2YWxBbmRMb2coInN0b3JlID0gZGIuY3JlYXRl T2JqZWN0U3RvcmUoJ3N0b3JlJykiKTsKKyAgICBldmFsQW5kTG9nKCJzdG9yZS5jcmVhdGVJbmRl eCgnaW5kZXgnLCAna2V5UGF0aCcpIik7Cit9CisKK2Z1bmN0aW9uIGNsb3NlQW5kUmVPcGVuKCkK K3sKKyAgICBwcmVhbWJsZSgpOworICAgIGV2YWxBbmRMb2coImRiLmNsb3NlKCkiKTsKKyAgICBk ZWJ1ZygiIik7CisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coImluZGV4ZWREQi5vcGVuKGRibmFt ZSwgMikiKTsKKyAgICByZXF1ZXN0Lm9uYmxvY2tlZCA9IHVuZXhwZWN0ZWRCbG9ja2VkQ2FsbGJh Y2s7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJhY2s7CisgICAg cmVxdWVzdC5vbnVwZ3JhZGVuZWVkZWQgPSBvblNlY29uZFVwZ3JhZGVOZWVkZWQ7CisgICAgcmVx dWVzdC5vbnN1Y2Nlc3MgPSBmaW5pc2hKU1Rlc3Q7Cit9CisKK2Z1bmN0aW9uIG9uU2Vjb25kVXBn cmFkZU5lZWRlZChldnQpCit7CisgICAgcHJlYW1ibGUoZXZ0KTsKKyAgICBldmFsQW5kTG9nKCJk YiA9IGV2ZW50LnRhcmdldC5yZXN1bHQiKTsKKyAgICBldmFsQW5kTG9nKCJzdG9yZSA9IGV2ZW50 LnRhcmdldC50cmFuc2FjdGlvbi5vYmplY3RTdG9yZSgnc3RvcmUnKSIpOworICAgIC8vIERvIE5P VCBhZGQgYSBjYWxsIHRvIHN0b3JlLmluZGV4KCdpbmRleCcpIGhlcmUgKGUuZy4gdG8gYXNzZXJ0 IGl0IGV4aXN0cykKKyAgICAvLyBvciB0aGUgYnVnIGRpc2FwcGVhcnMuCisgICAgZXZhbEFuZExv Zygic3RvcmUuZGVsZXRlSW5kZXgoJ2luZGV4JykiKTsKKyAgICBldmFsQW5kRXhwZWN0RXhjZXB0 aW9uKCJzdG9yZS5pbmRleCgnaW5kZXgnKSIsICJET01FeGNlcHRpb24uTk9UX0ZPVU5EX0VSUiIs ICInTm90Rm91bmRFcnJvciciKTsKK30KKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0uLi8uLi9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanM+PC9zY3JpcHQ+Cg==