110787 2013-02-25 13:03:26 -0800 [BlackBerry] Use APIEntryShim when making JS call 2013-02-26 10:06:36 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned webkit.review.bot oldest_to_newest 841226 0 yong.li.webkit 2013-02-25 13:03:26 -0800 PR 301451. 841232 1 190112 yong.li.webkit 2013-02-25 13:10:04 -0800 Created attachment 190112 the patch . 841238 2 190112 rwlbuis 2013-02-25 13:18:08 -0800 Comment on attachment 190112 the patch LGTM. 841521 3 190112 webkit.review.bot 2013-02-25 18:51:45 -0800 Comment on attachment 190112 the patch Rejecting attachment 190112 from commit-queue. yong.li.webkit@outlook.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 841877 4 190112 yong.li.webkit 2013-02-26 04:31:55 -0800 Comment on attachment 190112 the patch try again 841893 5 190112 webkit.review.bot 2013-02-26 04:57:13 -0800 Comment on attachment 190112 the patch Rejecting attachment 190112 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190112, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://webkit-commit-queue.appspot.com/results/16771101 842128 6 190112 webkit.review.bot 2013-02-26 10:06:34 -0800 Comment on attachment 190112 the patch Clearing flags on attachment: 190112 Committed r144069: <http://trac.webkit.org/changeset/144069> 842129 7 webkit.review.bot 2013-02-26 10:06:36 -0800 All reviewed patches have been landed. Closing bug. 190112 2013-02-25 13:10:04 -0800 2013-02-26 10:06:33 -0800 the patch 110787.diff text/plain 1606 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IGJmMjljNmEuLmE2 NmJmMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMTks NiArMTksNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYlBhZ2UuaCIKIAor I2luY2x1ZGUgIkFQSVNoaW1zLmgiCiAjaW5jbHVkZSAiQXBwbGljYXRpb25DYWNoZVN0b3JhZ2Uu aCIKICNpbmNsdWRlICJBdXRoZW50aWNhdGlvbkNoYWxsZW5nZU1hbmFnZXIuaCIKICNpbmNsdWRl ICJBdXRvZmlsbE1hbmFnZXIuaCIKQEAgLTg4OCw3ICs4ODksNyBAQCB2b2lkIFdlYlBhZ2U6OmV4 ZWN1dGVKYXZhU2NyaXB0RnVuY3Rpb24oY29uc3Qgc3RkOjp2ZWN0b3I8QmxhY2tCZXJyeTo6UGxh dGZvcm06OgogICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gcm9vdC0+Z2xvYmFsT2JqZWN0KCkt Pmdsb2JhbEV4ZWMoKTsKICAgICBKU0dsb2JhbENvbnRleHRSZWYgY3R4ID0gdG9HbG9iYWxSZWYo ZXhlYyk7CiAKLSAgICBKU0M6OkpTTG9ja0hvbGRlciBsb2NrKGV4ZWMpOworICAgIEpTQzo6QVBJ RW50cnlTaGltIHNoaW0oZXhlYyk7CiAgICAgV1RGOjpWZWN0b3I8SlNWYWx1ZVJlZj4gYXJnTGlz dFJlZihhcmdzLnNpemUoKSk7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGFyZ3Muc2l6 ZSgpOyArK2kpCiAgICAgICAgIGFyZ0xpc3RSZWZbaV0gPSBCbGFja0JlcnJ5SmF2YVNjcmlwdFZh cmlhbnRUb0pTVmFsdWVSZWYoY3R4LCBhcmdzW2ldKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdl TG9nCmluZGV4IDRiMzU0MTEuLmNmODAxOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAyLTI1ICBZb25nIExpICA8eW9saUByaW0uY29tPgor CisgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgQVBJRW50cnlTaGltIHdoZW4gbWFraW5nIEpTIGNh bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMDc4 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIyAz MDE0NTEuCisgICAgICAgIFVzZSBBUElFbnRyeVNoaW0gdG8gZml4IGFuIGFzc2VydCBhbmQgZW5z dXJlIGl0IGlzIHRocmVhZC1zYWZlLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAg ICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpleGVjdXRlSmF2YVNjcmlwdEZ1bmN0 aW9uKToKKwogMjAxMy0wMi0yNSAgQWxiZXJ0byBHYXJjaWEgIDxhbGJnYXJjaWFAcmltLmNvbT4K IAogICAgICAgICBbQmxhY2tCZXJyeV0gQ2hyb21lQ2xpZW50QmxhY2tCZXJyeTogZml4IHZhcmlh YmxlIG5hbWVzCg==