110783 2013-02-25 12:37:01 -0800 [texmap] Rename TextureMapperGL::ClipStack::init to reset 2013-02-25 20:06:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bruno.abinader bruno.abinader cmarcelo igor.oliveira luiz noam tonikitoo webkit.review.bot oldest_to_newest 841198 0 bruno.abinader 2013-02-25 12:37:01 -0800 When debugging over TextureMapper::ClipStack, I've noticed that the ClipStack::init() function is used not only when begin painting, but also when clearing. I'm used to see init() functions being called inside ctor's to initialize member variables that were unable to be assigned on an initialization list, which is not the case, and also because reset() better reflects the behavior (clears the clip stack and assigns a value to the initial clip state). 841200 1 190106 bruno.abinader 2013-02-25 12:41:10 -0800 Created attachment 190106 Patch Proposed patch 841559 2 190106 webkit.review.bot 2013-02-25 20:06:31 -0800 Comment on attachment 190106 Patch Clearing flags on attachment: 190106 Committed r144003: <http://trac.webkit.org/changeset/144003> 841560 3 webkit.review.bot 2013-02-25 20:06:35 -0800 All reviewed patches have been landed. Closing bug. 190106 2013-02-25 12:41:10 -0800 2013-02-25 20:06:31 -0800 Patch bug-110783-20130225163724.patch text/plain 3559 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGJjZmFkMGJiN2Y3NjNm YTk5MGJhYmVjNGI2N2VjMzYxZTRhYWUzZi4uYmE5MGU3NjNiYWRhOTZhYjBjMDI3MGI4ZWNlMmJj ZTAwNjk1MDg5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTAyLTI1ICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBbdGV4bWFwXSBSZW5hbWUgVGV4dHVyZU1hcHBlckdMOjpDbGlwU3RhY2s6OmluaXQg dG8gcmVzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExMDc4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZ1bmN0aW9ucyBuYW1lZCBpbml0KCkgYXJlIHVzdWFsbHkgY2FsbGVkIGluc2lkZSBjdG9yJ3Mg dG8gaW5pdGlhbGl6ZQorICAgICAgICBtZW1iZXIgdmFyaWFibGVzIHRoYXQgd2VyZSB1bmFibGUg dG8gYmUgYXNzaWduZWQgb24gYW4gaW5pdGlhbGl6YXRpb24KKyAgICAgICAgbGlzdCwgd2hpY2gg aXMgbm90IHRoZSBjYXNlLCBhbmQgYWxzbyBiZWNhdXNlIHJlc2V0KCkgYmV0dGVyIHJlZmxlY3Rz CisgICAgICAgIHRoZSBiZWhhdmlvciAoY2xlYXJzIHRoZSBjbGlwIHN0YWNrIGFuZCBhc3NpZ25z IGEgdmFsdWUgdG8gdGhlIGluaXRpYWwKKyAgICAgICAgY2xpcCBzdGF0ZSkuCisKKyAgICAgICAg Tm8gYmVoYXZpb3IgY2hhbmdlcywgdGh1cyBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyR0w6OkNsaXBTdGFjazo6cmVzZXQpOgorICAg ICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckdMOjpiZWdpblBhaW50aW5nKToKKyAgICAgICAg KFdlYkNvcmU6OkJpdG1hcFRleHR1cmVHTDo6aW5pdGlhbGl6ZURlcHRoQnVmZmVyKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmg6CisgICAgICAg IChDbGlwU3RhY2spOgorCiAyMDEzLTAyLTE5ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdh bGlhLmNvbT4KIAogICAgICAgICBGaXggYnVpbGQgYnJvZWtuIGJ5IHIxNDI5ODguCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckdMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyR0wuY3BwCmluZGV4IDNjZGRjOTM2MzExMDNjZTg3NzdhNDUzMTg5ZmU4YTc4YmJjODE2 ODEuLjVmMmU3MWNmMjdiMjE0MTRlMjJlZDA2MzljMjllMTZjZjA3MTZkMmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyR0wuY3BwCkBAIC0xNzUsNyArMTc1LDcgQEAgVGV4dHVyZU1hcHBlckdMRGF0YTo6flRl eHR1cmVNYXBwZXJHTERhdGEoKQogICAgICAgICBjb250ZXh0LT5kZWxldGVCdWZmZXIoaXQtPnZh bHVlKTsKIH0KIAotdm9pZCBUZXh0dXJlTWFwcGVyR0w6OkNsaXBTdGFjazo6aW5pdChjb25zdCBJ bnRSZWN0JiByZWN0KQordm9pZCBUZXh0dXJlTWFwcGVyR0w6OkNsaXBTdGFjazo6cmVzZXQoY29u c3QgSW50UmVjdCYgcmVjdCkKIHsKICAgICBjbGlwU3RhY2suY2xlYXIoKTsKICAgICBjbGlwU3Rh dGUgPSBUZXh0dXJlTWFwcGVyR0w6OkNsaXBTdGF0ZShyZWN0KTsKQEAgLTI3MCw3ICsyNzAsNyBA QCB2b2lkIFRleHR1cmVNYXBwZXJHTDo6YmVnaW5QYWludGluZyhQYWludEZsYWdzIGZsYWdzKQog ICAgIG1fY29udGV4dDNELT5kZXB0aE1hc2soMCk7CiAgICAgbV9jb250ZXh0M0QtPmdldEludGVn ZXJ2KEdyYXBoaWNzQ29udGV4dDNEOjpWSUVXUE9SVCwgZGF0YSgpLnZpZXdwb3J0KTsKICAgICBt X2NvbnRleHQzRC0+Z2V0SW50ZWdlcnYoR3JhcGhpY3NDb250ZXh0M0Q6OlNDSVNTT1JfQk9YLCBk YXRhKCkucHJldmlvdXNTY2lzc29yKTsKLSAgICBtX2NsaXBTdGFjay5pbml0KEludFJlY3QoMCwg MCwgZGF0YSgpLnZpZXdwb3J0WzJdLCBkYXRhKCkudmlld3BvcnRbM10pKTsKKyAgICBtX2NsaXBT dGFjay5yZXNldChJbnRSZWN0KDAsIDAsIGRhdGEoKS52aWV3cG9ydFsyXSwgZGF0YSgpLnZpZXdw b3J0WzNdKSk7CiAgICAgbV9jb250ZXh0M0QtPmdldEludGVnZXJ2KEdyYXBoaWNzQ29udGV4dDNE OjpGUkFNRUJVRkZFUl9CSU5ESU5HLCAmZGF0YSgpLnRhcmdldEZyYW1lQnVmZmVyKTsKICAgICBk YXRhKCkuUGFpbnRGbGFncyA9IGZsYWdzOwogICAgIGJpbmRTdXJmYWNlKDApOwpAQCAtMTAzMCw3 ICsxMDMwLDcgQEAgdm9pZCBCaXRtYXBUZXh0dXJlR0w6OmNsZWFySWZOZWVkZWQoKQogICAgIGlm ICghbV9zaG91bGRDbGVhcikKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9jbGlwU3RhY2suaW5p dChJbnRSZWN0KEludFBvaW50Ojp6ZXJvKCksIG1fdGV4dHVyZVNpemUpKTsKKyAgICBtX2NsaXBT dGFjay5yZXNldChJbnRSZWN0KEludFBvaW50Ojp6ZXJvKCksIG1fdGV4dHVyZVNpemUpKTsKICAg ICBtX2NsaXBTdGFjay5hcHBseShtX2NvbnRleHQzRC5nZXQoKSk7CiAgICAgbV9jb250ZXh0M0Qt PmNsZWFyQ29sb3IoMCwgMCwgMCwgMCk7CiAgICAgbV9jb250ZXh0M0QtPmNsZWFyKEdyYXBoaWNz Q29udGV4dDNEOjpDT0xPUl9CVUZGRVJfQklUKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuaAppbmRleCAzZTgw YTE3ODJlYzE0ODkxZmQ3YmNjYzJlOTkwOTNiOTZkZGRlMzE1Li5hMmI0N2VhOGNkZGYzNmU4ZmM4 ZTZmNDA5MWRjOTI0N2Q5NDk1ODQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5oCkBAIC05Myw3ICs5Myw3 IEBAIHByaXZhdGU6CiAgICAgICAgIHZvaWQgcG9wKCk7CiAgICAgICAgIHZvaWQgYXBwbHkoR3Jh cGhpY3NDb250ZXh0M0QqKTsKICAgICAgICAgaW5saW5lIENsaXBTdGF0ZSYgY3VycmVudCgpIHsg cmV0dXJuIGNsaXBTdGF0ZTsgfQotICAgICAgICB2b2lkIGluaXQoY29uc3QgSW50UmVjdCYpOwor ICAgICAgICB2b2lkIHJlc2V0KGNvbnN0IEludFJlY3QmKTsKIAogICAgIHByaXZhdGU6CiAgICAg ICAgIENsaXBTdGF0ZSBjbGlwU3RhdGU7Cg==